- 04 Sep, 2019 40 commits
-
-
Mirko Bonadei authored
Example of failure: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4011 Bug: 997673 Change-Id: I25453b2750346e5ee460d76dc4ead6555de11fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785218Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#693369}
-
Mugdha Lakhani authored
Bug: 988639 Change-Id: I354df80a573bf76e114e7f693017c00266621a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783442 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#693368}
-
Richard Knoll authored
This adds UMA metrics when a user clicks on the help text in a Click to Call dialog. We also log which dialog type was shown at that time. Bug: 995253 Change-Id: If22ca2ee5ec984015f8ef4c771997aa815abe2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774933 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#693367}
-
Nicholas Verne authored
The feature is currently default enabled and the flag is expired. Bug: 1000506 Change-Id: I51911054286297e2bdc071379940603008898422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784022 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#693366}
-
Vadym Doroshenko authored
This update contains implementation of lock which covers Windows. That makes libphonenumber thread-safe on all platforms. updated for >2 years. Binary-Size: this is an update of third_party library, which wasn't Bug: 976328 Change-Id: I1a2ea13436e2e735eb18a8da481ddd9d630c5fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761271 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#693365}
-
Jimmy Gong authored
- CupsPrinterManager will now detect for network changes. - Previously, when the network changes CupsPrintersManager would wait until ZeroConfDetector updates with new printers. - This resulted in a small time frame in which CupsPrintersManager would still retain stale printers from the previous network. - This fixes that bug by clearing the all printers upon a network change, ensuring only new printers are populated. Bug: 779602 Test: unittests, end to end manual Change-Id: I0efe9e0a2252378bca178dc4b6dcea4da6baa978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764677 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#693364}
-
Evan Stade authored
Bug: 998625 Change-Id: I97a94d94e8fb0e364c0c595c2289079b7e062e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785100Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#693363}
-
Balazs Engedy authored
This CL adds separate NotificationChannels for quiet (icon only) and heads-up (icon + pop-up) permission request notifications, and uses the newly added kQuietNotificationPrompt value to select the appropriate channel when displaying a notification permission request. Bug: 986737 Change-Id: I9b181fb4bcb964fdd065df51b6370ba327070b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766488 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693362}
-
Ayu Ishii authored
This change adds the following metrics to measure if the option of having the infobar is the best UI option and how disruptive the experience of having the infobar be automatically replaced by the keyboard while the keboard is active. Metrics: - Number of times the keyboard is automatically replaced by the Infobar - Duration from when the keyboard is replaced until when the user decides to cancel the infobar (not click confirm) to get out of the verification flow. Bug: 999238 Change-Id: I743028063e8f788270c6c17c15e646b4558df236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777118Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#693361}
-
Bailey Berro authored
Per UX guidance on crbug.com/978380, hide the list of users who are allowed to sign in when the "Restrict sign-in to the following users" toggle is in the off position, rather than disabling it. Bug: 978380 Change-Id: I139955f79ca00efd7024b1626f49521bf472447a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784964Reviewed-by:
-
François Doray authored
Test fails on Windows. TBR=dalecurtis@chromium.org Bug: 1000396 Change-Id: I7afae1373abe4afeb88b6993852c35934f63fe36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784131Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#693359}
-
Jeremy Roman authored
Noticed this as part of another CL. No need to bind the interface (which associates it with a task runner and creates the necessary objects to receive replies) until adoption actually occurs. This makes the parallel construction between the Portal and PortalClient more obvious (they're both pending or not-pending at the same time). Change-Id: Icd0b92501eb97f0903faf3cc53a650fc6f5de815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784940 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#693358}
-
Mugdha Lakhani authored
Bug: 988624 Change-Id: I17d50d7f51a404ed9ebf61fae82374ec4e3a3d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783441 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Francois Doray authored
The value of the "origin trial freeze policy" of a page is updated by the FreezeOriginTrialPolicyAggregatorAccess, which aggregates policies from the page's current frames. Bug: 999594 Change-Id: I8d71a4639ffb1e78854e82c3a309854ca0a6cd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779106 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#693356}
-
Tricia Crichton authored
ExecuteWindowCommand will now check for nonblocking execution that results in target navigated or closed error. When detecting this case, the command will be retried. Bug: 999026 Change-Id: I7c06b6a75887c98b842ffd82ec4b241fd9c0e117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785277Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#693355}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a9cf4462bf62..53a464d7b4f6 git log a9cf4462bf62..53a464d7b4f6 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 sadrul@chromium.org dashboard: Use faster API to get list of metrics. Created with: gclient setdep -r src/third_party/catapult@53a464d7b4f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:998988 Change-Id: I4298601add2934c0ba25f9d9e0e7f4f0a4e1bb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693354}
-
Daniel Rubery authored
Again due to string proto fields, the FCM protos will now be base64 encoded. Bug: 980777 Change-Id: Ie3ea60532b1a0e88f5ffeda4c15353342caf5ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785002 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693353}
-
Tibor Goldschwendt authored
+ Some plumbing to forward args to the test runner. Bug: 989654 Change-Id: I61ecbf26ab02fae7aa0792bfbdffbc9cc020b3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768665Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#693352}
-
Jimmy Gong authored
- Restamping the nearby printers element will make nearbyPrinters requery for a new set of printers whenever |canAddPrinter| is flipped to true. Bug: 779602 Change-Id: I6dfeebfaa57d615affb8209bba8d23765d43f0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779563 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693351}
-
Alex Newcomer authored
When the AppListView was chached, AppsContainerView::UpdateControlVisibility was accidentally being called on closing. This unintentionally set the visibility of many elements to false. Return early if AppListView is being closed. Bug: 992335 Change-Id: I2dfd4db9354ff5e5c2324a963ebbb23df35920ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783912Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693350}
-
François Doray authored
The test is flaky on Chrome OS and Linux. TBR=dgozman@chromium.org Bug: 1000654 Change-Id: Ibef73f609154fd2bd9ab37511b40f96d1822c05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784880Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#693349}
-
Ben Goldberger authored
If a value is not provided by the server we fall back to a sane default on the client side that can handle the intent. Bug: 1000340 Change-Id: I6714cb617eb9721ab991bf22eda9fd2d1cb9f4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783859 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#693348}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b34717a9016..65b7843ab9b6 git log 9b34717a9016..65b7843ab9b6 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 taylori@google.com perfetto-ui: Move viewport if no search result Created with: gclient setdep -r src/third_party/perfetto@65b7843ab9b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I5214723f10e7d7e566cf5edece1e4880afaf62a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783865Reviewed-by:
-
Petr Smirnov authored
This is a reland of 40c58fd0 Relanding because it was not causing test failures after all. See https://crbug.com/1000694#c6 Original change's description: > Refactor UpdateScreen > > Divide UpdateScreen class into UpdateScreen and VersionUpdater classes. The latter is responsible for communication with UpdateEngineClient and NetworkPortalDetector, and UpdateScreen is responsible for screen's specific logic only. > > The purpose of it is to make possible creation of another update screen. > > Bug: 997841 > Change-Id: I8a77403dc8e86f304e10021a9d690c015cf8a14a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771596 > Commit-Queue: Petr Smirnov <petrsmirnov@google.com> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692636} TBR=petrsmirnov@google.com Bug: 997841, 1000694 Change-Id: I72874266b405c8aaa128482a066546d7601cce6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784332Reviewed-by:
-
Ricardo Quesada authored
This CL adds support for PIP (Picture in Picture) window state when querying ARC window state via autotest_private_api. This is needed because we are replacing "dumpsys" with "dumpsys --proto" and "dumpsys --proto" does include the PIP state. And besides that, it is better to query Ash, than Android, for ARC states. TEST=Calling "ash.GetARCAppWindowState" from Tast returns PIP on PIP ARC windows. BUG=chromium:1000774 Change-Id: I4096ab205836f3f3f8b1d4eb964321dd62df77dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785058Reviewed-by: -
Christopher Cameron authored
Also rename the RemoteCocoa flag to be kAppShimRemoteCocoa. Scope this flag to only control RemoteCocoa (the actual app shim is still created), since that has been more helpful in debugging. Also disable the app shim menu when RemoteCocoa is enabled. Bug: 982024 Change-Id: I4a083d4aae892e05e942d5ca5f6252ccca44ca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775265 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#693344}
-
Andrew Grieve authored
Breaking downstream builds: Bug: 1000467, 1000763 Change-Id: Ia5e35ef9d309f3378d7ffc916ed5fd6afc9df7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784167 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#693343}
-
Ken Buchanan authored
When the user holds the mouse down over an OOPIF, that OOPIF captures all mouse inputs, including if the user moves the mouse out of the OOPIF's boundaries. A consequence of this is that when the user releases the mouse button, only the OOPIF sees that, and the frame that the mouse is now over does not see any mouse events. A consequence of this is that the mouse cursor will not be updated following a MouseUp. This CL artifically creates a MouseMove as a result of the capture-releasing MouseUp in order to trigger any necessary cursor update. Bug: 893101 Change-Id: Ib6572149dd1841c9774997928d2afeb158feb757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773758Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693342}
-
Maksim Ivanov authored
Properly localize the two strings that are used as user-facing error messages from the online challenge-response based authentication (a.k.a. smart card based login). Bug: 826417 Change-Id: Id3206806a750ba0d347e1b12e6bc0542b5f00d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778766Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#693341}
-
Himanshu Jaju authored
An error notification is shown when the user uses click to call and does not have any dialer app present on device. Nothing happens on tapping on the notification. Screenshots https://drive.google.com/open?id=19udCa1fOQHIBr2vm6Qsyu9rZsBn_pst3 Bug: 998433 Change-Id: Ic09691e48f98051274a8484ff55c9354cc1a8178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781428 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693340}
-
Nicolas Arciniega authored
This change adds a test that is almost identical to the one above it, which tests CT enforcement exceptions for specific certificate authorities. In this case, we'll pretend we're trying to use a legacy certificate from the Federal Common Policy CA. Bug: 981598 Change-Id: I8b1d25833f7b9903aa5a2ab5f32880bf9151ebe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783862Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693339}
-
Daniel Rubery authored
We decided that a feature flag would be useful in case there's any problems with the initial testing. So this CL puts an enabled by default flag in front of the uploading. Bug: 980777 Change-Id: I4eb399aee2b0d9d732dd5e12e83520b3c3a1e014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783646 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#693338}
-
Yue Li authored
This cl migrates kAssistantEnabled and kAssistantHotwordEnabled preference from arc_prefs to assistant_prefs. Also updated usages in Assistant Service and ash, removed obsolete methods. Detailed design doc: https://goto.google.com/assistant-prefs Bug: b/110211045 Test: Run existing tests Change-Id: If53d08622d5fc3b4722a04a2b4a1023358ea1056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779538Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#693337}
-
Christian Biesinger authored
This mirrors the legacy code in LayoutBox::UpdateLogicalHeight; see also https://crrev.com/612705b60640f5e4157898e8d3d9bc128155924e. Bug: 999253 Change-Id: Iabe46b61aebc952b8bd76470d7569b82d1901bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784330 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#693336}
-
Yuke Liao authored
This CL turns on 3% experiment for linux-chromeos-coverage-rel to evaluate the stability of code coverage pipeline on ChromeOS platform. Bug: 1000378 Change-Id: I1d3a8f1bb946562c6978dfd271f83d5391e4f069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784899Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693335}
-
François Doray authored
These tests are leaking: external/wpt/web-locks/idlharness.tentative.https.any.html external/wpt/geolocation-API/idlharness.window.html external/wpt/web-share/idlharness.https.window.html external/wpt/storage/idlharness.https.any.html TBR=foolip@chromium.org Bug: 1000768 Change-Id: Ie38c61d0d7e7cf3746421727b60a66620081844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784130Reviewed-by:
-
Tommy Li authored
This CL improves how we handle non-ASCII characters within AdjustTextForCopy. Previously, we did not handle it consistently. After this CL, we %-escape non-ASCII characters consistently whenever we interpret |text| as a URL and set |write_url| to true. This CL also adds some tests for this. Bug: 995019 Change-Id: I15ae0d93148492973c4e00ce28dce32139893acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782693 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#693333}
-
Justin Cohen authored
On iOS13, immediately following this navigation, WebKit will navigate to an internal failure page. Unfortunately, due to how SlimNav session restoration works with same document navigations, this page blocked by a content filter puts WebKit into a state where all further restoration same-document navigations are 'stuck' on this failure page. Instead, avoid restoring this page completely. Consider revisiting this if and when a proper session restoration API is provided by WKWebView. Bug: 997182 Change-Id: I5c27889e11a99b1aa3f26e290e0e2d3e8b0644c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778408 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#693332}
-
Rose Garcia authored
Add dynamic selection highlight for Switch Access text editing. This allows the user to see the selection as it is made. The selection is updated with the navigation through the text. This also resulted in updating the selection listener to make sure the menu reload only happens when necessary. See go/switchaccess-select-highlight for more information. This can be tested using emulated Chrome on Linux with the flags --enable-experimental-accessibility-switch-access and --enable-experimental-accessibility-switch-access-text. Bug: 999400 Change-Id: Ifab41e06976126d12d2c7962d7772517b0605b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774980 Commit-Queue: Rose Garcia <rosalindag@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#693331}
-
Aaron Tagliaboschi authored
On HSTS redirects, a new URLRequestRedirectJob is made in such a way that calls the `responseReceivedExtraInfo` DevTools protocol event, but not the `requestWillBeSentExtraInfo` event called from the request headers callback. This calls the callback with fake headers to for the matching fake headers sent out to the other event. Bug: 993019 Change-Id: Ibd1645f4ba1458557095e992d910e3aedfdbbad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758341Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#693330}
-
