GitLab

Rename SyntheticPointer to SyntheticPointerDriver, SyntheticTouchPointer to
SyntheticTouchDriver, and SyntheticMousePointer to SyntheticMouseDriver,
because these classes do not represent the synthetic pointers. They actually create
synthetic pointers for each pointer types and their actions.

BUG=525187

Review-Url: https://codereview.chromium.org/2478423002
Cr-Commit-Position: refs/heads/master@{#434763}

This CL removes xdisplaycheck from xvfb.py.  Previously, we used
xdisplaycheck to block until Xvfb set up a display.  However, there's
a utility called xvfb-run that does this already, and it's included in
the xvfb package.

In future CLs, this will allow us to:
* Remove the /path/to/build_dir argument to xvfb.py since it was only
used determine the xdisplaycheck path.
* Remove xdisplaycheck from the tree

R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2526663002
Cr-Commit-Position: refs/heads/master@{#434762}

After we placed omnibox suggestion list as a child of
CompositorViewHolder, it no longer is able to scroll.

The investigation of this regression gave interesting result: if an
ACTION_MOVE is dispatched to a ListView or a ScrollView and the
ViewGroup intercepts it, the framework will generate an ACTION_CANCEL to
the ViewGroup's children. The behavior, however, will steal this cancel
event and send to the ViewGroup again, causing scroll to fail. Thus we
should specifically not catch ACTION_CANCEL in behavior.

BUG=648136

Review-Url: https://codereview.chromium.org/2526673004
Cr-Commit-Position: refs/heads/master@{#434761}

This patch wraps the process of getting requests in a simple task
in order to ensure that getting requests can be serialized with
other tasks to prevent race conditions.

BUG=651238

Review-Url: https://codereview.chromium.org/2517383008
Cr-Commit-Position: refs/heads/master@{#434760}

The goal is to reduce number of datatype controllers to simplify future
refactoring.

In this chagne:
- Removed UIDataTypeController
- All datatypes are switched to NonUIDataTypeController
- Removed model_safe_group method, in favor of DirectoryDataTypeController field
- Added backend_thread_ so that most of datatypes don't need to override
  PostTaskOnBackendThread

R=maxbogue@chromium.org
BUG=647505

TBR=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2511703004
Cr-Commit-Position: refs/heads/master@{#434759}

BUG=668001

Review-Url: https://codereview.chromium.org/2526713002
Cr-Commit-Position: refs/heads/master@{#434758}

The current module id length check excludes some third party modules
that are not as well behaved as expected. Remove it so we can transfer
profiles containing these modules.

BUG=659903

Review-Url: https://codereview.chromium.org/2532243002
Cr-Commit-Position: refs/heads/master@{#434757}

This function uses GURL::ReplaceComponents which triggers
canonicalization of the new URL. For the normal case where urls do not
have usernames, passwords, or ref parts, we can just return the original
URL.

ReplaceComponents takes around 13% of the time spent in
HttpCache::Transaction::Start with a SimpleCache backend on Linux, but
this method is used in a few different places.

BUG=664174

Review-Url: https://codereview.chromium.org/2498423004
Cr-Commit-Position: refs/heads/master@{#434756}

BUG=669076

Review-Url: https://codereview.chromium.org/2532193002
Cr-Commit-Position: refs/heads/master@{#434755}

Now DesktopEnvironmentOptions are passed to the desktop process in
StartSessionAgent IPC message. This will allow the network process
controll DesktopEnvironment configuration and particularly
DesktopCaptureOptions.

Review-Url: https://codereview.chromium.org/2529533003
Cr-Commit-Position: refs/heads/master@{#434754}

This patch is done on behalf of roisinmcl@chromium.org (original work in
https://codereview.chromium.org/2230053002/).

When a chromedrvier session is created with a flag for W3C compliance,
chromedriver will reference the element with a UUID in place of the
existing ID generation method.

Chromedriver wrapping/unwrapping functions have been changed to match
the new referencing when the W3C flag is true.

BUG=

Review-Url: https://codereview.chromium.org/2295443003
Cr-Commit-Position: refs/heads/master@{#434753}

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457

Review-Url: https://codereview.chromium.org/2533753003
Cr-Commit-Position: refs/heads/master@{#434752}

Small bug fix.

BUG=625382, 626752

Review-Url: https://codereview.chromium.org/2483573002
Cr-Commit-Position: refs/heads/master@{#434751}

BUG=542537

Review-Url: https://codereview.chromium.org/2528323002
Cr-Commit-Position: refs/heads/master@{#434750}

Remove useless class and struct forward declarations, and add
missing ones in extensions header files.

BUG=662195

Review-Url: https://codereview.chromium.org/2535713004
Cr-Commit-Position: refs/heads/master@{#434749}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6d2cfc95eb2f..1e916c1c87c8

$ git log 6d2cfc95e..1e916c1c8 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 charliea Enable arrow-body-style eslint rule
2016-11-28 perezju [dashboard] Disiable story filtering for octane benchmark
2016-11-28 simonhatch Dashboard - Bisect bot guessing code should return valid bot.

BUG=668165

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2533853002
Cr-Commit-Position: refs/heads/master@{#434748}

This cl restores the line break attribute as it was calculated in the past. Once we implement something based on the AX-tree that covers all bases, this can be safely removed.

TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2526073003
Cr-Commit-Position: refs/heads/master@{#434747}

BUG=angleproject:1492
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2533873002
Cr-Commit-Position: refs/heads/master@{#434746}

Linux Aura got support for translucent windows in CL:
https://chromium.googlesource.com/chromium/src.git/+/62ba78ffcdf525eb9ed640724e640fcf22fbbf87

Some Chrome widgets used a TRANSLUCENT_WINDOW opacity for widgets that fade in
or out, but that don't actually have an alpha mask.  This was to support a
limitation on MS Windows where windows must be translucent to fade.

However, most Linux window managers only draw shadows on opaque windows: that is,
windows that do not have an alpha channel.  Windows that fade in or out may still
have shadows since opacity is set as a property of the toplevel window.

Therefore, the solution is to use INFER_OPACITY for fading widgets so it will
work across platforms.  TRANSLUCENT_WINDOW should only be used on widgets that
have alpha masks.

BUG=640170

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2398203002
Cr-Commit-Position: refs/heads/master@{#434745}

This change implements the key C++ portion of the Select-to-speak feature
by adding an event handler that takes Search plus the mouse button, and
fires accessibility events instead.

In the future we could modify or extend this event handler for use in
ChromeVox too, but for now I think building something specifically for
Select-to-speak makes sense.

Adds new accessibility events for mouse down, mouse up, and so on - allowing
the select-to-speak extension to get not only the mouse events and global
coordinates, but most importantly the proper accessibility object that's hit
for each event.

This change implements support for hit testing in Views. For web,
the extension will get the event fired on the views::WebView and it can do
its own hit testing within the accessibility tree from there. A follow-up
will improve on this by doing native hit testing in the web before firing
the accessibility event.

BUG=593887

Review-Url: https://codereview.chromium.org/2493923002
Cr-Commit-Position: refs/heads/master@{#434744}

The problem was that |route_id| is scoped to a particular child process,
but the process was not being plumbed in correctly, resulting in a
situation where we would create (1) a RenderFrameHost with a routing ID
that might later be reused, and also, (2) a RenderFrameHost with a
plumbed-in routing ID, but no corresponding extant RenderFrame in the
child process.

The solution involves plumbing in the actual SiteInstance, and only
using |route_id| if we don't change to a different SiteInstance.

BUG=627852
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2521793003
Cr-Commit-Position: refs/heads/master@{#434743}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5e9339ae484..0ab5a1cdaf39

$ git log b5e9339ae..0ab5a1cda --date=short --no-merges --format='%ad %ae %s'
2016-11-28 chrome-bot Update config settings by config-updater.
2016-11-28 drinkcat parseelf: Add comment about getting number of symbols from DT_HASH
2016-11-16 sjg crosfw: Return an exit code when we get a build error
2016-11-25 drinkcat parseelf: Ignore empty symbol_name
2016-11-25 drinkcat parseelf: Parse number of symbols from DT_HASH section
2016-11-21 sadrul deploy_chrome: Remove special handling for mash
2016-11-23 ayatane [sysmon] Track the number of running sysmon processes
2016-11-23 chrome-bot Update config settings by config-updater.
2016-11-23 nxia Revert "Add buildbucket_id index in buildTable"

BUG=none

Review-Url: https://codereview.chromium.org/2536553004
Cr-Commit-Position: refs/heads/master@{#434742}

This is a follow up to https://codereview.chromium.org/2483003003/

It introduces a factory class to create and get a CertificateReportingService
singleton. It also introduces a metrics provider class that currently doesn't
do anything, but will send pending reports in follow up CLs.

BUG=554323

Review-Url: https://codereview.chromium.org/2507253004
Cr-Commit-Position: refs/heads/master@{#434741}

GpuMemoryBufferHandle::shared_memory_handle is only valid if type is
SHARED_MEMORY_BUFFER. So try to serialize only when it's valid.

BUG=643746

Review-Url: https://codereview.chromium.org/2534533002
Cr-Commit-Position: refs/heads/master@{#434740}

Passing -S to python breaks in a virtualenv because it cannot
find the stdlib modules (e.g. base64). Only pass -S if not
already in a virtualenv.

BUG=667897
TEST=net_unittests inside a virtualenv

Review-Url: https://codereview.chromium.org/2526553002
Cr-Commit-Position: refs/heads/master@{#434739}

When download path is determined, Chrome will commit that information to history.
However, the information is not committed immediately.
As a result, if Chrome crashes before the next commit, the path information is lost.
When resuming the download later, Chrome will generate a new target path.
And the old temp file is left permanently on external storage.
This might not be a big issue for desktop, as Chrome rarely gets killed and there are ample storage.
However, this has a great impact on android.
This CL requests the path information to be committed immediately to address the issue.

BUG=664677

Review-Url: https://codereview.chromium.org/2508503002
Cr-Commit-Position: refs/heads/master@{#434738}

Reland of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2526383002/ )

Reason for revert:
Clang still asserts when building Precompile-core.obj, but it's somewhere else:
Assertion failed: AllowUnresolvedNodes && "Cannot handle unresolved nodes"...

Original issue's description:
> Revert of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2520833005/ )
>
> Reason for revert:
> The crash is now hopefully fixed in clang-cl.
>
> Original issue's description:
> > Disable Precompile-platform with clang-cl.
> >
> > It currently asserts while trying to build that PCH file.
> >
> > BUG=667891,495697
> > NOTRY=true
> >
> > Committed: https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3
> > Cr-Commit-Position: refs/heads/master@{#434028}
>
> TBR=rnk@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=667891,495697
>
> Committed: https://crrev.com/a0eb8ed36a1c3e2c5becc95ef03d42655c7cd95c
> Cr-Commit-Position: refs/heads/master@{#434534}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=667891,495697

Review-Url: https://codereview.chromium.org/2533853003
Cr-Commit-Position: refs/heads/master@{#434737}

Previously ash would make a direct connection to Chrome (content_browser) to
handle showing system tray menu UI. This is a layering violation and makes
it more difficult to run ash without chrome.

Chrome's SystemTrayClient now explicitly registers itself with ash on startup.
It no longer attempts to reconnect on error; my understanding is that chrome
tolerating an ash crash is not a goal.

BUG=none
TEST=manual, can still open settings via system tray menu

Review-Url: https://codereview.chromium.org/2525813004
Cr-Commit-Position: refs/heads/master@{#434736}

BUG=667373

Review-Url: https://codereview.chromium.org/2530633003
Cr-Commit-Position: refs/heads/master@{#434735}

BUG=666616

Review-Url: https://codereview.chromium.org/2522313003
Cr-Commit-Position: refs/heads/master@{#434734}

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

This CL fixes the threading issues by either starting the server after
the handlers are added or by splitting the server start into two phases.
This is needed when the server's base URL is required for registering
the handlers.

BUG=546060

Review-Url: https://codereview.chromium.org/2522283002
Cr-Commit-Position: refs/heads/master@{#434733}

BUG=652332

Review-Url: https://codereview.chromium.org/2528553002
Cr-Commit-Position: refs/heads/master@{#434732}

Use an int instead of a StaticAtomicSequenceNumber to generate the ids for
the gpu memory buffers. This should be sufficient since this is used only
in the same thread.

BUG=none

Review-Url: https://codereview.chromium.org/2532763003
Cr-Commit-Position: refs/heads/master@{#434731}

This adds signature validation for the component cloud policy
(e.g. policy for extensions). The signature is validated against
the same key that is used for the "superior" policy (e.g. the
user policy, the device local account policy, etc.).

This CL also adds keeping a copy of the most recent component
cloud policy and rechecking it when some of the credentials
change. This allows to handle key rotations gracefully: even
though the component cloud policy may fail the validation
immediately after the cloud policy refresh with the rotated key,
it will be re-validated and applied when the superior policy gets
processed and the credentials get propagated.

BUG=644632
TEST=existing tests (now with the signature checks enabled),
     new unit tests and new browser test

Review-Url: https://codereview.chromium.org/2493603002
Cr-Commit-Position: refs/heads/master@{#434730}

https://pdfium.googlesource.com/pdfium.git/+log/e421327725da..c92e26defaa6

$ git log e42132772..c92e26def --date=short --no-merges --format='%ad %ae %s'
2016-11-28 npm Merge CPDF_ImageLoader with its handle
2016-11-28 npm Nits in fx_ge_linux
2016-11-28 npm Fix leak in cpdf_document_unittest

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2539513002
Cr-Commit-Position: refs/heads/master@{#434729}

Both type name and stack deduplicators need to estimate their memory
overhead. Previously they were using simplistic models and estimated
only half of their actual memory usage. This CL changes estimation
methods to use EstimateMemoryUsage(), resulting in better accuracy.

Review-Url: https://codereview.chromium.org/2514913002
Cr-Commit-Position: refs/heads/master@{#434728}

The DCHECK was mostly benign, though Chrome would close the socket
without waiting for a response to its QUIT messages, which has unclear
consequences.

BUG=668759

Review-Url: https://codereview.chromium.org/2532873003
Cr-Commit-Position: refs/heads/master@{#434727}

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174

Review-Url: https://codereview.chromium.org/2536573003
Cr-Commit-Position: refs/heads/master@{#434726}

BUG=546953

Review-Url: https://codereview.chromium.org/2534873002
Cr-Commit-Position: refs/heads/master@{#434725}

It is no longer possible to explicitly construct and destroy surfaces. A
SurfaceFactory instance now handles only one surface at a time. Once the
local frame id passed to SubmitCompositorFrame changes, the factory gets
rid of the old surface and creates a new one.

BUG=658607

Committed: https://crrev.com/b902fd366ba91757dbee99d5f821f00d2de1d181
Cr-Commit-Position: refs/heads/master@{#432312}
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2485473003
Cr-Commit-Position: refs/heads/master@{#434724}