GitLab

https://webrtc.googlesource.com/src.git/+log/4157936823f7..0ffe03d2ef6f

$ git log 415793682..0ffe03d2e --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:none,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1d66ca764c197d0761964cf1443929129e625c40
Reviewed-on: https://chromium-review.googlesource.com/988691Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547362}

This reverts commit 2298aca2.

Reason for revert: Remove changes made in monochrome since apk merge script needs to
be updated first.

Original change's description:
> Revert "Reland "Enable extracting unwind table on official builds without channel""
>
> This reverts commit 0db71a0d.
>
> Reason for revert: Monochrome apk merge is failing because the unwind
> file for both apk has the same name.
>
> Original change's description:
> > Reland "Enable extracting unwind table on official builds without channel"
> >
> > This reverts commit a2474b64.
> >
> > Reason for revert: The failure was due to parent CL getting reverted
> > Relanded parent in: https://chromium-review.googlesource.com/c/chromium/src/+/984452
> >
> > Original change's description:
> > > Revert "Enable extracting unwind table on official builds without channel"
> > >
> > > This reverts commit eb07cea1.
> > >
> > > Reason for revert: Windows tryjobs are failing.
> > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example.
> > >
> > > ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion.
> > >     "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table",
> > >                                 ^------------------------
> > > "can_unwind_with_cfi_table" is not currently in scope.
> > > See //BUILD.gn:65:5: which caused the file to be included.
> > >     "//base:base_perftests",
> > >     ^----------------------
> > > GN gen failed: 1
> > >
> > > Original change's description:
> > > > Enable extracting unwind table on official builds without channel
> > > >
> > > > This CL enables extraction of unwind tables for chrome when
> > > > is_official_build is set to true and when android_channel is not set to
> > > > a release channel. This affects build time only on official builds.
> > > > Also, Set legacy heap profiler to use unwinder for profiling.
> > > >
> > > > TBR=dpranke@chromium.org
> > > > BUG=819888
> > > >
> > > > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244
> > > > Reviewed-on: https://chromium-review.googlesource.com/976944
> > > > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#546425}
> > >
> > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> > >
> > > Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 819888
> > > Reviewed-on: https://chromium-review.googlesource.com/983893
> > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > Commit-Queue: agrieve <agrieve@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#546478}
> >
> > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> >
> > Change-Id: I100f540c8d5bc9f59b9631ea207c7f290dc42e96
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 819888
> > Reviewed-on: https://chromium-review.googlesource.com/985112
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547196}
>
> TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
>
> Change-Id: Ifa59a5882b18c2634bcf96c2c1fc58b09d7f303f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 819888
> Reviewed-on: https://chromium-review.googlesource.com/989153
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547332}

TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org

Change-Id: I7750c70e52b55ccfbf1e2457a19fee4852575e59
Bug: 819888
Reviewed-on: https://chromium-review.googlesource.com/989192
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547361}

Bug: 803245
Change-Id: I0abe1da94bca9f38b99bf2fdaa0cd9cfa0f35783
Reviewed-on: https://chromium-review.googlesource.com/988842Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547360}

This patch implements a custom slider that provides the basic
functionality of the paper-slider but provides an additional option to
display a label for the current slider value. The slider has the Prefs
Behavior integrated with it.

This slider has a general implemention and is ready to be used in other
locations as well.

Functionalities implemented:
 - Slider works the same way as the paper-slider in terms of mouse and
   keyboard interactions.
 - Additionally The slider displays a label on mouse hover and keyboard
   focus.
 - The slider only works for discrete values or options.

This patch also adds web ui tests for all the slider functionalities.

A video of this slider in use can be found on the bug link below.

Bug: 798906
Change-Id: Ib51ec47d0d2e8ad83ea66220ddf746fe15208d5f
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Component: Display Slider, display settings, webui tests
Reverted Patch: https://chromium-review.googlesource.com/c/chromium/src/+/988092

TBR=stevenjb@chromium.org

Change-Id: Ib51ec47d0d2e8ad83ea66220ddf746fe15208d5f
Reviewed-on: https://chromium-review.googlesource.com/988823Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547359}

BUG=823874

Change-Id: Ib433aaf4bd56eef002861c0ea1a77f442283b5b6
Reviewed-on: https://chromium-review.googlesource.com/985248
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547358}

Change-Id: I4be44cede736df1aba6b92bf3674274a6e3ba40c
Reviewed-on: https://chromium-review.googlesource.com/978467
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547357}

Use ChromeLauncherController's ShelfModel to get/set shelf pinning.
Ash's Shell is inaccessible from Chrome in Mash.

Fix unit tests to construct a ChromeLauncherController and ShelfModel.
Make BrowserStatusMonitor check for a Shell to support non-Mash tests.
Convert AshTestBase fixture to BrowserWithTestWindowTest; disable sync.

Bug: 826415
Test: App list -> app context menu -> app info -> dialog shows [un]pin.
Change-Id: Icdfdde84692184cf95dee83a71ff068cef5f98e9
Reviewed-on: https://chromium-review.googlesource.com/988825
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547356}

https://chromium.googlesource.com/external/leveldb.git/+log/41172a24016b..6fa45666703a

$ git log 41172a240..6fa456667 --date=short --no-merges --format='%ad %ae %s'
2018-03-23 costan Rename CMake project / targets from Leveldb to leveldb.
2018-03-23 costan leveldb: Add more thread safety annotations.
2018-03-21 costan Take <atomic> for granted in port/atomic_pointer.h.
2018-03-21 costan leveldb: Require C++11.
2018-03-20 costan Remove build configuration for make.
2018-03-20 hyzeta Add export.h to CMakeLists.txt
2018-03-20 costan Replace SIZE_MAX with std::numeric_limits.
2018-03-16 costan Add CMake build support.
2018-03-16 costan Extend thread safety annotations.
2018-03-16 costan Fix includes in util/testharness.h.
2018-03-12 costan Remove extern from function declarations.
2018-03-12 costan Add tests for {Old}InfoLogFileName().
2018-03-12 costan Remove unused function ExtractValueType.
2018-03-09 costan Bypass OSMemoryBarrier() warning on Mac.
2018-03-09 costan leveldb: Update Travis CI configuration for open source build.
2018-03-09 costan Expose Env::GetTempDirectory() for use in C test.
2018-03-09 costan Switch HAVE_ library detection macros to 0/1.

Created with:
  roll-dep src/third_party/leveldatabase/src

Change-Id: Ic8d8208d10ead9892c8f726b8cc4671f4b9b6389
Reviewed-on: https://chromium-review.googlesource.com/958224Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547355}

Some artifacts show up on intel devices on the splitview indicators
highlights, which are rounded_rect_views. Use addCircle and addRect
as a temporary workaround.

Test: manual
Bug: 824564
Change-Id: Ic5bee0b6eaf412ea5fa569afefcde66843af4e4c
Reviewed-on: https://chromium-review.googlesource.com/986974Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547354}

Bug:825742

Change-Id: I99a81da0a4275fcc6d5cb366f14706deaf3e686e
Reviewed-on: https://chromium-review.googlesource.com/987111Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547353}

Bug: 823482
Change-Id: I633fa3fc6be6b04cc9d58a8165fed1bc388f731b
Reviewed-on: https://chromium-review.googlesource.com/981308
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547352}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/36a9c890b979..907239157e6a

$ git log 36a9c890b..907239157 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 cmtice Add new builder and builder stages for clang-tidy warnings.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:687243


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I51cccba654c5dd6ae667a49b2e6794017c5d9c24
Reviewed-on: https://chromium-review.googlesource.com/989113Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547351}

Launch bug: https://crbug.com/805851
Design doc: https://goo.gl/Rrrc7n

Bug: 705744
Change-Id: If959163cdafc49913edccbca980179aa5e97ef21
Reviewed-on: https://chromium-review.googlesource.com/852094Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547350}

Using wpt-import in Chromium 6ac0ae59.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14970

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

TBR=markdittmer

No-Export: true
Change-Id: Ia194aeadbaedae4235bc0c3d7c7168c04e3f3ede
Reviewed-on: https://chromium-review.googlesource.com/988477
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547349}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bb16e339ce72..62af4e40a8f4

$ git log bb16e339c..62af4e40a --date=short --no-merges --format='%ad %ae %s'
2018-03-30 ehmaldonado gclient setdep: Add support for more use cases
2018-03-30 amatyukhin [cipd] Do not rewrite ERRORLEVEL

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:760633,chromium:none


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I0d76a0615d81b408fd825f0eb8f12a5fb065b09a
Reviewed-on: https://chromium-review.googlesource.com/988690Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547348}

Refine existing MouseLeaveTest for more general mouse event testing.
(renames, add click handlers, add basic test, cleanup helpers and html)

Add a test that triggers click/double click handlers in html content.

Remove IsX11SendEventTrue filtering to allow ui_controls double clicks.
Originally added in https://chromiumcodereview.appspot.com/11761027
(I think to prevent reposted clicks from counting as double clicks)
(crrev.com/c/980662's GetRepeatCount timestamp checks should suffice)

TODO: try to enable more disabled tests, update cited bugs.

Bug: 825695
Test: Automated; no double click when dismissing menus, no regressions.
Change-Id: Iefcc2d313b36710a18e5c94079aa5dd75d8500bf
Reviewed-on: https://chromium-review.googlesource.com/985904
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547347}

* Use in-declaration initializers
* NULL -> nullptr
* Deinline member functions in non-test class.  This is mostly personal
  preference; it's easier to see which base class functions are being overridden
  and makes for better line wrapping.
* Eliminate unnecessary destructor/DISALLOW_COPY declarations
* Add comments
* Simplify loop in InfoBarContainerView::Layout() by relying on child order
  (which it already does)
* Remove unnecessary #include
* Prefer type alias to typedef

BUG=none
TEST=none

Change-Id: Ie3bd1c083c0a497d2137e437a75ca81f8c764b0a
Reviewed-on: https://chromium-review.googlesource.com/987329
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547346}

The NOTREACHED() in InitAsFullscreen has failed appear in crashes, so I
suspect that this has been dead code for a while now.

Bug: 821651
Change-Id: Ia057b630b8ebb89bc570884979bbd855156e4bf1
Reviewed-on: https://chromium-review.googlesource.com/982580
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547345}

R=jchinlee@chromium.org

Bug: 790157
Change-Id: I0d85be5822c7add2625772c5b6b4f4dc82652fc7
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/989217
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547344}

This CL just adds virtual interfaces around the existing classes for the
BLE interfaces. No other code changes should be made.

BUG=internal b/77282414
TEST=cast_bluetooth_unittests cast_internal_bluetooth_unittests

Change-Id: I3891eebb61dd187709ec15bbaac32b962e4c2d9e
Reviewed-on: https://chromium-review.googlesource.com/987374
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547343}

Experiments showed no benefits to this approach unfortunately. So turn
down code and feature flags.

Bug: 734813
Change-Id: Ied51da9854ca122b27ad4675bc15e19f22bc643c
Reviewed-on: https://chromium-review.googlesource.com/988305Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547342}

The logic of combining something into tracks goes to the model now.
We do not glue threads between each other anymore, so cross-process
navigation now shows two separate tracks.

Bug: 820250
Change-Id: I752e4c40d5362b927e23df92d5a2442aab134c6c
Reviewed-on: https://chromium-review.googlesource.com/985618
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547341}

Bug: 827490
Change-Id: Id737a5a7d8d781c6e7ea329238ddaae7c2d60ff5
Reviewed-on: https://chromium-review.googlesource.com/988959
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547340}

When closing a Window on MacViews, this logic would needlessly trigger relayouts
for every tab close, causing massive jank.

Bug: 826287
Change-Id: I30bac1e8c12eb16305be8c7630082adbeae54c6d
Reviewed-on: https://chromium-review.googlesource.com/988853Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547339}

This change adds logic to the WebUSB device chooser (on desktop) so that
when the WebUSB guard permission is set to 'block' the chooser will be
automatically dismissed as if the user had not selected any devices.

This matches the behavior of the Web Bluetooth chooser and its guard
permission.

To test this change the WebUsbChooserService class has been refactored
so that its shared logic can be reused by tests. A follow-up patch will
make WebUsbChooserServiceAndroid also inherit from this class.

Bug: 771703
Change-Id: I3f2cc6e96a9ebf039bc15d396d16eb4a0766007e
Reviewed-on: https://chromium-review.googlesource.com/987327
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547338}

When the feature flag is enabled and the user has opted-in via the
SBER2(Scout) pref, verifies certificates with both the platform verifier
and the CertVerifyProcBuiltin, and reports if the results differ. Has no
user-visible effect, the result from the platform verifier is used as soon
as it is complete, and the trial verification is completed in the background.
Currently, the trial is only supported on Mac and Linux.

Design doc: https://docs.google.com/document/d/1AM1CD42bC6LHWjKg-Hkid_RLr2DH6OMzstH9-pGSi-g/edit

Bug: 649026
Change-Id: If5b7e8841a072224aaa748f7bbd5609adb9170a0
Reviewed-on: https://chromium-review.googlesource.com/898388Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547337}

This CL implements crash/content/app/crashpad.h for linux but does not
migrate any clients from breakpad to crashpad.

Bug: crashpad:30
Change-Id: I00587795331d39d00c98f36949735c43d3e2e9a4
Reviewed-on: https://chromium-review.googlesource.com/972183
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547336}

Test is flaky on Android, see the flakiness dashboard in the crbug.

TBR: ctzsm@chromium.org
Bug: 827525
Change-Id: Ie5b099126dcd7cd8aa60c400ea0c3333e3a8e9a4
Reviewed-on: https://chromium-review.googlesource.com/989033Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547335}

This is a partial revert for r536969 Change TranslateHelper to use a
TextContent-like text dump.

r536969 is a workaround for a lifecycle violation bug that layout is
still dirty after running layout update.

It turns out that textContent is not a good text dump for
TranslateHelper, as pages may hide arbitrary content (e.g., JSON) in
invisible text nodes, which can't be reliably filtered without checking
element style or layout.

Since we don't always run CapturePageText() with dirty layout, there is
no need to always dump textContent. Hence, this patch partially reverts
r536969 that, we still dump innerText as long as layout is clean. We
dump textContent only when layout is dirty, which is enough to get
around the lifecycle violation bug.

Bug: 826174
Change-Id: I63e97832caa9858e67992847fb9a22f6405183cb
Reviewed-on: https://chromium-review.googlesource.com/984474Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547334}

Testing for a specific number is causing problems and determining the right
number is problematic in general, as running out of memory is always a
legitimate possiblity. See https://github.com/WebAssembly/design/issues/1167 for
more discussion. In light of this, it's best to just remove the test.

Bug: 
Change-Id: I66e248c8ab851bca0c54fa6fe13b6e93e55f1264
Reviewed-on: https://chromium-review.googlesource.com/851081
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547333}

This reverts commit 0db71a0d.

Reason for revert: Monochrome apk merge is failing because the unwind
file for both apk has the same name.

Original change's description:
> Reland "Enable extracting unwind table on official builds without channel"
> 
> This reverts commit a2474b64.
> 
> Reason for revert: The failure was due to parent CL getting reverted
> Relanded parent in: https://chromium-review.googlesource.com/c/chromium/src/+/984452
> 
> Original change's description:
> > Revert "Enable extracting unwind table on official builds without channel"
> >
> > This reverts commit eb07cea1.
> >
> > Reason for revert: Windows tryjobs are failing.
> > https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example.
> >
> > ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion.
> >     "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table",
> >                                 ^------------------------
> > "can_unwind_with_cfi_table" is not currently in scope.
> > See //BUILD.gn:65:5: which caused the file to be included.
> >     "//base:base_perftests",
> >     ^----------------------
> > GN gen failed: 1
> >
> > Original change's description:
> > > Enable extracting unwind table on official builds without channel
> > >
> > > This CL enables extraction of unwind tables for chrome when
> > > is_official_build is set to true and when android_channel is not set to
> > > a release channel. This affects build time only on official builds.
> > > Also, Set legacy heap profiler to use unwinder for profiling.
> > >
> > > TBR=dpranke@chromium.org
> > > BUG=819888
> > >
> > > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244
> > > Reviewed-on: https://chromium-review.googlesource.com/976944
> > > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#546425}
> >
> > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> >
> > Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 819888
> > Reviewed-on: https://chromium-review.googlesource.com/983893
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Commit-Queue: agrieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#546478}
> 
> TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> 
> Change-Id: I100f540c8d5bc9f59b9631ea207c7f290dc42e96
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 819888
> Reviewed-on: https://chromium-review.googlesource.com/985112
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547196}

TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org

Change-Id: Ifa59a5882b18c2634bcf96c2c1fc58b09d7f303f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819888
Reviewed-on: https://chromium-review.googlesource.com/989153Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547332}

Crash reporting shows that the following devices all experience
crashes in the same place when testing resolutions:

0x1002 0x9850	26.22%	Mullins [Radeon R3 Graphics]
0x1002 0x9830	23.78%	Kabini [Radeon HD 8400 / R3 Series]
0x1002 0x9874	15.85%
0x1002 0x6821	12.80%	Venus XT [Radeon HD 8870M / R9 M270X]
0x1002 0x9851	9.76%	Mullins [Radeon R4/R5 Graphics]
0x1002 0x130f	4.88%	Kaveri [Radeon R7 Graphics]
0x1002 0x983d	3.66%	Temash [Radeon HD 8250/8280G]
0x1002 0x67b1	1.83%	Hawaii PRO [Radeon R9 290]
0x1002 0x6798	0.61%	Tahiti XT [Radeon HD 7970/8970 OEM / R9 280X]
0x1002 0x130a	0.61%	Kaveri [Radeon R6 Graphics]

So add them to the blacklist. Since the list is getting a little long,
switch it to uint16_t, sort it, and switch to a binary search instead
of a linear scan.

BUG=822644
TEST=builds.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I10951afeb39a08f1fa465b6157017925fe69326b
Reviewed-on: https://chromium-review.googlesource.com/988794Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547331}

Bug: 712693
Change-Id: I65a7fd3086fe2e2c2e0177462eb97b7b864c1c11
Reviewed-on: https://chromium-review.googlesource.com/988739Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547330}

* mac_chromium_10.10
* mac_chromium_10.13_rel_ng

Also, fix LUCI configs:
* fix mac_chromium_10.10 name
* add missing buildbot mac_chromium_10.13 in LUCI UI.

R=jbudorick@chromium.org, shenghuazhang@chromium.org

Bug: 807149, 764174
Change-Id: I38ec38630358000e70a9451f30fcbf363b8d7217
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/989114Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547329}

This reverts commit 65582739.

Reason for revert: Causes failure on Win x64 Builder:
https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/64392

Original change's description:
> Change AAGUID of AttestedCredentialData to array
> 
> Since AAGUID always has fixed size(16), change |aaguid_| of
> AttestedCredentialData from std::vector<uint8_t> to std::array<uint8_t,
> 16>.
> 
> Bug: 780078
> Change-Id: If30dd55b6e88e38f2a6ab53365a6724cf29892a5
> Reviewed-on: https://chromium-review.googlesource.com/981682
> Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547321}

TBR=engedy@chromium.org,hongjunchoi@chromium.org

Change-Id: Iab663a0617a364cb11c10beb1759f1543fb485fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 780078
Reviewed-on: https://chromium-review.googlesource.com/989152Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547328}

We're eventually going to launch pixel canvas on Windows and Linux, so
the flag should be available on those platforms for testing. It will now
should up in about:flags.

Bug: 765723, 765724
Change-Id: Iba85b34b60f4a92075693cff27e1c59671594e6c
Reviewed-on: https://chromium-review.googlesource.com/988836Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547327}

Purely renaming.

TBR=bshe@chromium.org

Bug: None
Change-Id: Ia4eae1c6cc69ecfef0522bb052e2c98a94ffe193
Reviewed-on: https://chromium-review.googlesource.com/988682Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547326}

Coverage by fuzzers is lacking compared to coverage by unit test
HTTPParsersTest.cpp

Change-Id: I958c1217d26850621d1333072622eb0d3fb72e4d
Reviewed-on: https://chromium-review.googlesource.com/988333
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547325}

Check flag when determining status text for a failed download attempt.
When the flag is enabled, descriptive status texts should be used for
downloads that failed due to an actionable error. Descriptive status
texts still are TBD. When the flag is disabled, use generic "Download
failed."

Bug: 824931
Change-Id: I2d67a7c3213a3a57a39b72eeae7433a6b847283e
Reviewed-on: https://chromium-review.googlesource.com/982520
Commit-Queue: Candice Sy <cmsy@google.com>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547324}

Features can be restricted to a maximum manifest version. Remove all
features restricted to manifest v1. In practice, this only includes
the "background_page" manifest feature.

Bug: 816677
Change-Id: I6ecea6c04f3afffc8c01848dc892683c0b63d29e
Reviewed-on: https://chromium-review.googlesource.com/953174Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547323}