- 18 Jan, 2018 40 commits
-
-
Tarun Bansal authored
When RTT values are overridden in the network quality estimator test class, then the effective connection type is immediately recomputed. This makes it simpler to write tests. Without this change, the caller has to create and run a main frame URL request (which also forces recomputation of ECT). Bug: 704339 Change-Id: I4f92038a5577991a87d561ac4f4b2bcdd8172d79 TBR: mmenke@chromium.org,mpearson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/874872 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#530314}
-
Steven Valdez authored
Bug: Change-Id: I658c2aa67df629e65cc7289f2256b0ac3b0d49e6 Reviewed-on: https://chromium-review.googlesource.com/847081 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#530313}
-
Jinho Bang authored
Should use std::make_unique directly instead of using base::MakeUnique since August[1]. So, this change removes usages of base::MakeUnique in //ios. This change removes `#include "base/memory/ptr_util.h"` if it's no more used in files. (Might not remove if base::WrapUnique is used) This change also adds `#include <memory>` header except the following two cases: - Not add the header if the file contains the <memory> header - Not add the header if the related header contains <memory> header (The style guide[2] says that foo.cc can rely on foo.h's includes) Confirmed no additional lint errors(by `git cl lint`) after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/616016 [2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: 755727 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7d62699d862da199d76ed44e22a988e0d96bab4e Reviewed-on: https://chromium-review.googlesource.com/873890Reviewed-by:Eugene But <eugenebut@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#530312}
-
Matt Reynolds authored
RawInputDataFetcher uses methods from hid.dll to enumerate and fetch gamepad state for RawInput devices. The DLL is loaded as needed and a handle is retained by the data fetcher. This CL moves the DLL management logic and function pointers to a separate object that can be shared between the data fetcher and other classes. BUG=749295 Change-Id: Ifbdf1d67a4577e91806e3e7ee5ee6e4cae621691 Reviewed-on: https://chromium-review.googlesource.com/871845 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#530311}
-
Christopher Cameron authored
This is needed for an investigation on the effect of number of quads on power consumption. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I3b08fb599e3bfa9076cae837416139884615b60c Reviewed-on: https://chromium-review.googlesource.com/863143 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#530310}
-
Jinho Bang authored
Should use std::make_unique directly instead of using base::MakeUnique since August[1]. So, this change removes usages of base::MakeUnique in //chrome/browser/search_engines. This change removes `#include "base/memory/ptr_util.h"` if it's no more used in files. (Might not remove if base::WrapUnique is used) This change also adds `#include <memory>` header except the following two cases: - Not add the header if the file contains the <memory> header - Not add the header if the related header contains <memory> header (The style guide[2] says that foo.cc can rely on foo.h's includes) Confirmed no additional lint errors(by `git cl lint`) after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/616016 [2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: 755727 Change-Id: I9d43839370510fb7369f52d54f22ed9a84511ef2 Reviewed-on: https://chromium-review.googlesource.com/874250Reviewed-by:Marc Treib <treib@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#530309}
-
Jinho Bang authored
Should use std::make_unique directly instead of using base::MakeUnique since August[1]. So, this change removes usages of base::MakeUnique in //chrome/browser/safe_browsing. This change removes `#include "base/memory/ptr_util.h"` if it's no more used in files. (Might not remove if base::WrapUnique is used) This change also adds `#include <memory>` header except the following two cases: - Not add the header if the file contains the <memory> header - Not add the header if the related header contains <memory> header (The style guide[2] says that foo.cc can rely on foo.h's includes) Confirmed no additional lint errors(by `git cl lint`) after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/616016 [2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: 755727 Change-Id: Ifd0b4b4a06feb3de9725191bde9979a248e2bb2f Reviewed-on: https://chromium-review.googlesource.com/874033Reviewed-by:Jialiu Lin <jialiul@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#530308}
-
Jacob Dufault authored
Bug: 784495 Change-Id: If58401246ba905279624805b31b866ad93b0ec62 Reviewed-on: https://chromium-review.googlesource.com/824915 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#530307}
-
Yves Arrouye authored
Bug: chromium:778535 Test: visual Change-Id: I6fb9658b9d71c9614c4f5a1ed5326e0d8f236212 Reviewed-on: https://chromium-review.googlesource.com/874721Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#530306}
-
Tao Bai authored
This patch fire submission in both WillSendSubmitEvent and FormSubmitted(), to avoid to miss form submission, but only one event will be sent to AutofillDriver. Also pass SubmissionSource to browser side, and add the code to handle PROBABLY_FORM_SUBMITTED in AutofillProviderAndroid. Bug: 785519 Change-Id: I7a732135da759f206547beb48995896bd58a85c6 Reviewed-on: https://chromium-review.googlesource.com/821610 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530305}
-
Jiaquan He authored
This commit passes the model updater from a model builder to its items so that changes can be synced to AppListModel in ash. The model updater is set after the item is constructed since we don't want to sync changes in its constructor. Bug: 733662 Change-Id: I7475141ffa066ef9a9da750c774ee9ee5181b197 Reviewed-on: https://chromium-review.googlesource.com/861226 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#530304}
-
Mounir Lamouri authored
This is marking the WebDocumentLoader that the load was user activated which will tells the frame that it was activated before navigation which allows feature relying on that information to work when the context menu is used. Bug: 799136 Change-Id: I1dc51cbc07f96dcd55b8bfeb8424fb10b5a4fd13 Reviewed-on: https://chromium-review.googlesource.com/870832Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#530303}
-
John Abd-El-Malek authored
Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7dd4b23a8f9006845b73966591d7f410a5979d91 Reviewed-on: https://chromium-review.googlesource.com/875005 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#530302}
-
Marco authored
https://chromium.googlesource.com/webm/libvpx.git/+log/bed28a55f593..373e08f921e5 $ git log bed28a55f..373e08f92 --date=short --no-merges --format='%ad %ae %s' 2018-01-16 vigneshv vp8dx.h: Add macro for skipping loop filter 2017-12-28 johannkoenig adopt some clang 5.0.0 formatting 2018-01-09 marpan vp9: Skip encoding of enhancement layers on the fly. 2018-01-10 vtsyrklevich [CFI] Remove function pointer casts 2018-01-09 paulwilkins Add zoom break out for kf boost loop. 2018-01-10 paulwilkins Fix kf detection in some slide shows. 2018-01-05 linfengz Add vp9_highbd_iht4x4_16_add_sse4_1() 2018-01-05 linfengz Update dct_test.cc 2018-01-04 paulwilkins Fix bug in use of zoom metric as part of arf breakout. 2017-12-28 linfengz Update iadst4_sse2() 2017-12-22 slavarnway Add quantize_fp_32x32_nz_c() Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I513e8878fbce176332a9e1eb362fa2593cd656c5 Reviewed-on: https://chromium-review.googlesource.com/874995Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#530301}
-
CrystalFaith authored
Minor fix to style/format. Bug: Change-Id: I40304f0f04d9a2db84c621436d2c94f798590324 Reviewed-on: https://chromium-review.googlesource.com/833969Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#530300}
-
Troy Hildebrandt authored
Cleans up a bunch of warnings when building CustomTabActivityTest related to catching exceptions and just Assert.failing. Bug: Change-Id: I547009482808a5d9042815fb98d533ce6c2a4a28 Reviewed-on: https://chromium-review.googlesource.com/874592Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#530299}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: Ie3bb2ab435a646e44f6ff9b1567d8d2b9a29adfa Reviewed-on: https://chromium-review.googlesource.com/874800Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#530298}
-
Hajime Hoshi authored
The old CL (https://chromium-review.googlesource.com/c/chromium/src/+/839321) passed the main task runner at RendererBlinkPlatformImpl initialization, and this caused thread-mismatching when the IndexedDB is used at workers. This CL instead passes task runners from IndexedDB user side. This CL also adds a new internal TaskType kInternalIndexedDB for our task-execution-time analyzation. This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I5513fe071407664dffb985d9961f773ce5b736a7 Reviewed-on: https://chromium-review.googlesource.com/867970Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#530297}
-
Kurt Horimoto authored
The prior implementation of |-currentPageLoadStarted| directly called |-startProgressBar| rather than going through |-updateToolbarState|. |-updateToolbarState| changes the WebToolbarController's |loading| property, and optionally calls |-startProgressBar| or |-stopProgressBar| when the value changed. When a file is downloaded, we receive |-currentPageLoadStarted| for the started load, then immediatly receive |-updateToolbarState| when the WebState::IsLoading() is reset to false (since the download manager is native UI and isn't actually downloaded from the server). Since WebToolbarController's |loading| property was not getting reset to YES in the |-currentPageLoadStarted| call, the |-updateToolbarState| call with WebState::IsLoading() == false failed to hide the progress bar since the value matches the WebToolbarController's previous |loading| value. This CL updates |-currentPageLoadStarted| to call |-updateToolbarState| so that the internal property is consistent with the toolbar model and the progress bar can be hidden correctly when the load finishes. Bug: 802891 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f88c501e8448752b1f4efaf61aef0e264953824 Reviewed-on: https://chromium-review.googlesource.com/874993Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#530296}
-
MinChen authored
ConvertiblePowerButtonController and create PowerButtonUtil. changes in this cl, Since we will put the logic of power button menu in TabletPowerButtonController instead of creating a new controller. Reverting related previous cls, 1. Revert rename TabletPowerButtonController to ConvertiblePowerButtonController. Related cl, https://chromium-review.googlesource.com/c/chromium/src/+/852518 2. Revert the creating of PowerButtonUtil. Related cl, https://chromium-review.googlesource.com/c/chromium/src/+/852905 Bug: 799524 Change-Id: I4883c7eb9f4b73fad9e8d862fbc106aee22072d4 Reviewed-on: https://chromium-review.googlesource.com/874911Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#530295}
-
Bill Budge authored
- Raises the limit of direct mapped allocations. WASM needs to be able to allocate 2GiB regions. Bug: chromium:801604 Change-Id: I559e55d2474623805eabae64f5b1f3dfe35a7acb Reviewed-on: https://chromium-review.googlesource.com/868844 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#530294}
-
Alexey Kozyatinskiy authored
TBR=lushnikov@chromium.org Bug: none Change-Id: If35d4a79b67574b03b438ffcd22ab5804cc79238 Reviewed-on: https://chromium-review.googlesource.com/874603Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530293}
-
Jinsuk Kim authored
This CL isolates ImeAdapter from ContentViewCore by turning ImeAdapter into a public interface, and moving input-related CVC APIs to it. ImeAdapter implementation is backed by WebContentUserData so that it can be obtained by |ImeAdapter.fromWebContents()| any time. CVC which previously kept the reference to it, doesn't any more. A few details in the changes: - InputMethodManagerWrapper needs not be open to public interface, but one of the test-only methods requires it to facilitate testing (to inject TestInputMethodManagerWrapper). It's used by tests only, so I decided not to move it to content_public. Same goes for ChromiumBaseInputConnection. It is used for testing only - didn't feel like it deserves relocation to content_public. Rewrote the API |ImeAdapter.getInputConnectionForTest| to return |InputConnection| instead of |ChromiumBaseInputConnection| to hide it in the interface though. It's still in DEPS exception for javatest package to allow chrome/webview test to use it. - Now we have more objects in CVC that are managed via WebContentsUserData, did a tiny refactoring to avoid using too many |isAlive| scattered around the class. |onFocusChanged| in particular, there are not much cleanup worth doing if it is called after CVC is destroyed, and hence losing the focus. For which case it just hides popups and returns. - Removed a method left unused (updateAfterSizeChanged). Bug: 789000 Change-Id: Iddfb7672d1789016745223837dea0d4dd5585e50 Reviewed-on: https://chromium-review.googlesource.com/867177Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#530292}
-
John Abd-El-Malek authored
Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ida11d6dc98e31a6a09f8ea260dd2e5da2507ac81 Reviewed-on: https://chromium-review.googlesource.com/874551Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#530291}
-
Stephen McGruer authored
MaterialBookmarksDNDManagerTest.All is flaky on Win7 Tests (dbg) Bug: 803570 Change-Id: If26d0c077e787f80c278d7d0e9d11622bf0b3b51 TBR=dpapad@chromium.org Change-Id: If26d0c077e787f80c278d7d0e9d11622bf0b3b51 Reviewed-on: https://chromium-review.googlesource.com/874793Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530290}
-
Fadi Meawad authored
The first reland caused a major regression in Android Webview bots running with a single process, since Webview had a bug that did not propagate the background state properly to the renderer scheduler. This bug was fixed in: https://chromium-review.googlesource.com/c/chromium/src/+/865769 > Original change's description: > > Reland "[PageLifecyle] Move the launch process state to Webkit/common" > > > > This is a reland of 99a51fca > > > > The failures described in crbug.com/796940 was result of throttling > > the scheduled tasks as a result of the new backgrounding state. > > > > The fix foregrounds the RendererScheduler before running the tests > > to avoid throttling. > > > > Original change's description: > > > [PageLifecyle] Move the launch process state to Webkit/common > > > > > > This CL introduces Webkit/common/page/launching_process_state.h that > > > includes the launch background and launch boosted state. > > > > > > The reason this file is needed, is because the state is different per > > > OS but needs to be consistent between the RenderProcessHostImpl and > > > the RendererSchedulerImpl. To prevent future changes in one not > > > reflecting in the other, the code is moved to a common place and > > > shared. > > > > > > This CL fixes an issue where the scheduler assumes that it is > > > foregrounded while it is actually backgrounded during the initial > > > phase on Android. > > > > > > Bug: chromium:780191 > > > Change-Id: Ib8dbfb6447f58c8b998a94ae2c69f8bc906d150f > > > Reviewed-on: https://chromium-review.googlesource.com/815678 > > > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > Reviewed-by: Bo <boliu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#525563} > > > > TBR=haraken@chromium.org,boliu@chromium.org > > > > Bug: chromium:780191,chromium:796940 > > Change-Id: I117afad3b910239656dbc7e9dc3a1447291263a9 > > Reviewed-on: https://chromium-review.googlesource.com/840340 > > Reviewed-by: Fadi Meawad <fmeawad@chromium.org> > > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#525841} > > TBR=boliu@chromium.org,fmeawad@chromium.org,haraken@chromium.org,oysteine@chromium.org,altimin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:780191, chromium:796940, chromium:798310 > Change-Id: I0c8b7e075c29761d2a6f0d02461551b651682748 > Reviewed-on: https://chromium-review.googlesource.com/847653 > Reviewed-by: Fadi Meawad <fmeawad@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526586} TBR=boliu@chromium.org,altimin@chromium.org Bug: chromium:780191, chromium:796940, chromium:798310 Change-Id: I213457c16ee09f272c5e188bc88e915e23ed40ea Reviewed-on: https://chromium-review.googlesource.com/871370 Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#530289}
-
Carlos Knippschild authored
We have detected unusual metrics coming from the wild that seem to indicate that Chrome instances have had limitless mode enabled. This CL hard codes the disabling of limitless mode, overriding the feature flag state, so that we can decide on fixing or fully removing it. Bug: 793109, 803584 Change-Id: I4fc58f195ff0abf324bf86e2e7fe985ecaea5a3e Reviewed-on: https://chromium-review.googlesource.com/874614 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#530288}
-
chrome://flags#enable-webauthenticationKim Paulhamus authored
This patch adds a flag to enable support for PublicKeyCredentials in CredentialManager. Bug: 664630 Change-Id: Icbdfc6318dd1d3bce65136e826f2bb1f4da1c04e Reviewed-on: https://chromium-review.googlesource.com/873390 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530287}
-
danakj authored
This RAII object, InUsePoolResource wraps an underlying backing from the ResourcePool, and verifies at runtime that the object is passed back to the ResourcePool exactly once to indicate the backing is no longer in use and release it into the pool again. The RAII object exposes the backing but requires the caller to know if they are expecting a software or gpu backing when they ask for it. This means that TileManager can no longer try to access the backing, and must always go through the RasterBufferProvider. It was already doing this mostly, but the API was a bit lazy and leaked the backing info (the ResourceId) into TileManager in a couple places, so we must resolve that and make it use InUsePoolResource exclusively. PictureLayerImpl grabs a ResourceId off the TileDrawInfo as before, but it is explicitly marked as an id meant for export to the display compositor, as opposed to a backing that can be written to. For now the backing is still a ResourceId for both software/gpu and it is written to via the ResourceProvider locks, but this sets us up to be able to change that. R=vmpstr@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I79292834482a8d1a3858d61a8313f14b3221337e Reviewed-on: https://chromium-review.googlesource.com/868713Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#530286}
-
Kyle Horimoto authored
This URL parameter will be used by Google Help's back-end to determine which page to serve for pages which have different content based on the device type. Bug: 788897 Change-Id: Ie3438010ee4a4a3e13ca01dea03aa9bd628d2cd4 Reviewed-on: https://chromium-review.googlesource.com/872196Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#530285}
-
Robert Ma authored
Apart from a few timed out tests, one test has non-deterministic output, and the other is pass-failure flaky. Bug: 800570, 709227, 803200, 803558 Change-Id: I86d5a14f26fcab6b862cd2e1b2108c10db4ee94e Reviewed-on: https://chromium-review.googlesource.com/871138 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#530284}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/28cb9a764765..4aadb7086420 $ git log 28cb9a764..4aadb7086 --date=short --no-merges --format='%ad %ae %s' 2018-01-18 thestig Avoid integer overflows in CJBig2_Image::composeTo_opt2(). Created with: roll-dep src/third_party/pdfium BUG=802983 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idf932d7194798e74a27098db0d3e485223b10078 Reviewed-on: https://chromium-review.googlesource.com/874720 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530283}
-
Filip Gorski authored
This patch adds tracking to: * BackgroundTaskSchedulerImpl * BackgroundTaskSchedulerPrefs In order to understand how much time we spend in these routines and find a link to performance issue on webview startup. Bug: 763955 Change-Id: I92e9614dec572211fa31d61d8ab6dfcad96bc829 Reviewed-on: https://chromium-review.googlesource.com/687966Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#530282}
-
Miguel Casas-Sanchez authored
This CL disables GLImageIOSurface/GLImageBindTest/1.BindTexImage (i.e. with gfx::BufferFormat::BGRX_1010102) that seems to be failing on Mac Book Pro 10.13 bots with nVidia GeForce 750M "(4.0.8 [3.2.8])". Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I817f489ef47a387a0d174fb084ed6717fe8c86d1 Reviewed-on: https://chromium-review.googlesource.com/874795Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#530281}
-
Marijn Kruisselbrink authored
blink::BlobData now creates mojom::DataElement instances directly. TBR=kinuko@chromium.org Bug: 740588 Change-Id: Ied990349baec9ba89ad95b2253b35adcad1a6679 Reviewed-on: https://chromium-review.googlesource.com/872610 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#530280}
-
Mohamed Heikal authored
This change makes local_device_instrumentation_test_run.py read the package name from the _test_instance.apk_under_test.GetPackageName() rather than from the _test_instance.package_info.package which may not be available. Bug: 799228 Change-Id: I3cff31d4e9888597719a5be629cd4480e6a58e1d Reviewed-on: https://chromium-review.googlesource.com/850816Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#530279}
-
rbpotter authored
Bug: 803404 Change-Id: I2079c15f3de84549748b058cfcd498c54ca50516 Reviewed-on: https://chromium-review.googlesource.com/874630Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#530278}
-
Greg Kerr authored
This resolves performance and stability issues with the GPU process when run under the V2 sandbox. Its add an API call to prevent the sandbox from waiting on launchservicesd, and allows access to necessary mach services. Bug: 797730 Change-Id: If5690bf2b76bb7ec66f4644b3795b1a6ce4baecd Reviewed-on: https://chromium-review.googlesource.com/865945Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#530277}
-
Stephen McGruer authored
This is flaking hard on mac_chromium_rel_ng, and is blocking tryjobs. Bug: 800840 Change-Id: If79dd7e475aad28cd93d22dbfb699c058efb056f TBR=sahel@chromium.org Change-Id: If79dd7e475aad28cd93d22dbfb699c058efb056f Reviewed-on: https://chromium-review.googlesource.com/874896Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530276}
-
Alexey Kozyatinskiy authored
- removed last test, this test checks how breakpoints work when UISourceCode has no real script behind. It is hard to reproduce this case without persistent and persistent should cover this case, - removed breakpoint manager test infra. R=lushnikov@chromium.org Bug: chromium:872239 Change-Id: I0753eccbc8f33519c37f3018aa4f7957329daf2d Reviewed-on: https://chromium-review.googlesource.com/874780Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530275}
-