- 30 Jun, 2020 40 commits
-
-
Filip Gorski authored
Failures happen mostly: * network_service_out_of_process_chrome_public_test_apk, however * chrome_public_test_apk also occasionally fails TBR=gangwu@chromium.org, tedchoc@chromium.org Bug: 1100967 Change-Id: I09180f254ce4566dae3b680b7a5091f474d3528b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274319Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#784046}
-
Robert Phillips authored
With the Skia-side CL: https://skia-review.googlesource.com/c/skia/+/298751 (Be more consistent about calling release procs in SkImage factories) the following SkImage factories guarantee they will call a provided releaseProc on a null return: MakeFromCompressedTexture MakeFromTexture MakeFromYUVATexturesCopyWithExternalBackend MakeFromYUVTexturesCopyWithExternalBackend MakeFromNV12TexturesCopyWithExternalBackend This CL cleans up the relevant call site. Bug: 1097484 Change-Id: I5471fad8df981c7976bdf702575e7cdc91bf9177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264598 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#784045}
-
Steven Bennetts authored
Bug: 1099902 Change-Id: Ibd638587346ccf7060914297f7c4f1f98fcc4dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271081 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#784044}
-
Abigail Klein authored
The UI spec (go/chrome-live-caption-ux) was approved by the Chrome UI reviewers. This CL updates the caption bubble to the spec in the following ways: 1. Change the title text to "Detecting speech..." 2. Left-align the title text and error text 3. Make the error text on one line and update the error icon size when the caption font size changes 4. Add a tooltip to the close button 5. Change the size and color of the close button hover 6. Match all of the sizing specs, such as padding and margin Screenshot of the changes: https://screenshot.googleplex.com/wTduQB95d59 The one remaining spec change needed is to update the focus state, which will be done in a follow-up as it requires more investigation. Bug: 1055150 Change-Id: I9f0b79ecc7f875e4f04f92bf8eea7c2b598f2169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275369Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#784043}
-
behdad authored
The platform specific tags are updated with: - Correct OS names for mac bots - Appropriate master tag were added to the platform specific tags Adjust_upper_limits script is updated to support master tag provided. Bug: chromium:1094379 Change-Id: Icccaf162a42def7ca1413ecf673c00841e9b4056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250349 Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#784042}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bc4525604b66..5f4e87cd92c2 2020-06-29 navil@google.com cbuildbot: Skip Update ChromeOSLKGM stage for basic-builder. 2020-06-29 quasisec@google.com config: add puff back to hw testing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3aa39adb03df4722cccb884bb3eba645a5dd72c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784041}
-
Chris Harrelson authored
direct compositing reason. Previously we omitted one for squashed layers, but we should also do so for layers which hit a squashing-disabled reason. There are three reasons to make this change: * The only reason to allocate a paint offset translation is in order to reduce invalidations when the layer moves, but these layers are not intended to be composited by the developer. * This makes pre-CAP behave more like CAP. * It removes a dependency of property trees on the result of the overlap test. Bug: 1100711 Change-Id: If5b32d49521189fe62ecad32a1baf4e142fcc262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274253Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784040}
-
Rakib M. Hasan authored
This reverts commit 4500c34d. crrev.com/c/2273620 was missing several variable declarations. This CL adds those declarations. Bug: chromium:960606, chromium:952105 Change-Id: Id3b7d830b39409675ae6ed7f01da8bbaa74d6507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274366Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#784039}
-
John Delaney authored
If initialization fails to initialize, we reset the |storage_| pointer. This allows possible null pointer exceptions if there are later calls into manager. This change simply removes this pointer reset, as the storage layer itself is robust to initialization failures. Bug: 1088072 Change-Id: Ieda3b4043f55b94add921217abd58ec7971c138e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270703 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#784038}
-
Ghazale Hosseinabadi authored
This CL enables ExtensionService::ReloadExtension() to handle reload failures, where subsequent calls can retry the reload, rather than immediately giving up. Bug: 792277 Change-Id: I482da093133a1baee7f2f5cad8abbc9c85e9e074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242642 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784037}
-
Nate Chapin authored
* Remove the Document and DocumentLoader variants of CountDeprecation, so only the ExecutionContext variant remains. * Move the special-cases in Document::CountDeprecation to Deprecation::CountDeprecation * Add a Deprecation object to WorkerOrWorkletGlobalScope to track deprecation de-duplication, instead of having its own custom tracking * Deprecation::CountDeprecation can inspect the appropriate Deprecation object to determine whether the deprecation has already been reported, and it can then do the requisite use counting, console messages and deprecation reports based on the ExecutionContext it was provided. * UseCounter::CountDeprecation is now no longer necessary, its subclasses don't do anything. Bug: 1029822 Change-Id: I07f42a49d6371321b4fedde208a586ecda90ea23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261444 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#784036}
-
Nazerke authored
This CL removes a|SyncedWindowDelegateBrowserAgent| from TabModel as a part of a tabmodel deprecation. Bug: 1045575 Change-Id: I9e5b6868348f9ec6039746eec0082787bd17868a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232944Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#784035}
-
Ben Wagner authored
The SK_WHITELIST_SERIALIZED_TYPEFACES this controls is no longer used. Change-Id: Ibb1d635e9db1eda3f83af661f0e75909f5a79933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276292Reviewed-by:
Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784034}
-
Teresa Kang authored
To show that willReadFrequently solves crbug.com/1013323, getImageData perf test needs to be run with willReadFrequently set to true. Pinpoint tests will be run against CL 2238991 with getImageData-cpu.html. New perf tests are added to benchmarks_to_shard.json to be included in the benchmark: blink_perf.canvas. Bug: 1090180 Change-Id: I07cbdc18f9145160a6614afa8b9b35724796a5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271527Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#784033}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8f4251a70801..c858d7bd811e 2020-06-30 johnkslang@users.noreply.github.com Merge pull request #2301 from ben-clayton/split-libs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ia65c305ed3921ce3414fe4da84058bad7260a77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276334Reviewed-by:
-
Maks Orlovich authored
Before this CL, the entire settings map was sent to the renderer, it then parsed accept-ch, and sent IPCs to the browser to persist settings. This has following downsides: 1) client-hint settings map can leak history to render (I don't know if there are other sources of that, probably, so maybe not such a big deal) 2) If this becomes popular, map size would be a performance risk 3) This requires trusting renderer to update client hint settings. Instead, this uses existing network service hook to parse accept-ch (which was needed for navigation redirects), and the browser persists the results and sends the relevant client hint configuration to the renderer with CommitParams. The IPC for renderer to write config is therefore removed. This required teaching the browser code to behave more consistently with some flags (lang, accept-ch-lifetime support). Change-Id: I421b3c07d4644e179a0f6a26088e44c55f68f7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081628 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#784031}
-
sandromaggi authored
This adds integration tests for the new step progress bar. It also adds disabling of animations. Bug: b/158750294 Change-Id: I6c49d5768dbcc4ce57f5ce5c3801931ec9207744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275440 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#784030}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55d3cca75729..b0452c2e8370 2020-06-30 sigurds@chromium.org Add missing dependency 2020-06-30 sigurds@chromium.org Remove legacy support that may crash the DevTools renderer 2020-06-30 sigurds@chromium.org Add missing dependency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I69e6f7de689d889740a9c9a6ba5de1a3d10e3a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276162Reviewed-by:
-
dpapad authored
compress="gzip" is (as of r761031) the default behavior for HTML/CSS/JS/SVG files, and therefore there is no need to explicitly specify it. Bug: 1068407 Change-Id: Id1a7c4429b97fc0ed9059e71b02adc1450cf3054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265239Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#784028}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d55c3eec..584a47eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2908fba8f8482d92503b71882d04085c01f08561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275101Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784027}
-
Jérôme Lebel authored
-UnifiedConsentCoordinator.uiDisabled needs to remain. crbug.com/1003737 was suggesting to make the SigninViewController add ActivityOverlayCoordinator for the full sign-in view. It would not be a good idea since the Cancel button would not be tappable anymore. Plus, an activity indicator is already displayed instead of "Yes I'm In" button, when the sign-in process is triggered. Fixed: 1003737 Change-Id: I57a5390b27ffa0f475a04962d7a53e3506224ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273192Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#784026}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie18680865b9b0fb9e8e071e4064971969b31b3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276331Reviewed-by:
-
OlivierLi authored
Some pages update the title/favicon to produce a "blinking" effect that is meant to catch the user's attention. Once such an update takes place the intensive timer throttling intervention should be inhibited for a few seconds, to allow a timer to perform another update, which will produce the "blinking" effect. The existing 1-second alignment is still applied while intensive throttling is inhibited. Bug: 1075553 Change-Id: Ie344c5880eb1cbe6037142297b5038a3fb7275ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259488 Commit-Queue: Oliver Li <olivierli@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#784024}
-
Nico Weber authored
Hopefully still enough to have an arm64 compiler-rt while keeping the rest of the script mostly as it was before https://chromium-review.googlesource.com/c/chromium/src/+/2269512 Bug: 1098899 Change-Id: I67385083126d2d1e75599b0bd201e8bc9894809b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274590Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784023}
-
Filip Gorski authored
TBR=aluo@chromium.org Bug: 1100950 Change-Id: I36285b4341a6952414ab5e52d085645141a90e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276333Reviewed-by:
-
Takashi Toyoshima authored
This patch adds a new WebView specific base::Feature to control newly introduced origin checks to reduce unexpected compatibility breakages. Bug: 1096677 Change-Id: I28c9fadc6ee5ce0f06017c4977358a3566d6c159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265709 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#784021}
-
kylechar authored
OutputSurfaceProviderImpl would segfault in viz_demo because |gpu_service_impl_| is null for software compositing. Bug: 1094389 Change-Id: Ief873c16bd36a14ef3d37428972a796fed1f2196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270712 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
The dependency bug on Gaia infrastructure (b/157015322) was fixed so it is now safe to enable feature kUseNSURLSessionForGaiaSigninRequests by default. This CL enables this feature by default. The finch kill switch is kept to ensure that we can disable the feature in case of any regression. Bug: 944442 Change-Id: I8a4bcfecd0d7816fd4b00308ab9c925341dbeb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247023 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784019}
-
Himanshu Jaju authored
Bug: 1082305 Change-Id: I0018ce068d2820befccf5e69c833725940690bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273141 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784018}
-
Daniele Castagna authored
crrev.com/c/2220482 used the in_fence in OnPresentation to fill ready_timestamp. We incorrectly assumed that OnPresentation is always called after the in_fence is signaled. When that was not the case, a DCHECK was triggered. This patch fixes that, restricting the assumption that the in_fence is signaled to only when the presentation feedback is valid. Bug: 1100376 Test: DCHECK doesn't trigger when the screen is off Change-Id: If038c1aefa6c0dc2f7d87c10648b1577ff85e4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274098 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#784017}
-
Roman Sorokin authored
This CL adds more comments to UserType enum to better describe individual values. Fixed: 1082681 Change-Id: Ief87757e45b1c353f9752b8b8d4af804bcbabde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212278Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784016}
-
dpapad authored
Use a Polymer binding to pass down |docLength| and |pageNo| instead of programmatically updating the toolbar. Also update the old <pdf-viewer-toolbar> to use the same mechanism, for simplifcity. Fixed: 1100432 Change-Id: Ifbd6b0230094bd7e82861ed2d00cf1271cc727ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274185Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#784015}
-
Javier Ernesto Flores Robles authored
Prefixing the data will stop a problem caused by two instances of Chrome sharing the same data in the app group. Move to standardUserDefaults what doesn't needs to be shared. Bug: 1090397, 1094282 Change-Id: Id34b4ba8c22b39bb7d35c5c9094f574be341ca58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275892Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784014}
-
Sammie Quon authored
Follow up to crrev.com/c/2258687. That was originally done in cros shelf code as it was intended to be merged. Test: manual Bug: 1100467 Change-Id: Ibe54a8a95dd2aaeff515c221fd13c349488d2bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274669Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#784013}
-
Richard Knoll authored
This adds various new folders for WebUI resources to the watchlist for Nearby Share. Bug: None Change-Id: I561866d6e3b190e2b7d3b1c8ac926562fae6b445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274507Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a72bd10ae637..162e2b2eb46e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC parastoog@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058102 Tbr: parastoog@google.com,drott@google.com Change-Id: I7e0f05cca1437e28a529f0027c12ebd09139302a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276155Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784011}
-
Guillaume Jenkins authored
Moves BrowserDMTokenStorage to components/enterprise so it can be reused on iOS. Unit tests will follow in a separate change to keep the CL from getting too big. Bug: 1091929 Change-Id: Id2f854b004d70d593bc28e735b478251d3aec7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267645Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#784010}
-
Nate Fischer authored
This is a mostly mechanical renaming CL to change AwSafeBrowsingWhitelistManager to AwSafeBrowsingAllowlistManager (and related methods). Notable exceptions: * We inherit some "whitelist" methods from //components/safe_browsing/ types. This does CL does not change that layer. * This leaves the old name for the API stubs for the setSafeBrowsingWhitelist() Android/AndroidX API for a follow-up CL, as these are more complex to change. * This prefers "allowed" over "allowlisted" because "allowed" is already a verb. Fixed: 1097242 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest.* Test: android_webview_unittests -f AwSafeBrowsingAllowlistManager.* Change-Id: I1d8568e0de4da6d02aba18128feb0eb749f319ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274364Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784009}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/62f7f26355fd..b5d9bdb51608 2020-06-30 fmayer@google.com Pass const parameter by reference. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I43ef03f6119f28950807261bdda9b277fb5aedd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276167Reviewed-by:
-
Samuel Huang authored
SuperSize-archive should have only one main input file, and this restriction was enforced in crrev.com/c/2263012. However, the CL broke diagnose_bloat.py, which mixes --elf-file with -f. This CL fixes the above by having diagnose_bloat.py use --aux-elf-file to specify ELF (instead --elf-file) if the main input is APK. Bug: 1040645 Change-Id: I2055def74e5e39446e62f89fb26aa1e5e3ec9c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276391Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#784007}
-
