- 24 Oct, 2018 40 commits
-
-
Yi Gu authored
This test started to crash on linux-xenial-rel. Suspecting the patch crrev.com/c/1286425. TBR the owner and merge the bug to the LayoutNG meta bug. TBR=mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Ib5c8c74f80ce9e2b4c0215504a39bfd1695eb823 Reviewed-on: https://chromium-review.googlesource.com/c/1297734Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602240}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I0dcfcf2bf08021590984dedd56efe43c36e94625 Reviewed-on: https://chromium-review.googlesource.com/c/1297483Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#602239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc77baee. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." 57cc1d42 "Added 304 CSP test and removed "content-*" prefix from headers to ignore on 304" 89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26611 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/workers NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I940b69a43f4cd022459673c471ff50cde4e836d3 Reviewed-on: https://chromium-review.googlesource.com/c/1297729 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602238}
-
Scott Violet authored
Which is used in some tests. BUG=889101 TEST=covered by tests Change-Id: I2757361aed21909b8020fe0f9e7c600fe88f950c Reviewed-on: https://chromium-review.googlesource.com/c/1297408 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602237}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c6a85907fbdd..685b5de1133a git log c6a85907fbdd..685b5de1133a --date=short --no-merges --format='%ad %ae %s' 2018-10-23 eakuefner@chromium.org [Dashboard] Rewrite/remove add_histograms_queue TODOs Created with: gclient setdep -r src/third_party/catapult@685b5de1133a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iea2b3ad4e7fb9a37f09ac6fc10f8052d23c24cbc Reviewed-on: https://chromium-review.googlesource.com/c/1297669Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602236}
-
Antonio Gomes authored
In a follow up step UserCloudPolicyTokenForwarder will be migrated away from using ProfileOAuth2TokenService, in favor of PrimaryAccountAccessTokenFetcher. BUG=893504 Change-Id: I3b1f96a46e5ef61a8f6b796af37f344deef3023f Reviewed-on: https://chromium-review.googlesource.com/c/1296873Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#602235}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f52fb7021299..d86805176f39 git log f52fb7021299..d86805176f39 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 tsepez@chromium.org Be more particular about FX objects constructed from JS 2018-10-23 thestig@chromium.org Pull in current Chromium IMMEDIATE_CRASH() implementation. 2018-10-23 tsepez@chromium.org Test color.convert() and equal() from JS (and fix comparison logic). 2018-10-23 tsepez@chromium.org Split field.in into field_properties.in and field_methods.in 2018-10-23 tsepez@chromium.org Remove CJS_Field::ValueIsOccur() 2018-10-23 tsepez@chromium.org Remove CJS_Report class. Created with: gclient setdep -r src/third_party/pdfium@d86805176f39 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic6f03fddbacc45e87954ccec3da4701ac284eb4a Reviewed-on: https://chromium-review.googlesource.com/c/1297120Reviewed-by:
-
Tetsui Ohkubo authored
This is the first part of three CLs removing old MessageListView code. The split is suggested in the review. https://crrev.com/c/1292667 (1) Removing the old implementation (2) Removing the flag (3) Renaming the implementation TEST=trybot pass BUG=870801 Change-Id: Id5c31fa38a6df4bae3b991b2a88950d01b4b1979 Reviewed-on: https://chromium-review.googlesource.com/c/1295613 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#602233}
-
Esmael El-Moslimany authored
Bug: 888922 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7ab9988ec40f715979cf94ec2d8fd94e87723d4f Reviewed-on: https://chromium-review.googlesource.com/c/1277868 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602232}
-
Alan Cutter authored
TBR=creis@chromium.org Bug: 898370 Change-Id: Ic868afff813491718b30d2cd36b12307c09cdd9d Reviewed-on: https://chromium-review.googlesource.com/c/1296937Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602231}
-
Aiden Benner authored
Even though String is an object (and so being casted to jobject across the jni boundary would make sense), the JNI spec gives special treatment for java string types and they're casted to jstrings instead of jobjects. This change makes sure Strings stay as Strings in the native method declaration. Previously all non-primitive types would be casted to objects. Also fixed a bug where void was being cast to object (this happened because void is non-primitive). Also adds better array support. Arrays with a primitive component type will stay as primitive arrays but arrays with a non-primitive component type will be casted to an object array. Change-Id: If795bcddf7a38f051d0c6fb515e1dd320dd3f30d Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1297083 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#602230}
-
Ken Rockot authored
Introduces generation of smaller JS mojom bindings. This implementation is incomplete, lacking support for unions, associated interfaces, and versioning. It's still sufficient for many existing WebUI use cases. The new bindings also present more ergonomic/webby interfaces for things. See bug and documents linked therein for details. The old concatenated mojo_bindings.js sits at around 155 kB, and the new mojo_bindings_lite.js is around 47 kB uncompiled. With compilation enabled it's 21 kB, a net reduction of ~86%. On platforms where the build supports Closure compilation, the common bindings library is always compiled. Bug: 894376 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I47dafbca77dccd6a45a829d21c33679440da0a2f Reviewed-on: https://chromium-review.googlesource.com/c/1278470Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#602229}
-
Yi Gu authored
This test is consistently slow on Mac 10.13. TBR=sahel@chromium.org NOTRY=true Bug: 898378 Change-Id: I09c144a06023918f6b4965409cecdb7743c095dc Reviewed-on: https://chromium-review.googlesource.com/c/1297733Reviewed-by:
-
Ehsan Chiniforooshan authored
This should be submitted after https://chromium-review.googlesource.com/c/catapult/+/1286371 Bug: 890757 Change-Id: I1185895b778024fd8c2f64a6597899cb717c6610 Reviewed-on: https://chromium-review.googlesource.com/c/1287029Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#602227}
-
Adrienne Walker authored
In looking at some sampling profiles, it turned out that these commands (set/reset url and the query commands) were all causing unnecessary RestoreState in RasterDecoder. As these don't touch gl state, whitelist them so that they don't cause extra work. Bug: 894200 Change-Id: I54837830d7df3b5333b3a3e8e42d9232ef8e8b41 Reviewed-on: https://chromium-review.googlesource.com/c/1297592 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602226}
-
Renee Wright authored
This allows up to discriminate between container setup errors and container startup errors in the UMA Bug: 898043 Change-Id: I71921b6980c3f1f85c27ecee178db64a93bed232 Reviewed-on: https://chromium-review.googlesource.com/c/1295630Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#602225}
-
Karan Bhatia authored
This CL adds a csp_validator::ParseCSP method to parse a CSP string. Existing code doing the parsing is changed to use this new method. This CL should have no behavior change. Also add unit tests exercising the new method. BUG=896041 Change-Id: Ic97e31ab23b6d21c0b3ad4b771a2fd7c37bec6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1292825 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602224}
-
Esmael El-Moslimany authored
Bug: 897050 Change-Id: I0d3a758917d44ea9841e78696b1be829b20b3596 Reviewed-on: https://chromium-review.googlesource.com/c/1297636Reviewed-by:
-
HyeockJinKim authored
Bug: 866923 Change-Id: I7e68f4b199ae41280e3745d47849fe3557d24661 Reviewed-on: https://chromium-review.googlesource.com/c/1257723 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602222}
-
Alan Cutter authored
This reverts commit 3b3248da. Reason for revert: Test crashing on all bots. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931832645289538640/+/steps/blink_platform_unittests/0/logs/BitmapImageTest.DecoderAndCacheMipLevels/0 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&tests=BitmapImageTest.DecoderAndCacheMipLevels https://bugs.chromium.org/p/chromium/issues/attachment?aid=364338&signed_aid=j6fGrtk-5lTyU5qtiDtjbg==&inline=1 Original change's description: > Move image resources for bitmap_image_test to /testing/data > > This pacth means blink/renderer/platform/graphics/bitmap_image_test.cc > loads images from blink/renderer/platform/testing/data. > This will more cleanly separate the unit test and layout test data. > > Bug: 898155 > Change-Id: I34f582f127df6fff8634aaff66893fb27abffaaa > Reviewed-on: https://chromium-review.googlesource.com/c/1296870 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> > Cr-Commit-Position: refs/heads/master@{#602168} TBR=pdr@chromium.org,jdragon.bae@gmail.com Change-Id: I2996bdfa2fdf7bcba544b8925bc33da5b634a8df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898155 Reviewed-on: https://chromium-review.googlesource.com/c/1296938Reviewed-by:
-
Yi Gu authored
This test started to fail after crrev.com/c/1296870 which was landed 4 hours ago. Disable the test and assign the bug to the owner. TBR=jdragon.bae@gmail.com NOTRY=true Bug: 898372 Change-Id: I7b3d8ba10535caed7226b295d74537ac7e5dfeda Reviewed-on: https://chromium-review.googlesource.com/c/1297715Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ade44ef019d0..f57470be7f99 Created with: gclient setdep -r src-internal@f57470be7f99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8680a11783ed6a2c72b67cb54faa961156a16ebe Reviewed-on: https://chromium-review.googlesource.com/c/1297608Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602219}
-
Peter K. Lee authored
In http://crrev/c/1272598, a new enumerated value for FirebaseConfiguredState was added. This adds to enums.xml for display in frontend tools. Bug: 892880 Change-Id: I1d3794ef4fdd3c0eaa824e34f43afd2bc0f9c41b Reviewed-on: https://chromium-review.googlesource.com/c/1297450Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#602218}
-
Ken Rockot authored
See bug for context. Bug: 872076 Change-Id: I6aa25842174facb56f3e74fa88d99caf4d1d9680 Reviewed-on: https://chromium-review.googlesource.com/c/1297061Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#602217}
-
dpapad authored
Bug: 896581 Change-Id: Ie8542938f8eb92670ea17fd8a8feb9df91368040 Reviewed-on: https://chromium-review.googlesource.com/c/1297599Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602216}
-
liberato@chromium.org authored
To try to reduce time to first frame regressions, this CL makes D3D11VideoDecoder fall back to VDAVideoDecoder via FallbacKVideoDecoder. This prevents a round trip or two between the GPU and renderer processes. This relands https://chromium-review.googlesource.com/c/1294810 with a fix to prevent deleting the preferred decoder during a failed init callback. Instead, it posts destruction. Bug: 832917 Change-Id: I24173ef8c4005961ed8ec0a9125b136b7267e6a7 Reviewed-on: https://chromium-review.googlesource.com/c/1297006Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#602215}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7259c048b9a3..f52fb7021299 git log 7259c048b9a3..f52fb7021299 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 tsepez@chromium.org Remove JSMessage::kRunSuccess and its string Created with: gclient setdep -r src/third_party/pdfium@f52fb7021299 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie08ba8bb3d27340ddac9f81e10192bc5a8e99b60 Reviewed-on: https://chromium-review.googlesource.com/c/1297273Reviewed-by:
-
Toshiki Kikuchi authored
This CL allows to show the notification with buttons in create_notification request, and allows Exosphere to handle this request. Also, this CL adds clicked event for that protocol. BUG=chromium:838531 TEST=NotificationTest.*, manual verification Change-Id: Ib7d0693695afac5c732a8c0808a9b3250fa7a327 Reviewed-on: https://chromium-review.googlesource.com/c/1276045 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602213}
-
Tetsui Ohkubo authored
When notifications are manually expanded / collapsed, the state should be restored on UnifiedSystemTray reopen. In order to do that, we have to store the state in UnifiedSystemTrayModel so that it lives longer than the lifetime of UnifiedSystemTrayView & UnifiedMessageListView. TEST=UnifiedMessageListViewTest.KeepManuallyExpanded BUG=870801 Change-Id: I978b034e7c3467f2ddccf4cabcd984847da93518 Reviewed-on: https://chromium-review.googlesource.com/c/1286102Reviewed-by:
-
Hiroshi Ichikawa authored
Bug: 884047 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I38633533a62eb69d2b1c0ff305d88481f5078f87 Reviewed-on: https://chromium-review.googlesource.com/c/1273176 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#602211}
-
Joel Einbinder authored
This does the backend part of adding the remoteVersion into the query string. A follow up will use the remoteVersion to selectively apply only parts of the compatibility script. Bug: 898245 Change-Id: I2130e951a0368b4d565bfdc2bb03e2d327c2569f Reviewed-on: https://chromium-review.googlesource.com/c/1297236Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#602210}
-
chrome://accessibilityJames Wallace-Lee authored
Bug: 843313 Change-Id: I400d554ec0500899c238e3fa739586790ebda4a5 Reviewed-on: https://chromium-review.googlesource.com/c/1294514 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#602209}
-
Bret Sepulveda authored
Follow up to http://crrev.com/c/1297180. Test is only flaky on Win dbg. TBR=skyostil@chromium.org Bug: 867447 Change-Id: If2bc19e39bfa59519fca38424e27be08459a9958 Reviewed-on: https://chromium-review.googlesource.com/c/1297642Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#602208}
-
Katie Dillon authored
Chromium starts propagating errors from worker's onerror to window's onerror after https://chromium-review.googlesource.com/c/chromium/src/+/1287208, resulting in test failures for mixed-content/module-data-worker-import tests that do not account for the thrown exception being sent to the window. This CL adds preventDefault() to the worker.onerror() to handle the case of uncaught exceptions. Strictly speaking, this is not necessary according to the current spec, as "worker's error event" fired at Step 12.1 of #run-a-worker https://html.spec.whatwg.org/multipage/workers.html#run-a-worker does not cause "report the error" and thus window's onerror. But whether window.onerror is fired or not is not what the mixed-content tests aim to test. Change-Id: I571aaa85d90b5f933b6212691dcc783579b294be Reviewed-on: https://chromium-review.googlesource.com/c/1294535 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#602207}
-
Satoshi Niwa authored
Define ARC FileProvider URL constans in arc/fileapi/arc_content_file_system_url_util and have other files use them BUG=b:111816608 TEST=out/Default/unit_tests --gtest_filter="FileManagerPathUtilConvertUrlTest.*" Change-Id: I4fac43a8f2f1c48389e275dfe56f7bb39efd6ef9 Reviewed-on: https://chromium-review.googlesource.com/c/1295976Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#602206}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/29e179cc0d5f..962ec4e02afc git log 29e179cc0d5f..962ec4e02afc --date=short --no-merges --format='%ad %ae %s' 2018-10-23 dgarrett@google.com chromeos_config: Schedule nocturne/grunt firmwarebranch. 2018-10-23 yshaul@google.com chromeos_config: Migrate default_hw_tests_override to test config Created with: gclient setdep -r src/third_party/chromite@962ec4e02afc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9a9edb1e75f746d7088f16b28b2ed25f5e08dd9c Reviewed-on: https://chromium-review.googlesource.com/c/1297119Reviewed-by:
-
Hitoshi Yoshida authored
Running bindings_test on local machine without --reset-results removes all temporary generated cache files. In the process, we get a list of files to be removed, but it fails if the target directory does not exist. This happens when a test fails in some situation. This CL makes to skip iterating non existing directories. Bug: None Change-Id: Ib18dc2bd4ab8fa5d93863e5d29ca97cbd7241384 Reviewed-on: https://chromium-review.googlesource.com/c/1295757Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#602204}
-
Esmael El-Moslimany authored
Bug: 870732 Change-Id: I5cb196b87d339699be8bf5a2091e7e239d38b50d Reviewed-on: https://chromium-review.googlesource.com/c/1289302Reviewed-by:
-
dpapad authored
This fixes missing header text in chrome://settings/content/ subpages, when Polymer2 is turned on. Bug: 896621 Change-Id: I2c153ac69aca9c8e0b536e7af5388e412f9bc183 Reviewed-on: https://chromium-review.googlesource.com/c/1297597Reviewed-by:
-
Manu Cornet authored
Bug: 891416,886622,888205,887733,881684,822477 Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4 Reviewed-on: https://chromium-review.googlesource.com/c/1290056 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602201}
-
