GitLab

replace std::find() with base::containsValue()
at components/safe_browsing and components/search_engine
and components/signin

Bug: 561800
Change-Id: I0b100cd3e058cdf506cc59a6cf5ee4b6ee844c1a
Reviewed-on: https://chromium-review.googlesource.com/1107429Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#569068}

This is one of several patches that will remove the sequence version of
supportedMethods member. This patch stops using it by removing the
related code in renderer side.
  - [1/2] This patch
  - [2/2] https://crrev.com/c/1108057

The value of |supportedMethods| was changed from array to string, but
the name was left as a plural to maintain compatibility with existing
content on the Web. But it might reduce readability in implementation
perspective. So, using [ImplmenetedAs] extended attribute, this patch
just change a plural to |supportedMethod| internally.

Intent to remove:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU

Bug: 754779
Change-Id: I90e50a218b3e8d9e0d92e4b6293835a9b038231c
Reviewed-on: https://chromium-review.googlesource.com/1078687Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#569067}

replace std::find() with base::containsValue()
at components/update_client and components/url_matcher
and components/viz.

Bug: 561800
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If9e7a59fa41dec078dc7a8901d91dec390504f9b
Reviewed-on: https://chromium-review.googlesource.com/1107426Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#569066}

In VirtualKeyboardController, we query the keyboard container window to
determine which display it is on. As we're getting rid of the container,
we need to query the keyboard contents window instead. This should be
fine as keyboard contents always has the same bounds as the container.

Since we now need keyboard contents window for VirtualKeyboardController
/ KeyboardLayoutDelegate, we need to create the keyboard contents window
before calling the layout delegate in |PopulateKeyboardContents|.

Bug: 849980
Change-Id: I3f39358f8d500df0e864a5e88c526ac7a220b467
Reviewed-on: https://chromium-review.googlesource.com/1096586
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569065}

Change-Id: Iadb76c4c2165ee269ff72154365a6469873b3f1e
Reviewed-on: https://chromium-review.googlesource.com/1108506
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569064}

Migrate the LayoutTestBrowserMain and BlinkTestController classes to use
the quit closure registered with the content::Shell by the default main
message loop, to exit it, rather than QuitCurrent*Deprecated().

Bug: 844016
Change-Id: I0b7e8249df6ed62757e5bb27c51dd16b35e0e4a6
Reviewed-on: https://chromium-review.googlesource.com/1106814Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569063}

This CL implements the PerformanceEventTiming entry of type "firstInput"
whose explanation can be found at:
https://github.com/WICG/event-timing#first-input-timing

Bug: 841224, 851484
Change-Id: I40d799f1920ec2fc5fb9140a5e5faec6642a7f03
Reviewed-on: https://chromium-review.googlesource.com/1103230Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569062}

Previously WindowTreeHost::Create() was taking one argument for bounds.
That didn't allow to pass any other window initialization parameters.
Updated Create() to take PlatformWindowInitProperties instead of bounds.
Also updated it to return std::unique_ptr<> instead of raw pointer.

Bug: 829980
Change-Id: I8789cf9c8fb4deaca86eaff128f125cf7490994a
Reviewed-on: https://chromium-review.googlesource.com/1105130Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569061}

Convert AppLauncherTabHelper to a policy decider,  and update the RequestInfo
structure to take recent user interaction boolean.
Use the ApplauncherTabHelper to check for user interaction / request frame
and allow/reject requests based on that.


Bug: 850760
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3413958ce7fedb01e3d8e4f2bafe0a7b022e759e
Reviewed-on: https://chromium-review.googlesource.com/1101497
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569060}

Add the MediaRemoter implementation to the Mirroring Service. Mainly
ported over from the existing Media Router extension code.

Bug: 734672
Change-Id: I7dd8a0dab122f452e96c3fa6b188a92ebefd9c3d
Reviewed-on: https://chromium-review.googlesource.com/1086421
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569059}

Reland "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element"

This reverts commit f30471c5.

Reason for revert: Test failures don't appear to be related in any way. This is accessibility code that hasn't been turned on yet, i.e. it should never be running.

Original change's description:
> Revert "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element"
> 
> This reverts commit a65d8a04.
> 
> Reason for revert: I think this broken the layout tests on 32-bit Win10, see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36552
> 
> Original change's description:
> > Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element
> > 
> > R=​nektar@chromium.org,dmazzoni@chromium.org
> > 
> > Bug: 844149
> > Change-Id: I7e92097761057c8fb795582098f54daeb00ef204
> > Reviewed-on: https://chromium-review.googlesource.com/1099434
> > Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> > Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567899}
> 
> TBR=dmazzoni@chromium.org,nektar@chromium.org,suproteem@chromium.org
> 
> Change-Id: I0efca59b219cc9432d14e68f340c3dff12f4ef76
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 844149
> Reviewed-on: https://chromium-review.googlesource.com/1103502
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567904}

TBR=dmazzoni@chromium.org,dpranke@chromium.org,nektar@chromium.org,suproteem@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 844149
Change-Id: I0fc68b9b611e0b90b6fc5cf73bdf709020fba079
Reviewed-on: https://chromium-review.googlesource.com/1108937Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569058}

Add the document title in app.js instead of print_preview_new.html.
This also ensures that the title will exist in debug build browser tests
that only create print-preview-app.

Bug: 773928
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia9f7c01291a03011b3ffa5ec11618ed9688d4a6a
Reviewed-on: https://chromium-review.googlesource.com/1108539Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569057}

https://pdfium.googlesource.com/pdfium.git/+log/b6b01cb2cbaf..cc4802edc4fa


git log b6b01cb2cbaf..cc4802edc4fa --date=short --no-merges --format='%ad %ae %s'
2018-06-20 npm@chromium.org Fix a couple of CPDF_DefaultAppearance::GetFont usages
2018-06-20 tsepez@chromium.org Avoid more .c_str() usage, part 3


Created with:
  gclient setdep -r src/third_party/pdfium@cc4802edc4fa

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:853238
TBR=dsinclair@chromium.org

Change-Id: Ic52e974886de5023884a44852335bf096e1f0ebf
Reviewed-on: https://chromium-review.googlesource.com/1108897Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569056}

This will let any test invoked via test_env.py on swarming handle timeouts.

This should also cover xvfb.py:
https://chromium.googlesource.com/chromium/src/+/master/testing/xvfb.py#97

Bug: 733612, 848402
Change-Id: I33242bd6fe86072f0b32150eab6b878436252388
Reviewed-on: https://chromium-review.googlesource.com/1105022Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569055}

https://swiftshader.googlesource.com/SwiftShader.git/+log/1fa2067..20eea3c

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I7b790c182a42018424f4d34f9fb2a87cb7edf65c
Reviewed-on: https://chromium-review.googlesource.com/1108341Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569054}

Fuchsia recently changed the zx_channel_write() API to always consume
the supplied handles, by default, regardless of whether the call
succeeds in transferring them to the peer process.

Update the mojo::edk::Channel::Write() implementation to account for the
new semantics.

Bug: 854458, 754084, 740791
Change-Id: I27f78a09ff8bf2aaf94ac571678d4c2259b48b10
Reviewed-on: https://chromium-review.googlesource.com/1108970Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569053}

This CL creates a MediaLauncherActivity class that handles media VIEW
Intents and opens them in a media-viewing CustomTabActivity. The
MediaLauncherActivity is added to the manifest but is disabled.

Bug: 778276
Change-Id: I9111f446849722976c7e39c38f611ff3966cb9b7
Reviewed-on: https://chromium-review.googlesource.com/857324Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569052}

Bug: 853924
Change-Id: Ide62705b38858dc9d02658784bbfc02001e933bd
Reviewed-on: https://chromium-review.googlesource.com/1106277
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569051}

Menu horizontal spaces were consolidated into a single
item_horizontal_padding by crrev.com/c/1089431, which also made the
value come from the layout provider.

However, when Harmony is enabled, the horizontal padding becomes too
large (8 instead of 16). As a side effect, menus became too spacey on
Harmony (see details on the linked bug).

One alternative was to use DISTANCE_RELATED_CONTROL_HORIZONTAL_SMALL and
define the corresponding padding as 8 for Harmony, but that would
introduce a dependency from ui/views/controls to chrome/browser/ui/views,
which I don't think is desirable. In addition, while Harmony is rolling
out, making sure we don't break paddings on other browser components can
be challenging, so I added a TODO to make a general consolidation once
Harmony becomes the default.

Bug: 851843
Change-Id: Ifbecf12f434e20af8f93b590feed7eb4b2bc33de
Reviewed-on: https://chromium-review.googlesource.com/1108451Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569050}

Add the assessment assistant external component extension to the
allowlist for the enterprise.platformKeys API.

Bug: http://crbug.com/854695
Change-Id: I10441b4320174b128151bd83dcc4142f6d1fda57
Reviewed-on: https://chromium-review.googlesource.com/1108492
Commit-Queue: Jimmy Hastings <jhastings@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569049}

This CL adds SafeJsonParser::ParseBatch which also takes in a |batch_id|
parameter. This allows clients to potentially use the same process for multiple
usages of data decoder service.

BUG=852058

Change-Id: If23f0cad2e819a6d3a2c0a136aab57284937f20c
Reviewed-on: https://chromium-review.googlesource.com/1105565
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569048}

OptOutBlacklist is the interface now backing PreviewsBlackList. This
class handles set up, management of rules, synchronous/asynchronous
behavior, etc. PreviewsBlackList supplies params and type/URL friendly
interfaces to its consumers. PreviewsBlackList also records UMA.

Bug: 852593
Change-Id: I8dee819a4d6ab37b58f3ce2914b09cbbcf21d1d5
Reviewed-on: https://chromium-review.googlesource.com/1108479
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569047}

Prior to this change, Guest mode has an empty read-only DB and Incongito
has a read-only DB. This CL allows both profiles to write to an "in
memory" database that disapears when the profile is destroyed.

This improves the experience for the user and avoids the possibility
of using MediaCapabilites to detect incognito/guest profiles.

R=jam@chromium.org

Bug: 796280
Change-Id: I37e25478ce6efe8c25bf49f77929f94c9ca27655
Reviewed-on: https://chromium-review.googlesource.com/1092156Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569046}

Bug: 846424
Change-Id: I8162eb0abaeed40a75638165c71a2306c99e8d3d
Reviewed-on: https://chromium-review.googlesource.com/1097943
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569045}

This CL makes some changes to the media controls sizing. It changes the
small threshold to go up to 740px instead of 640px, it changes the
overlay play button size calculation to be smaller, and it changes the
icons to be smaller in the medium threshold.

Bug: 854361
Change-Id: Ic73d254361ffbb5b60bb974253d1abb48a8a04ce
Reviewed-on: https://chromium-review.googlesource.com/1107244
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569044}

Bug: 837501
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia55c5e302d70c1a65409fd7268ae135e0ee7c5ca
Reviewed-on: https://chromium-review.googlesource.com/1102904
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569043}

A local root  OOPIF has its own lifecycle but doesn't have its own
visual viewport layers so we'd crash when trying to process them. Only
try to process viewport layers for blink-gen-property-trees when we're
in the main frame.

TEST=Open chrome with --enable-blink-gen-property-trees and open any
site with an out of process iframe. Pass if renderer doesn't crash.

Bug: 854221
Change-Id: I423c90e5cbc7aa20be8541e8e7d89158233f774c
Reviewed-on: https://chromium-review.googlesource.com/1106668Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569042}

MSAN/ASAN correctly identified a user-after-free in
ClipboardMacTest::CreateImage(). Specifically, when using
CGDataProviderCreateWithData(), the caller is responsible for keeping the
data buffer referenced by the CGDataProvider alive as long as necessary.
ClipboardMacTest::CreateImage() incorrectly assumes that the buffer does
not need to be kept alive after an the CGDataProvider is used to create
an NSImage.

This CL implements a CGDataProviderReleaseDataCallback and passes it to
CGDataProviderReleaseDataCallback(), so the data buffer is only freed
after the CGDataProvider stops using it. This fixes the use-after-free.

Bug: 818167
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
Change-Id: Iafdc7a4b2448fd2d31bcd6f3078af69b8062c06b
Reviewed-on: https://chromium-review.googlesource.com/1108550
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569041}

If was considered redundant by UX designer and writer.

Bug: 850571
Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError --test-launcher-intera
Change-Id: I3630fabdc7cabec92106d75ed907faa1b72a64b1
Reviewed-on: https://chromium-review.googlesource.com/1107778Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569040}

Previous version (https://chromium-review.googlesource.com/c/chromium/src/+/1060254) had to be
reverted since it did not handle running off UI thread, which pre-change version did.

The reland is permitted by
https://chromium-review.googlesource.com/c/chromium/src/+/1108137
which removes the off-thread usage, and is identical except for:

1) Some additional sequence checking
2) Port of the one new client that showed up during lifetime of this CL
3) Test filter update.
(See patchset 1 for straight re-apply)

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9a039409fe8069df7d03242eb0eb579f4c11dc4b
Reviewed-on: https://chromium-review.googlesource.com/1098035
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569039}

This makes sure the DownloadContentTest.DownloadAttributeBlobURL test
works with mojo blob URLs enabled even when network service isn't
enabled. We want to ship Mojo Blob URLs before network service is ready
to ship, so need to support this in the downloads code as well.

This simply switches DownloadManagerImpl to use the network service code
path whenever a blob_url_loader_factory is passed in.

Bug: 800901
Change-Id: Ib2668a1a7b9544e29e796eb40ac8680265c7e82b
Reviewed-on: https://chromium-review.googlesource.com/1105477Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569038}

allow more inlining. Not flag protected.

Merge internal cl: 201354423

R=rch@chromium.org

Change-Id: I312d75438afadb385df223efd8bf7eec55296b52
Reviewed-on: https://chromium-review.googlesource.com/1108372
Commit-Queue: Bin Wu <wub@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569037}

Bug: 854181
Change-Id: Id2418b88928fcd998e67bed8f011f2dcbb4cc8f5
Reviewed-on: https://chromium-review.googlesource.com/1106293Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569036}

Implemented by Chrome, the majority is only used from within //chrome/,
and only from one callsite each. Thus the implementations can be inlined.
The one remaining method in the interface is only used for ash tests.
Resolving that and removing the interface altogether is TODO.

Bug: 826374
Change-Id: Ib808ae70f3cf87be688b05c3cec15f35e4e121b5
Reviewed-on: https://chromium-review.googlesource.com/1107128
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569035}

Wrongly used "^" and "|" in two tests, so the selection direction is not
matching the old tests.

This CL fixed these misuse.

Bug: 847192
Change-Id: I036c3a00eacb9ff4a7d8244ec40b3899aa68feb3
Reviewed-on: https://chromium-review.googlesource.com/1108742Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569034}

https://webrtc.googlesource.com/src.git/+log/beb2d9813c71..db6af36979b6


git log beb2d9813c71..db6af36979b6 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 aleloi@webrtc.org Add RNN-VAD to AGC2.
2018-06-20 yvesg@webrtc.org Add format check to `git cl presubmit`


Created with:
  gclient setdep -r src/third_party/webrtc@db6af36979b6

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ifb7a0dc76ead7c9687a3fb8f9dcd38c35570ba8d
Reviewed-on: https://chromium-review.googlesource.com/1108637Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569033}

There as been confusion regarding the term "bubble". As such, this CL:
- Renames AssistantBubbleController to AssistantUiController.
- Renames AssistantBubbleModel to AssistantUiModel.
- Renames AssistantBubbleModelObserver to AssistantUiModelObserver.
- Renames AssistantBubbleView to AssistantContainerView.

Bug: b:80542452
Change-Id: I7a9797da83d9bc3a53718aef5e76933fa43c1f3f
Reviewed-on: https://chromium-review.googlesource.com/1105134
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569032}

Bug: 840631
TBR: tandrii
Change-Id: Ie3794a3c74b9643a10596d106ffc12c31f7e599f
Reviewed-on: https://chromium-review.googlesource.com/1108552
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569031}

The feature is currently active at 10% on stable and it's time to make
it the default.

Bug: 717696
Change-Id: I7b6c3e162c6d475408b201a6c1417c89762f6b32
Reviewed-on: https://chromium-review.googlesource.com/1106484Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569030}

Commit fc5fe708 ("FrameSinkVideoCapture clean-up: Remove unused APIs,
style fixes") added the noexcept marker to FrameSinkVideoCapture's
ConsumptionState inner class.

This breaks the GCC build due to the fact that its members' types do not
have noexcept themselves:

    ../../content/browser/media/capture/frame_sink_video_capture_device.cc: At global scope:
    ../../content/browser/media/capture/frame_sink_video_capture_device.cc:372:1: error: function ‘content::FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState(content::FrameSinkVideoCaptureDevice::ConsumptionState&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
    FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState(

clang is fine because we pass -fno-exceptions and it disables the same error
there, while GCC continues to raise it (bug 843143 and its corresponding CL
have a longer discussion on this issue).

In this case, mark CursorRendererUndoer as well as mojo's ubiquitous
InterfacePtr with noexcept to fix the build.

Bug: 754872, 819294, 843143
Change-Id: I78714fda26d21e0979aed4fe26d543463dff9631
Reviewed-on: https://chromium-review.googlesource.com/1107918Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#569029}