- 09 Sep, 2019 40 commits
-
-
Martin Šrámek authored
TBR: wittman@chromium.org Bug: 1001923 Change-Id: Ib2e5f19650f6ac4dbda6586f6e4e3dd64e3b8182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789153Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#694673}
-
Takashi Toyoshima authored
Now the tests run without OOR-CORS on CQ and try. But we already have oor-cors fyi bot to run major tests with OOR-CORS enabled. # Please update test expectations for flaky tests NOAUTOREVERT=true Bug: 1000554 Change-Id: Ie4fbee82495640effb974304409467719613e4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786375 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#694672}
-
Gyuyoung Kim authored
This CL applies pending_remote to VideoCaptureObserver argument int VideoCaptureHost::Start. - Convert mojo::Binding to mojo::Receiver - Convert VideoCaptureObserverPtr to mojo::PendingRemote<>. Bug: 955171 Change-Id: I8943efcd102ad265b3b7b95553a0123f0f1684b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777347Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#694671}
-
Yi Su authored
This reverts commit 7c516511. Reason for revert: <INSERT REASONING HERE> Original change's description: > [ios] Enable SlimNav and dependent features by default. > > Tentatively enabling this by default for M79. > > Bug: 789582 > Change-Id: I030902ddbb1a19f5b49a847b727c439cfd10fcf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787885 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694620} TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org Change-Id: Idb139bf5eed97036ccd2d0f26d331db77786b6e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789152Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694670}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Revert changes in v8_unit_test.h R=treib@chromium.org Bug: 891670 Change-Id: I20b5a2f1635c3b515370ea689d2515b4536c9b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787103 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694669}
-
Maksim Sisov authored
Enable views_unittests for Ozone/X11 platform and add a filter file, which disables crashing/failing tests. Bug: 1001075 Change-Id: I2b4cd26ccdae8d86e78f020a653e042daad4edb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787646Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#694668}
-
Matt Falkenhagen authored
Service worker tests had its own mechanism to override the network factory, called EmbeddedWorkerTestHelper::SetNetworkFactory(). But this doesn't set the network factory for StoragePartitionImpl, which we'll need for ServiceWorkerOnUI, and it doesn't play well with the mechanism used by other tests, URLLoaderInterceptor. Remove the EmbeddedWorkerTestHelper mechanism in favor of the standard mechanism. Also extend URLLoaderInterceptor to override the factory of MockRenderProcessHost, which service worker tests use. This CL enables "*ServiceWorker*" content_unittests to pass when ServiceWorkerOnUI is enabled. Bug: 1001435, 824858 Change-Id: Ibccb0fc2c04c6f9cbd55bc89f081caaf6edb9072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786710Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#694667}
-
Rakina Zata Amni authored
This causes failing dchecks if we call on an unconnected shadowroot, which turns out to be allowed! Bug: 999874 Change-Id: Iecaa3786817cacaf4ffb02809c44a0c104fcdb6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792203 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#694666}
-
Maksim Sisov authored
Close and CloseNow were move to DWTHPlatform. The same was done with the container of children DWTH. Bug: 990756 Change-Id: Ic09852c3a22e780738d98da3f4fdfee4a6741a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771407 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694665}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /dbus. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=hashimoto@chromium.org Bug: 891670 Change-Id: I05ed8a9c81b692d2deda1ebb32abfce3011f15cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786754 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#694664}
-
Alexey Baskakov authored
Instead, all the call sites should DCHECK if extension is enabled. BookmarkAppFinalizer is ready for the situation when Extension gets disabled and listed in disabled_extensions() instead of enabled_extensions(). BookmarkAppFinalizer (and the install pipeline) returns kWebAppDisabled error in this case. Drive by: Rename the function as GetEnabledExtension. Bug: 993666 Change-Id: I6dd8aca33f4f123e63bfd063a022e86512c2f8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792033 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#694663}
-
Jeevan Shikaram authored
This CL implements permission-item using the toggle-row element, removing the need for a permission-toggle. Bug: 999896 Change-Id: I49be9065eee6731adc6e2718cd0fdb7b4d022410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784238 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/cryptohome. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=hashimoto@chromium.org Bug: 891670 Change-Id: I682201afc209ceed93ea2f248580506db382fe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787076 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Fergal Daly authored
This tests whether the contentSize property exists and if it does, uses rendersubtree and contentSize. Bug: 1001293 Change-Id: Ifef8d60388d865d119b19de872a2cfe69504b16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787494 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#694660}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7588f07cd928..627d15588f4d git log 7588f07cd928..627d15588f4d --date=short --no-merges --format='%ad %ae %s' 2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df0ce01870fa..a7ff7df26f28 (5 commits) 2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 64926377..a0cef9f5 (522 commits) Created with: gclient setdep -r src/third_party/skia@627d15588f4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None,chromium:None Change-Id: I0fd4435c1ff6dc72db446c2828d39838ca6e5d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694659}
-
Kenichi Ishibashi authored
It seems we should check if WorkerScheduler is ready in CallOnAllWorkerThreads() because: * The ctor of WorkerThread adds itself to WorkerThreads(). * WorkerScheduler is initialized when Start() is called. * WorkerThread::CallOnAllWorkerThreads() can be called at any time. The above things imply that WorkerScheduler may not be ready when CallOnAllWorkerThreads() is invoked. Skip calling the given function on threads which don't have a valid WorkerScheduler. This should be safe because the only callsite of CallOnAllWorkerThreads() is SetIcuTimeZoneAndNotifyV8(). The purpose of the SetIcuTimeZoneAndNotifyV8() seems to notify timezone changes to V8 isolates. Since we initialize a V8 isolate for a worker after WorkerScheduler is initialized, we don't have to care about workers which don't have scheduler. Bug: 1000077 Change-Id: I7476cefcbebd323a7f95c0dcb06eec62ec28b25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792028 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#694658}
-
Hitoshi Yoshida authored
This is a reland of 5c872c1a Original change's description: > IDL: Fix invalid extended attributes > > An invliad extended attribute [Enabled] was used in IDLs of WebRTC, > and some APIs are visible regardless a runtime enabled feature. > This CL fixes the IDL description and hide them behind a flag. > > > Bug: 999690, 986069 > Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Florent Castelli <orphis@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693038} Bug: 999690, 986069 Change-Id: I9d225027c377935ca70948359887096a701275c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792036Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Nate Fischer authored
aluo@ is a committer now (for 3+ months), so this is a reland of https://crrev.com/c/1419901 (but adding in the cts_archive, since it's related). Test: N/A Change-Id: Ic1c0890c89a3ec64d69340525a2e7f123930ef91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790387 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#694656}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0fb30ed6419..27325b90a86c Created with: gclient setdep -r src-internal@27325b90a86c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6fa2eb6e11246fa5cba0deade92857682c56b975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791784Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694655}
-
Rakina Zata Amni authored
TBR=rego@igalia.com Bug: 1001817, 1001816, 1001814, 1001928 Change-Id: If8682aff08adb18675d2fd0c18daa77711a90095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792037Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#694654}
-
Simon Que authored
This was previously reverted due to reaching the Goma RBE server capacity limit. https://chromium-review.googlesource.com/c/chromium/src/+/1786872 The limit has since been increased. R=bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org Bug: 1001231,950413 Change-Id: I820be1e6128db0d6ff16c9e8d3b12207db71cf92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789220Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#694653}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/favicon. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mastiz@chromium.org Bug: 891670 Change-Id: I9a8ef1f34217a8d8110454a28138963c99b66ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787060 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#694652}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c3bd09ead0f..7588f07cd928 git log 6c3bd09ead0f..7588f07cd928 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5d0faf9be9d7..44e6523d7ff3 (12 commits) Created with: gclient setdep -r src/third_party/skia@7588f07cd928 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None Change-Id: I0fd6e2ec1f623a5cea68d9946a565daa55bc1285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791435Reviewed-by:
-
David Munro authored
BUG=chromium:996945 Change-Id: I9c53f26e6a9364e88b641a6af677b0340d79012a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787489 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#694650}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 67aeeb51. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I74009311a82387db712800215761b478fe525ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792084Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694649}
-
David Staessens authored
This CL fixes the IVF header of the resolution_change_500frames-vp8.ivf and resolution_change_500frames-vp9.ivf videos. These test files were created manually and have an incorrect IVF header. The first 4 bytes are set to 'DKIF' to identify the file as an IVF file. The frame header size and codec FOURCC are also added to the IVF header. Other entries such as resolution have not been added. TEST=./video_decode_accelerator_tests resolution_change_500frames-vp8.ivf BUG=b:140538436 Change-Id: Ic9738140895861a5b8e9c219082e16f190ca7c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788962Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#694648}
-
Hirokazu Honda authored
This CL changes GetTestName() to return test_suite_name+test_name, which originally returns test_name. This change mainly affects the directory where frames and images are saved. For example, the saved directory in video_decode_accelerator_tests is changed to $(CUR_DIR)/VideoDecoderTest/FlushAtEndOfStream from $(CUR_DIR)/FlushAtEndOfStream. The saved directory in image_processor_test is changed to $(CUR_DIR)/PixelFormatConversionToNV12/ConvertOneTime_MemToMem/0 from $(CUR_DIR)/ConvertOneTime_MemToMem/0. This is useful for a parameterised test like image_processor_test. For instance, before this change, image_processor_test saves the processed images in PixelFormatConversionToNV12 and NV12Scaleing to $(CUR_DIR)/ConvertOneTime_MemToMem/0. Bug: 917951 Test: video_decode_accelerator_tests --output_frames Test: video_decode_accelerator_perf_tests Test: image_processor_test --save_images Test: tast run video.DecodeAccelVDH264 Test: tast run video.DecodeAccelVDPerfH2641080P30FPS Change-Id: Ife8412603dc95ca24e87960523d249abc6bcacfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778104Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#694647}
-
Luciano Pacheco authored
The native types that are mocked in mock_entry.js (FileSystem, Entry, FileEntry, DirectoryEntry and DirectoryReader) can't be instantiated or extended in JS, making the closure type of these mocks trickier, to allow to provide the Mock type where implementation expects the native type. This issue has been solved in 2 different ways: MockFileSystem and MockDirectoryReader are marked as @extends {_native type_}, however they don't actually extend/inherit from its native type, this is only to allow Closure type check to accept these mocks as their native types. MockEntry, MockFileEntry and MockDirectoryEntry, couldn't use the same false @extends, because they use inheritance from MockEntry and closure checks the @extends with the actual "extends" in the ES6. To make Closure accept these are their natives a static factory casting to the native type is used instead of the normal constructor which is declared @private so can't be called directly. All caller sites were updated to use the factory instead of constructor. Note that to be able to promote to native type Closure requires to cast to Object first, otherwise it fails saying that the cast has to be from a derived class. Note #2: For both of these style of fixes, Closure doesn't check that the Mock actually adheres to the native type API, but it's expected that the tests would fail if the mocks don't perform the expected action/behaviour. Bug: 778674 Change-Id: I0d5e69ace7f59295dcda4a867b2746043ac9a3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788425 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694646}
-
Kouhei Ueno authored
This CL allows pages which have requested Geolocation permission from entering BFCache, and verifies that the inflight geolocation requests from renderer are canceled when the page enters bfcache. This CL doesn't implement the request cancel logic. * The Blink code [1] already has this implemented. * This CL is just adding browser_test to verify the cancel logic. We are replacing the "real" implementations of the device service counterpart to a "fake" one so we can: - decouple the browser_test from relying on a real GPS device - "keep the request inflight": renderer requestPosition, but the "fake" service can be Pause()-d to not respond to the request, so we can test that renderer would forcibly cancel the request when put into BFCache on that case. - count the active number of mojo-channels renderer<->device_svc, to confirm that the request has been cancelled. [1] src/third_party/blink/renderer/modules/geolocation/geolocation.cc Bug: 989847 Change-Id: I9b5b5af2ee50418ff92738560039967fcb20b8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730153 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#694645}
-
David Staessens authored
This CL changes the video_decode_accelerator_(perf_)tests to not crash when decoding a video frame failed, as this causes all further tests to be aborted. The error is now ignored, but tests will still properly fail as the number of decoded frames and their contents are verified. TEST=./video_decode_accelerator_tests \ vda_sanity-vp90_2_17_show_existing_frame_20190109.vp9 BUG=None Change-Id: I5828111fb354b765ef331a9bbb7fc1183b1cb10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775651Reviewed-by:
-
Takashi Toyoshima authored
This patch adds webRequest API tests that inject headers in a way to trigger CORS preflight, then confirm if it actually triggers the CORS preflight only when the required extra option to avoid the CORS preflight is not specified. Bug: 1000554 Change-Id: I31bfc9b9b2495efd51d88a078f7273f8edf34118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782229 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694643}
-
Sanket Joshi authored
This is a reland of 27e98258. The original change was reverted due to a MSAN failure with the color-picker-appearance-hue-slider-keyboard-navigation test. The test failed due to a timeout, and the likely explanation is that the test is just too slow on MSAN builds. This is being fixed by shortening the test, and it now passes on the MSAN trybot. Original change's description: > Add keyboard based navigation for visual color picker > > This change adds functionality to move the color selection ring > through the color well and hue slider via keyboard input. The user > can press the up/down/right/left arrows to move the ring in the > corresponding direction. The user can also press ctrl+[arrow key] > to perform an accelerated movement. The accelerated movement is > particularly useful for the color well as it takes time to navigate > from one end of the color well to the other with just the standard > keyboard movement. > > Bug: 994437 > Change-Id: Idfef70adf443f8576f83dc9e6c9347a0d320b768 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757159 > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690076} Bug: 994437 Change-Id: I9e3e60568ee6e651979613af08102792728c52f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772126Reviewed-by:
-
Shik Chen authored
Bug: b:134636934 Test: Manually on Nocturne Change-Id: I10bf9a8af174b4686ae645e534f2500b77a218ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788424Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#694641}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd57eac06cab..d0fb30ed6419 Created with: gclient setdep -r src-internal@d0fb30ed6419 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4f3d418130b5adf04f4f0405c43dabbc80d7f101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792002Reviewed-by:
-
Peter Kotwicz authored
This CL: - Fixes a regression in WebappInfo#themeColor()/ WebappInfo#backgroundColor() as a result of https://crrev.com/c/1770001 - Fixes incorrect WebappInfoTests BUG=1001755 Test=WebappInfoTest.* Change-Id: I0aaa3cdb6ae121ec2f4d2bfa9aada0117ee2ddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790737 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#694639}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91c6d76345fe..879cafdd9c15 git log 91c6d76345fe..879cafdd9c15 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 primiano@google.com Move wire_protocol.proto under protos/perfetto/ipc Created with: gclient setdep -r src/third_party/perfetto@879cafdd9c15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:140126865 Change-Id: I519e40dc5cae1015e2180f5c3fcb2fed274baf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791988Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Icf2f0bea8f4a5cd0a2999fb54c497592a68904fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790301Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694637}
-
Glen Robertson authored
Also remove repeated registrar getter. Following up on points raised offline discussing crrev.com/c/1746116 (relanded as crrev.com/c/1787021) Bug: 989792 Change-Id: I211208d5b1a3aacc66fb28e2082f0051a5254cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763277 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Leon Han authored
This CL switches the IDL type definition from "enum NDEFRecordType { "empty", "text", "url", "json", "opaque" };" to "typedef DOMString NDEFRecordType" according to web-nfc spec. This is in preparation for supporting 'smart-poster' and external type records in the future, which was added in https://github.com/w3c/web-nfc/pull/278. BUG=520391 Change-Id: I45ec31afb3841cc5b12c954ffc2821da357fef04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781510 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#694635}
-
Matt Falkenhagen authored
Change-Id: Icfc0645d1a4b22a7849639febc3d076cee2d8491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787664Reviewed-by:
-
