GitLab

At this point it's only used in tests, to test itself.
Also remove Resource::usage, which isn't used for anything anymore.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3b75bba09565d52a126c0f27c344d94ed50fc4c6
Reviewed-on: https://chromium-review.googlesource.com/1014274Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551212}

In normal cases in the render process WebMediaPlayerImpl holds a
reference to the CDM such that the CDM should never be destructed before
the media pipeline. Howeven, when both the decoder and CDM are hosted
remotely (e.g. in the GPU process on Android), the destruction order
could be reversed due to IPC. In this case, we should just fail instead
of crash.

Note that this case is already handled in MojoAudioDecoderService,
MojoVideoDecoderService and MojoRendererService.

Bug: 833641
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7f07c07dea86033ebe57700e0ce8834ea94b06f3
Reviewed-on: https://chromium-review.googlesource.com/1013690Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551211}

Spec: https://webaudio.github.io/web-audio-api/#rendering-loop (Step 9.5)

The AudioWorkletNode with zero output must be pulled by the renderer.
The actual output will be ignored just like AnalyserNode.

Bug: 831245
Test: LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-automatic-pull.https.html
Change-Id: If9bd27d6c4bfeecdcd2dd4c8445459afd8593e85
Reviewed-on: https://chromium-review.googlesource.com/1014388Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551210}

Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I982e24b7234617b111e7adfa3c0f83356722ec8d
Reviewed-on: https://chromium-review.googlesource.com/1013280Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551209}

BUG=773295
TEST=
  1. <out_chromeos>/chrome --user-data-dir=<profile> --new-wallpaper-picker
  2. settings -> select wallpaper
  3. selection is functional.

Change-Id: Ib24dca7b428225772984860193c49f4d46225a0a
Reviewed-on: https://chromium-review.googlesource.com/1014223Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#551208}

Revert "Add browser tests for autofilling the shipping address info and payment info on captured sites."

This reverts commit 34a6f41d.

Reason for revert: Broke the Mac and Windows build.

https://ci.chromium.org/buildbot/chromium/Mac/40485

chrome/test/base/interactive_test_utils_aura.cc:24:9: error: member access into incomplete type 'NSWindow'
  window->Hide();

https://ci.chromium.org/buildbot/chromium/Win%20x64/21368

chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc(133,9):  error: format specifies type 'char *' but the argument has type 'const wchar_t *' [-Werror,-Wformat]
        src_dir.AppendASCII("third_party/catapult/web_page_replay_go")

Original change's description:
> Add browser tests for autofilling the shipping address info and payment info on captured sites.
> 
> These tests are the first step in building a test framework for testing chrome autofill on complex, real-world sites pages. Since interacting with live sites are flaky and vulnerable to updates to the sites' features, this framework interacts with captured sites.
> 
> Sites are captured with the Web Page Replay (WPR) tool. Prior to running the test, the browser test will start WPR locally on the machine using a capture file. The test then navigates to the test site, interact with the site's checkout workflow, and verifies that autofill correctly completes the address and payment information.
> 
> Tests for 5 sites are included in this code change: Amazon, Zappos, Apple, Ebay and Walmart.
> 
> Change-Id: I4b28e645554a2912c632fcb462439cac7142cf9f
> Reviewed-on: https://chromium-review.googlesource.com/963800
> Commit-Queue: Yiming Zhou <uwyiming@google.com>
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551190}

TBR=anthonyvd@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,uwyiming@google.com

Change-Id: Ied983de9c011fb6e3099e68b03bc60641a31b056
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1014497Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551207}

Following bot results are included.
4822 4825

Inlucdes 2 rebaselines after manual review of failures.

6 lines were removed and 7 lines were deflaked by consecutive
results since 4761.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic196acdbab4a48ab44d3cd9c50750fc399a9fe57
Reviewed-on: https://chromium-review.googlesource.com/1013780
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551206}

This is exact same thing as https://chromium-review.googlesource.com/c/chromium/src/+/987919
but on explicit mass-erase rather than eviction.

Thanks to nedwilliamson@ (on gmail) for the report and testcase.

Bug: 831963
Change-Id: I96a46700c1f058f7feebe038bcf983dc40eb7102
Reviewed-on: https://chromium-review.googlesource.com/1014023
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551205}

* Sub-directories of PerformanceTests are renamed to snake_case

* Need to skip PRESUBMIT because third_party/blink/perf_tests/speedometer/resources/todomvc/learn.json
 is not a valid JSON.


NOPRESUBMIT=true

Bug: 829695
Change-Id: I6c7fb94792aedbea19bbee194bb9ceaf6df5ddfb
Reviewed-on: https://chromium-review.googlesource.com/1006740Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551204}

Over time, individual features were added before or after the calls that
set groups of features. This could lead to different behavior for
individual features. Therefore, this CL moves them back to their
original position and adds comments to hopefully deter such future
changes.

This CL does not attempt to modify overall order (issue 832393).

Bug: 830978
Change-Id: I83df46b733751a0e9f1272c214518a3bdc67b199
Reviewed-on: https://chromium-review.googlesource.com/1013212Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551203}

snapshot is not necessary to be there when compiling.
This change allows src for headless to be compiled before generating snapshot.

This dependency optimization improves build parallelism and build time of chrome on Z840 linux with goma -j1000 reduced from 6m14.035s to 4m45.244s when goma's backend cache cannot be used.

Change-Id: I90e302f4b9da8ec252020755636483006f332a80
Reviewed-on: https://chromium-review.googlesource.com/1013958Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551202}

This reverts commit bc5d4eab.

Reason for revert: This change breaks numerous tests on Android with NetworkService enabled.

BUG=833612

Original change's description:
> Fix content_shell with network service enabled not loading pages.
> 
> This regressed in my earlier cl r528763.
> 
> Change-Id: I06513d517eaa96373628772159f639388fdea1db
> Reviewed-on: https://chromium-review.googlesource.com/988220
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547221}

TBR=jcivelli@chromium.org,jam@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I1d3a83c789b845ec88e92cd9f81b0fe39993d01b
Reviewed-on: https://chromium-review.googlesource.com/1012736Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551201}

Bug: 775534
Change-Id: Ie06e780366afede4b6f9cd89f69e40bc14044fab
Reviewed-on: https://chromium-review.googlesource.com/1014654Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551200}

This CL adds the entity images (if present) to the preload list.

Bug: None
Change-Id: I614efbc6201122f36a180b40861ba22f9e6ad4d3
Reviewed-on: https://chromium-review.googlesource.com/1012511
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551199}

The rounded omnibox drop-down cuts out a hole for the omnibox to show through
when it's open to avoid having to teleport the LocationBarView between Widgets.
r550927 adjusted the positioning and size of the drop-down, but regressed by
positioning the cutout incorrectly. This patch re-aligns it.

Bug: 833281
Change-Id: If95dad702b54fa44e6e8e6df4b959401510993df
Reviewed-on: https://chromium-review.googlesource.com/1013020Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551198}

https://chromium.googlesource.com/catapult.git/+log/5d0c16d725ca..69a36a622381

$ git log 5d0c16d72..69a36a622 --date=short --no-merges --format='%ad %ae %s'
2018-04-16 nednguyen Update Chrome reference builds (Chrome 63 to 65)
2018-04-16 simonhatch Dashboard - Remove whitespace from index.yaml
2018-04-16 nednguyen Update update_chrome_reference_binaries to use 'win-clang' and 'win64-clang' in cloud storage directory

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828378


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia8d35f0ab940b07231ee7520ec2e56e700fe9a39
Reviewed-on: https://chromium-review.googlesource.com/1014625Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551197}

Bug: 814897
Change-Id: Ibed0c4e7708cfa1b7ba1756e3cfca78c9501a22b
Reviewed-on: https://chromium-review.googlesource.com/1008875
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551196}

Chrome will open a tab with chrome://reset-password if the user reuses
their protected enterprise password on other sites that are not allowed
by enterprise policy.
chrome://reset-password will only show if password protection related
enterprise policy settings are properly set. Otherwise, user will see
ERR_INVALID_URL.

The new icon in ui/webui/resources/cr_elements/icons.html is copied from
/chrome/browser/resources/settings/icons.html

Bug: 824501
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8d648f0484e0c569ddbed048114a90471e4eea25
Reviewed-on: https://chromium-review.googlesource.com/996565
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551195}

Using MessageLoopCurrent* was an incorrect move of the old code.
In this case the preferred type would be a MessageLoopCurrent (which
is a proxy for a MessageLoop*), but we can't define
ScopedNestableTaskAllower with a MessageLoopCurrent member because
MessageLoopCurrent isn't fully defined by the time the inner-class is
defined.

Instead use a MessageLoop* member like before and move the impl to .cc

Also deprecating the old constructor which required a pointless
indirection:
  base::MessageLoop* loop = base::MessageLoop::current();
  base::MessageLoop::ScopedNestableTaskAllower allow_nested(loop);
I will follow-up with a scripted cleanup to remove such usage.

R=kylechar@chromium.org, thestig@chromium.org

Bug: 825327
Change-Id: I28c68d6450cf7c1743908118ce4dc2b4e09a4e76
Reviewed-on: https://chromium-review.googlesource.com/1014267Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551194}

This moves JavaScriptSourceFrame into a plugin, and completes
the plugin initiative.

Bug: 778043
Change-Id: I5908cfe46650fd50524a08b2e402d8ac6ce77cc9
Reviewed-on: https://chromium-review.googlesource.com/889692
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551193}

This reverts commit 673e013b.

Reason for revert: http://crbug.com/833550

Original change's description:
> [Closure GN] Convert simple WebUI Closure Compilation to GN.
> 
> See go/closure-compile-gn for details.
> 
> This CL converts the Closure Compilation from GYP to GN for the following:
> - cryptotoken
> - download_internals
> - md_downloads
> - md_extensions
> - md_history
> - md_user_manager
> - offline_pages
> - signin
> - webapks
> - welcome
> 
> A local closure compile can be run by setting closure_compile = true in
> args.gn, and then running ninja -C out/Default webui_closure_compile.
> Individual projects can be compiled via, for example,
> ninja -C out/Default chrome/browser/resources/md_extensions:closure_compile
> 
> Bug: 632206
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I401fc54ee6c5202bd27855ba28d886677e52210e
> Reviewed-on: https://chromium-review.googlesource.com/954772
> Commit-Queue: calamity <calamity@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550956}

TBR=calamity@chromium.org,dpapad@chromium.org

Change-Id: I298237aae447470ad5e75ec6781baa124e58e925
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 632206
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1012904Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551192}

Although these will only be used in official builds on Windows,
providing the flag definitions cross-platform allows developers to
build for other platforms with |dcheck_is_configurable=true| if they
want.

Bug: 812058
Change-Id: I9a53681487e432129001620548e0a62052abab50
Reviewed-on: https://chromium-review.googlesource.com/1012267Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551191}

These tests are the first step in building a test framework for testing chrome autofill on complex, real-world sites pages. Since interacting with live sites are flaky and vulnerable to updates to the sites' features, this framework interacts with captured sites.

Sites are captured with the Web Page Replay (WPR) tool. Prior to running the test, the browser test will start WPR locally on the machine using a capture file. The test then navigates to the test site, interact with the site's checkout workflow, and verifies that autofill correctly completes the address and payment information.

Tests for 5 sites are included in this code change: Amazon, Zappos, Apple, Ebay and Walmart.

Change-Id: I4b28e645554a2912c632fcb462439cac7142cf9f
Reviewed-on: https://chromium-review.googlesource.com/963800
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551190}

Bug: 810904
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibd9bae957927fa3fa78569792c58015e1b6039f0
Reviewed-on: https://chromium-review.googlesource.com/1013682Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Daniel Blakemore <danblakemore@google.com>
Cr-Commit-Position: refs/heads/master@{#551189}

Uberblame now looks like this:
https://bugs.chromium.org/p/chromium/issues/detail?id=773350#c9

BUG=773350
R=dpranke

Change-Id: I43b75fbedac5a9350a5c227882743b8a9bd33282
Reviewed-on: https://chromium-review.googlesource.com/1014621
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551188}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I829c73a630d817100f0632aeac194fdbc1e09d0a
Reviewed-on: https://chromium-review.googlesource.com/1014503
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551187}

If native VAO is disabled on ES2, but not ES3 contexts, and on ES2 we use client side arrays, then we have to switch to driver's default VAO (id = 0) when we switching to the ES2 contexts. Otherwise VertexAttribPointer for client array set up will fail with an GL_INVALID_OPERATION error.

BUG=829766
TEST=manual on affected devices
R=piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ide93c4fa4649dd2fd2b6d25137f3346320473b4b
Reviewed-on: https://chromium-review.googlesource.com/1013140Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551186}

Those were mistakenly and automatically generated by the rebaseline-cl tool in
(https://chromium-review.googlesource.com/c/chromium/src/+/1010511).

Change-Id: I5cc9f5dabf56a599883b4d14b57c72befb6584e8
Reviewed-on: https://chromium-review.googlesource.com/1012495
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551185}

This is in preparation for displaying the diff in the Uberblame visualization.
About 3 lines of context is nice when viewing diffs.

Some extra logic is now necessary to handle the context.

BUG=773350
TBR=dpranke

Change-Id: If202deb3d9fd85ee6f9376739205a15f542b8005
Reviewed-on: https://chromium-review.googlesource.com/1014349Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551184}

10fd672bde9d linux: Enable brokered memory reading
3a20d34ac356 Fix build with glibc 2.27
1bb4c233e341 linux: skip zero length mappings in the maps file
a3ba96c0d4c7 linux: Use an empty string for unmapped module names
914e7f76dd26 linux, x86: Read floating point state via mcontext.fpptr
e83103c80503 fuchsia: Implement CaptureContext() for x64
b08165c9e52a Extract BuildHandlerArgvStrings to common shared location
c7fe30dddbb0 fuchsia: Get generate_dump to start attempting process
             dumps
cf55a7ef5506 fuchsia: Implement SnapshotTime()
f5f0aa4a8e84 fuchsia: Implementation of system snapshot
a4f4d6a73659 fuchsia: Small fixes in system and process snapshot hit on
             generate_dump
d9bf38f39c5a fuchsia: More fixes to get a basic minidump written
856339b2d211 fuchsia: Avoid uname() in system snapshot
091308be6aeb gyp: build client_argv_handling
dd4ba4c8a168 linux, x86/x64: set fpregs to nullptr in CaptureContext()
c80bf96001dd Don't record reports as complete if there is no upload
             thread
f5d5a41317be fuchsia: Add implementation of ScopedTaskSuspend
c2583364a36e fuchsia: Capture general purpose registers in thread
             snapshot
eca0ea8427c2 Add limited version of URL cracking
ca2d7e776a0a Pull go toolchain for all host types
799dcef4c90f fuchsia: Fix compilation after hasty review changes

Bug: crashpad:30
Change-Id: Iab7c09aaa390e73129eb0eea308ba8af9eddb668
Reviewed-on: https://chromium-review.googlesource.com/1012446Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551183}

This fix the issue when default ARC app icons are not loaded in case
of provisioning is not finished for new user flow.

Test: Manually + unit_test
Bug: 833596
Change-Id: I99af81eafb78c65857b6fe5a6475d3372e08beb5
Reviewed-on: https://chromium-review.googlesource.com/1014326
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551182}

HostListFetcher returns a -1 error code when it fails to get the HTTP
response (because of timeout?). We map the HTTP code into error message
using net::GetHttpReasonPhrase(), which reaches NOTREACHED() when the
argument is -1 and causes a crash on debug build.

This CL prevents this by explicitly translating -1 into "Connection
failed".

Bug: 832994
Change-Id: I94f5c353de2674500190efb9dc8066ad40aaed8e
Reviewed-on: https://chromium-review.googlesource.com/1012787
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551181}

A LocalSurfaceId allocation/renewal for an aura::Window happens in
response to a bounds or dsf-change to its corresponding ui::Layer.
The root window is special in this regard, since its state can be
changed only by the WindowTreeHost, and should happen before the
ui::Compositor is updated for the new bounds/dsf (since it needs
to provide the LocalSurfaceId to the ui::Compositor).

Window::SetDeviceScaleFactor() is no longer needed after this. So
remove that.

BUG=821987

Change-Id: I3eb674b1c59a2728315125b6eb14b610033f6bf4
Reviewed-on: https://chromium-review.googlesource.com/1012932Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551180}

Adding tests as per request of the origin trial team.

Bug: 832387
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie7d09c127f46d7de2928388d69712b2c73fdd630
Reviewed-on: https://chromium-review.googlesource.com/1003041Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551179}

PDF and QuickOffice plugins use the mimeHandler API only. Once QuickOffice that uses mimeHandler is updated to all users (depends on 67 reaching stable) we can delete the streams API code.

Bug: 705114
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia402364e4ee88e9f3eb06b3e413253ffb5e71413
Reviewed-on: https://chromium-review.googlesource.com/1013403Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551178}

Easy win, additional 72 tests pass.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4c77bafcbce24245bac482c3fb3afe1f064e6f1c
Reviewed-on: https://chromium-review.googlesource.com/1014325
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551177}

Add a caching factory for Chrome OS |AccountManager|. Cache is keyed on
the basis of Profile path (|Profile::GetPath|).

AccountManager cannot be simply a part of |g_browser_process| because of
Chrome OS Multi Sign In. Accounts participating in Multi Sign In should
see separate instances of |AccountManager|.
Once Multi Sign In has been replaced by Multi Profile,
|AccountManagerFactory| can be removed and |AccountManager| can be made
a part of |g_browser_process|.

Bug: 820046
Change-Id: I8c2f2b2b5d8d61c5a818ab711197840bd605567b
Reviewed-on: https://chromium-review.googlesource.com/1010542Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551176}

Static initializers are not allowed.

BUG=831951

Change-Id: I1c1d41ea66a34d38119c639c2af48183b9d1ab64
Reviewed-on: https://chromium-review.googlesource.com/1012870
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551175}

BUG=773295
TEST=
  1. <out_chromeos>/chrome --user-data-dir=<profile> --new-wallpaper-picker
  2. settings -> select wallpaper
  3. selection is functional.


Change-Id: Ia8cab4086550b723ce904705db26c5f171277dbf
Reviewed-on: https://chromium-review.googlesource.com/1014222Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#551174}

No change to production logic.

This aims to deflake
SafeBrowsingTest#testSafeBrowsingDontProceedNavigatesBackFor*.

These tests previously depended on the interstitial to change the page
title to the string "Security error." This is unreliable, however, as
chromium translates this for non-English locales.

This CL removes the dependency on page title, and asserts that the
previous page is visible after clicking "back to safety."

I couldn't locally reproduce test failures except by changing device
locale, but I expect this method to be more robust than relying on page
title. As mentioned below, I tested this ~200 times without failure, so
I don't expect many flakes.

This also removes the @FlakyTest annotation previously added.

Bug: 822753
Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsingDontProceedNavigatesBackFor*
Change-Id: I91ded411514302c2c34fdb8e06f7694f58f7e526
Reviewed-on: https://chromium-review.googlesource.com/1013686Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551173}