- 04 Oct, 2018 40 commits
-
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/android/signin. This CL was uploaded by git cl split. R=bsazonov@chromium.org Bug: 809610 Change-Id: I6f1d6fcc1e311286e193d7be174fc5cf6687c309 Reviewed-on: https://chromium-review.googlesource.com/c/1258360 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#596564}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/translate. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 809610 Change-Id: Iad4ab19844ec672459312067de78681b70684765 Reviewed-on: https://chromium-review.googlesource.com/c/1258356 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#596563}
-
Yuichiro Hanada authored
This CL allows us to set the cursor positing to inside of the composing text. We need it to implement InputConnection.SetComposingRegion(). It allows an IME to put the cursor position to arbitrary position after setting composing region. Bug: 845079 Test: unit_tests Change-Id: Ib70a67f3b4d78c753205efe6465084f1e69c938b Reviewed-on: https://chromium-review.googlesource.com/c/1258809 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596562}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /components/sync. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=mastiz@chromium.org Bug: 890902 Change-Id: I4a816ae8d6a4f164bb11dfe1b8f81e6354cad70d Reviewed-on: https://chromium-review.googlesource.com/c/1257849Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596561}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/login. This CL was uploaded by git cl split. R=achuith@chromium.org Bug: 809610 Change-Id: I5630118ead9379c1dd5cb9ba8aeedcffa8a2e8d8 Reviewed-on: https://chromium-review.googlesource.com/c/1257836 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#596560}
-
A Olsen authored
Moves system_settings_provider from chrome/browser/chromeos/system to chromeos/system - part of an effort to move cros_settings and related settings code out of chrome/browser and into chromeos/system, so that they can be used in processes other than the chrome process. Duplicates the timezone_util functions that system_settings_provider depends on - ideally, all of timezone_util would move too but since it depends on cros_settings, it might have to be moved last. Bug: 446937 Change-Id: I3863cd3dd274b0f94dc4d87938b7ccda2fe89269 Reviewed-on: https://chromium-review.googlesource.com/c/1128861Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596559}
-
Guido Urdaneta authored
This change follows advice from the UX team. Bug: 860311 Change-Id: I97760456cb4c2c21d5e4d2b5de03f5d14b68ba2b Reviewed-on: https://chromium-review.googlesource.com/c/1256985 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#596558}
-
Anders Hartvoll Ruud authored
This CL treats custom properties registered with syntax <transform-function> as direct CSSStyleValue subclasses, similar to how e.g. <color> is treated. This behavior does not get a WPT, because it's not specified (not even as temporary behavior). It is however consistent with how other "don't know yet"-types behave in TypedOM, and it's an infinitely more reasonable temporary behavior that how master currently behaves: a <transform-function> value becomes CSSUnitValues. For instance, "transform(10px)" becomes "10px", which is obvious nonsense. R=futhark@chromium.org Bug: 641877 Change-Id: Ie06569592192f204d2c05a565458589baeb8378d Reviewed-on: https://chromium-review.googlesource.com/c/1258328Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#596557}
-
Fredrik Söderquist authored
The Translate() function can use the same check as Equal() to determine if the string is ASCII-only. Saving a conversion from UTF-8 to UTF-16. Bug: 889183 Change-Id: Ieffab05f34a1e4a2ef725e298e7f15e7ff14a3f8 Reviewed-on: https://chromium-review.googlesource.com/c/1257928 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596556}
-
Yuichiro Hanada authored
This allows Android IMEs to set the selection range when updating composing state. Bug: 845079 Test: unit_tests Change-Id: I8110dfeb5f10d2a77df76aa40c4c2ff067034c51 Reviewed-on: https://chromium-review.googlesource.com/c/1258814Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
We used coordinates relatively to the line box, while we were expected by the caller to be relative to the containing block. Flipping for writing mode was bogus for NG (but needed by legacy), since NG uses truly physical coordinates. Hardened tests to contain a leading line and padding, and leading content on the first line of the clipped child. Bug: 641907 Change-Id: I2b1b9ff4ea92a6405fcdffcf139842458b46442f Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1257913Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#596554}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e2a9282198da..b222f495a95b git log e2a9282198da..b222f495a95b --date=short --no-merges --format='%ad %ae %s' 2018-10-04 nisse@webrtc.org Split ChannelProxy into send and receive classes. Created with: gclient setdep -r src/third_party/webrtc@b222f495a95b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib51cf4f26b5847da5a28b376b624ae15b77e14f7 Reviewed-on: https://chromium-review.googlesource.com/c/1260267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596553}
-
Takashi Toyoshima authored
There were DCHECKs there, but it is ok to be called, and happens actually on running tests with NetworkService enabled, e.g. some tests in SafeBrowsingBlockingPageBrowserTest hit. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I27721bf4c3ea445266797cbe6e06b5e19773bd1d Reviewed-on: https://chromium-review.googlesource.com/c/1260744Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#596552}
-
Alice Boxhall authored
Bug: 835455 Change-Id: Ifdcbf93252ee64438cc43adaf89ac17b2759a99f Reviewed-on: https://chromium-review.googlesource.com/c/1260523 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#596551}
-
Mohamed Amir Yosef authored
Before this CL: favicon is always loaded when creating specifics out of a bookmark node. After this CL: a new paramter is added to control this behavior and ignores the favicon field if the favicon is not loaded already. This is added such that in debug page chrome://sync-internals, the load of a favicon is avoid if not loaded already. Bug: 516866 Change-Id: I14093cea131d44e83cca1b5ab07d64d6b46061c1 Reviewed-on: https://chromium-review.googlesource.com/c/1254066 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f8aa25fa1e19..40a16ffeefe6 git log f8aa25fa1e19..40a16ffeefe6 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 saklein@chromium.org run_chroot_version_hooks: hook and version file permissions fix 2018-10-04 dgarrett@google.com pre-cq-launcher: Stop issuing --swarming. 2018-10-04 vapier@chromium.org paygen: scrub unused Remove/RemoveDirContents helpers 2018-10-04 vapier@chromium.org paygen: urilib_unittest: switch to gs.TemporaryURL 2018-10-04 vapier@chromium.org paygen: paygen_build_lib: convert to lib.gs Created with: gclient setdep -r src/third_party/chromite@40a16ffeefe6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I63ccae63cd8b9ff889d3ad7d9b6a728bae19cbb9 Reviewed-on: https://chromium-review.googlesource.com/c/1260268Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de6d4d2b0fca..0a817f0a559a Created with: gclient setdep -r src-internal@0a817f0a559a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6f4b54196947fa1289c0fdf1fb1f5785342deead Reviewed-on: https://chromium-review.googlesource.com/c/1260264Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596548}
-
François Beaufort authored
This CL makes sure pip_player does not get reset when entering PiP while there was already another video playing in PiP mode. Bug: 889850 Change-Id: I468459584745bcd7eb21d282c52c4cbb8053fd74 Reviewed-on: https://chromium-review.googlesource.com/c/1249064Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#596547}
-
Lukasz Suder authored
Bug: 806868 Change-Id: I3c65412070cae48033e4fb91108407ca332d6e5d Reviewed-on: https://chromium-review.googlesource.com/c/1256802 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596546}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/thumbnails. This CL was uploaded by git cl split. R=treib@chromium.org Bug: 809610 Change-Id: If593d807b93661db5414e15acb5efb46c93e99a2 Reviewed-on: https://chromium-review.googlesource.com/c/1259026 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596545}
-
Dominick Ng authored
On desktop platforms, calling AppBannerManager::OnInstall in BookmarkAppHelper::FinishInstallation resulted in a bug where the userChoice promise on beforeinstalleventprompt was not resolved. This is because OnInstall() clears Mojo bindings, wiping out the connection between AppBannerManager and the beforeinstallpromptevent in the renderer. This CL moves the call to AppBannerManager::OnInstall from BookmarkAppHelper::FinishInstallation to BookmarkAppHelper::callback_. For installations from app banners on desktop, this is AppBannerManagerDesktop::DidFinishCreatingBookmarkApp; for installations from the menu, it is extensions::TabHelper::FinishCreateBookmarkApp. This means that for banners, OnInstall can be called after resolving the userChoice promise, fixing the bug. Tests are refactored and a new AppBannerManagerDesktopBrowserTest is introduced to test the events are fired as expected after installation. BUG=890848 Change-Id: I26a122e261ad1104af69443d9230e5458e271d24 Reviewed-on: https://chromium-review.googlesource.com/c/1256392 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#596544}
-
Rakina Zata Amni authored
In cases where there are only one match, active match ordinal might not update properly due to prevention of update of UI. In other cases when Find-in-page is forcefully redone due to DidFinishLoad call, previously found active match is not reactivated correctly. This CL fixes both of them. Bug: 890622 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icdb287af7a4cd27bdfb70dba1f53e12bd46d4723 Reviewed-on: https://chromium-review.googlesource.com/c/1256393Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#596543}
-
Ryo Hashimoto authored
BUG=None TEST=unit_tests Change-Id: Id67c423d842b7fabf9fb29e17cca2336cbd542cb Reviewed-on: https://chromium-review.googlesource.com/c/1260025Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596542}
-
rhalavati@chromium.org authored
Android notifications are stored in Android logs. User data are removed from media notifications in incognito mode to avoid leaking this data. The change is behind a disabled by default switch and is previously reviewed in: crrev.com/c/586868 Bug: 629887 Change-Id: Icbe2ba7b7b670e59f78dd53e282bc326631c9a9c Reviewed-on: https://chromium-review.googlesource.com/c/1196367 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
Currently PrefetchURLLoader in the browser process handles prefetch requests to reduce the memory consumption by skipping sending back the body to the renderer process, and to handle signed exchanges. But when NetworkService or ServiceWorkerServicification feature is enabled, prefetch requests from Service Worker controlled pages don't go to the PrefetchURLLoader. So SignedExchange's prefetching processes, such as certificate fetching and sub resource preloading will not be triggered. To fix this problem, this CL moves the prefetch_loader_factory from RenderFrameImpl to ChildURLLoaderFactoryBundle. BuildServiceWorkerNetworkProviderForNavigation() clones the ChildURLLoaderFactoryBundle with the prefetch_loader_factory, and passes it to the ServiceWorkerNetworkProvider as a fallback_loader_factory which will be used when respondWith() of the fetch event is not called in the service worker. Note: This CL moves the routing logic of prefetch request from RenderFrameImpl::FrameURLLoaderFactory to ChildURLLoaderFactoryBundle. Calling fetch(event.request) in service workers for prefetch requests doesn't go to the PrefetchURLLoader. So the signed exchange handling is not triggerd. This change is supposed to be tentative and should go away, as we're likely moving the special prefetch handling code into the network service. So we can remove this change when that happens. Bug: 890748 Change-Id: I6b5362b180a133d9274a20045ef82eaad9034ee4 Reviewed-on: https://chromium-review.googlesource.com/c/1256468 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596540}
-
David Jean authored
Image: https://drive.google.com/open?id=1fxpVgLqHb4-5oUCU1pMVJbGjUhrheQSf On 10.3.1: https://drive.google.com/open?id=1xaO4Ja8WZbvjRvT1lQXccBkTfBFiECqE Bug: 891279 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I13ac8525ebc6108f0e2e064c424d7e8762435694 Reviewed-on: https://chromium-review.googlesource.com/c/1257792 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#596539}
-
Matt Falkenhagen authored
Bug: 715640 Change-Id: I130337f41b02b9402e4d27dd6e909212768989bf Reviewed-on: https://chromium-review.googlesource.com/c/1260745Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596538}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3447bbe. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25791 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I899f588ba549321cda054ebf8929c9dcf29b2e7f Reviewed-on: https://chromium-review.googlesource.com/c/1260922 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596537}
-
Yoshifumi Inoue authored
This patch renames |at_start_of_block_| to |should_collapse_white_space_| to make variable name to represent what is indicate, for ease of code reading. This is follow-up of the patch[1] which changed role of the variable. [1] http://crrev.com/c/1250825 Make Element#innerText to not collapse white space around inline-block Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Idfb50d1fe1b88643e8ccd8d38346587740251b0b Reviewed-on: https://chromium-review.googlesource.com/c/1260387 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#596536}
-
Greg Thompson authored
This reverts commit 4ad50af3. Reason for revert: Breaks is_chrome_branded builds -- startup_tab_provider_unittest.cc is still referencing members of StandardOnboardingTabsParams that were removed. Original change's description: > NUX Onboarding: clean up build process. > > This CL cleans up the remnants of the NUX Experiments bulid configs. Including: > - removing os_win and google_chrome_branded build flag. > - removing prefs that tracks if the one-off NUX experiments were seen. > - fixing closure compile errors now that it needs to build on non-official bots. > > Bug: 874153 > Change-Id: I03c1ed09c54f5ba91944bcb31837e80a0ee1fc74 > Reviewed-on: https://chromium-review.googlesource.com/c/1252906 > Commit-Queue: Scott Chen <scottchen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596432} TBR=sky@chromium.org,scottchen@chromium.org Change-Id: I643cfa84bb9da07b4e1ebf8a9481d0ac32aeea90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874153 Reviewed-on: https://chromium-review.googlesource.com/c/1260128Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#596535}
-
Alexey Baskakov authored
Flaky crashes on all platforms. TBR=dalecurtis@chromium.org Bug: 891880 Change-Id: Ia4ae47a2c427d16a4983cd9188901353e1562ae6 Reviewed-on: https://chromium-review.googlesource.com/c/1260607Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596534}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4243cfba3ba6e7b756ff434ba76eedfeee73ce6e Reviewed-on: https://chromium-review.googlesource.com/c/1260265Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Use Adapter's power state for GetState(). Bug: 870192 Change-Id: I4c431fad09e540e8f20b21feb638ae6ba701f637 Reviewed-on: https://chromium-review.googlesource.com/c/1250581 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596532}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cd18bf9522d4..e2a9282198da git log cd18bf9522d4..e2a9282198da --date=short --no-merges --format='%ad %ae %s' 2018-10-04 buildbot@webrtc.org Roll chromium_revision d6b77ab5..fdb60d4f (596382:596485) 2018-10-04 thaloun@google.com Prepare for per-media DSCP values. Push dscp for stun packets to the port layer where they are created. 2018-10-03 buildbot@webrtc.org Roll chromium_revision f33d9eb9..d6b77ab5 (596278:596382) 2018-10-03 qingsi@google.com Add API level check for the use of ConnectivityManager.getActiveNetwork. Created with: gclient setdep -r src/third_party/webrtc@e2a9282198da The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I44ce5da6f6466e37d292eb61fdb24f36a0b1f1c9 Reviewed-on: https://chromium-review.googlesource.com/c/1260765Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b79459a0027..de6d4d2b0fca Created with: gclient setdep -r src-internal@de6d4d2b0fca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib83cde7f11e95c6813fa4a25a803c219dff7c9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1260766Reviewed-by:
-
Alexey Baskakov authored
This reverts commit cdafdcb9. Reason for revert: Time outs on Mac https://bugs.chromium.org/p/chromium/issues/detail?id=892016 Original change's description: > Do not apply hover during scroll > > In order to improve the performance and eliminate the issues that the > fake mouse move events cause to the testing and web developers, we > should not send fake mouse move events during scroll. This is > implemented behind a flag. > > We will update the hover effect after scroll finishes in a following > patch. > > Bug: 877132 > Change-Id: Iee838f50e0a52b5048081d79f91442ddf0467e8f > Reviewed-on: https://chromium-review.googlesource.com/c/1211907 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596049} TBR=dgozman@chromium.org,bokan@chromium.org,lanwei@chromium.org,dtapuska@chromium.org,nzolghadr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 877132 Change-Id: Ia388825045560d1d4cd4275e4ec5572819f2b6a1 Reviewed-on: https://chromium-review.googlesource.com/c/1260603Reviewed-by:
-
Roberto Carrillo authored
This should fix a NO_RESOURCE error due to a change of bot from 8 core to 32 core. TBR=nodir Bug: 891884 Change-Id: I7e496871a1b531e50e95cb55b82193519f8977bf Reviewed-on: https://chromium-review.googlesource.com/c/1260327Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#596528}
-
Hugo Holgersson authored
Let's also assert focus movements to the other focusables. Previously, the only thing this test tested was that DOWN would _not_ move focus... Once we've fixed Issue 801162, this test's expectations will change: We want spatnav to first _focus_ the scroller (before scrolling it). Bug: 803086, 801162 Change-Id: I5c8a964c2900fb3a550a55ba9a975c7a33ef42dd Reviewed-on: https://chromium-review.googlesource.com/c/1257832 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
-
Mitsuru Oshima authored
Changing bounds in minimized state can lead to bounds change on android side when restored, which in turn causes delay. Bug: 889438 Test: covered by unit test Change-Id: I9f9c2feef9cf468a670bcdb5a729c5877fdca2b6 Reviewed-on: https://chromium-review.googlesource.com/c/1258970 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596526}
-
Alexey Baskakov authored
Rename it to WebAppDataRetriever. Modernize: Use BindOnce. Bug: 875698 Change-Id: I4bf74a2966642f606f0ed602bc5bc7d72466e1da Reviewed-on: https://chromium-review.googlesource.com/c/1256404Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596525}
-
