GitLab

This CL disables VoiceSearchNavigationsTest.NotVoiceSearchNavigation.

TBR=justincohen@chromium.org

Bug: 900667
Change-Id: I662e767f993c151ca133b48d0afe654707548c7b
Reviewed-on: https://chromium-review.googlesource.com/c/1310560Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604350}

Currently the chrome-extension scheme is treated as 'insecure' in
cast_shell, and that makes service worker unavailable in cast_shell.
Add chrome-extension scheme to secure_schemes to solve this.

Bug: internal b/111359399
Test: check window.isSecureContext is true
Change-Id: Ic1d68ceac3b522f2c0140910d53e664fd9ff895d
Reviewed-on: https://chromium-review.googlesource.com/c/1308914
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604349}

This reverts commit b68dde46.

Reason for revert:
The test is still flaky. Fails with same error as before.
e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8629

Original change's description:
> Mash: Re-enable a test which may no longer be flaky.
> 
> test is ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown
> 
> Bug: 883371
> Change-Id: I1ce860a5c25e9b6b791be681e98907aed9ffb9bc
> Reviewed-on: https://chromium-review.googlesource.com/c/1305873
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603591}

TBR=jamescook@chromium.org,estade@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 883371
Change-Id: I7b232b609a0f60a3c68c61822871ba8dadd6109f
Reviewed-on: https://chromium-review.googlesource.com/c/1310506Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604348}

Re-enables pixel tests after rebaselining due to the
EnableGpuRasterizationViewportRestriction experiment.

TBR=kbr@chromium.org for second half of pixel test rebaseline

Bug: 899399
Change-Id: Icc11b44b9b2240b4e70ffe5bf78f1a24673db0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1309103
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604347}

We are creating a prototype for a Send Tab To Self Feature, in collaboration with
the better together team . the Design Doc was originally written by hansberry@
and can be seen here

https: //docs.google.com/document/d/11WONDgBRJ3kZGQZQ44_6f9lGXsIX7zOoP4PDOjT3shk
Change-Id: Ic3a07d0315336a1308f164a567720bd36a9c5d1a
Reviewed-on: https://chromium-review.googlesource.com/c/1297391Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604346}

https://chromium.googlesource.com/angle/angle.git/+log/193a284d34d2..5ca3e5a0b285


git log 193a284d34d2..5ca3e5a0b285 --date=short --no-merges --format='%ad %ae %s'
2018-10-31 ynovikov@chromium.org Fix ShaderStorageBlockOutputHLSL::writeEOpIndexDirectOrIndirectOutput
2018-10-31 jiajia.qin@intel.com ES31: add row major matrix support (part 1)


Created with:
  gclient setdep -r src/third_party/angle@5ca3e5a0b285

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I48a7edc3a87fe4fcb57c313d56b4d38d79de4800
Reviewed-on: https://chromium-review.googlesource.com/c/1310553Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604345}

GetIncognitoId() (in theme_service.cc) was not providing the incognito variants of control button background colors, so the caption buttons were receiving the non-incognito colors to blend against - causing them to have insufficient contrast in incognito with certain themes.

Bug: 889711
Change-Id: I801ed5b915d67e12b6e998c8d96400baf04c3e40
Reviewed-on: https://chromium-review.googlesource.com/c/1310497
Commit-Queue: Ryan Meier <rameier@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604344}

This is a reland of 491ed062

Original change's description:
> [DevTools] Merge InspectorSession and DevToolsAgent::Session
>
> These are not needed as separate entities anymore, after making
> workers reuse DevToolsAgent::Session. We merge them into a single
> DevToolsSession class.
>
> Bug: 775132
> Change-Id: I213de7e33c5b7ce12d4f58e1b2daa363ad563b12
> Reviewed-on: https://chromium-review.googlesource.com/c/1282207
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603869}

TBR=caseq@chromium.org

Bug: 775132
Change-Id: I066cb72659bcbd7ad992735c5249503d34578d0d
Reviewed-on: https://chromium-review.googlesource.com/c/1308983Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604343}

This patch is a followup to [1] and paints the LayoutView hit test
rects into the scrolling contents layer, like the background does. This
improves performance because the hit test rect does not need to be
repainted on every scroll change.

With this patch we no longer regress raster in the rendering.desktop
touch_handler_scrolling benchmark.

[1] https://crrev.com/603335

Bug: 888269
Change-Id: I27864ed6d612c26f2258b60805778b2c6f894d62
Reviewed-on: https://chromium-review.googlesource.com/c/1303868
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604342}

Replace "bool is_scripted" with an enum. This makes it clearer what a
true or false argument means, and it sets up the code to potentially
have other print modes in the future.

Change-Id: I498140820b8b6ffc4380c07fa9988a1b33e534e9
Reviewed-on: https://chromium-review.googlesource.com/c/1309416Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604341}

NTP title should be set earlier in DidStartNavigation.  It was previously moved
to didFinish to sync up with changes to ios/web.

Also adds an OWNERS file.

Bug: 826369
Change-Id: I1f65118aa16425b44b96e14802638e67f1acd24d
Reviewed-on: https://chromium-review.googlesource.com/c/1308495
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604340}

It currently uses RepeatingCallback, and resets the callback after
running it.

Also initialize members in the header and fix some nits.

Change-Id: I92248c94993fa09ab4061a7ef17f4a2a82be4d8d
Reviewed-on: https://chromium-review.googlesource.com/c/1308911Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604339}

- Move various ext/ sources to the top, so they are all together.
- Move skia features to the bottom.

Change-Id: I7dcf0cebc8f0ae2bbb8b4950cce2a5dbce703ae0
Reviewed-on: https://chromium-review.googlesource.com/c/1309419Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604338}

This test is flaking quite a bit:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.SubresourceFilterTest%23resourceNotFiltered

TBR=csharrison@chromium.org

Bug: 899903
Change-Id: I4785f8ac1d517a23696aaba40a9a5e245440f47d
Reviewed-on: https://chromium-review.googlesource.com/c/1310503Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604337}

Add flaky expectations for virtual/fractional_scrolling_threaded/fast/scrolling/listbox-wheel-event.html

fast/scrolling/listbox-wheel-event.html is flaky on virtual/threaded/ test
suite, virtual/fractional_scrolling_threaded/ is virtual/threaded/ plus
FractionalScrollOffsets flag. It should be same flaky with
virtual/threaded/fast/scrolling/listbox-wheel-event.html.

Bug: 841567
Change-Id: If3e0c7b465ccd3935e105fd52c946cd75c8651dd
Reviewed-on: https://chromium-review.googlesource.com/c/1309993Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604336}

BrowserSwitcher is no longer controllable by the prefs themselves. They
have to be set through the policies to be effective.

Bug: 876805
Change-Id: I9f819de1d4b30df5ca299653a24fa392060ed820
Reviewed-on: https://chromium-review.googlesource.com/c/1293560
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604335}

This was broken when PerformPreMainMessageLoopStartup() started
getting called on Android by this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1213316/

That call made the variations service determine the URL and start
fetches before the restrict mode parameter was set, causing the
issue.

This CL also turns a DCHECK that would have caught this into a
CHECK - which would have caught this had it been enabled on the
release official builds.

Bug: 899058
Change-Id: I66dc658950f3cccb4013a3902b1223ef529936b7
Reviewed-on: https://chromium-review.googlesource.com/c/1309118Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604334}

When a window is focused, the ATK_STATE_ACTIVE state should be available
in the list of object states for a window. Additionally, we should
receive state change, activate, and deactivate events when focus changes.
This change adds those features, but does not produce the appropriate
events for dialog boxes, which is the second part of adding full support
for the active state.


Bug: 866336
Change-Id: I890c39ada3d368c547d3b8a0801cc90fa1e2371a
Reviewed-on: https://chromium-review.googlesource.com/c/1257831
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604333}

Disable
  CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads_GuestMode
  KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode
  KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteFolderDownloads_GuestMode
due to flakiness under MSan.

TBR=lucmult@chromium.org

Bug: 899664
Change-Id: Ic39f71f6b07999ca39a6d58f6674d32ab002739c
Reviewed-on: https://chromium-review.googlesource.com/c/1310502Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604332}

Multiline parameters in proxy natives would be ignored by the jni_generator
because the .* in the params portion of the proxy natives regex was not
matching on newlines. This CL adds the flag re.DOTALL so that dot matches
on newline which fixes the issue, and adds test coverage for this case.

Bug: 898261
Change-Id: I28f1fb3c57b39daff4d8bb1eb2bfba4a2f4d7adc
Reviewed-on: https://chromium-review.googlesource.com/c/1306694Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#604331}

https://webrtc.googlesource.com/src.git/+log/e6caa9fbf6ef..71822866c65d


git log e6caa9fbf6ef..71822866c65d --date=short --no-merges --format='%ad %ae %s'
2018-10-31 srte@webrtc.org Allow FakeNetworkPipe to wake up its processing thread
2018-10-31 Peter) Slatala Add obj-c mapping from native configuration to RTCConfiguration


Created with:
  gclient setdep -r src/third_party/webrtc@71822866c65d

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie2859c6da2defbf1e573dd735f0c7c72e734f503
Reviewed-on: https://chromium-review.googlesource.com/c/1310334Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604330}

We previously employed an optimization that skips OOPIFs occluded by
parent frame's layers. This optimization is problematic as the layer's
bounds do not necessarily represent its hit test region, and it works
incorrectly when the occluding layers have pointer-events property.

This CL removes that optimization.

Bug: 846798, 896786
Change-Id: Id33c7d658cfd677ab3eb496371a213de2423d349
Reviewed-on: https://chromium-review.googlesource.com/c/1296821Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604329}

https://skia.googlesource.com/skia.git/+log/73329c8df9d5..c9eace8194dd


git log 73329c8df9d5..c9eace8194dd --date=short --no-merges --format='%ad %ae %s'
2018-10-31 mtklein@google.com add unpremul gm
2018-10-31 caryclark@skia.org give include comments the once over
2018-10-31 jvanverth@google.com Only copy subrect in DistanceFieldGen setup
2018-10-31 benjaminwagner@google.com Upgrade Win10 Skylake graphics driver.
2018-10-31 herb@google.com Use bulk calls between SkGlyphRunPainter and SkDraw
2018-10-31 csmartdalton@google.com ccpr: Don't use cache entries as path listeners


Created with:
  gclient setdep -r src/third_party/skia@c9eace8194dd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:896987
TBR=herb@chromium.org

Change-Id: I1a44a333372733913970c1a3f2924e0cb31f7e3f
Reviewed-on: https://chromium-review.googlesource.com/c/1310074Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604328}

It used to fail on Windows. The rebaseline tool shuffled expectations
around quite a bit (I expected only Windows to change), but I guess
that's right.

Bug: 591500, 900469
Change-Id: Id894f5637a52b9623990b7a618447490c80d137a
Reviewed-on: https://chromium-review.googlesource.com/c/1309653
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604327}

https://pdfium.googlesource.com/pdfium.git/+log/1e185db4498d..79263ca083e0


git log 1e185db4498d..79263ca083e0 --date=short --no-merges --format='%ad %ae %s'
2018-10-31 thestig@chromium.org Move Skia features bits to the end of the "skia" target.


Created with:
  gclient setdep -r src/third_party/pdfium@79263ca083e0

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6d856dab5c479026068b2180ae3aa01831a42497
Reviewed-on: https://chromium-review.googlesource.com/c/1310076Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604326}

The "Initial upload" patch is the same as the reverted CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1184306

Bug: 874651, 896603
Change-Id: I406f587cf4b9e69a80fb82e4558a78209eca801c
Reviewed-on: https://chromium-review.googlesource.com/c/1294719
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604325}

Bug: 897829
Change-Id: I652665d6a0531ac820329cb64ce073c3b517c8b6
TBR: rkaplow@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1299537
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604324}

This adds Fetch domain on the browser target, that carries interception
functionality previously available through Network domain, with a
slightly brushed up interface.

Bug: 899303
Change-Id: I74ef83ddfe711c566500ab9e815a24dfbf813106
Reviewed-on: https://chromium-review.googlesource.com/c/1292008Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604323}

Why remove DoesSiteRequireDedicatedProcess
==========================================

This CL removes
LayoutTestContentBrowserClient::DoesSiteRequireDedicatedProcess.  We plan
to remove other overrides of this ContentBrowserClient method in
follow-up CLs.  We want to remove this ContentBrowserClient method
altogether, because
1) it is currently the only reason
   SiteInstanceImpl::DetermineProcessLockURL needs to take
   BrowserContext* as an argument (and therefore is problematic on
   threads other than UI thread)
2) the method was initially introduced to support --isolate-extensions
   which has been obsolete since shipping --site-per-process in M67.


Removal mechanics
=================

This CL replaces
LayoutTestContentBrowserClient::DoesSiteRequireDedicatedProcess with
LayoutTestContentBrowserClient::GetOriginsRequiringDedicatedProcess
(i.e. mechanism based on --isolate-origin functionality).


Bug: 898281
Change-Id: I3d7cfa7cce6077d2d7b5af24089d6e3d212b8e73
Reviewed-on: https://chromium-review.googlesource.com/c/1307848
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604322}

Introduce a new ShapeResultView class representing a read-only view into
one or more ShapeResults. Will be used instead of ShapeResult::CopyRange
in line breaking to avoid the extra memory and computational overhead of
creating a copy. Switches the ShapeResult::runs_ vector to ref count the
RunInfo instances to allow a ShapeResultView to outline the ShapeResult.

Bug: 900015
Test: renderer/platform/fonts/shaping/shape_result_view_test.cc
Change-Id: Id676b08a3f03c392ed4271af2f66c51a9e0b2ff6
Reviewed-on: https://chromium-review.googlesource.com/c/1306637
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604321}

TBR=smut

Change-Id: I83595c80791ad4c4f54597b6b09c88d5eebd45f7
Reviewed-on: https://chromium-review.googlesource.com/c/1310354Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604320}

This reverts commit 28c21fa4.

Reason for revert: The tests are flaky again.

Original change's description:
> Re-enable disabled VR tests
> 
> Re-enables all the VR tests that were marked as flaky now that the
> root cause has been reverted.
> 
> TBR=mthiesse@chromium.org
> 
> Bug: 894796
> Change-Id: I34c4b8e10edec2e682c450b1b18c2428f3e29473
> Reviewed-on: https://chromium-review.googlesource.com/c/1305211
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603594}

TBR=bsheedy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 894796
Change-Id: I502b065118723a03d26f2a5b010dc44a724572cc
Reviewed-on: https://chromium-review.googlesource.com/c/1310357Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604319}

This is consistent with the new close-x on bubbles. It also fixes ink
drops being out of sync with focus rings on Mac, since they were not
derived from the same path.

Bug: chromium:898806
Change-Id: I51ebd333b60435fee4b252a4db60e7ca459cea0d
Reviewed-on: https://chromium-review.googlesource.com/c/1309136Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604318}

Clicking ElementInspect button would toggle entering/exiting
inspector mode. However, previously clicking that button in
inspector mode would be handled by pinned element logic. In this
CL, we capture returned window element's active state. If the
window is not active, pinned element logic should not mark the
event as handled to give frontend a chance to handle the event.

BUG=899000

Change-Id: I4356f85f0ec6d90298473bb894f197aa4ab733e3
Reviewed-on: https://chromium-review.googlesource.com/c/1306403Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604317}

Throwable and Class have special JNI types jclass and jthrowable.
Converting these types to object breaks the function bindings,
This CL adds Class and Throwable to the list of types not to cast to objects
when creating the JNI bindings

Bug: 898261
Change-Id: I84f008a8aa6d3505a975f5989482ffb5f6bba237
Reviewed-on: https://chromium-review.googlesource.com/c/1307774Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#604316}

Bug: 806868
Change-Id: Ia30d9ff86560bfb39217877f40c7b0e36cf475b6
Reviewed-on: https://chromium-review.googlesource.com/c/1307508
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604315}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab0e8a3d06fc..673cf8fc2ca9


Created with:
  gclient setdep -r src-internal@673cf8fc2ca9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


BUGS=900463
TBR=mmoss@chromium.org

Change-Id: I8965bbc01f00b033f51731de3083b6c911998823
Reviewed-on: https://chromium-review.googlesource.com/c/1310077Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604314}

All tests run with 30 iterations with no failures.

Bug: none
Change-Id: I727c08ef70d6c0a34b31435009e419eeab4a5aac
Reviewed-on: https://chromium-review.googlesource.com/c/1309137
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604313}

Also mark as obsolete histograms that stopped being recorded in
https://chromium-review.googlesource.com/c/chromium/src/+/961384.

Bug: 885293
Change-Id: Id14bbc92a6aa175f5e5c9b5ebfa9173b8b157046
Reviewed-on: https://chromium-review.googlesource.com/c/1305195
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604312}

Bug: 900631
Change-Id: I849b63b4ec647a650e6d94986853468600f05da2
Reviewed-on: https://chromium-review.googlesource.com/c/1310215Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604311}