- 09 Aug, 2018 40 commits
-
-
Dan Sanders authored
DecoderSelector provides an InitCB that destroys the VideoDecoder immeidately when initialization fails. This means that |this| is invalidated immedately upon calling |init_cb_| in MojoVideoDecoder. This CL adds a WeakPtr-based test for |this| destruction to the potentially problematic callbacks in MojoVideoDecoder::Stop(). Bug: 839881 Change-Id: I9b1302ad3007a834c95ed1d3845e24b0d07158f8 Reviewed-on: https://chromium-review.googlesource.com/1169907Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#581954}
-
Emircan Uysaler authored
This CL moves the picker UI triggered from extensions into DesktopMediaPickerFactoryImpl which lives under /chrome/browser/media. We are planning to use this common implementation to trigger the same picker UI for getDisplayMedia(). Bug: 326740 Change-Id: Idb8b9d094ce55ecc8281c3db1f1acb0f5e3a24f1 Reviewed-on: https://chromium-review.googlesource.com/1169594 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581953}
-
Antonio Gomes authored
While migrating some classes from URLFetcher to SimpleURLLoader, it is useful to have the size of the resulting decompressed body. In case of DownloadToString* calls, this is straightfoward: the length to the string is the size. However, in the case of DownloadTo{Temp}File calls, where only the resulting file path is passed to the completion callback, having an API to get the decompressed body size is useful. It also avoids sync calls to access the file data. This CL adds a SimpleURLLoader::GetContentSize API that provides such value. When used with SimpleURLLloader::SetAllowPartialResults(true), the API returns the total decompressed body size even in the case of errors. BUG=773295,844972 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia8cdb3326b5d5c74276e384f966a7e98f61a8c46 Reviewed-on: https://chromium-review.googlesource.com/1167683Reviewed-by:Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581952}
-
Scott Violet authored
This differs from the first version in that SetFocus(null) now returns true. As you suggested in the last patch, returning false caused the client to attempt to revert, which lead to some oddities. So, it seems safer to return true. views_mus_unittests no longer fails with this version, and https://chromium-review.googlesource.com/c/chromium/src/+/1169525 fixs the issue with the browser_test NavigatingExtensionPopupBrowserTest.Webpage. Here's my comment as to why this is ignored: // The client is asking to remove focus from a window. This is typically a // side effect of the window becoming, or about to become, an unfocusable // Window (for example, the Window is hiding). Windows becoming unfocusable is // handled locally. Assume the request is for such a scenario and return // true. Returning false means the client will attempt to revert to the // previously focused window, which may cause unexpected activation changes. // // To process null requests conflicts with top-level activation changes. For // example, the typical sequence when a window is hidden is to first remove // focus, and then hide the window. FocusController keys off window hiding to // move activation. If this code were to set focus to null, FocusController // would not see the window hiding (because the active window was set to null) // and not automatically activate the next window. // // Another possibility for this code is to handle null as a signal to move // focus to the active window (if there is one). I'm going with the simpler // approach for now. BUG=867654, 871652 TEST=covered by tests Change-Id: Iff2ddb31c2b99b977bca8e56fb653b6ce4eb6813 Reviewed-on: https://chromium-review.googlesource.com/1165692 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#581951}
-
Mike Klein authored
Should be a good number of teensy layout test diffs. Change-Id: I3dc74252fab7ec8ee4aa38d95ba1f60ed3e96b01 Reviewed-on: https://chromium-review.googlesource.com/1169313 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#581950}
-
James West authored
Bug: internal b/112331554 Test: manual Change-Id: Ib7670d56a1d8444ac895cae7117365ccda0ef9e4 Reviewed-on: https://chromium-review.googlesource.com/1168507Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#581949}
-
Tommy Steimel authored
This CL removes some obselete sizing-* CSS rules that were inadvertently causing a scrollbar to appear in the overflow menu at certain zoom levels. Bug: 851492 Change-Id: Ibafa0b74312d3f18b5ca5c3ee1050f1710c1e810 Reviewed-on: https://chromium-review.googlesource.com/1168394Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581948}
-
Xiyuan Xia authored
This is needed to make content_browsertests happy under mash. Bug: 866942 Change-Id: I21885e4328706f83bb57805abe4cff581551120a Reviewed-on: https://chromium-review.googlesource.com/1168143Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581947}
-
Danyao Wang authored
TabGridMediator relies on VisibleURL to determine if the title of a tab should be hidden. During session restore, the restore_session.html item is briefly the only visible item in the web view until the other entries are restored, and it has chrome://newtab as the virtual URL. This incorrectly causes the CreateItem() in TabGridMediator to set |hidesTitle| to true for the grid item. Previously visible item title was cached in WebStateImpl for a similar reason (http://crbug.com/819606). This change combines the two use cases. Bug: 869351 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5391eda466ad9de26087d2d8a1e2a97a7a83f27a Reviewed-on: https://chromium-review.googlesource.com/1157866 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#581946}
-
John Chen authored
ChromeDriver built in Chrome release branches now embeds Chrome version number (e.g., 69.0.3497.23) instead of ChromeDriver version (e.g., 2.41). Bug: chromedriver:2080 Change-Id: I8727b0c42ad3d59a0833345a596a4bdbce83b282 Reviewed-on: https://chromium-review.googlesource.com/1166229 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#581945}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 78fe025a. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22578 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources mkwst@chromium.org: external/wpt/cookies mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=kereliuk No-Export: true Change-Id: Ic353a494c2b6fc7d49be2aa32313b8e04b7014d8 Reviewed-on: https://chromium-review.googlesource.com/1169943 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#581944}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: I2a460de83529e88058054d2407da6a6d8f6e9357 Reviewed-on: https://chromium-review.googlesource.com/1169053 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581943}
-
Clark DuVall authored
This uses the strategy suggested in crbug.com/842445#c10 to map the renderer request IDs to global request IDs so PageLoadMetrics can associate ResourceLoadComplete events with the correct PageLoadTracker. The LoadingMetricsFailed test is still failing because DidFinishNavigation is called before ResourceLoadComplete, which means the PageLoadTracker has already been destroyed before we can track the failed request. From the discussion in crbug.com/842445, this doesn't seem like a big deal. Bug: 842445, 816684 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ifb1c0d689840f626c0612ddab26a10d8ea9eb078 Reviewed-on: https://chromium-review.googlesource.com/1155800 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#581942}
-
Derek Cheng authored
Also update a TODO. Bug: 809249 Change-Id: I80bb4cc046c765de6b1bc5e519cb22628af6bf9e Reviewed-on: https://chromium-review.googlesource.com/1169875Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581941}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8af4c40014e3..644d8e7175ae git log 8af4c40014e3..644d8e7175ae --date=short --no-merges --format='%ad %ae %s' 2018-08-09 kjlubick@google.com [PathKit] Add PathOps Op and Simplify tests imported from the C++ tests. 2018-08-09 brianosman@google.com Remove old sRGB config support from backend render target tool utilities 2018-08-09 bungeman@google.com Move Views into Sample and Viewer. 2018-08-09 benjaminwagner@google.com Add jobs for GTX1050 eGPU. 2018-08-09 timliang@google.com Revert "implemented GrMtlSampler for metal gpu backend" 2018-08-09 brianosman@google.com Stop treating 2.2 gamma as sRGB 2018-08-09 caryclark@skia.org make some textblob builders private for now 2018-08-09 fmalita@chromium.org [skottie] Optimize opacity layerization 2018-08-09 herb@google.com Remove use of RunPaint from regenerateGlyphRunList 2018-08-09 mtklein@google.com clean up SK_LEGACY_COLORSPACE_XFORMER_IMPL 2018-08-09 brianosman@google.com Remove CachedFormat remnants 2018-08-09 kjlubick@google.com [Pathkit] Add recipe for running JS tests using Docker 2018-08-09 brianosman@google.com Remove picture_utils 2018-08-09 timliang@google.com implemented GrMtlSampler for metal gpu backend 2018-08-09 brianosman@google.com Cleanup and simplify some skiaserve and utility code 2018-08-09 brianosman@google.com Remove dead code from Benchmark Created with: gclient setdep -r src/third_party/skia@644d8e7175ae The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ib16bfce3717cbfc71ab37fdbb68ae3a80a956246 Reviewed-on: https://chromium-review.googlesource.com/1169722 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581940}
-
Hector Carmona authored
We are preloading the favicon cache for bookmarks created by this onboarding flow. The icons that we preload are overdidden when the user navigates to the site. Bug: 832938 Change-Id: I3866ca4fdbc1044f7492f85f7f52c6d119a2a227 Reviewed-on: https://chromium-review.googlesource.com/1168397Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#581939}
-
Daniel Rubery authored
Observe RenderFrameCreated, so that when a subframe is created, we can add an InputEventObserver to that frame as well as the main frame. Bug: 869062 Change-Id: I24cd1f20f46375ec37963ecc72e69f255e756d87 Reviewed-on: https://chromium-review.googlesource.com/1163824 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#581938}
-
Sonny Sasaka authored
It is a valid use case for a daemon to have multiple ObjectProxies of different services with the exact same object path and interface name. Currently, this may cause log pollution of "rejecting a message from a wrong sender" because one ObjectProxy receives signals intended for another ObjectProxy. Since it's actually a valid case and not a bug, it shouldn't be logged as error but it may still be logged with VLOG. Currently this is discovered in Bluetooth daemon (btdispatch) because it listens to both BlueZ's and Newblue's objects which have identical object paths and interfaces. Bug: 866704 Change-Id: I25b6437ec6081e244a47c635c0adedf281530967 Reviewed-on: https://chromium-review.googlesource.com/1164474Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#581937}
-
Sean O'Brien authored
Minor touch radius was incorrectly scaled using major scale factor. BUG=None Change-Id: Ib14976a85b5457c1ed52de79e3008b2a425eea7a Reviewed-on: https://chromium-review.googlesource.com/1168504Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#581936}
-
Joshua Peraza authored
Bug: crashpad:30 Change-Id: Iff2d508ae265882e6187cdc418a8074b7b6203fd Reviewed-on: https://chromium-review.googlesource.com/1118910 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581935}
-
Weiyong Yao authored
UX and PM think it's better to say "This tab is sharing your screen.". Also fixed a typo in desc. Bug:859981 TBR=rockot@chromium.org Change-Id: I503ab2ce47190ed1069e99a58eaa01c001558a8e Reviewed-on: https://chromium-review.googlesource.com/1169540Reviewed-by:
-
Ryan Cui authored
Adds support for setting and adjusting volume. Supported queries: "set volume to 20%" "set volume to max" "set volume to minimum" "increase the volume" "decrease the volume" "increase the volume by 15%" Also works with "step" values: "set volume to 20" "increase the volume by 20" The backend treats these separately, but the client still treats them as percentages. Bug:b/111133529 Bug:b/78189672 Change-Id: I1e02ca2f15c46dc847206dfef93ee340f901f7e0 Reviewed-on: https://chromium-review.googlesource.com/1168511Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#581933}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5570c88a3dce..aba1649cfb98 git log 5570c88a3dce..aba1649cfb98 --date=short --no-merges --format='%ad %ae %s' 2018-08-09 lannm@chromium.org Remove git retry constants 2018-08-09 tikuta@chromium.org Use gomacc for host compiler in simple chrome build 2018-08-09 lannm@chromium.org Create chromite.lib.repo_util and migrate autotest_evaluator to it Created with: gclient setdep -r src/third_party/chromite@aba1649cfb98 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie4fe2bd6346284734bfe9e9f64d19778df2d3157 Reviewed-on: https://chromium-review.googlesource.com/1168416Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581932}
-
Kevin Schoedel authored
Replaced Stub with parent implementation stubs to make it easier to add sounds; made the proxy explicit; renamed things for clarity. Follow-up CL will remove accessibility_sound_delegate.h. Bug: internal b/73383411 Test: manual Change-Id: I95d6619f373024f66aed6204ee667585c7db0f76 Reviewed-on: https://chromium-review.googlesource.com/1166029Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581931}
-
Jian Li authored
Currently it is reported as "Download Home". We now add the logic to separate it out, together with the case that clicking from progress bar. Bug: 869692 Change-Id: I9f2fcbbac20da9cf23176a00505fe10d04136b2f Tbr: dgn@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1157644 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581930}
-
Tom Anderson authored
This CL fixes some colors I noticed were off around the NTP. * Specify COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR in the GTK theme. Previously we were falling back to a value calculated in [1]. * Gets the download bar separator color from the ThemeProvider. Previously it was hardcoded to #D6D6D6. This changes it to use the toolbar separator color. This color should work well with the download bar because the background color of the download bar is already obtained from the toolbar color. [1] https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_service.cc?rcl=b0784bef916569b6e4f06a6dce95b75a8a2cf10a&l=530 BUG=None Change-Id: Ib892b8ebb3355299020a4bc570cf37a3aee7a8c2 Reviewed-on: https://chromium-review.googlesource.com/1167979 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581929}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd5051fa529e..15a5a77db412 git log dd5051fa529e..15a5a77db412 --date=short --no-merges --format='%ad %ae %s' 2018-08-09 tandrii@chromium.org Reland "Deploy git 2.18 to depot_tools on a bleeding edge." 2018-08-09 tandrii@chromium.org Revert "Deploy git 2.18 to depot_tools on a bleeding edge." 2018-08-08 tandrii@chromium.org Deploy git 2.18 to depot_tools on a bleeding edge. 2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@15a5a77db412 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851505,chromium:851505,chromium:851505 TBR=agable@chromium.org Change-Id: I925476691895d7caf2e8e3ada3144e0312302025 Reviewed-on: https://chromium-review.googlesource.com/1169114Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581928}
-
Tommy Steimel authored
This CL adds content:// to the list of schemes that the UrlBar should display completely. This fixes an issue with the media intent handler where only "content:" was shown as the url, which looked buggy. Bug: 872489 Change-Id: I4af4bf01df1b62738df2023ebb633b4674562b86 Reviewed-on: https://chromium-review.googlesource.com/1168383Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Kevin Strohbehn authored
Bug: 869638 Change-Id: Ifea913dd4df2c94487173e87eba2bd860802c6c9 Reviewed-on: https://chromium-review.googlesource.com/1168475 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581926}
-
Hector Carmona authored
Bug: 832938 Change-Id: Id53c3e80f9db1b160e252a23e33a448daf22514c Reviewed-on: https://chromium-review.googlesource.com/1160727Reviewed-by:
-
Scott Violet authored
As the widget is shown only once the webcontents has loaded it is possible to close the popup before it's shown. Ignore activation changes until the popup is shown. BUG=867654 TEST=covered by tests in mash Change-Id: I74956b137a119f2b745a52698cb9dee6543b85e4 Reviewed-on: https://chromium-review.googlesource.com/1169525Reviewed-by:
-
Becca Hughes authored
If the sound content setting has been set to ALLOW by the user then we should set the force allow autoplay flag. BUG=865548 Change-Id: I895ce4d1a0f99357f097ee23ee52fa5fa566cc69 Reviewed-on: https://chromium-review.googlesource.com/1159349 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
Scott Violet authored
This test is creating an aura::Window and then embedding another client in it. When this happens it is expected that clients set the type before doing this. I'm sending this to make sure we don't block some work being done to mojo. I think the real fix is to remove EMBED_IN_OWNER (there is a bug filed on it). BUG=872071 TEST=test only change Change-Id: I6e0f6c5584ea9ec19b0e09fe944a83187a9f5ebf Reviewed-on: https://chromium-review.googlesource.com/1169695Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581922}
-
Scott Violet authored
These now pass because of adding kOverrideUseSoftwareGLForTests in AshTestSuite. BUG=838520, 725095 TEST=test only changes Change-Id: I070d5749486338e2fd72815b4dd75d13a391204f Reviewed-on: https://chromium-review.googlesource.com/1169535 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581921}
-
Evan Stade authored
Bug: 854704 Change-Id: I13acab5de5dc2565f12c02b2cb23b2d41d4331f8 Reviewed-on: https://chromium-review.googlesource.com/1167744Reviewed-by:
-
Lukasz Anforowicz authored
There has been a lot of work on adding OOPIF support to DevTools. I am guessing that some of that work has fixed the tests - they are passing when 20 times in a row on my local machine. Bug: 582176 Change-Id: I8ec94ff9cf8d19774c88eaf86fe4839d43a5d8b6 Reviewed-on: https://chromium-review.googlesource.com/1169948Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#581919}
-
Joshua Peraza authored
CrashReportMimeWriter provides a method to call into native code to rewrite the minidumps as MIME messages. This CL also links that native code into webview and clank, but makes no functional changes. Bug: crashpad:30 Change-Id: Ief41d366614a833db3b643f46a0297c52fea495f Reviewed-on: https://chromium-review.googlesource.com/1115702 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581918}
-
Toni Barzic authored
Make sure every call to SendNewNoteRequest is followed by call to FlushTrayActionForTesting, which should flush mojo pipes. For most instances this was already the case, but it was missing in few places - these were followed up with ExpectObservedStatesMatch, which did fluch of its own (to ensure the mojo pipe is flushed in other direction), which flushed the new note request as well, or were expecting mojo call to have no effect. With CL:1145692, this does not seem to be enough anymore, as flush in ExpectObservedStatesMatch ends up handling only a single mojo message. While here, replace checks for empty observed state changed with calls to ExpectObservedStatesMatch. TEST=run tets with CL:1145692 applied BUG=872070 Change-Id: I58447ffe8315ddcd5917f0ce901ea5b2624b4e2a Reviewed-on: https://chromium-review.googlesource.com/1170026 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#581917}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I2e2e069052f7b8d593119e8e96f670e7f1a12073 Reviewed-on: https://chromium-review.googlesource.com/1169980 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581916}
-
Muyuan Li authored
Bug: b/112373646 Test: use "set timer for 3s" and listen. Change-Id: I642325f182f2e2895b6a7d0c76019dc064cd8552 Reviewed-on: https://chromium-review.googlesource.com/1168467Reviewed-by:
-
