- 18 Jun, 2019 40 commits
-
-
Lucas Furukawa Gadani authored
This CL fixes the HTMLPortalElement so that when the Frame is disconnected by the ChildFrameDisconnector we also consume the portal. This prevents anything being executed between the disconnection of the Frame and the portal being consumed (which is where we fire focus events and unload events). Bug: 971702 Change-Id: Ic4cedb1c48df35984ee8a1b02111762aab780089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655381 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670256}
-
Victor Costan authored
Interfaces are base classes that only consist of virtual methods. This CL adds the following: * deleted copy constructor and assignment - prevent unintended slicing * protected constructors - prevent unintended direct instantiation * protected destructors - prohibit the user of an interface implementation from destructing the implementation, enforcing that the user does not own the implementation Change-Id: I2bb093e430cacb870846c74397051917ce50c83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663462 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#670255}
-
Daniel McArdle authored
Bug: 972412 Change-Id: I985783b4dcb695d4714dcd74246a185c94cd0825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652545Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#670254}
-
Henrik Lundin authored
These are monitored as part of experiments from time to time. Bug: none Change-Id: I2f40fef29348873ab18b3f4d179a983d0faab875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663511Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Lundin <hlundin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670253}
-
Daniel Murphy authored
This change adds the time it takes from creating the IDBOpenDBRequest till when: 1. The upgradeneeded event is dispatched, or 2. The success event is dispatched without a prior upgradeneeded event The goal is to measure the time it takes for both a warm (files already open) and cold (unopened) initialization of IndexedDB, from the perspective of the renderer. R=cmp@chromium.org Change-Id: Ie3495458e76dbd10d6ed6349254e78832e85c7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647335Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#670252}
-
Dale Curtis authored
We aren't using (or have ever used) the metrics around why we're falling back, so go ahead and remove them. We mostly just care if we're still falling back. This switches the code to use the histogram functions and not the macros since they are infrequently reported. Some of the Media.Hardware metrics are marked as expire never, since we do want ongoing monitoring of our hardware audio population. BUG=975072 TEST=none Change-Id: Ibd7e211d8afa062e0d0f3ac6cf29871b3b87ec3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663375 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#670251}
-
Khushal authored
R=zmo@chromium.org Bug: 974485,976060 Change-Id: Ifd40d06facc31e0f9e0629490cb1a136c0fad0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663736 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670250}
-
Sinan Sahin authored
The Revamped context menu header doesn't show a title if the image/video doesn't have alt/title. This CL fixes the issue by using the name of the image/video extracted from the source URL if the alt/title is empty. Bug: 971500 Change-Id: I366532d3fbbd5b19e7b542c533df20ac020c21df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664991Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#670249}
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: Iba5628ea881350cff723a2ec9116f7fe3adba5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664430 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#670248}
-
Mustaq Ahmed authored
Bug: 959850 Change-Id: I3c63d5d9540bbc565582242dcf2b0b6d9b2a3398 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658948 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#670247}
-
Lucas Furukawa Gadani authored
Bug: 908139 Tbr: boliu@chromium.org, bengr@chromium.org, seantopping@chromium.org, lazyboy@chromium.org, scottmg@chromium.org Change-Id: I24a403afe5d7b5f5a58e4ac6f8d3d82eb23f2611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661149 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#670246}
-
Regan Hsu authored
Change-Id: I022f2aa29b468a43d2dbfecac5275575b9317e57 Bug: 825150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660880 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#670245}
-
Jesse Schettler authored
When an event target is not an exo::Surface, let another handler process the event. BUG=b:135076290 TEST=Confirm arrow keys work correctly in a custom tab and a normal ARC app (such as Google Docs) TEST=exo_unittests --gtest_filter=KeyboardTest.OnKeyboardKey Change-Id: I8218aeced9f5a7e15db55099da45ce4cd72e83b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659488 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#670244}
-
Xing Liu authored
This CL adds a delegate class in DownloadDirectoryProvider, so we can mock this behavior in test. This is needed for the DownloadContentProvider effort for testing purposes. Bug: 970072 Change-Id: I585e51f60d5a356ffe1b5cb0116e615ceababad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663249Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670243}
-
Tommy Nyquist authored
The following histograms: - Android.PackageStats.CacheSize - Android.PackageStats.DataSize - Android.PackageStats.CodeSize were added to be able to keep track of various sizes of the package Chrome is installed under. Given the focus on binary size and other size-related issues, these histograms continue to provide real value and are poised to becoming even more important shortly, therefore extending their lifetime ~1 year for now. Also, adding another owner, so there are more people to contact in the future. Bug: 975303 Change-Id: Ic9de7d73fd0a2b266f063ae83cce55e9fca3fbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663397 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Sidney San Martín authored
Toggling substitution types via this menu is temporary, which is consistent with other Mac apps' behavior. Bug: 42434 Change-Id: Ifa07909464f8a10f1e77be176fc456eb8855f093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654188Reviewed-by:
-
Robert Ogden authored
Change-Id: I2e829fd56258fd6218a7de3a09b51e025ebef2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660959Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#670240}
-
Xianzhu Wang authored
Paint invalidation tracking was a good feature. It shows paint invalidation events in timeline and indicates the reasons (not generic reasons like "style", "layout", but specific reasons that can link to the javascript code etc.) However it has a problem that we often fail to match paint invalidation events to other invalidation events by node ids to find the reasons, and discard these events. This is because the paint invalidation caused by style or layout change on one node may not happen on that node, but on other nodes. This problem makes the feature incorrect in many cases, and it's hard to fix. We could show paint invalidation events without specific reasons, but I doubt how much value that would provide to web developers. So I'm removing the feature to avoid the maintenance burden. Change-Id: I2de2135dbb69041683bac49242b5e9bb6484ee02 Bug: 410701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661690Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670239}
-
Mike Wasserman authored
http://crrev.com/c/1660107 (PS1 here) was reverted for MSAN failures. This CL also initializes AccessibilityFocusRingInfo's members. Replace mojom with an abstract singleton controller, c++ struct & enums. Update impl & tests, expose a protected static helper for simplicity. Remove an unnecessary test subclass, unit test passes without this. Bug: 958129 Test: Automated; no accessibility focus ring regressions. Change-Id: I6071ee33dd5bdbfd3d5933e638ad27e703f206d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664872 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#670238}
-
Anatoliy Potapchuk authored
Bug: 971593 Change-Id: I19d34abc6b0861debb5b6052976954ea87a3e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648242Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#670237}
-
Michael Crouse authored
When the HintsFetcherTopHostBlacklist is initialized, the top hosts currently in the Site Engagement Service are added to the blacklist. The number of hosts is limited to two times the number of hosts that hints can be fetched for by the HintsFetcher. Metrics are also added for the number of hosts added to the blacklist on initialization and the number of hosts in the blacklist when top hosts are requested. The next change will remove hosts from the TopHostBlacklist if the blacklist has been initialized and the user navigates to the host. Browser tests will also be added in a future change along with functionality to force a request for top hosts to be made without a delay. Bug: 943846 Change-Id: I129a90985b318815361d17a25361a75eedd21c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650080 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#670236}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e1814403169a..342f98b11765 git log e1814403169a..342f98b11765 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 srte@webrtc.org Fixes for flexfec crash in scenario tests. 2019-06-18 sprang@webrtc.org Add support within PacedSender and pacer queue for owning rtp packets. 2019-06-18 mbonadei@webrtc.org Support __EMSCRIPTEN__ in rtc_base. 2019-06-18 ssilkin@webrtc.org Add/rewrite H264 VUI video signal type description. 2019-06-18 srte@webrtc.org Cleanup of resources from removed remote bitrate estimate test framework. 2019-06-18 mbonadei@webrtc.org Stop running 'bwe_simulations_tests'. Created with: gclient setdep -r src/third_party/webrtc@342f98b11765 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9cbc8fe85bfec357af1489012384d8940ec5949b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670235}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7b8008e2e7e4..40ee745abc3b git log 7b8008e2e7e4..40ee745abc3b --date=short --no-merges --format='%ad %ae %s' 2019-06-18 evanhernandez@chromium.org test: Fix usage of LoopbackPartitions. 2019-06-18 evanhernandez@chromium.org test: MoblabVmTest assumes it is outside chroot Created with: gclient setdep -r src/third_party/chromite@40ee745abc3b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I4c3bbd6783132c56ffdb2b3ab81bad996bfd6dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665248Reviewed-by:
-
Eugene But authored
UI>Browser>Navigation is the most appropriate component for this directory. Bug: None Change-Id: I6a639892931977244188948011553c56c087fe00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665557 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670233}
-
Toby H authored
Bug: 943208 Change-Id: Ic5fc323d86f5f9818027011948a8af85c43da287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663380Reviewed-by:
-
Eugene But authored
UI>Browser>Sessions is the most appropriate component Bug: None Change-Id: I356fca2650c6339e299801b60b9479d729dce46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665475 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Robert Sesek authored
- The Renderer helper gets com.apple.security.cs.allow-jit, which is used with MAP_JIT when allocating pages for V8. - The Plugin helper gets com.apple.security.cs.disable-library-validation, allowing it to load non-Team ID-signed libraries (e.g. Flash), and com.apple.security.cs.allow-unsigned-executable-memory required to run Flash content and NaCl modules. Bug: 850193 Change-Id: Iefaac47d85683b7a5e155b169cd4eb5d5f94bd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664834Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#670230}
-
Darwin Huang authored
- fast/events/before-unload-return-value-from-listener.html - https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/24083 - https://chromium-swarm.appspot.com/task?id=4584885a49ea6b10 TBR=eae@chromium.org NOTRY=true Bug: 976355, 974725 Change-Id: I889c24db648667f26c47c421352001b39d13b709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665558 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670229}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c39cb7918f0b..88825299a7d4 Created with: gclient setdep -r src-internal@88825299a7d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I7a60d7a975b513a2a6d8715cbf737abfab135aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665489Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670228}
-
Robert Ma authored
Namely, `doc_root` and `domains` (the latter was added in https://github.com/web-platform-tests/wpt/pull/17141) Also a drive-by fix to improve test discovery (only run .py files). Bug: 974877 Change-Id: Idb917ee0dcab9691709e3d99e3f29ceec82edeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664042Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#670227}
-
Michael Crouse authored
Add a commandline flag, kHintsFetchOverrideTimer to force a hints fetch without specifying a list of hosts. This allows testing of the TopHostProvider and HintsFetcherTopHostBlacklist without the timer delay for fetching hints. A future change will implement browsertests that utilize this flag to test the TopHostProvider, blacklist, and blacklist state. Bug: 932707 Change-Id: I309daedec53be4e250adf2abcc2215dccf8dac51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657392Reviewed-by:
-
Aleks Totic authored
While stepping throught the code, I've noticed that AddOutOfFlowDescendant was doing a memcpy. Change-Id: I97fd39e91656dc31a26ae744780ded3ca4ee9be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663184 Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#670225}
-
Yining Wang authored
This metric records time spent on focus mode browser. Bug: 971690 Change-Id: Ida9aa8aa05fd090a44fc179650f1cc0d6682de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652367Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yining Wang <yiningwang@google.com> Cr-Commit-Position: refs/heads/master@{#670224}
-
Daniel Libby authored
Note: based on crrev.com/c/1648953 In order to get swap timing in the renderer process, we'll need to send down additional information via BeginFrame. crrev.com/c/1639559 adds a new FrameTimingDetails struct that will be sent down, instead of just the PresentationFeedback. We'll be adding to that struct in a future CL that plumbs out swap information. This struct add the first bit of plumbing from OutputSurface to Display. OutputSurfaceClient::DidReceiveSwapBuffersAck now takes a SwapTimings parameter, which will then be plubmed out to Surface then SurfaceClient (CompositorFrameSinkSupport) once dependent changes all land. Bug: 971712 Change-Id: Ibdd49356ce94261aec4a695b22f96dec1ed5e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650224 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#670223}
-
Peng Huang authored
Bug: none Change-Id: Iee7c2d97a61f665ec82c5e0ab579b69a26debf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665206 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Archana Simha authored
Elements with the tag-name "a" or "img" with "onclick" attributes will be included in the RIND report. The inline JS is stored in the inner_html field of HTMLElement. This string is not modified or inspected before the report is generated. The capturing of inline JS and onclick content is disabled. http://gpaste/5722548836761600 Bug: 959964 Change-Id: I8c59cfb83fdb211dd5bc8486d4d21eb0378037df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594034Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Archana Simha <archanasimha@google.com> Cr-Commit-Position: refs/heads/master@{#670221}
-
Lucas Tenório authored
Bug: 973985 Change-Id: I06377f374f3c2e5985b7c80914fb184be94a5a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658854 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#670220}
-
Jun Cai authored
This CL adds some unit tests for Bluetooth Scanning prompt when user grants permission or cancels the permission prompt. Bug: 953075 Change-Id: Ibb3a085a9ceffe304e5a4c49af79127cae8b75de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660811Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#670219}
-
Vadim Bendebury authored
Let's keep them for another year to be able to detect ubnormalities of Board ID management processes. BUG=chromium:975873 Change-Id: I32117c6ecae11f5596afa91c86128d5700ea5e27 Signed-off-by:
Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663040Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670218}
-
Xida Chen authored
Currently the layout test parse-input-arguments-018.https.html is crashing with virtual/threaded which runs off-thread paint worklet. The problem is that CSSPaintImageGeneratorImpl::HasDocumentDefinition does not check whether the definition is valid or not. In particular, PaintWorkletProxyClient::RegisterCSSPaintDefinition can register two different CSSPaintDefinition which would throw an exception. But the |document_definition_map_| will still have an entry for this CSSPaintDefinition and the value of the entry is nullptr. In this case, the CSSPaintImageGeneratorImpl::HasDocumentDefinition should return false. Bug: 957459 Change-Id: Ic192676e537ce6b09bf56f244db61dac68598bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662592 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670217}
-
