- 12 Oct, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 79df1ff1. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25976 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/trusted-types NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I69e6efafb3ac195e0db73834a882c48e0270fddb Reviewed-on: https://chromium-review.googlesource.com/c/1278929 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599277}
-
Denis Kuznetsov authored
Demo mode enrollment flow. Bug: 854101 Change-Id: I87111b78ee89c5acd242ce4808a23162dee038e0 Reviewed-on: https://chromium-review.googlesource.com/c/1252481Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#599276}
-
rbpotter authored
This link was added following an old pattern in the Print Preview code, which was originally for opening a new tab just before closing Print Preview for a feature that has now been deleted. A standard link works for the current use case and is simpler. Bug: None Change-Id: I63955ded5a6d7c67edfaee5d7dbb6dec4e6b9dbe Reviewed-on: https://chromium-review.googlesource.com/c/1274837Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#599275}
-
chrome://flagsDonn Denman authored
Creates a new entry in chrome://flags for the Ephemeral Tab experiment which will present a "sneak peek" of a linked page in an Overlay. Also remove the ModernFullRoll from chrome://flags. BUG=894619, 856792 Change-Id: I9f9ea48d405eddd158e083231f4e88b0a5800dae Reviewed-on: https://chromium-review.googlesource.com/c/1277681Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#599274}
-
rbpotter authored
This no longer needs to be an action-link, since it is not opening native dialogs or going through the C++ handler to correctly open cloud print URLs with the correct user information. Instead, it is always opening the chrome://settings printing page. This can be handled more simply by using a normal link. Bug: None Change-Id: I9375ae0ac0c936aec379270f79f6130d054c1dcf Reviewed-on: https://chromium-review.googlesource.com/c/1278527Reviewed-by:
-
James Cook authored
The only callers pass |this| for the view argument, so CHECK that it isn't null and remove some dead code. This simplifies an upcoming refactor in AXRemoteHost for mash. TBR=msw@chromium.org Bug: 888147 Test: existing unit tests Change-Id: I93c9bb9ea5a9e55cbca5f51340625ffe60fe64d8 Reviewed-on: https://chromium-review.googlesource.com/c/1273991Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#599272}
-
Mugdha Lakhani authored
permission with devtools. This was suggested a previous review: https://chromium-review.googlesource.com/c/chromium/src/+/1233714/18/content/browser/devtools/protocol/browser_handler.cc#140 Bug: 886896 Change-Id: I41e850811da4c8d11f091b2fb0b49320af6cd0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1278926Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#599271}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/62b1345c850d..f7fee39547d8 git log 62b1345c850d..f7fee39547d8 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 mbonadei@webrtc.org Remove rtc_base:rtc_base_generic. 2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d47784f2..c12ec9ee (599082:599188) 2018-10-12 sprang@webrtc.org Add mock_video_encoder.h to api/test 2018-10-12 danilchap@webrtc.org Mitigate miscalculation of rtp packet size 2018-10-12 artit@webrtc.org Restore "device type" for iOS internal.client.webrtc Created with: gclient setdep -r src/third_party/webrtc@f7fee39547d8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4cc5d63780b7f3905730d1aa7d9a0793c7700cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1278724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599270}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/03ec3c699be2..3ae38f99451d git log 03ec3c699be2..3ae38f99451d --date=short --no-merges --format='%ad %ae %s' 2018-10-12 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@3ae38f99451d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7d46734d85dc65bea29172fa9f9851581806de7f Reviewed-on: https://chromium-review.googlesource.com/c/1278946Reviewed-by:
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb18-35.html BUG=412078 TBR=jschuh@chromium.org Change-Id: I3cb6654ba0c45ef3f2ed8cfcece43638d6c5582e Reviewed-on: https://chromium-review.googlesource.com/c/1278930Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599268}
-
Avi Drissman authored
BUG=893317 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8920fd240a55a32ee5dd27e049cc528193644dcf Reviewed-on: https://chromium-review.googlesource.com/c/1273809 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599267}
-
danakj authored
This was created to allow scrollbars to be disabled in "browser action popups". However the IPC is never actually used anymore. In RenderViewImpl scrollbars are disabled when the size goes below a limit and send_preferred_size_changes_ is true. Since the limit is always 0, the size is always >= the limit, and so scrollbars are always set to be shown. The comments imply that we use this to /disable/ scrollbars when send_preferred_size_changes_ is true, but now it would actually enable them always when send_preferred_size_changes_ is true. Other code does disable scrollbars on the LocalFrameView, so this would override that code which seems like a bug that we must just not hit. Instead of focusing scrollbars on for send_preferred_size_changes_, we can just remove the code that changes scrollbar showing at all from RenderViewImpl. Found this while trying to detangle DisplayMode and VisualProperties. R=ajwong@chromium.org, avi@chromium.org Change-Id: Ifa34cbe7aa880c1787873f622967aea25d62d720 Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1278164 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Sawyer Vaughan authored
NSUserActivityTypeBrowsingWeb indicates to the system that the user is browsing a website. This allows iOS to suggest native apps that have claimed the domain in their associated domains rather than always suggesting Safari. Change-Id: Ia08abb20f258f8dad474c081cfd59ff0d1666a9f Reviewed-on: https://chromium-review.googlesource.com/c/1270882Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sawyer Vaughan <sawyervaughan@google.com> Cr-Commit-Position: refs/heads/master@{#599265}
-
Patrick Monette authored
Bug: 884075 Change-Id: I85829ee1e898296013c4ead98d4b9b39121a49d6 Reviewed-on: https://chromium-review.googlesource.com/c/1265121Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#599264}
-
Mike Reed authored
Change-Id: Iee1b81a1ff7eb256f7c12ddbff672337d59b964b Reviewed-on: https://chromium-review.googlesource.com/c/1277926 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#599263}
-
Collin Baker authored
Change-Id: I5671d95901a93f227d14f24eb89d5cbfe588727b Reviewed-on: https://chromium-review.googlesource.com/c/1277271Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#599262}
-
Benjamin Wright authored
This change updates Chromium to use CryptoOptions::Srtp fields to configure the command line switches for WebRTC crypto instead of the old deprecated fields. This API was changed in: https://webrtc-review.googlesource.com/c/src/+/105180 Once this change lands the top level fields: absl::optional<bool> enable_gcm_crypto_suites and absl::optional<bool> enable_encrypted_rtp_header_extensions Will be removed and their replacements will be under the Srtp sub struct. Bug: webrtc:9859 Change-Id: I3f140097b870da8a6dd6a691f05298775a468230 Reviewed-on: https://chromium-review.googlesource.com/c/1275025Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Ben Wright <benwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#599261}
-
Sebastien Marchand authored
Also change the default value of the "mainThreadTaskLoadLowThreshold" param to 25 as it's the value we've used in all our Finch experiments. Bug: 829933 Change-Id: If26ad7c87e97b325ba254ce5346e6becfb353899 Reviewed-on: https://chromium-review.googlesource.com/c/1277270Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#599260}
-
Pavel Shmakov authored
and use it in TWAs to avoid toolbar flickering. When TWA is opened, the toolbar shows for a fraction of a second before disappearing. It happens because before finishNativeInitialization() is called we either don't have a tab, or have one from a warmup that is not yet attached anywhere. Thus the Tab#canShowBrowserControls() mechanism, which would use TrustedWebActivityUi#mInTwaVisibilityDelegate as part of ComposedBrowserControlsVisibilityDelegate doesn't allow to reliably hide the toolbar in TWAs. The alternative mechanism is ChromeFullscreenManager#setHideBrowserControlsAndroidView. Using it as-is would be dangerous, though, because several clients would now manipulate the same boolean. It needs a token mechanism like the one implemented in BrowserStateBrowserControlsVisibilityDelegate. I move the setHideBrowserControlsAndroidView into BrowserStateBrowserControlsVisibilityDelegate and introduce tokens for persistent hiding. Persistent hiding has a priority over persistent showing. Then I use persistent hiding in TWA instead of an additional BrowserControlsVisibilityDelegate. Bug: 891214 Change-Id: I0a1c2ee50f4dba5f07fb1d8f0fd1b8a9dd1cc6cf Reviewed-on: https://chromium-review.googlesource.com/c/1256965Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#599259}
-
Donn Denman authored
Writes a snippet-hash and doc-id to UKM iff a command-line flag is set that allows this development-only data to be logged. Disabled on Beta and Stable channels. See go/ukm-cs-5, go/ukm-dev-data, go/cs-sanitized for details. Unfortunately our ContextualSearchDelegate cannot decode a JSON 64bit value so we now expect to receive these new data in string format. Also fix a bug in the existing Ranker code: the native logger cannot log 64-bit values, so we rename some misleading methods. Also, we need to break these new data up into high/low 32-bit values when we log to Ranker. BUG=894568, 872902 Change-Id: Id0dd3ac218bafeb23396f010c340e5e5531799f0 Reviewed-on: https://chromium-review.googlesource.com/c/1264591Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#599258}
-
Katie D authored
No functional changes. Bug: 876115 Change-Id: Id4a4008c6aff53ff4718b04d5c4186b97c769580 Reviewed-on: https://chromium-review.googlesource.com/c/1277987 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
This is for the convenience of testing rlz ping. The normal waiting time is 24 hours and it's unrealistic for testing team. Bug: 894331 Change-Id: Ia5d6d38bc05221672d4ae4a0b6da4e221aaa0607 Reviewed-on: https://chromium-review.googlesource.com/c/1270012Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit 90115af8. Reason for revert: caused layout test failures on Android: * compositing/geometry/bounds-ignores-hidden.html * compositing/images/clip-on-directly-composited-image.html * crypto/random-values.html * crypto/subtle/importKey-badParameters.html Original change's description: > Layout test text dump rebaseline using Element.innerText part 1 > > This patch changes tests in the following directories to use > Element.innerText for text dump: > > accessibility/ > animations/ > battery-status/ > bindings/ > clipboard/ > compositing/ > crypto/ > > Most of this patch is mechanical rebaseline, except: > - Some LayoutNG-specific baselines become redundant and are > removed > - One test is turned into failure with LayoutNG flag due to > LayoutNG innerText bug with ellipsis (crbug.com/873957). > > Bug: 887148 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Idf28a2696b4824f3fd845c7392b588544e8de1d3 > Reviewed-on: https://chromium-review.googlesource.com/c/1239165 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599052} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org Change-Id: I0018e928bd9789c95c2d923b35296f1f82fd41c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887148, 894841 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1278931 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599255}
-
Moe Ahmadi authored
Bug: 892220 Change-Id: I0aa186011149b4c53697fcfa0a62d3ee60dbe956 Reviewed-on: https://chromium-review.googlesource.com/c/1278885 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#599254}
-
François Beaufort authored
Change-Id: I0186fd20fc1d1e763208f5488917b65d24fa3e00 Reviewed-on: https://chromium-review.googlesource.com/c/1278786Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#599253}
-
Ulan Degenbaev authored
Original change's description: > [perf] Add browse:media:tumblr:2018 system health story > > This also add a login helper for tumblr and updates credentials.json > > Bug: 878390 > Change-Id: Iba56faf550cb638692899326b217347e04be9932 > Reviewed-on: https://chromium-review.googlesource.com/c/1256883 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596763} Change-Id: I45d738bf10b7fcc72a1d032785d4eba2727b5363 Reviewed-on: https://chromium-review.googlesource.com/c/1277789Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599252}
-
Katie D authored
This cleans up Autoclick code, resolving a TODO, by refactoring AutoclickControllerCommon into AutoclickController and eliminating the need for the delegate. Also makes AutoclickController into a concrete class, removing the need for AutoclickControllerImpl and improving readability. Bug: 876115 Change-Id: Id38917adc38aafcb4f4602e8827f0ad43d1f1dba Reviewed-on: https://chromium-review.googlesource.com/c/1277961 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
-
Tim Volodine authored
Add InterceptedRequest class, which represents an in-progress network request and allows to receive callbacks at certain points in the process and control the flow. This patch also adds code for the OnReceivedHttpError callback, which fixes the following tests: - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testAfterRedirect - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testForMainResource - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testForSubresource - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testNotCalledIfNoHttpError This patch in more detail: - add IntercepedRequest internal class - add code necessary for AwContentsClientBridge lookup - detect http errors and code for the onReceivedHttpError callback - update tests filter BUG=891722 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2123a30b0c9ea8c3f07c34adc0fedb6bc69ca8f3 Reviewed-on: https://chromium-review.googlesource.com/c/1259019 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#599250}
-
Xianzhu Wang authored
Bug: 703899 Change-Id: I3b19b91c5e74401e7ba576112d68f0adc9893aca Reviewed-on: https://chromium-review.googlesource.com/c/1277286Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599249}
-
Greg Kerr authored
This reverts commit 4173f201. Reason for revert: The dependent CL was reverted so this has to be reverted. https://chromium-review.googlesource.com/c/chromium/src/+/1278162 Original change's description: > Reland "macOS V2 Sandbox: Remove the feature flags." > > This is a reland of 5c4908e8 > > Original change's description: > > macOS V2 Sandbox: Remove the feature flags. > > > > The V2 sandbox is now default for all but the network and GPU processes > > on macOS. This CL deletes the feature flag. A new experiment will be > > introduced for the GPU process. The default case for the sandbox profile > > switch is removed, because previous CHECK() failures were confusing to > > diagnose. All profiles must now be handled explicitly, so Chrome won't > > build if a new profile type isn't handled. > > > > Bug: 749839 > > CQ-Depend: 1268671 > > Change-Id: I0860d3a5148b0085be6a99dc01c4971602ee5582 > > Reviewed-on: https://chromium-review.googlesource.com/c/1269996 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Mark Pearson <mpearson@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#598128} > > CQ-DEPEND=CL:1268671 > > Bug: 749839 > Change-Id: I91544907b640c572823f3aae3e29c0cfa003da51 > Reviewed-on: https://chromium-review.googlesource.com/c/1274888 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598822} TBR=avi@chromium.org,mpearson@chromium.org,kerrnel@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I301c95634bd447d35ef19948cf0488c0bf847e58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749839 Reviewed-on: https://chromium-review.googlesource.com/c/1278861Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599248}
-
Owen Min authored
Bug: 894212 Change-Id: Icd4c7d9f8a79a9b57900366d4677b0e7023b8ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1274196 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#599247}
-
Sergey Poromov authored
PrintingAllowedColorModes - Launch in M70 (remove 'Future' flag) PrintingAllowedDuplexModes - Launch in M71 (remove 'Future' flag) PrintingAllowedPageSizes - M72 PrintingColorDefault - M72 PrintingDuplexDefault - M72 PrintingSizeDefault - M72 Bug: 853877 Change-Id: Ibda00ef02efc4dfc1f5b04079bb776f8b3e10f05 Reviewed-on: https://chromium-review.googlesource.com/c/1235675 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#599246}
-
Min Chen authored
The kAppType of browser based custom apps are set based on the |app_name|, which is not set for the internal apps like Settings and Discover. Rewrite it for these two apps in corresponding window manager to make sure both of them can have the correct app type now. calamity@ is doing a refactoring of the system apps here (https://docs.google.com/document/d/16CRTWFjU8Ohrn9aSTPuDJcbqh1z7E4wKwyEWstInRh0/edit#), which will fix all these related issues in long term. Bug: 877723 Change-Id: Iaaf9fb4998a1416bae4a8c6fa5582d1ff2235326 Reviewed-on: https://chromium-review.googlesource.com/c/1258090Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#599245}
-
Marc Treib authored
A small step on the journey to making sync-internals useful for investigating auth-related issues. Bug: 889844 Change-Id: Ifa84cdb4e0f418e89b5207d4ea3cb1cb7d31b382 Reviewed-on: https://chromium-review.googlesource.com/c/1278628 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#599244}
-
W. James MacLean authored
This suite of tests has been flakey for a *long* time on Windows, it's time to disable them until they are fixed. TBR=nyquist@chromium.org TBR=sky@chromium.org Bug: 882937 Change-Id: I383a959faeb2798a15ee0fe9c32a06c58af20573 Reviewed-on: https://chromium-review.googlesource.com/c/1278543Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599243}
-
Marc Treib authored
It's always set to the same value, and it's never actually read (apart from some DCHECKs). This also uncovered lots of IWYU violations which this CL fixes. Bug: none Change-Id: Idf98478d8fcf81f65ab42b7b9561de0ceff701dc Reviewed-on: https://chromium-review.googlesource.com/c/1276505 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Daniel Bratell authored
When a different static char broke the build (for unrelated reasons), I looked through the tree for other static chars without const. This was the only other one outside third_party and tests. It's possible the generated machine code is the same, or it might become better this way. Depends on the compiler/linker/OS. Change-Id: I11a75cda4de25d468357f36e1afb23c79460ace8 Reviewed-on: https://chromium-review.googlesource.com/c/1278730 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#599241}
-
Morten Stenshorne authored
Remove some special-code to resolve the logical height of percent-based replaced content whose containing block was an out-of-flow object with auto height and non-auto top/bottom. This caused problems for LayoutNG, which typically hasn't stored the new heights on the containing blocks at the time of calculating the height of some child (so attempting to calculate anything based on the ancestor layout objects during layout won't work in NG). If we just remove the special-code, and fall back to calling ContainingBlockLogicalHeightForContent() further down, that method will honor the containing block logical height override (which NG has calculated and set before entering the legacy replaced content object). For legacy layout, we'll eventually bump into more or less identical (to what I'm removing here) special-code in AvailableLogicalHeightUsing() anyway. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I78636cce88bd66e625925b79e19183d4653f32fe Reviewed-on: https://chromium-review.googlesource.com/c/1278865 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#599240}
-
Jialiu Lin authored
SignInManager considers incognito profile as not signed-in. As a result, when user reuses their sync password in incognito profile, the reuse password type is mis-identified as OTHER_GAIA_PASSWORD. This CL makes incognito profile aware of its original profile's sync username such that sync password reuse detection can work correctly in incognito mode. This CL also makes it more explicit that Chrome does NOT save any password hashes if the user is in incognito mode to prevent leaking any browsing history to original profile. Change-Id: Ie4398a85e4a13045f418cebd38313bb32c4bb6fd Bug: 893715 Reviewed-on: https://chromium-review.googlesource.com/c/1273993 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599239}
-
Ehsan Chiniforooshan authored
Bug: 894622 Change-Id: I89647c29faccb5654000a98cebabea92d9511618 Reviewed-on: https://chromium-review.googlesource.com/c/1278850Reviewed-by:
-
