- 18 Oct, 2018 40 commits
-
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: I4531f45b3b5cc6da3deaae06955a30150e762e36 Reviewed-on: https://chromium-review.googlesource.com/c/1286089Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#600658}
-
Victor Costan authored
Bug: 892852 Change-Id: Iaca2e20497edb4317c9e628afc398845decca54b Reviewed-on: https://chromium-review.googlesource.com/c/1266758Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600657}
-
Stephen Barber authored
BUG=chromium:894919 TEST=none Change-Id: I03c7f9332ca2fcf33e908a3ad42f9651d5406cba Reviewed-on: https://chromium-review.googlesource.com/c/1279288Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Stephen Barber <smbarber@chromium.org> Cr-Commit-Position: refs/heads/master@{#600656}
-
Josh Pratt authored
This mitigates pixelisation in the Tux logo when rendered in the Crostini installer. Bug: 896540 Change-Id: I1f96206701dcfccef4f806a67adbdb5af9f6fa12 Reviewed-on: https://chromium-review.googlesource.com/c/1288109Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600655}
-
Asa Karlsson authored
Fix leak in RemoteFontFaceSource where a temporary SimpleFontData instance was not de-referenced and hence never destroyed. The leak was introduced by the refactorings made in this commit: https://chromium-review.googlesource.com/c/chromium/src/+/691475 Change-Id: I6473702a53e83f5fdfbe0fe84ede675c41c5ddad Reviewed-on: https://chromium-review.googlesource.com/c/1286451Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#600654}
-
Tetsui Ohkubo authored
Some a11y related source files were put directly under ash/system or ash/system/unified while there's ash/system/accessibility. TEST=trybot pass BUG=none Change-Id: I779b7791c582422451d0f8ef1d63ccadc0d40952 Reviewed-on: https://chromium-review.googlesource.com/c/1272918 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600653}
-
Giovanni Ortuño Urquidi authored
Some pages could perform same-document navigations e.g. push/popState while we download icon. Since these navigations are still in the same document it should be safe to ignore them and continue with the installation. Changes WebAppIconDownloader to ignore same-document navigations and continue downloading the icons. Bug: 889660 Change-Id: I120ba6f38a5aa0a803fa82615cd8bd73412bbb67 Reviewed-on: https://chromium-review.googlesource.com/c/1287330 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#600652}
-
Nicholas Verne authored
We can detect that they stopped behind our backs (e.g. via crosh commands). Bug: 896387 Change-Id: I38147f836fce54a34ddb7a792137a007fca145c2 Reviewed-on: https://chromium-review.googlesource.com/c/1288089 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600651}
-
Stuart Langley authored
Add support for /drive/Computers in volume_info and directory_tree, for displaying a users backed up Computers, if they have any. The logic here is very similar to the logic for team drives, where we will only display the '/Computers' entry if there is a sub-directory under it. Hence a lot of the code is cargo culted from the team drives implementation. Potentially come back and refactor the common code between Computers and Team Drives once this stabilizes. Bug: 884020 Change-Id: I1ebf52ba64e5cb5bd809b64cc52bf182e3d11f19 Reviewed-on: https://chromium-review.googlesource.com/c/1255084 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#600650}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 25073f6c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26379 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Id4c12bedcda6324aac7d435cbac41c9514bafc19 Reviewed-on: https://chromium-review.googlesource.com/c/1287436 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600649}
-
Anne Lim authored
Clears all strikes in a profile's StrikeDatabase when Autofill data is wiped out from Chrome Settings (chrome://settings -> Clear Browsing Data -> Advanced -> Autofill Form Data). Bug: 884817 Change-Id: I15cab8ab6812b1367d386c7bf321be24b1a0086c Reviewed-on: https://chromium-review.googlesource.com/c/1277842 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600648}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: If9a3f9d7a8b52148f6d39247e712bbe8bc177565 Reviewed-on: https://chromium-review.googlesource.com/c/1287317Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600647}
-
Luciano Pacheco authored
This reverts commit 1eeaf562. Reason for revert: The culprit CL is this one here: crrev.com/c/1282517 which is already reverted: crrev.com/c/1287729. Original change's description: > Revert "ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_" > > This reverts commit 0ad9fe79. > > Reason for revert: speculative revert, will revert the revert if not a root cause. > > Bunch of Video/file-manager related tests started to fail: > OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive_DriveFs > OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads > VideoPlayerBrowserTest.OpenSingleVideoOnDrive > VideoPlayerBrowserTest.OpenSingleVideoOnDownloads > VideoPlayerBrowserTest.ClickControlButtons > OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads_GuestMode > VideoPlayerBrowserTestInGuestMode.OpenSingleVideoOnDownloads > VideoPlayerBrowserTest.CheckInitialElements > OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive > > Failures: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9115 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9116 > > Original change's description: > > ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_ > > > > Appliy ES6 features to the DirectoryModel.onVolumeInfoListUpdated_ and > > FileManager.setupCurrentDirectory_. > > > > ES6 styles: > > - Change var to const or let. > > - Change anonymous functions+bind(this) to arrow functions. > > > > Remove a TODO that linked to a closed bug. > > > > Move comment to be before queue.run() to match the style of the > > previous lines. > > > > Apply the formatting from git cl format, which is slightly uglier, but > > at least automatic. :-) > > > > Test: No change in behaviour. > > Change-Id: I5564263d44f8639d97fc86d7add5a59e8938be6d > > Reviewed-on: https://chromium-review.googlesource.com/c/1286239 > > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600312} > > TBR=joelhockey@chromium.org,lucmult@chromium.org > > Change-Id: I5f4aa388d2b88c5914c705c71b0fcc70904a42fe > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/1288169 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600640} TBR=kinuko@chromium.org,joelhockey@chromium.org,lucmult@chromium.org Change-Id: I7ce79f80a47367a2e5547e1bb3d5b227c40e77dd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1288091Reviewed-by:
-
Tetsui Ohkubo authored
This CL adds 2dip padding between tray icons & fix WiFi icon padding. WiFi icon is also used in network detailed view, so we have to set the custom padding by checking IconType. TEST=manual BUG=885233 Change-Id: I5848007a1c71af54bba29105bcef7e063f7b6cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1286237 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/451dc721b571..324e0418e810 git log 451dc721b571..324e0418e810 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 ihf@chromium.org chromeos_config: run test on eve-arcnext PFQ. 2018-10-17 bhthompson@google.com Add bvt-inline HW tests to nocturne-paladin Created with: gclient setdep -r src/third_party/chromite@324e0418e810 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I819c58c3eb55d9c1d4c4bc94ff2640b6f193431f Reviewed-on: https://chromium-review.googlesource.com/c/1288010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600644}
-
Alan Cutter authored
PWA windows are intended to appear stand alone from the main browser so they should not adopt the main browser's theme colors. This CL provides a default theme getter to be used by hosted app (and PWA) windows. This CL also removes the quick fix for this issue done by https://chromium-review.googlesource.com/c/chromium/src/+/1275466. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363145&signed_aid=TMzuMVlMKC2dm6ppdYp9PQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363146&signed_aid=Og46P66KeV7iP-mnBHO3cA==&inline=1 Bug: 891560 Change-Id: I2d94bff9f72bfca59fcf7d6cb940f42e4a25cc70 Reviewed-on: https://chromium-review.googlesource.com/c/1272896 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#600643}
-
Luciano Pacheco authored
This reverts commit c4d25f5b. Reason for revert: This made some tests for Video and Audio players flaky crbug.com/896529 Original change's description: > Unify JSErrorCounter for Files, Audio, Video and Gallery apps. > > Bug: 893430 > Change-Id: I4cb8149eaec9c9ab22700905dae804ac893fdb6c > Reviewed-on: https://chromium-review.googlesource.com/c/1282517 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600308} TBR=tapted@chromium.org,noel@chromium.org,lucmult@chromium.org Change-Id: I676ef1e26b98ff842158501ebf1221520db18bc9 Bug: 896529 Reviewed-on: https://chromium-review.googlesource.com/c/1287729 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This is similar to https://crrev.com/c/1256384 but for subresource loading. Design doc: https://docs.google.com/document/d/16K2X5k6hUq7lZSee-KXR9FUeSTEEypDXCjYbu_CvkT0/edit?usp=sharing Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 877972 Change-Id: Iba9c82b4de08862699eb1ba318f5710fe0264d86 Reviewed-on: https://chromium-review.googlesource.com/c/1264335 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600641}
-
Kinuko Yasuda authored
This reverts commit 0ad9fe79. Reason for revert: speculative revert, will revert the revert if not a root cause. Bunch of Video/file-manager related tests started to fail: OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive_DriveFs OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads VideoPlayerBrowserTest.OpenSingleVideoOnDrive VideoPlayerBrowserTest.OpenSingleVideoOnDownloads VideoPlayerBrowserTest.ClickControlButtons OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads_GuestMode VideoPlayerBrowserTestInGuestMode.OpenSingleVideoOnDownloads VideoPlayerBrowserTest.CheckInitialElements OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive Failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9115 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9116 Original change's description: > ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_ > > Appliy ES6 features to the DirectoryModel.onVolumeInfoListUpdated_ and > FileManager.setupCurrentDirectory_. > > ES6 styles: > - Change var to const or let. > - Change anonymous functions+bind(this) to arrow functions. > > Remove a TODO that linked to a closed bug. > > Move comment to be before queue.run() to match the style of the > previous lines. > > Apply the formatting from git cl format, which is slightly uglier, but > at least automatic. :-) > > Test: No change in behaviour. > Change-Id: I5564263d44f8639d97fc86d7add5a59e8938be6d > Reviewed-on: https://chromium-review.googlesource.com/c/1286239 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600312} TBR=joelhockey@chromium.org,lucmult@chromium.org Change-Id: I5f4aa388d2b88c5914c705c71b0fcc70904a42fe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1288169Reviewed-by:
-
Tetsui Ohkubo authored
This CL adds sliding out animation to NewMessageListView when notifications are removed. Animation on removal consists of two stages: SLIDE_OUT and MOVE_DOWN. Previously, MOVE_DOWN was implemented in https://crrev.com/c/1280087 . Video: http://shortn/_HiEcuNpheU UnifiedMessageListView will replace MessageListView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest BUG=769219 Change-Id: I8abe9eedeeb7bd1bcef09e5cb5a072a0ab88fee2 Reviewed-on: https://chromium-review.googlesource.com/c/1282628 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#600639}
-
Xiaohan Wang authored
This CL updates the EME requestMediaKeySystemAccess() stack to support AV1. For library CDMs, it needs to be signaled during CDM registration. In the next CL, ClearKeyCdm will be updated to actually support AV1 playback. TBR=sorin@chromium.org Windows. Bug: 884898 Test: Added new test cases. Also manually tested component installer on Change-Id: I0222136c76682db51bcf021c6bd5db3c467c271e Reviewed-on: https://chromium-review.googlesource.com/c/1241569 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600638}
-
Victor Costan authored
The new release changes how ALTER TABLE RENAME is implemented, and requires an update to WebSQL's SQLite authorizer. This CL includes the update, and extends the LayoutTest for the authorizer to cover the newly implemented column renaming functionality. Bug: 892852 Change-Id: I58fdc2927cacb6ccc84a741d7fc519fb2e5b8721 Reviewed-on: https://chromium-review.googlesource.com/c/1266881Reviewed-by:
-
Takuto Ikuta authored
`gn gen` failed due to missing pdb files. This is follwup of https://chromium-review.googlesource.com/c/1279380 TBR: wfh@chromium.org thestig@chromium.org Change-Id: I513d10d61a3868953c4afc025adf840e0f3c70c2 Reviewed-on: https://chromium-review.googlesource.com/c/1286108 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600636}
-
rbpotter authored
Bug: 895733 Change-Id: Iee9b0deb1016d28c8d6b4c870cdd452c52feda71 Reviewed-on: https://chromium-review.googlesource.com/c/1285116Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600635}
-
Ned Nguyen authored
Bug: 893618 Change-Id: Idbfa57949f173847d2985e528fe05bdf1a2e93a2 Reviewed-on: https://chromium-review.googlesource.com/c/1287033 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600634}
-
Ned Nguyen authored
Bug: 893618 Change-Id: I56f6c0ccf0c7cecfa419d557ed9fc444f500cd2d Reviewed-on: https://chromium-review.googlesource.com/c/1287039Reviewed-by:
-
Alexander Alekseev authored
This Cl changes layout of PIN setup input/keyboard to match new specs. This changes behavior both in First Run and in Settings UI. Bug: 884667,890685 Change-Id: Ie0f94dfaa3ea22cdf99f478eb21ec1631de41bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1286199Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#600632}
-
Giovanni Ortuño Urquidi authored
The implementation just forwards the call to BlueZ. Future iterations will support saving the new state into a user pref and concurrent calls. Bug: 870192 Change-Id: I1dc1ebec9a58378ed8a4b87f31027c76a2a03323 Reviewed-on: https://chromium-review.googlesource.com/c/1280066Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#600631}
-
Shakti Sahu authored
This CL fixes 1 - Paused downloads showing up as failed after browser restart 2 - Pending for network downloads showing up as failed Bug: 894159 Change-Id: Id4879c7e7a8e66413943c2a7732a72c558e11a49 Reviewed-on: https://chromium-review.googlesource.com/c/1284889 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600630}
-
James Cook authored
Bug: none Change-Id: I9d5b73409d25cf667a5b1ac580a7c5d6ddd3ea1a Reviewed-on: https://chromium-review.googlesource.com/c/1286878Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#600629}
-
Sergey Ulanov authored
swiftshader now supports arm64 Bug: 881334 Change-Id: I370fb7bdc361588ff69e47ac81af991ee2c02af1 Reviewed-on: https://chromium-review.googlesource.com/c/1287206Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600628}
-
Findit authored
This reverts commit f24f12dd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 600509 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjI0ZjEyZGRhYzc2ZmRlZDRiYmJkMmI0NjMxOTUyYjlhY2QyOWNjMQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14827 Sample Failed Step: viz_content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Added Fling Bubbling browsertests. > > The tests were initially landed in the following cl: > https://chromium-review.googlesource.com/c/chromium/src/+/1278963 > > The logic of the cl is re-landed in a separate cl(r599781) to give it > more time to bake. This cl re-lands the browser tests after applying > the following changes: > > 1- Addressed renaming nit. > 2- Used MainThreadFrameObserver to make sure that compositor is synced > after scrolling on main thread. > > Bug: 894703 > Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55 > Reviewed-on: https://chromium-review.googlesource.com/c/1286875 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600509} Change-Id: Ie617c2ccc9b0048d24804ab59cdb5753f99a3e32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894703, 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1287077 Cr-Commit-Position: refs/heads/master@{#600627}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a482179dedb..25843dd65181 git log 3a482179dedb..25843dd65181 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 ynovikov@chromium.org Align memory access in Copy32FixedTo32FVertexData 2018-10-17 jmadill@chromium.org perftests: Record trace events to JSON file. Created with: gclient setdep -r src/third_party/angle@25843dd65181 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2013d8790c16cd8e11b2b34d9ff5c6973d32ec0a Reviewed-on: https://chromium-review.googlesource.com/c/1287412Reviewed-by:
-
Tom Finegan authored
Re-encoded for spec compliance. Previous versions omitted the Codec Private. BUG=879263 R=dalecurtis Change-Id: I466e15886bba2b975b4b8b93a15cefb604f93057 Reviewed-on: https://chromium-review.googlesource.com/c/1287091Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600625}
-
Sky Malice authored
Bug: 896468 Change-Id: I17754946715d84c0db9b8d1bda237553d171c4ac Reviewed-on: https://chromium-review.googlesource.com/c/1287292Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#600624}
-
Eugene But authored
Bug: 546191 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I870931443b05f0ea8767864346703ba954df63f0 Reviewed-on: https://chromium-review.googlesource.com/c/1287291Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600623}
-
dpapad authored
The test was failing because it was asserting on a DOM subtree that was behind a <dom-if> that is false. In Polymer 2, a new optimization prevents those parts of the DOM to receive any updates. Bug: 896208 Change-Id: I268b6732ccf75f5544b3ce3011a73fbc8d11f55b Reviewed-on: https://chromium-review.googlesource.com/c/1287199Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600622}
-
Carlos Knippschild authored
TBR=edwardjung@chromium.org Bug: 852872 Change-Id: I6a48dca2ccb00fcac5f4ad2420694478d93639b7 Reviewed-on: https://chromium-review.googlesource.com/c/1285693Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#600621}
-
Mike Dougherty authored
When a WKWebView is displaying a PDF, the first responder is not in the view hierarchy (but a class adhering to UIResponder). Bug: 882470 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6f9e993e740541b7cf009b1d11e16183b409fdae Reviewed-on: https://chromium-review.googlesource.com/c/1284438 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600620}
-
Michael Giuffrida authored
When localizing an extension, prioritize the user's preferred language over the application locale. Normally, these are the same. In some cases, they differ. For example, the user may choose to display Chrome in "en-CA" (the intl.app_locale pref), but because we don't have translations for that, the actual UI locale is "en-GB". This CL makes extensions try to use the user's preferred locale for i18n ("en_CA"), falling back to the UI locale ("en_GB") if no locale directory is found for the preferred locale. This change also updates the "current_locale" manifest key to reflect the user's preferred locale, or the UI locale if intl.app_locale is unset. Note: Like the application locale, the preferred locale is only set at startup (and in certain situations in CrOS). If the user changes their intl.app_locale pref, they have to restart Chrome before extensions are re-localized, just like before. Bug: 874225 Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d Reviewed-on: https://chromium-review.googlesource.com/c/1244666 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600619}
-
