- 12 Jun, 2019 40 commits
-
-
Ben Pastene authored
Fixes include: - Using the system python when trying to invoke a python script. - Don't run the test via swarming on mac since there's no mac VMs available in chrome-swarming's test pool. Bug: 961548 Change-Id: Idad126d8b90ea77d772fc239d55f799864127eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654268Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#668424}
-
Eric Willigers authored
Web Platform Tests for computed values of CSS Text properties https://drafts.csswg.org/css-text-3/#property-index Change-Id: I52b3de169752db63c96c8662819d3b8a1141d721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653608 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#668423}
-
Nektarios Paisios authored
When trying to retrieve the target of an in-page link accessibility node, testing if the node IsAnchor() is not enough. The accessibility node may have the correct role to be an anchor, but no anchor element might be present in the DOM. The user facing bug is that "Reply All" crashes in Gmail. TBR=aleventhal@chromium.org, gilmanmh@google.com Bug: 971188 Change-Id: I119e51678ddaf03d6142d70f0872af4538d7a820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654808Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#668422}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2589cdcc88ec..fce1e2d1e279 git log 2589cdcc88ec..fce1e2d1e279 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 jonahr@google.com Extend eglGetPlatformDisplay to allow feature overrides. Created with: gclient setdep -r src/third_party/angle@fce1e2d1e279 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Change-Id: Ia0649a281fa1ad236fb7967e34a19fabb9bf0709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655038Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668421}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b2e12b08cdc..07b9e9354427 git log 0b2e12b08cdc..07b9e9354427 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 primiano@google.com Merge "trace_processor: fix asan leak in gzip decoding" Created with: gclient setdep -r src/third_party/perfetto@07b9e9354427 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id21e4b186df4bd3d4a82cd5a24048dbe2b3d77cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655040Reviewed-by:
-
Bailey Berro authored
This is the first CL in a series of changes to the add printer dialog flow that will remove the configuring dialog where possible, switching to promises rather than WebUI events, and move setup errors to be shown inline rather than as a toast on the cups_printers settings page. This change removes the configuring dialog between the manually add printer dialog and the model/manufacturer dialog Change-Id: I43100a99c8ade7a5df582c3d2f6e06f9ee52671a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637531Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#668419}
-
Moe Ahmadi authored
Adds tests for: -Accessibility -Toggling the Translate Switch -Adding a language -Changing language details Bug: 957688 Change-Id: Icadc52b121c18f823bcd37515b46daa1a3bec949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653250 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#668418}
-
danakj authored
The default command line set up by InProcessBrowserTest for browser tests should also be used by AndroidBrowserTest. Move the set up of that command line to chrome/test/base/test_launcher_utils.cc and have AndroidBrowserTest call it. Some clean up in InProcessBrowserTest while we there, moving the shared constructor code into an Initialize() method, so that #ifdefs around TOOLKIT_VIEWS are more clear, move variable initialization to the header declaration, and pass in the ViewsDelegate directly instead of going through a Bind and a lambda when it is just called synchronously anyhow. R=jam@chromium.org Bug: 961849 Change-Id: I3c3fad2b18fbead231e24b4ece32049ca9d43fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652195Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#668417}
-
Tibor Goldschwendt authored
Previously, we created a SplitInstallManager _before_ calling SplitCompat.install(-), which breaks the module install flow on Android pre-Q. Bug: b/133669491 Change-Id: I0b317732ed364a592047eeb7387c74dd1ea1b258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646903 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#668416}
-
Rakesh Soma authored
R:tienmai,yusufsn Bug: 973105 Change-Id: Ib7c05f3d9cc70cab53b2a106f1ec5d44096d95c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652735Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#668415}
-
Allen Bauer authored
Bug: 945335 Change-Id: I5671a91452f9c286dbf656da6cb9f0b219f34a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652084 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#668414}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. The virtual functions of this class has been refactored as part of another cl. Bug: 959157 Change-Id: I9f1354af8d8958f4df097816a70e78278f319c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649682 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#668413}
-
James Cook authored
Bug: 720159 Test: compiles Change-Id: I54d5836d71f41b7ce4367e9d89e12e14ded587f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652663 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Joanmarie Diggs authored
We need to unref root_obj. Bug: 973185 Change-Id: Ie0a326c125fda8ef397d4c8f4b68cabd2c8e7365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655674Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#668411}
-
Evan Stade authored
In some cases in this class, we already return early if no Browser is found for the web contents. This updates one callsite of FindBrowserWithWebContents with an early return, and another with a DCHECK. See also crbug.com/737346 Bug: 971468 Change-Id: I04bbc26679d96f58c7a6d6402cde4bec1409375b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649374 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Hugo Holgersson authored
The HTML spec says: "The href attribute on a and area elements is not required; when those elements do not have href attributes they do not create hyperlinks." Background: Chrome already excludes unclickable <area>s, <area>s without a href attribute, from the tab order. Problem: Unclickable <area>s still show a "click me" hint. Solution: Mimick Firefox. Only show the pointer for actual <area> links. Note: Found during crrev.com/c/1632231. We don't want unclickable <area>s to act navigable. Bug: 972556 Change-Id: I9214171290659b8b800db3e462478e2a1327c832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653009 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#668409}
-
Nazerke authored
Simplify the favicon loader API by converting the FaviconLoader's methods to non-return-value methods. Unit tests are rewritten according to the new API. Bug: 967660 Change-Id: I23c0ec34ecaba1cd363a4e99d13b8aa3a45ccb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645305Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#668408}
-
Ioana Pandele authored
If the focused field changes between the user manually requesting to generate a password and the callback coming back from the renderer to show the dialog, the callback should be ignored and the dialog should not be shown. This is because it is no longer relevant to the current focused field. Bug: 835234 Change-Id: Ic778d504b9aa07c12238ddc8ad4dada317801542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655433Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#668407}
-
Peter Wen authored
BitmapCache is more of a utility than a fundamental base package class like ChromeApplication.java. This paves the way for moving it out of chrome_java into //chrome/lib/util. Bug: 846440 Change-Id: I7b465f0915c6b107da1b648d94a3b00c8300f26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646412 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#668406}
-
Rohit Rao authored
iOS 13 supports running UpsideDown on phone, so this test is updated with new expectations. BUG=973398 Change-Id: Ic4fad631af1a01b3a35423d9272d9ae5de92b062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655669Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#668405}
-
Sam Maier authored
Change-Id: Id57b2d1e2f2749903f50c2c20e721faa650c2beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655035 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#668404}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/337c6daadba3..2875b88d0b00 Created with: gclient setdep -r src-internal@2875b88d0b00 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=haraken@google.com,tangltom@google.com,flackr@google.com Change-Id: Ica9c2a5f7efb2a54c663cd007c5744e3244030d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655251Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668403}
-
Rohit Rao authored
iOS 13 adds a new type of scroll indicator that needs to be explicitly excluded from ChromeSigninViewControllerTest. BUG=973398 Change-Id: I79048368b78fe862765eaca1b53092a578b31921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655668Reviewed-by:
-
Peter Kotwicz authored
This CL fixes a bug where the LaunchHostBrowserSelector would be called twice when a user selects a host browser: - once with the host browser package - once with null. This CL surpresses the second callback by disabling the OnDismissListener when a 'button is clicked' or 'host browser is chosen' This CL also fixes the same bug in InstallHostBrowserDialog BUG=972922 Change-Id: I6b33cc6a600f170e92e44de329f0d3eb24b6f23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652291Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#668401}
-
Brian White authored
Bug: 972781 Change-Id: I8254e2c67e5807f549a2a4a782ffb294683b5ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653529 Auto-Submit: Brian White <bcwhite@chromium.org> Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#668400}
-
Mario Sanchez Prada authored
These should have been removed with CL1631403 and CL1641882 but I forgot to do it, so let's remove them now to keep the tree clean. Bug: 939943 Change-Id: Ie185baf8cf653e68d5f9a10bbc4a5b39982e631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655469 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#668399}
-
Sergio Villar Senin authored
This is the first step to wipe WebThreadSupportingGC from the tree. It's basically a wrapper over WorkerThread adding some GC capabilities. This CL adds GC handling support to WorkerThread. It uses a new class called GCSupport which is in charge of creating the GCTaskRunner apart from attaching/detaching the current thread to ThreadState. This new machinery is disabled ATM, it'll be enabled later in followup CLs which will convert callsites to use WorkerThread instead of WebThreadSupportingGC. Bug: 961743 Change-Id: Ibee4e3ce40500398d5794c13e18984e52fc2c39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655430Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#668398}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5cf390386bdd..da1c65fb53c3 git log 5cf390386bdd..da1c65fb53c3 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 titovartem@webrtc.org Change reporting of time_between_freezes. Created with: gclient setdep -r src/third_party/webrtc@da1c65fb53c3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iad17c389bf5c9237b6e754397232795ea8e59cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655252Reviewed-by:
-
Peter Wen authored
Lifecycle is a self-contained package for managing Android application and activity lifecycles: https://developer.android.com/guide/components/activities/activity-lifecycle This CL moves the java target from //chrome/android/public to //chrome/lib as it is not specific to //chrome/android and can be reused by other //chrome layer features. Bug: 846440, 966644 Change-Id: I5b3a516b0818b39044ee757695203e915512acf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630740Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium db82c1cf. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: atotic@chromium.org: external/wpt/css/CSS2/abspos chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I229152a38214541c11e387a718a4ec67e05df260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655027Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668395}
-
Raphael Kubo da Costa authored
Since commit b1b678fa ("Allow providing README for license.py in 3p subdirectories"), when licenses.py finds a directory with a file called additional_readme_paths.json it parses the file and scans the directories listed there. However, it then excludes the very directory containing that file from the scanning process, which can lead to missing licenses since it can also contain a README.chromium. This can be verified via third_party/angle, which has both files and whose main license was not part of chrome://credits. Bug: 39240, 794210 Change-Id: I5335446b1b086cb1618a3b879c8d3f12cef7c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645361Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#668394}
-
Anders Hartvoll Ruud authored
Unfortunately the logical properties also need -internal-visited- counterparts. Initially you'd think we could first resolve the logical property into a physical property, and then handle its associated -internal-visited property, but that's impractical, since we can't resolve a logical property to a physical property until the computed values of text-direction and writing-mode are known. Bug: 972388 Change-Id: Iff4a385ecfd2af4d491b69d51ebf8efcfc4656a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653017 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668393}
-
David Bokan authored
Change-Id: Ia8150df51426928949742cb9bea234c6a5bf2f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655690Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#668392}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I79a8f6dafb9b0da82fee0538029263bfe062d597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654936Reviewed-by:
-
Alan Cutter authored
This CL removes expired flags in flag-metadata.json that have no corresponding flag in the codebase: - enable-autofill-save-credit-card-uses-strike-system - enable-autofill-save-credit-card-uses-strike-system-v2 - enable-cros-ime-service - enable-message-center-new-style-notification - enable-sync-pseudo-uss-app-list - enable-sync-pseudo-uss-apps - enable-sync-pseudo-uss-dictionary - enable-sync-pseudo-uss-extension-settings - enable-sync-pseudo-uss-extensions - enable-sync-pseudo-uss-favicons - enable-sync-pseudo-uss-history-delete-directives - enable-sync-pseudo-uss-preferences - enable-sync-pseudo-uss-priority-preferences - enable-sync-pseudo-uss-search-engines - enable-sync-pseudo-uss-supervised-users - enable-sync-pseudo-uss-themes - safe-browsing-telemetry-for-apk-downloads - sync-USS-autofill-profile - sync-USS-autofill-wallet-data - user-activity-prediction-ml-service Bug: 897809 Change-Id: I56ccaa2c5da5186c2f9ec385438203593a4cfc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654742 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#668390}
-
Yusuf Sengul authored
Access token being passed to GCPW from chrome login UI is login scoped. As part of chrome login UI, a down scoped access token is also generated. A similar scoped token is also needed in chrome/credential_provider code. R=rogerta, tienmai Bug: 971498 Change-Id: I8696947cc7d0b46d96f786af63b4c8a597328a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646496 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#668389}
-
Kevin Bailey authored
Currently, in and below CopyOldMatches, we copy all the working matches into 2 by-provider maps, and copy out the missed ones into the final working matches. This CL changes it to move the soon-to-be-destroyed matches (the old ones) into the map, and moves any matches which need to be copied out (old ones not in new set). Change-Id: Ibf58aa018dfb6f6f79620b43860034edff254d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593732 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#668388}
-
Mohamed Amir Yosef authored
We have suspecion that there are orphan metadata in the Password sync database due to some bug. This CL is relaxing the constaints for the detecting failures when the deletions fails. After monitor UMA, we may decide to revert this change. Bug: 973053 Change-Id: Id4f57921418978d9c6805e115d868c31b3d2200b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655511 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#668387}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=melandory@chromium.org Change-Id: I2cfad90e97f4cbfb11c34c1d0d3c596224c87204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649754 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#668386}
-
Alexandre Courbot authored
Having to keep a reference to the V4L2 buffer until the decode surface is released is a constraint of the config store, where V4L2 buffer IDs are used to reference frames: reusing a V4L2 buffer ID before all references to it have dropped would result in using a different picture as reference, even if the buffer that has been used for decoding remains unchanged. The request API does not have this limitation and this is thus just a sad workaround. Make it easier to remove by moving its tracking into the decode surface release callback. This is also a required step to remove the output buffer map, which comes in the next CL. BUG=941330 TEST=VDAtest passes on Minnie. Change-Id: I79f035e02e5b31144bace1cf0499727a371a45a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647308 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#668385}
-
