- 12 Apr, 2018 27 commits
-
-
Theresa authored
Adds some testing foundation and one simple integration test. BUG=827348 Change-Id: I71034071d32307dd922bc1a10f62e0bf1af070d0 Reviewed-on: https://chromium-review.googlesource.com/1007314 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550000}
-
Rohit Rao authored
BUG=825431 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I044a4fd10f669facccb7bc571b0e39548ac81a0b Reviewed-on: https://chromium-review.googlesource.com/1008666 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549999}
-
Jian Li authored
Bug: 831831 Change-Id: If1a36fbec7e73571d7d8c6a921afb3d8fa9b70c3 Reviewed-on: https://chromium-review.googlesource.com/1008635Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#549998}
-
Xiaocheng Hu authored
This patch records some InSameLine() call results as a preparation for implementing NG InSameLine(). Bug: 830956 Change-Id: Ia1a2a9b80363fa20be570638f057ccc8895d7a30 Reviewed-on: https://chromium-review.googlesource.com/1008173Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#549997}
-
Eliot Courtney authored
This covers the following cases: 1. Transition to clamshell mode while resizing. 2. Minimize/destroy a window while resizing with splitview with two windows. 3. Minimize/destroy a window while resizing with splitview with one window. BUG=b/72806943 Change-Id: I3d85ea882722b8d2bfe9361287bf78d9cae9d88a Reviewed-on: https://chromium-review.googlesource.com/1000659 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#549996}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 829695 Change-Id: I65285444001e79f1905fcaa4ae11e064f73049a2 Reviewed-on: https://chromium-review.googlesource.com/1006567Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549995}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ifeb035905396cc94df4a0f42d72fd84409e808d8 Reviewed-on: https://chromium-review.googlesource.com/1008730Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549994}
-
Yuqian Li authored
Bug: chromium:817110 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I184faae3ff12d8a23f6e5c12e43c92f1899f54c4 Reviewed-on: https://chromium-review.googlesource.com/1005297Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549993}
-
Kenneth Russell authored
Suppressing flakes in the following layout test: virtual/modern-media-controls/media/controls/modern/ doubletap-to-jump-forwards-too-short.html Tbr: steimel@chromium.org Bug: 831720 Change-Id: Id8975175c8a0001e433cdcc693b340170a5036c2 Reviewed-on: https://chromium-review.googlesource.com/1007976Reviewed-by: -
Sunny Sachanandani authored
We want |reason_hr| to be in scope so that the debugger can show it. Otherwise it's still on the stack at [rbp-10h], and you have to view the value in raw memory. R=piman CC=zmo BUG=794735 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4ecf1ce80885a64fd34a3aae235bab7a84ea9972 Reviewed-on: https://chromium-review.googlesource.com/1008629Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#549991}
-
Devlin Cronin authored
Update notification_system_observer_unittest.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: Ida57ff94738d3ec7fcfb207b8495d7a31d784a94 Reviewed-on: https://chromium-review.googlesource.com/1008607Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549990}
-
Andrii Shyshkalov authored
From chromium.gpu: Mac Retina Debug (AMD) Mac Debug (Intel) GPU Mac Builder (dbg) Mac Retina Release (AMD) Mac Release (Intel) GPU Mac Builder From chromium.mac: Mac Builder Mac10.10 Tests Mac10.11 Tests Mac10.12 Tests Mac10.13 Tests and two more builders I migrated long time ago: Mac Builder (dbg) Mac10.13 Tests (dbg) R=hinoka@chromium.org, kbr@chromium.org Bug: 790070, 790063, 790066, 790067, 790068, 790077 Bug: 790157, 790162, 790160, 818391, 790164 Change-Id: Icbe6cd4f3ad8ee0fa079d8127be7030776dfb311 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1009062 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#549989}
-
Brian White authored
Also, move one metric to where it will be recorded more frequently. Bug: 828244 Change-Id: I0e28a9ed2f3eedfd6d4c293fa293347f6edfdf08 Reviewed-on: https://chromium-review.googlesource.com/1004920Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#549988}
-
Scott Violet authored
Apparently this has been required for a while now on ChromeOS. It's not really required on non-ChromeOS, but no doubt it will soon, so adding to both. BUG=831700 TEST=none Change-Id: I6f859ff4767582c6c2a7155c995347d1963ceebd Reviewed-on: https://chromium-review.googlesource.com/1008420Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#549987}
-
Brian White authored
This histogram isn't showing anything meaningful and the problems it could show are better observed by looking at the allocators directly. Bug: 831013 Change-Id: Ibe968597758230192e53a7675e7390e968c9e5b9 Reviewed-on: https://chromium-review.googlesource.com/1008047 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Update shortcuts_provider_extension_unittest.cc to generate extensions using manifest_version 2. Bug: 816679 Change-Id: I1d895e66c6ebadff948ff78690d1130fbc725f4f Reviewed-on: https://chromium-review.googlesource.com/1008603 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#549985}
-
Michael Thiessen authored
Bug: 817423 Change-Id: I381e8b98926ffd9c18cf640daf033775e16bcac7 Reviewed-on: https://chromium-review.googlesource.com/1008702Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#549984}
-
Daniel Erat authored
Make ash::TrayPower avoid showing the low-power USB charger notification when the battery is full. This is a workaround for situations where the EC may choose to use a lower power level from a full-power charger. Bug: b/64913617 Change-Id: I0ba669eeeede7f21fe4371366e2f44032ce9cc7a Reviewed-on: https://chromium-review.googlesource.com/656525 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549983}
-
Yuly Novikov authored
deqp/functional/gles3/samplerobject.html conformance/glsl/functions/glsl-function-mod-float.html conformance/renderbuffers/depth-renderbuffer-initialization.html conformance2/renderbuffers/multisampled-depth-renderbuffer-initialization.html BUG=828984 TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I25fc291bacac96c2b757081eff430f69e61fa00f Reviewed-on: https://chromium-review.googlesource.com/1008826Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#549982}
-
https://chromium.googlesource.com/angle/angle.git/+log/ebd6e2df290a..14f4817c4dad $ git log ebd6e2df2..14f4817c4 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 lucferron Vulkan: Simplify viewport / scissor updates 2018-04-11 cwallez cq.cfg: equivalent_to to 100% for Windows tryservers. 2018-04-11 jmadill D3D11: Fix inactive attrib VAO perf regression. 2018-03-31 jmadill Texture: Pass ImageIndex to relevant methods. 2018-04-08 jmadill Vulkan: Rename vk::LineLoopHelper. 2018-04-10 lucferron Vulkan: Cleanup some TODOs in TextureTest.cpp 2018-04-10 jdarpinian D3D11: Fix primitive topology dirty bit tracking. Created with: roll-dep src/third_party/angle BUG=chromium:815092,chromium:829906,chromium:696345 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ib53f6489642caaae9657a7f69d4bd28c60527e19 Reviewed-on: https://chromium-review.googlesource.com/1008728Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#549981}
-
Sergey Berezin authored
BUG=790168 R=dpranke@chromium.org Change-Id: I7f6f95fba735ed2e317ee228ef21c5b78f1ff3b8 Reviewed-on: https://chromium-review.googlesource.com/1006155Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549980}
-
Brian White authored
Previously, TLS::Slot::Get() would create the TLS vector if it doesn't yet exist and then return the slot value which of course is null since it was just created. Now, just return null instead of creating the vector. The vector will be created by Set() if it doesn't exist. This allows clients to make use of an existing slot in dangerous situations (such as exception handling) without necessarily creating the underlying vector at that time. Bug: 821494 Change-Id: I404524ec7ccf0da4ea5451eea25b49783a711c04 Reviewed-on: https://chromium-review.googlesource.com/1007682 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549979}
-
Ramya Nagarajan authored
The menu item is not shown when the context menu is in a non-editable area. It's also omitted if a misspelling is selected, giving more prominence to spelling suggestions. Bug: 830213 Change-Id: I6a75bed3b091313c6dc32580d1c8900d8ab6ef83 Reviewed-on: https://chromium-review.googlesource.com/1008422Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549978}
-
Andrii Shyshkalov authored
R=hinoka@chromium.org No-Try: True Change-Id: I23053999ddc0fe6ca1c3ff62dd4a169214e58684 Reviewed-on: https://chromium-review.googlesource.com/1008739 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Bug: 742517 Change-Id: Ibb4f5f0b1bacb7c4c9e1b2b3f40a2c5d5f9d2ebb Reviewed-on: https://chromium-review.googlesource.com/1008419Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549976}
-
Daniel Cheng authored
Bug: 705169, 742517 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I105debbc2ccca76bd251d1f068a2fefb8bba3e09 Reviewed-on: https://chromium-review.googlesource.com/1004447Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549975}
-
Devlin Cronin authored
Update extension_app_shim_handler_mac_unittest.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: If39956a5b8b986da6d84957e91849cfe670346a0 Reviewed-on: https://chromium-review.googlesource.com/1008175Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549974}
-
- 11 Apr, 2018 13 commits
-
-
Sidney San Martín authored
Chrome is experiencing crashes like this when a download is dragged: > [Uncaught NSException] CALayerInvalidGeometry reason CALayer position > contains NaN: [nan nan] They started when I touched the dragging code at r545861 and, based on some research, the probable cause is a zero-size component. I haven't been able to trigger this locally so I'm guarding both of them. Bug: 826632 Change-Id: I0e7c7acdd5a84dca8f0771aafab58987553b10e9 Reviewed-on: https://chromium-review.googlesource.com/1008502Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549973}
-
Zhiqiang Zhang authored
This CL suppresses the RestrictApi lint warnings for the upcoming play_services SDK update to 12.0.1. After upgrading the SDK, some API calls will trigger RestrictedApi lint warnings and don't compile (especially for downstream, don't know why yet). The plan is to update downstream SDK version first, then do for upstream. Bug: 822826 Change-Id: I052ee06b6da92ee89e58e4aa3f606e93350d7b5c Reviewed-on: https://chromium-review.googlesource.com/1005992Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549972}
-
Anita Woodruff authored
- While the array length of NotificationResources.action_icons must match that of NotificationData.actions, the bitmaps it contains may be null, so add a '?' to allow for that. - This allows 2 more layout tests to pass when the mojo-notifications flag is enabled. (They previously failed with 'bad serialization' errors, when actions were used with no icons). Bug: 796991 Change-Id: Ibf8f93ceb9cd2a556597d28ec41fab726257a661 Reviewed-on: https://chromium-review.googlesource.com/1005116Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#549971}
-
Peter Wen authored
These large binary files are copied over to the root output directory and then copied into the apk. There is no good way to propagate their source paths like pak or dex since they are plainly copied. These files rarely, if ever, change. Some are even renamed from the actual source file to this final name. Thus adding them as constants. Bug: 827196 Change-Id: I20611da9784fc9b355cc29845a61c3814306e291 Reviewed-on: https://chromium-review.googlesource.com/1007884 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#549970}
-
Paul Dyson authored
This is for testing Adaptive Screen Brightness code. Also changes the Adaptive Screen Brightness code to use this implementation of IsVisible. Bug: 820883 Change-Id: Ieb46e1b6cc8e9036c4e510872ee053017426943b Reviewed-on: https://chromium-review.googlesource.com/1004837 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#549969}
-
Amirhossein Simjour authored
UiWidgetFactory is not popup, so it should be moved from org.chromium.ui.widget.popups to org.chromium.ui.widget Bug: 813917 Change-Id: I8056b456bfa71e5de51bbd0fe244e5b347f57b0d Reviewed-on: https://chromium-review.googlesource.com/1005793Reviewed-by:
-
Weiliang Chen authored
This change adds more links to slides and other information on README files. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I45d70cf69f3213c26e13589d0bf4ca07ad6f51d0 Reviewed-on: https://chromium-review.googlesource.com/1005844Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#549967}
-
Trent Apted authored
Blink core reuses the PopupMenu of an element and first invokes Hide() over IPC if a menu is already showing. Attempting to show a new menu while the old menu is fading out confuses AppKit, since we're sting in the NESTED EVENT LOOP of ShowPopupMenu(). Disable pumping of events in the fade animation of the old menu in this case so that it closes synchronously. We still want to pump messages in normal/interactive menu fades, otherwise web content animations / videos will pause for the duration of the AppKit fade animation. So this only affects explicit calls to PopupMenuHelper::Hide(). r503112 added the logic to unblock animating content on menu fade out, but it broke a corner case when a <select> menu updates itself in a click handler. Bug: 812260 Test: See test case file in bug. Change-Id: I06a63870126383e44ae2862ebeb133680df2fd8d Reviewed-on: https://chromium-review.googlesource.com/1006238Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#549966}
-
nednguyen authored
Bug: 790422 Change-Id: I491e42ee19d4254caa0d3da1317f38966dd55885 Reviewed-on: https://chromium-review.googlesource.com/1008127Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#549965}
-
Kevin Marshall authored
TBR=junov@chromium.org Bug: 831701 Bug: 831686 Bug: 831685 Bug: 831673 Bug: 831496 Bug: 831482 Bug: 831249 Bug: 831230 Bug: 829952 Bug: 829938 Bug: 818426 Bug: 818324 Bug: 810437 Change-Id: Id3f657e2c5d2d46456892069e61730689a5f733b Reviewed-on: https://chromium-review.googlesource.com/1008411Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#549964}
-
Qiang Xu authored
Changes: CloseBrowserSynchronously is provided in InProcessBrowserTest, we should prefer to use it. Bug: 268984 Change-Id: I0988d31b87d77eff2d714641e8327974aaa01d53 Reviewed-on: https://chromium-review.googlesource.com/1006524 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
-
Ted Choc authored
This also removes the icon on the left of the new context menu UI, which is part of the updated UX spec for context menus. BUG=813926 Change-Id: I171ebfe19e4d412e73ff7d659db838eab3be4ca4 Reviewed-on: https://chromium-review.googlesource.com/1006277 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549962}
-
Rohit Rao authored
Recent Tabs tableview cells are no longer marked with the Button a11y trait, so the matcher for the "Other Devices" button needed to be updated accordingly. BUG=825431 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2daa26fb0b2aa2fa45d4df0b62361f512fcb243e Reviewed-on: https://chromium-review.googlesource.com/1008046Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549961}
-
