- 06 Sep, 2018 40 commits
-
-
Chih-Yu Huang authored
Originally we calculate the output buffer size by this formula: (width * height + 32768), but we cannot guarantee it is enough. In this CL, the new formula is: min(2MB, width * height * 1.5) 2MB is empirically big enough for current usage, and (width * height * 1.5) is uncompressed buffer size. Both are feasible upper bound of the output buffer, so we choose the minimum one. BUG=b:113309237 TEST=pass testOtherH264FlexArbitraryH and testOtherH264FlexArbitraryW CTS at cyan device TEST=pass VEA unittest Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie53f79a9997420e1aad57168ad16f9e9718e4a54 Reviewed-on: https://chromium-review.googlesource.com/1195175 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589121}
-
HobeXD authored
I add a tracing tool in ChromeOS, and this is the Chrome side code to interact with the hal_adapter in ChromeOS through mojo. Also add the tracing of the camera capture request and get result. CQ-DEPEND=CL:1158095 BUG=b:109714458 TEST=Open about://tracing in Chrome, click Record, and choose CrosCamera. Open any camera app, and close it. Click Stop button in Chrome, and there will have some events show on the UI. In the process of camera service, and if you open the camera in chrome the browser process will also have some events. TEST=Pass capture_unittests Change-Id: I1ae67b8ca49d63679228eea5b579818b0b3d3686 Reviewed-on: https://chromium-review.googlesource.com/1158106 Commit-Queue: Jyun-jhe Chou <hobexd@google.com> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589120}
-
Vadym Doroshenko authored
These functions are used for allowing the user to change username and password in save prompt. Bug: 831123 Change-Id: I8fe155ab543db58f6bc893c2e9e3280c12ab1428 Reviewed-on: https://chromium-review.googlesource.com/1206331 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 26007adf. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24161 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I243449ebeb3e3e842f25a8d3cfc4e7716a13fb20 Reviewed-on: https://chromium-review.googlesource.com/1208198 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589118}
-
Marina Ciocea authored
Add a temporary check to investigate audio service experiment output controller histograms count mismatch. If histogram persistent memory is not setup before output controller metrics are reported, the check will fail (see https://crbug.com/867827#c40). This CL will be reverted in a couple of days after gathering data from canary. Bug: 867827 Change-Id: I1f18c12c2aa2741a27c0bf82f383de70e273fd24 Reviewed-on: https://chromium-review.googlesource.com/1205606Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589117}
-
Vadym Doroshenko authored
When new parsing for saving enabled PasswordManager::MoveOwnedSubmittedManager tries to find submitted NewPasswordFormManager and if it's found it's moved. As result there is nullptr in |form_managers_|. That would crash this function if it's called twice. This CL makes this function behaves gracefully - to remove nullptr. Bug: 880229 Change-Id: I7f91a113dc33a6a2d0b483485a66657bec9e6d28 Reviewed-on: https://chromium-review.googlesource.com/1206591Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#589116}
-
Sam McNally authored
If DriveFS is first launched while offline, it'll fail to launch, retry a few times and then give up until the user logs out and in again or toggles drive off and on again. Reduce the likelihood of this by delaying retries until online if DriveFS mount fails while offline. Bug: 880720 Change-Id: Id1e851d81dd693284374fb4d32ce250958de41e2 Reviewed-on: https://chromium-review.googlesource.com/1208996 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#589115}
-
Bernhard Bauer authored
Change-Id: Icc55ebab929b8a0b7f9119b9ff2ecf23a5554260 Reviewed-on: https://chromium-review.googlesource.com/1199588 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589114}
-
yoshiki iguchi authored
If the lock screen notification is disabled, NotificationHiddenView had a leak. This CL fixes that. Bug: None Change-Id: I0ddb2a37777849c44ac19e4398ea88369fcb4a08 Reviewed-on: https://chromium-review.googlesource.com/1208694Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#589113}
-
Matthew Cary authored
This will enable prefetching on arm64. This doesn't matter now as it's not deployed, but makes the build system less crufty (see crbug.com/880425 as well). Tested: confirmed by manual log examination that prefetch happened. Bug: 874885, 880425 Change-Id: I2a962003df78d135bce783d0a9ad66b1b1ef290a TBR: agrieve@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1206475 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589112}
-
Boris Yusupov authored
Bug: 866456 R=tzik@chromium.org Change-Id: I54b1192a65e9646b5177ce5fcfd15e5fdb735058 Reviewed-on: https://chromium-review.googlesource.com/1206335Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Commit-Queue: Boris Yusupov <boriay@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#589111}
-
Greg Thompson authored
BUG=879568 Change-Id: I3edeb811f2c892b6162f21648c7644b387007e25 Reviewed-on: https://chromium-review.googlesource.com/1200868 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#589110}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ade33ea. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24160 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I5af425dd79fc1b20ef87766208aca6dfc6af5382 Reviewed-on: https://chromium-review.googlesource.com/1209090 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589109}
-
Greg Thompson authored
BUG=879568 Change-Id: Ia3247e32ad072b014561990a9e0da87b7be3edc0 Reviewed-on: https://chromium-review.googlesource.com/1200866 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589108}
-
Han Leon authored
This CL is part of Onion Soup effort for Notification APIs, moving notification.mojom from blink/public/platform/modules/notifications/ into blink/public/mojom/notifications/, which facilitates moving content/common/service_worker/service_worker.mojom into blink/public/mojom/ in future. This CL: - moves notification.mojom into blink/public/mojom/notifications/. - moves those native types typemapped with notification.mojom mojom types from content/public/common into Blink common: content::PlatformNotificationData -> blink::PlatformNotificationData content::PlatformNotificationData::Direction -> blink::PlatformNotificationData::Direction content::NotificationResources -> blink::NotificationResources - of course, moves the corresponding struct traits from Content common into Blink common as well. BUG=595685,789846 Change-Id: Id4e43f5f290ee248ee29e71cb05b62197b47c180 Reviewed-on: https://chromium-review.googlesource.com/1195114 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#589107}
-
Alex Lau authored
This fixes failing test 'Linux Chromium OS ASan LSan Tests', which caused the previous CL to be reverted by https://chromium-review.googlesource.com/c/chromium/src/+/1203353 The issue was due to using EXPECT_EQ instead of EXPECT_STREQ to compare raw strings (which unfortunately passes with default args). then confirmed that EXPECT_STREQ fixes it. Bug: 844252 Test: Reproduced the issue with gn args is_asan=true is_lsan=true and Change-Id: I07720ba57f80b0a19c21d2ee3308809e6a8ce582 Reviewed-on: https://chromium-review.googlesource.com/1203754Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Alex Lau <alexlau@chromium.org> Cr-Commit-Position: refs/heads/master@{#589106}
-
Greg Thompson authored
In particular: GetShortcutName, GetStartMenuShortcutSubfolder, and GetLongAppDescription are now in InstallUtil. BUG=879568 TBR=bauerb@chromium.org,sky@chromium.org Change-Id: I42fb4e44fa5d315ee60d051f3410f3dc92e16d9e Reviewed-on: https://chromium-review.googlesource.com/1200865Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#589105}
-
Albert J. Wong authored
Previously, ViewMsg_Close was handled by either RenderWidget or RenderViewImpl depending on a complex interaction of dynamic dispatch on the recipient object, and message routing (which was influenced by where in code, on the browser side, the message was sent from). This tangle was masked previouly because RenderWidget and RenderViewImpl shared a single routing ID. Now that there are separate routing IDs for RenderWidget and RenderViewImpl, collocating all uses of ViewMsg_Close in one class simplifies reasoning. Similarly, making ViewHostMsg_Close_ACK also correspond to the RenderWidget and not the RenderViewImpl keeps the ACKs consistent with the original Close message. The reason RenderWidget was chosen over RenderViewImpl is because, examining the existing code, this message does indeed primarily act on Widgets. Historical comments stating otherwise have been updated. This leads to one semantic oddness where SessionStorageNamespace is keyed off the routing ID of the RenderWidget associated with the RenderView, but fixing this semantic wart would introduce another set of delegate methods that don't seem worth the complexity. Lastly, this code removes the fast-path in OsX where the Close_ACK was sometimes sent early. As the only action Close_ACK currently triggers is early cleanup of the SessionStorageNamespace, this code path also did not seem worth the complexity. In fact, it's not clear that the old code wasn't causing a possibly crash in Mac in very edge-case scenarios. Bug: 545684 Change-Id: I5da5953b156f00571539cbb4a93045651f34fafa Reviewed-on: https://chromium-review.googlesource.com/1198008 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#589104}
-
Yuki Shiino authored
This reverts commit fcd25fc0. Reason for revert: This patch is suspicious to have broken ios_chrome_bookmarks_egtests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-uirefresh-simulator/2400 Original change's description: > [ios] Bookmarks TableVC uses dynamic row height. > > This CL changes BookmarksTableVC so it uses dynamic row height. > > It also updates some EG tests that started to fail once this change > was made. I suspect this has to do with internal TableView management > of cells when using dynamic height. > > The BottomCell test cell was moved to the penultimate position since > we now snap at the top of the top cells instead > of using the offset value of the TableView. This meant that the top > cell was completely visible when re-creating the cache and the > "Bottom Cell" was partially hidden. > > > > Bug: 869671 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: I3f02b580332161b3bd30b3df1cb7da0c782edabb > Reviewed-on: https://chromium-review.googlesource.com/1205806 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589073} TBR=kkhorimoto@chromium.org,sczs@chromium.org Change-Id: Iced5b16216a06fb10dd43a57d057b26735b60e2f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1207786Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589103}
-
Sam McNally authored
Drive is typically disallowed for directory-chooser dialogs because its workaround for not having real files is only applied to files, but not directories. With DriveFS, this is unnecessary since DriveFS files are real so allow native or drive when native-only is requested when DriveFS is enabled. Change-Id: Ib56e7066cf6798d9d37ac2c2442f8fcf62a92be9 Reviewed-on: https://chromium-review.googlesource.com/1208992Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589102}
-
Xiaocheng Hu authored
This patch allows block-level NGPaintFragment invalidations to be traced, to make relevant layout tests pass. Note: This is a hacky fix only for making tests pass, since devtools invalidation tracking is still an experimental feature. More work will be done if the feature is launched. Bug: 880519 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6bfcd0204a66ea266e2de7a6a421fea29dc70fbf Reviewed-on: https://chromium-review.googlesource.com/1204851Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589101}
-
Noel Gordon authored
Propagate the Table Mode (aka Ash immersive mode) test state into the base class of the Files App test suite. Make Tablet Mode tests enable the Ash Virtual Keyboard flag (as would happen on real chromebook in Table Mode). No change in test behavior: just erecting the scaffold so we can test this aspect of Chrome OS. Bug: 879434, 839243 Change-Id: Idfd4016698214876c991d26d1a3a8fd7dfa84bde Reviewed-on: https://chromium-review.googlesource.com/1207783 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#589100}
-
Zach Stein authored
This will enable us to issue MDNS queries for .local TLDs once HostResolver supports MDNS. Bug: chromium:879746 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4c5a8e01c2337f83a73ac3f6ecc6d3527bdcd875 Reviewed-on: https://chromium-review.googlesource.com/1200404Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Zach Stein <zstein@google.com> Cr-Commit-Position: refs/heads/master@{#589099}
-
Kevin Bailey authored
We were doing some of the work to generate accessibility announcements when "focusing" the tab switch button, but not all those necessary for MacOS. This CL attempts to fill in some of those gaps. Notably, the tab switch button will have to make its own call to the accessibility device on focus, and will have to manufacture a notification when focus returns to the result-view proper. TBR: tapted@chromium.org Bug: 853929 Change-Id: I8d81a8fa6a6528bb12c5e0ba3faff716610410b6 Reviewed-on: https://chromium-review.googlesource.com/1185300 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589098}
-
Asanka Herath authored
Async host resolver currently doesn't resolve CNAMEs. Thus use of the async resolver is not currently compatible with the needs of HttpAuthHandlerNegotiate where correct CNAME lookup is required. Due to an unfortunate oversight, b67c0a8e enabled the async DNS code path by default. This CL addresses both. The updates to the HttpAuthHandlerNegotia tests verify that the SYSTEM source is forced for CNAME lookups. Bug: 872665 Change-Id: I520f88f01084ef8ac12c377a50bba6c7f09ec3c1 Reviewed-on: https://chromium-review.googlesource.com/1208421Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#589097}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie224f3793d25f742c619d8f0deedfe426ac45114 Reviewed-on: https://chromium-review.googlesource.com/1208424Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#589096}
-
Jordy Greenblatt authored
This CL substitutes a dummy URL placeholder for URL that will house the Better Together eve build info page. Note that this is the Unified Setup flow WebUI's analog of https://chromium-review.googlesource.com/c/chromium/src/+/1208350 for the MultiDevice section in the Settings UI. Bug: 870108 Change-Id: Iba609ab6cb3d7d170fa726b136e96b828a6cf514 Reviewed-on: https://chromium-review.googlesource.com/1208897Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#589095}
-
Mathieu Perreault authored
Sending less data in GetUploadDetails, and using PaymentsCustomerData for Payments calls Bug: 878416, 870936 Change-Id: I423f3088f0a7ae331d87390f89aa33a3fe6f3792 Reviewed-on: https://chromium-review.googlesource.com/1207003Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589094}
-
Yuki Yamada authored
This CL removes unused includes regarding to blink::V8AbstractEventHandler and blink::V8EventListenerOrEventHandler. Bug: 872138 Change-Id: I0fec7187851165e36f1bef0508cecced1f1202b7 Reviewed-on: https://chromium-review.googlesource.com/1206751Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#589093}
-
Yuki Yamada authored
This CL renames V8 private property names regarding to V8EventListenerOrEventHandler. This property is used in not only blink::V8EventListenerOrEventHandler but also other classes (blink::V8EventListenerImpl, blink::V8LazyEventListener, blink::V8EventListenerHelper). These classes that is related to event listener is under redesigning as described crbug.com/872138 and it is confusing to use "V8EventListenerOrEventHandler" for the InterfaceName of private properties. Bug: 872138 Change-Id: I2509f60e7b527260b5f51a1e69305a53c3836302 Reviewed-on: https://chromium-review.googlesource.com/1206752Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#589092}
-
Kouhei Ueno authored
This CL adds a UseCounter that counts documents transferred as inner response of a signed exchange. In order to make this info available to Blink, this CL plumbs the |is_signed_exchange_inner_response| flag from content/browser to blink. - network::ResourceResponseInfo - blink::WebURLResponse - blink::ResourceResponse Bug: 863305 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I73e5e8e65c422c0882028d45a4443eb7d0d13d2a Reviewed-on: https://chromium-review.googlesource.com/1205920 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#589091}
-
Sadrul Habib Chowdhury authored
The BeginFrameAck needs to carry the trace-id from the BeginFrameArgs. So update the code to use the ctor for BeginFrameAcks that copies over all the necessary info from the associated BeginFrameArgs. BUG=none Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b864e94cd1b7c6819f2fb1aeb35eef73bd5d253 Reviewed-on: https://chromium-review.googlesource.com/1196845Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#589090}
-
Mohammad Refaat authored
Add AppBarNavigationController.h/m files and ColorThemer sub directory Also added strings needed for AppBarViewController Bug: 880938 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0b93329a2eca0b06b3ae803953b03912d105da57 Reviewed-on: https://chromium-review.googlesource.com/1208440Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#589089}
-
Marijn Kruisselbrink authored
The previous fix still passed nullptr as instance, so wasn't actually installing anything on the instance. This CL fixes that. Also adds SecureContext to the chooseFileSystemEntries method that wanted this to work. Bug: 878566, 878539 Change-Id: I7d7e6a5f62561ca5696b3066b3b7807ed61ff41c Reviewed-on: https://chromium-review.googlesource.com/1208812Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#589088}
-
Zhuoyu Qian authored
Rename blink/common/message_port/, blink/public/common/message_port/ and blink/public/mojom/message_port/ to messaging/. Bug: 868501 Change-Id: I2e657863803bb0a2c80baff970618075397c18b3 Reviewed-on: https://chromium-review.googlesource.com/1203753 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#589087}
-
Matt Giuca authored
This is a reland of cac69564 (r587490, reverted in r588581). The reland fixes a browser test crash on Mac Cocoa (because it's running Views-only code) (https://crbug.com/880363). Added a ScopedMacViewsBrowserMode to force the test to run in Views mode. Original change's description: The title text color and side/bottom frame color now match the GTK theme, rather than the app's theme color (which clashed with the title bar background color, that would use the native color scheme regardless of the app theme color). Adds a browser test for GetFrameColor. Bug: 878636, 880363 Change-Id: I21003e78b4232cc6b8583267b08e2b37a823cfed Reviewed-on: https://chromium-review.googlesource.com/1205972Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#589086}
-
Sungguk Lim authored
Relevant code is moved to extensions/renderer/extension_bindings_system.cc. So use the new location in comment. Bug: None Change-Id: I1de550ca370de9981a80479452d2ee0e3113dbf7 Reviewed-on: https://chromium-review.googlesource.com/1206730 Commit-Queue: Sungguk Lim <limasdf@gmail.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589085}
-
Ryan Cui authored
Pull in entries from the Mash filter file, for tests that are also failing in Mash. Also broadens filter coverage for some test classes using wildcards, to reduce the chance of a failure from a flakiness or new tests being added. Bug: 880584 Change-Id: Ic9d782e24fbd9c136c09b480fce5123190a53b43 Reviewed-on: https://chromium-review.googlesource.com/1208451 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#589084}
-
Tatiana Buldina authored
Change-Id: I21cad29f968ad4a01ee1edf5e16867658eecc9bb Reviewed-on: https://chromium-review.googlesource.com/1208723Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589083}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fccfd62a. With Chromium commits locally applied on WPT: f22f8191 "Throw errors for invalid rolloffFactor and coneOuterGain" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24141 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ib811e6d522d36032724a7e6f1bcca120b19f7b75 Reviewed-on: https://chromium-review.googlesource.com/1208912 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589082}
-