- 05 Oct, 2017 40 commits
-
-
Ian Kilpatrick authored
... in favour of IntrinsicBlockSize(). We weren't using inline overflow size, and "overflow" was incorrect for how it was being used. This also moves it to the layout result. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idd6c63dd5e0712c69f81bed21a03ad2be4c9331a Reviewed-on: https://chromium-review.googlesource.com/701357 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506799}
-
Matt Menke authored
This reverts commit 336a0871. Reason for revert: This is breaking Cronet iOS tests. Sample trace: #0 0x0000000102c2e6b0 in net::RunCookieCallback(base::OnceCallback<void ()>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:25 #1 0x0000000102c2eb20 in net::NSHTTPSystemCookieStore::GetCookiesForURLAsync(GURL const&, base::OnceCallback<void (NSArray<NSHTTPCookie*>*)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:45 #2 0x0000000102c0f5b0 in net::CookieStoreIOS::GetCookieListWithOptionsAsync(GURL const&, net::CookieOptions const&, base::OnceCallback<void (std::__1::vector<net::CanonicalCookie, std::__1::allocator<net::CanonicalCookie> > const&)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/cookie_store_ios.mm:459 #3 0x000000010380caec in net::URLRequestHttpJob::AddCookieHeaderAndStart() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:597 #4 0x000000010380c598 in net::URLRequestHttpJob::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:321 #5 0x00000001037e87d8 in net::URLRequest::StartJob(net::URLRequestJob*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:668 #6 0x00000001037e7ec4 in net::URLRequest::BeforeRequestComplete(int) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:613 #7 0x00000001037e7738 in net::URLRequest::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:538 #8 0x0000000102c3a620 in net::HttpProtocolHandlerCore::Start(id<CRNNetworkClientProtocol>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/crn_http_protocol_handler.mm:708 #9 0x0000000102c41130 in void base::internal::FunctorTraits<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), void>::Invoke<scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:194 #10 0x0000000102c41034 in void base::internal::InvokeHelper<false, void>::MakeItSo<void (net::HttpProtocolHandlerCore::* const&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (net::HttpProtocolHandlerCore::* const&&&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:277 #11 0x0000000102c40fc0 in void base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::RunImpl<void const(&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&, 0ul, 1ul>(void const(&&&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&&&, void const(id<CRNNetworkClientProtocol>)::integer_sequence<unsigned long, 0ul, 1ul>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:349 #12 0x0000000102c40ebc in base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::Run(base::internal::BindStateBase*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:331 Original change's description: > [Reland] Convert SystemCookieStore to Async. > > * Converts SystemCookieStore to Async > * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous > functions. > * Move creation time management to systemCookieStore. > * Update cookie_store_ios_presistent_unittest & > cookie_store_ios_unittests to account for SystemCookieStore changes > * (As CookieStoreIOS is using systemCookieStore internally). > > Another CL is in progress to add WKSystemCookieStore & unit_tests for > systemCookieStore (to handle async methods) with template for both > NSHTTP & WK systemCookieStore. > > Bug: 759229, 759227, 767948 > Change-Id: If5e1fdb8d6424085d5212a3ea867968642db554f > Reviewed-on: https://chromium-review.googlesource.com/700818 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506549} TBR=eugenebut@chromium.org,mrefaat@chromium.org Change-Id: I7c653c57501745359ecb35ff422996545b7587f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759229, 759227, 767948 Reviewed-on: https://chromium-review.googlesource.com/702974Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506798}
-
Yuki Shiino authored
Makes Supplementable/Supplement support TraceWrapperBase/ TraceWrapperMember appropriately. Supplementable<T> now holds HeapHashMap of TraceWrapperMember instead of one of Member, so that (subclasses of) Supplement<T> will be wrapper-traced. Bug: 569301,658073 Change-Id: I229eaca761d5d012b58b0aa745fb3e10c45224f6 Reviewed-on: https://chromium-review.googlesource.com/687375 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#506797}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/f8ebe0eae6cb..09fca0a3600a $ git log f8ebe0eae..09fca0a36 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 johnchen Remove '.' from media metric histogram name Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I72e7f49291108626f8a35eaee9ad5a2eedff1c3a Reviewed-on: https://chromium-review.googlesource.com/702680 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506796}
-
Jan Krcal authored
This CL uses the existing status AVAILABLE_LOADING to signal to the UI that the currently available suggestions are stale and that new ones are being loaded. When the fetch is over (or when it fails or when a timeout fires), the category status is switched back to AVAILABLE. Bug: 762932 Change-Id: If34d739ab316adec95f8e4e8f4b5319479fdacd5 Reviewed-on: https://chromium-review.googlesource.com/663729 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#506795}
-
Avi Drissman authored
The SigninViewControllerDelegate, as a modal dialog manager delegate, will outlive the manager. If so, don't call through to a non-existent manager. BUG=771872,771142 TBR=wittman@chromium.org Change-Id: Ia020c026094c3092e4946155d3437c2855951595 Reviewed-on: https://chromium-review.googlesource.com/702515Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#506794}
-
Hans Wennborg authored
We don't build them on Mac. Bug: none Change-Id: I8a79ef3ed837c7d1d81dc157bd4b95939f67c9d6 Reviewed-on: https://chromium-review.googlesource.com/702634Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#506793}
-
Khushal authored
For PaintShader and PaintImage, we lazily create the internally cached SkShader and SkImage. This can cause this access to be racy when later done on the raster worker threads during playback. Ensure that these objects are created during Paint object construction. R=enne@chromium.org, vmpstr@chromium.org Bug: 771156 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8538442e0459e1762a81d5fb150301621360d850 Reviewed-on: https://chromium-review.googlesource.com/701974Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506792}
-
Ben Chan authored
shill's Device.ProposeScan DBus method has been deprecated and superseded by the Device.RequestScan DBus method. BUG=763198 TEST=chromeos_unittests Change-Id: I9ae4a115ee2e0f14a10f06a5bdbe4e48b21bba83 Reviewed-on: https://chromium-review.googlesource.com/701622Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506791}
-
Khushal authored
Since we strip out strings on official release builds, don't use "Check Failed" for EXPECT_DEATH asserts. R=thakis@chromium.org Bug: 771998 Change-Id: Id9e65c699fdae2fab8354ea64cae82b5d0691109 Reviewed-on: https://chromium-review.googlesource.com/702647Reviewed-by:
-
Alex Clarke authored
This helps controls scripts get a better idea of the current virtual time. Bug: Change-Id: I39433f2790cdc51c14a3c02736c9320b0bce7c0a Reviewed-on: https://chromium-review.googlesource.com/702374Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506789}
-
Alex Clarke authored
This will allow devtools protocol users to distinguish between forms that use GET and POST. Bug: Change-Id: Id27f36cb675aaea02434a76eae492faac320f01e Reviewed-on: https://chromium-review.googlesource.com/700518Reviewed-by:
-
Shane Hansen authored
Headless users may want to decode captured traffic. Bug: 767532 Change-Id: Ied7fa3ec4fb771f845d9c38eb2a476f2e5a3b018 Reviewed-on: https://chromium-review.googlesource.com/677569 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
-
David 'Digit' Turner authored
For some reason, the ThreadSafeRefCounted destructor was not inlined in release builds. The end result was a completely empty function, that was called in many many places. This tells the compiler that, for release build, the destructor is inlined and doesn't do anything. This tiny patch reduces the final (compressed) size of the following Android APKs: - Chrome.apk -60 KiB (from 45 MiB) - Monochrone.apk -152 KiB (from 69 MiB) Note that the destructor is kept non-inlined for debug builds, since it must perform relevant debug checks. R=tzik@chromium.org,thakis@chromium.org,dcheng@chromium.org,agrieves@chromium.org BUG=NONE Change-Id: I45c9e87851a3c71861034bde8906b59d1033c455 Reviewed-on: https://chromium-review.googlesource.com/702301Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#506786}
-
Guido Urdaneta authored
After a successful StopForRestart(), if Restart() fails, the source should return to the previous state, which is STOPPED_FOR_RESTART, instead of being stopped for good. Bug: 763319 Change-Id: I907c320d0d4664d3b35fe89d141eb936381e78c7 Reviewed-on: https://chromium-review.googlesource.com/695306 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506785}
-
Ryan Hansberry authored
Adds metrics around advertisement registration/unregistration, scanning, creating a GATT connection, and the StartNotify operation. These metrics are being created in addition to existing similar Bluetooth metrics in order to gauge Tether's stability as a client versus Bluetooth as a whole. Bug: Change-Id: Idf719394e4193591230cc765d48a8ceb0a0f4b88 Reviewed-on: https://chromium-review.googlesource.com/701373Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#506784}
-
James Robinson authored
This provides a toolchain target for aarch64 Fuchsia and fixes a linux assumption in the generic compiler setup. The Fuchsia SDK provides a sysroot for aarch64 and the clang toolchain used by Chromium understands the aarch64-fuchsia target already. Bug: 772031 Change-Id: I6537b53d598afd2a0185870495261be8bc395c87 Reviewed-on: https://chromium-review.googlesource.com/701932 Commit-Queue: James Robinson <jamesr@chromium.org> Reviewed-by:
-
MinChen authored
Bug: 763181 Change-Id: I869ee1e72bddad2bf6b5aaf11c5480ae21a28da3 Reviewed-on: https://chromium-review.googlesource.com/701928Reviewed-by:
-
Robert Ma authored
Most notably we would like to have this new lint for Blink internal APIs in external/wpt: https://github.com/w3c/web-platform-tests/pull/7544 Bug: 749879 Change-Id: Ia1b2a1832b53e98d0c3204948a003a88d24dfff0 Reviewed-on: https://chromium-review.googlesource.com/702534 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506781}
-
Gary Klassen authored
This change routes HitTestRegionList objects received by CompositorFrameSinkSupport to the HitTestManager. The HitTestAggregator will query the HitTestManager for the active HitTestRegionLists when aggregating the data. HitTestManager also manages the lifetime of HitTestRegionList objects by deleting old objects when surfaces are discarded and deleting objects that correspond to older frames when a new surface is activated. This change also modifies HitTestAggregator memory management so that new memory is allocated as needed while aggregating HitTestRegionList data. Bug: 732399 Change-Id: Iaedec31a34f04446a539acd10d77c6fe18034d44 Reviewed-on: https://chromium-review.googlesource.com/650220 Commit-Queue: Gary Klassen <gklassen@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#506780}
-
Yoland Yan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Change-Id: I6a1857ab3322176c03256fba003f5a1677b5899e Reviewed-on: https://chromium-review.googlesource.com/701639Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506779}
-
Corentin Wallez authored
This reverts commit 73c5accd. Reason for revert: Breaks the Win 10 GPU FYI bots that can't find swarming bots with the required configuration anymore. Original change's description: > Specify Win/NVIDIA GPU bots driver version. > > Explicitly specifying the GPU driver version in the config will allow > us to safely test new driver versions. Because the tests will pick > machines of a particular driver version specified in the json, we > can ask infra to upgrade a few machines, then run a try job using the > new driver version. > > This modifies the generate script to allow use of wildcards in test > dimension set specifiers. Wildcards are only supported as the last > character in the dimension. This allows us to more easily match > ranges of driver versions. > > The current NVIDIA driver version used by the bots is 372.54. > > R=kbr@chromium.org > BUG=771654 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I5875b9e91fbe8d2d626a8af20005161bc3f082bb > Reviewed-on: https://chromium-review.googlesource.com/699761 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506600} TBR=jmadill@chromium.org,kbr@chromium.org Change-Id: Id8c6f60074994e7a7ae9a62a9e0f6658ba43fc6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771654 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/702734Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#506778}
-
Jinsong Fan authored
BUG=none TEST=none Change-Id: I721fd9c401a987611773025349bea391928ca810 Reviewed-on: https://chromium-review.googlesource.com/693821 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#506777}
-
Steven Bennetts authored
Instead call SessionController::RequestSignOut which does the same thing. Bug: 758365 Change-Id: I138b58a05a10a4cdc748896746a5acf14f9bb980 Reviewed-on: https://chromium-review.googlesource.com/699430 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506776}
-
John Chen authored
The userAgent strings associated with some emulated mobile devices contain substring "%s", which should be replaced with Chrome version. Bug: chromedriver:1883 Change-Id: I475a9a20e72008956bc201b3677cb60f6632e57c Reviewed-on: https://chromium-review.googlesource.com/689966 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#506775}
-
David Roger authored
Bug: 761362 Change-Id: Ib0cbc54e99bcde0be88317a87eeb903136128978 Reviewed-on: https://chromium-review.googlesource.com/691662Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#506774}
-
Peiyong Lin authored
Previously we have a dedicated detector to detect network idleness signal and send it to services/resource_coordinator, however, it uses a timer, thus it can't handle cases like, if a task is being processed for a long time, network requests won't be able to be fired, thus when the task is finished processing the network idleness signal will be fired before network requests are fired, which results in inaccurate network idleness signal. So, in this patch, we excluded task processing time in network idle time accumulation, and merged Performance Monitor life cycle report into the current detector. Minor: renamed kNetworkIdle to kNetworkAlmostIdle, renamed class/file name to IdlenessDetector. BUG=730098, 749789 Change-Id: Ied003129cd5ddf7c1ebb93019723e11e9a31be04 Reviewed-on: https://chromium-review.googlesource.com/664094 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506773}
-
Peiyong Lin authored
Adds UKM to report the duration in millisecond from when a tab is backgrounded to it is closed or foregrounded. BUG=753486 Change-Id: I995b4002c80c1eb91f3ed36556e23c5b06183edf Reviewed-on: https://chromium-review.googlesource.com/654144 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
BUG=681511 R=mkwst@chromium.org Change-Id: I351b28a09bfe09e5045ada5e228f8f0958a9eccb Reviewed-on: https://chromium-review.googlesource.com/700264 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#506771}
-
Sylvain Defresne authored
Chrome on iOS only uses a subset of skia (see ios/chrome/DEPS). That subset does not include fonts rendering, so the dependency on //third_party/freetype and //third_party/harfbuzz can be removed. Bug: none Change-Id: Ie3adf4abab442428986eafe074da0447b169db4e Reviewed-on: https://chromium-review.googlesource.com/697586Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
-
Boris Sazonov authored
This CL adds ThreadUtils.runOnUiThread around call to AccountManagerFacade.getNewAuthToken as this method should be invoked on UI thread only. Bug: 759023 Change-Id: I67c05084dca091ab1909549556211f84b8dec9c6 Reviewed-on: https://chromium-review.googlesource.com/702303Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506769}
-
Jacob Dufault authored
This adds support for parsing APNG images by hooking into the data_decoder service. webkit::WebImage API is extended to support fetching the relevant animation data from blink's PNG decoder. Bug: 750064, 719015 Change-Id: I7fb38643dce5d6e16eaaee2b6f74253ba70af20a Reviewed-on: https://chromium-review.googlesource.com/679459 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506768}
-
Michael Thiessen authored
The insecure content warning WebVR overlay is (virtually) unused, and causing maintenance overhead. It will never ship, so we should just remove it. Bug: 771223 Change-Id: I852e5bed6954606b894955fce71942b5e19dc3f0 Reviewed-on: https://chromium-review.googlesource.com/698276 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#506767}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/3a9305383169..8d64ee779599 $ git log 3a9305383..8d64ee779 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 bungeman Update SkBufferHead fRefCnt to std::atomic. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I053b4db1cabb725cbb6ae07441270e7c53ec1d96 Reviewed-on: https://chromium-review.googlesource.com/701672Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506766}
-
Hidehiko Abe authored
BUG=None TEST=Ran cpplint.py to all files under the directories. Change-Id: I91c5556b56c53ae4c66f6e288d3b6c37dea017ed Reviewed-on: https://chromium-review.googlesource.com/702080Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506765}
-
David Trainor authored
Reworks the DownloadService's code to interpret DownloadItem states better. We have some unexpected states/transitions from DownloadItem to DriverEntry that are causing our resumption/fail logic to get confused. This brings over the concept if "done" and "can_resume" into the state rectification logic. TBR=sky@chromium.org Bug: 769426 Change-Id: Iad7bc612a68421471ff4204e6a94d52eaea1b825 Reviewed-on: https://chromium-review.googlesource.com/699562 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506764}
-
Vladislav Belov authored
There was a duplication of the source type checking. It may lead errors when a type set will be changed for a language. R=dpranke@chromium.org Bug: None Change-Id: Ieab8885899446e625cfe20c1650418a085b937ee Reviewed-on: https://chromium-review.googlesource.com/702414Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506763}
-
Patrick Monette authored
This is to make sure future readers of that code don't make the same mistake that we've done in the past. Bug: 757398 Change-Id: Ie249e7b3ef22c8c0f8e69995a6adef463677e745 Reviewed-on: https://chromium-review.googlesource.com/701597Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#506762}
-
Joshua Pawlicki authored
Bug: 771987 Change-Id: If0293e9c73d575719544fbbdcb1f40fbf6df4962 Reviewed-on: https://chromium-review.googlesource.com/702057Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#506761}
-
Yoland Yan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Change-Id: I06ab6c5d14bdc382b294482d6a7b3cec497117e0 Reviewed-on: https://chromium-review.googlesource.com/701363Reviewed-by:
-
