GitLab

Increase the maximum limit of CCT bottom bar height to display larger
view.

Bug: None
Change-Id: I0b0a8831cbd39f299e0dafd8e0eb314e8fe9b398
Reviewed-on: https://chromium-review.googlesource.com/702687Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Lei Tian <ltian@google.com>
Cr-Commit-Position: refs/heads/master@{#506816}

This CL also #defines DeleteFile as DeleteFileW on Windows for all
compilation units that depend on leveldb. This definition impacts
leveldb's API (leveldb::Env::DeleteFile), and is in effect in most of
Chromium, because it is introduced by <windows.h>. After this CL, the
definition is guaranteed to be in effect everywhere, so we don't have to
reason about #include side-effects.

https://chromium.googlesource.com/external/leveldb.git/+log/09a3c8e74175..4a7e7f50dcf6

$ git log 09a3c8e74..4a7e7f50d --date=short --no-merges --format='%ad %ae %s'
2017-10-04 cmumford Add LEVELDB_EXPORT macro to export public symbols.
2017-10-04 costan leveldb: Include <algorithm> in util/env_test.cc.
2017-10-03 costan Fix FD leak in POSIX Env.
2017-10-03 costan leveldb: Add tests for CL 170769101.
2017-10-03 costan Remove handling for unused LRUHandle representation special case.
2017-10-02 sanjay Fix file writing bug in CL 170738066.
2017-10-02 cmumford Fix use of uninitialized value in LRUHandle.
2017-10-02 sanjay Fix issue 474: a race between the f*_unlocked() STDIO calls in env_posix.cc and concurrent application calls to fflush(NULL).
2017-09-26 costan Use portable CRC32C from google/crc32c.
2017-09-01 costan Remove confusing and unnecessary if.
2017-09-01 costan Simplify Table::Open() flow and remove a delete call.


Created with:
  roll-dep src/third_party/leveldatabase/src

Bug: 
Change-Id: I0096e6b863616d14c20994d6cb9696ebc263f138
Reviewed-on: https://chromium-review.googlesource.com/699018Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506815}

Bug: 612962
Change-Id: Idd15d1639defb4bd3cf56795b57b9f3a4f55379d
Reviewed-on: https://chromium-review.googlesource.com/702676Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506814}

Simplify moving sandbox_mac.mm itself out of content/, as it
no longer includes content headers.

Change-Id: I68e746fb4c003e6a4bc60ee44057b8d1ba0554d1
Reviewed-on: https://chromium-review.googlesource.com/701359Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506813}

For more on JUnit4 migration, please check
src/testing/android/docs/junit4.md

Bug: 640116
Change-Id: I0270db03b98377e50bcbd45ccbc972fe28e4c918
Reviewed-on: https://chromium-review.googlesource.com/699794
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506812}

When force-signin is enabled, profile should be able to removed even all profiles are locked
so that user is able to remove any locked profile that is not able be unlocked due to policy update.

Bug: 
Change-Id: I8c0433eaee76566f76d9a12c5a6f6883dcb94b20
Reviewed-on: https://chromium-review.googlesource.com/701397Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506811}

This reverts commit 5638e72c.

Reason for revert: compile error on bots ...


Original change's description:
> Send Emulation.virtualTimeAdvanced when virtual time advances
> 
> This helps controls scripts get a better idea of the current virtual
> time.
> 
> Bug: 
> Change-Id: I39433f2790cdc51c14a3c02736c9320b0bce7c0a
> Reviewed-on: https://chromium-review.googlesource.com/702374
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506789}

TBR=dgozman@chromium.org,skyostil@chromium.org,alexclarke@chromium.org

Change-Id: Iffebedd5d1c7f303d2e02f9f32e06d750eee29eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/702975Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506810}

This reverts commit 5638e72c.

Reason for revert: Breaking compile on Windows: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/113824

Change-Id: Ia0ca3f2bf43980eb13418c7c14deb16119d88efc

TBR=dgozman@chromium.org
TBR=skyostil@chromium.org

Change-Id: Ia0ca3f2bf43980eb13418c7c14deb16119d88efc
Reviewed-on: https://chromium-review.googlesource.com/702690Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506809}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/58c1372e..4754eed2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I6f673abb4422cbb6d4ee4dcd1b772e4e43397591
Reviewed-on: https://chromium-review.googlesource.com/702516Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506808}

This reverts commit 9f6b2091.

Reason for revert: The timing of the swap_chain_ destruction appears to be wrong. Reverting this until I can sort it out.

Original change's description:
> [vr] Enable 2x MSAA
> 
> This increases the number of samples used in the primary framebuffer.
> 
> Bug: 752085
> Change-Id: I869ae41943db925aff845b3d1da15e8130b14e45
> Reviewed-on: https://chromium-review.googlesource.com/680374
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505811}

TBR=vollick@chromium.org,mthiesse@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 752085, 771663
Change-Id: I6150abf5840fa81cc9ce135c0746d3fd4f8bca7a
Reviewed-on: https://chromium-review.googlesource.com/702517
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506807}

The recent change for using ColorUtils.isUsingDefaultToolbarColor to
decide emphazing htts scheme makes Chrome Home does not emphasize https
properly. This is because ColorUtils.isUsingDefaultToolbarColor does not
check whether BottomSheet is null. For Chrome Home, BottomSheet is not
null so the toolbar should not be populated by brand color and should
emphasize the https scheme.

To fix the problem, revert back to use ToolbarModel.isUsingBrandColor.
And also change CCT to use the same method. However, since
mIsUsingBrandColor also depends of whether there is a tab, make setTab
in ToolbarModelImpl also update mIsUsingBrandColor. This is needed
because CCT setTab after setPrimaryColor.

BUG=771559

Change-Id: Id94c811f2992ecc73b36c08d2537c63949131f2e
Reviewed-on: https://chromium-review.googlesource.com/701455Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Lei Tian <ltian@google.com>
Cr-Commit-Position: refs/heads/master@{#506806}

Changes in how selection and the action mode are triggered seem to
have deflaked these tests. Each of the re-enabled tests passed
60 times on a Nexus 6P running Android O and 60 times on a Nexus 4
running Android J.

Bug: 592428

Change-Id: If774d474df13e9e20e3d714f06358811a941d075
Reviewed-on: https://chromium-review.googlesource.com/701278Reviewed-by: Alexandre Elias <aelias@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506805}

This is a follow-up CL to: https://crrev.com/c/690314

Currently, gpuBenchmarking takes coordinates in the root-frame
coordinate space. Since input events are in the (visual) viewport space,
gpuBenchmarking was trying to convert them in the presence of pinch-zoom
by applying the pageScaleFactor. This is incorrect, as the
transformation must also include the visual viewport offset. However,
it makes a lot more sense for gpuBenchmarking to take coordinates in the
viewport space to begin with, leaving the conversion to the caller.

The above CL converts telemetry to pass these coordinates in viewport
space. It's gated on the presence of the
`gesturesExpectedInViewportCoordinates` attribute so that we can make
the transition without breaking the waterfall.

Bug: 610021
Change-Id: Ic6a4229e230b77427e6f1aa7ef71933c21d93106
Reviewed-on: https://chromium-review.googlesource.com/668376
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506804}

Another test is flaky on telemetry_unittests, skipping it in config.

TBR=sky@chromium.org

Bug: 758065
Change-Id: I49849ca1b271fcceb1976f86f8ed6225a22cc302
Reviewed-on: https://chromium-review.googlesource.com/700797Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506803}

Remove HpackStringDecoder:StartOnly(), StartAndDecoderLength(), and
StartSpecialCaseShort().

This CL lands internal change 170871163 by bnc.

BUG=488484

Change-Id: I5ea3d3650980816d3bd0729a277d5786b5e5e974
Reviewed-on: https://chromium-review.googlesource.com/688714Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506802}

This patch removes a random sources block that was ignored
in normal builds but triggered an assert in jumbo builds.

This also changes the OWNERS file according to presubmit instructions.

Bug: 771153
Change-Id: Ic32f92db25b1b4bd6e2087b95785b4934a94e120
Reviewed-on: https://chromium-review.googlesource.com/702258Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#506801}

This change is needed for the Harmony treeview, but it also looks better in the
non-Harmony treeview, so it's unconditional in this CL.

This change also removes the special background/foreground colors from the
example treeview. While those were useful as a demonstration, they are quite
garish and distracting when screenshotting the treeview :).

Bug: 610428
Change-Id: Icf14b2e1d5b8c20a6d72550cfe57436b3f31cce4
Reviewed-on: https://chromium-review.googlesource.com/695563Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506800}

... in favour of IntrinsicBlockSize(). We weren't using inline overflow
size, and "overflow" was incorrect for how it was being used.

This also moves it to the layout result.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Idd6c63dd5e0712c69f81bed21a03ad2be4c9331a
Reviewed-on: https://chromium-review.googlesource.com/701357
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506799}

This reverts commit 336a0871.

Reason for revert: This is breaking Cronet iOS tests.

Sample trace:

#0	0x0000000102c2e6b0 in net::RunCookieCallback(base::OnceCallback<void ()>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:25
#1	0x0000000102c2eb20 in net::NSHTTPSystemCookieStore::GetCookiesForURLAsync(GURL const&, base::OnceCallback<void (NSArray<NSHTTPCookie*>*)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:45
#2	0x0000000102c0f5b0 in net::CookieStoreIOS::GetCookieListWithOptionsAsync(GURL const&, net::CookieOptions const&, base::OnceCallback<void (std::__1::vector<net::CanonicalCookie, std::__1::allocator<net::CanonicalCookie> > const&)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/cookie_store_ios.mm:459
#3	0x000000010380caec in net::URLRequestHttpJob::AddCookieHeaderAndStart() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:597
#4	0x000000010380c598 in net::URLRequestHttpJob::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:321
#5	0x00000001037e87d8 in net::URLRequest::StartJob(net::URLRequestJob*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:668
#6	0x00000001037e7ec4 in net::URLRequest::BeforeRequestComplete(int) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:613
#7	0x00000001037e7738 in net::URLRequest::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:538
#8	0x0000000102c3a620 in net::HttpProtocolHandlerCore::Start(id<CRNNetworkClientProtocol>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/crn_http_protocol_handler.mm:708
#9	0x0000000102c41130 in void base::internal::FunctorTraits<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), void>::Invoke<scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:194
#10	0x0000000102c41034 in void base::internal::InvokeHelper<false, void>::MakeItSo<void (net::HttpProtocolHandlerCore::* const&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (net::HttpProtocolHandlerCore::* const&&&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:277
#11	0x0000000102c40fc0 in void base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::RunImpl<void  const(&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&, 0ul, 1ul>(void  const(&&&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&&&, void  const(id<CRNNetworkClientProtocol>)::integer_sequence<unsigned long, 0ul, 1ul>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:349
#12	0x0000000102c40ebc in base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::Run(base::internal::BindStateBase*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:331

Original change's description:
> [Reland] Convert SystemCookieStore to Async.
> 
> * Converts SystemCookieStore to Async
> * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous
> functions.
> * Move creation time management to systemCookieStore.
> * Update cookie_store_ios_presistent_unittest &
> cookie_store_ios_unittests to account for SystemCookieStore changes
> * (As CookieStoreIOS is using systemCookieStore internally).
> 
> Another CL is in progress to add WKSystemCookieStore & unit_tests for
> systemCookieStore (to handle async methods) with template for both
> NSHTTP & WK systemCookieStore.
> 
> Bug: 759229, 759227, 767948
> Change-Id: If5e1fdb8d6424085d5212a3ea867968642db554f
> Reviewed-on: https://chromium-review.googlesource.com/700818
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506549}

TBR=eugenebut@chromium.org,mrefaat@chromium.org

Change-Id: I7c653c57501745359ecb35ff422996545b7587f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 759229, 759227, 767948
Reviewed-on: https://chromium-review.googlesource.com/702974Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506798}

Makes Supplementable/Supplement support TraceWrapperBase/
TraceWrapperMember appropriately.

Supplementable<T> now holds HeapHashMap of TraceWrapperMember instead
of one of Member, so that (subclasses of) Supplement<T> will be
wrapper-traced.

Bug: 569301,658073
Change-Id: I229eaca761d5d012b58b0aa745fb3e10c45224f6
Reviewed-on: https://chromium-review.googlesource.com/687375
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506797}

https://chromium.googlesource.com/catapult.git/+log/f8ebe0eae6cb..09fca0a3600a

$ git log f8ebe0eae..09fca0a36 --date=short --no-merges --format='%ad %ae %s'
2017-10-04 johnchen Remove '.' from media metric histogram name

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I72e7f49291108626f8a35eaee9ad5a2eedff1c3a
Reviewed-on: https://chromium-review.googlesource.com/702680
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506796}

This CL uses the existing status AVAILABLE_LOADING to signal to the UI
that the currently available suggestions are stale and that new ones are
being loaded. When the fetch is over (or when it fails or when a timeout
fires), the category status is switched back to AVAILABLE.

Bug: 762932
Change-Id: If34d739ab316adec95f8e4e8f4b5319479fdacd5
Reviewed-on: https://chromium-review.googlesource.com/663729
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506795}

The SigninViewControllerDelegate, as a modal dialog manager
delegate, will outlive the manager. If so, don't call through
to a non-existent manager.

BUG=771872,771142
TBR=wittman@chromium.org

Change-Id: Ia020c026094c3092e4946155d3437c2855951595
Reviewed-on: https://chromium-review.googlesource.com/702515Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506794}

We don't build them on Mac.

Bug: none
Change-Id: I8a79ef3ed837c7d1d81dc157bd4b95939f67c9d6
Reviewed-on: https://chromium-review.googlesource.com/702634Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506793}

For PaintShader and PaintImage, we lazily create the internally cached
SkShader and SkImage. This can cause this access to be racy when later
done on the raster worker threads during playback. Ensure that these
objects are created during Paint object construction.

R=enne@chromium.org, vmpstr@chromium.org

Bug: 771156
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8538442e0459e1762a81d5fb150301621360d850
Reviewed-on: https://chromium-review.googlesource.com/701974Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506792}

shill's Device.ProposeScan DBus method has been deprecated and
superseded by the Device.RequestScan DBus method.

BUG=763198
TEST=chromeos_unittests

Change-Id: I9ae4a115ee2e0f14a10f06a5bdbe4e48b21bba83
Reviewed-on: https://chromium-review.googlesource.com/701622Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506791}

Since we strip out strings on official release builds, don't use
"Check Failed" for EXPECT_DEATH asserts.

R=thakis@chromium.org

Bug: 771998
Change-Id: Id9e65c699fdae2fab8354ea64cae82b5d0691109
Reviewed-on: https://chromium-review.googlesource.com/702647Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506790}

This helps controls scripts get a better idea of the current virtual
time.

Bug: 
Change-Id: I39433f2790cdc51c14a3c02736c9320b0bce7c0a
Reviewed-on: https://chromium-review.googlesource.com/702374Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506789}

This will allow devtools protocol users to distinguish between forms that
use GET and POST.

Bug: 
Change-Id: Id27f36cb675aaea02434a76eae492faac320f01e
Reviewed-on: https://chromium-review.googlesource.com/700518Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506788}

Headless users may want to decode captured traffic.

Bug: 767532
Change-Id: Ied7fa3ec4fb771f845d9c38eb2a476f2e5a3b018
Reviewed-on: https://chromium-review.googlesource.com/677569
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506787}

For some reason, the ThreadSafeRefCounted destructor was not
inlined in release builds. The end result was a completely empty
function, that was called in many many places.

This tells the compiler that, for release build, the destructor
is inlined and doesn't do anything. This tiny patch reduces the
final (compressed) size of the following Android APKs:

  - Chrome.apk       -60 KiB  (from 45 MiB)
  - Monochrone.apk  -152 KiB  (from 69 MiB)

Note that the destructor is kept non-inlined for debug builds,
since it must perform relevant debug checks.

R=tzik@chromium.org,thakis@chromium.org,dcheng@chromium.org,agrieves@chromium.org
BUG=NONE

Change-Id: I45c9e87851a3c71861034bde8906b59d1033c455
Reviewed-on: https://chromium-review.googlesource.com/702301Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506786}

After a successful StopForRestart(), if Restart() fails, the source
should return to the previous state, which is STOPPED_FOR_RESTART,
instead of being stopped for good.

Bug: 763319
Change-Id: I907c320d0d4664d3b35fe89d141eb936381e78c7
Reviewed-on: https://chromium-review.googlesource.com/695306
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506785}

Adds metrics around advertisement registration/unregistration,
scanning, creating a GATT connection, and the StartNotify operation.

These metrics are being created in addition to existing similar
Bluetooth metrics in order to gauge Tether's stability as a client
versus Bluetooth as a whole.

Bug: 
Change-Id: Idf719394e4193591230cc765d48a8ceb0a0f4b88
Reviewed-on: https://chromium-review.googlesource.com/701373Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506784}

This provides a toolchain target for aarch64 Fuchsia and fixes a linux
assumption in the generic compiler setup. The Fuchsia SDK provides a
sysroot for aarch64 and the clang toolchain used by Chromium
understands the aarch64-fuchsia target already.

Bug: 772031
Change-Id: I6537b53d598afd2a0185870495261be8bc395c87
Reviewed-on: https://chromium-review.googlesource.com/701932
Commit-Queue: James Robinson <jamesr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506783}

Bug: 763181
Change-Id: I869ee1e72bddad2bf6b5aaf11c5480ae21a28da3
Reviewed-on: https://chromium-review.googlesource.com/701928Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506782}

Most notably we would like to have this new lint for Blink internal APIs
in external/wpt: https://github.com/w3c/web-platform-tests/pull/7544

Bug: 749879
Change-Id: Ia1b2a1832b53e98d0c3204948a003a88d24dfff0
Reviewed-on: https://chromium-review.googlesource.com/702534
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506781}

This change routes HitTestRegionList objects received by
CompositorFrameSinkSupport to the HitTestManager.

The HitTestAggregator will query the HitTestManager for the
active HitTestRegionLists when aggregating the data.

HitTestManager also manages the lifetime of HitTestRegionList
objects by deleting old objects when surfaces are discarded
and deleting objects that correspond to older frames when
a new surface is activated.

This change also modifies HitTestAggregator memory management
so that new memory is allocated as needed while aggregating
HitTestRegionList data.

Bug: 732399
Change-Id: Iaedec31a34f04446a539acd10d77c6fe18034d44
Reviewed-on: https://chromium-review.googlesource.com/650220
Commit-Queue: Gary Klassen <gklassen@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506780}

For more on JUnit4 migration, please check
src/testing/android/docs/junit4.md

Bug: 640116
Change-Id: I6a1857ab3322176c03256fba003f5a1677b5899e
Reviewed-on: https://chromium-review.googlesource.com/701639Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506779}

This reverts commit 73c5accd.

Reason for revert: Breaks the Win 10 GPU FYI bots that can't find swarming bots with the required configuration anymore.

Original change's description:
> Specify Win/NVIDIA GPU bots driver version.
> 
> Explicitly specifying the GPU driver version in the config will allow
> us to safely test new driver versions. Because the tests will pick
> machines of a particular driver version specified in the json, we
> can ask infra to upgrade a few machines, then run a try job using the
> new driver version.
> 
> This modifies the generate script to allow use of wildcards in test
> dimension set specifiers. Wildcards are only supported as the last
> character in the dimension. This allows us to more easily match
> ranges of driver versions.
> 
> The current NVIDIA driver version used by the bots is 372.54.
> 
> R=​kbr@chromium.org
> BUG=771654
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I5875b9e91fbe8d2d626a8af20005161bc3f082bb
> Reviewed-on: https://chromium-review.googlesource.com/699761
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506600}

TBR=jmadill@chromium.org,kbr@chromium.org

Change-Id: Id8c6f60074994e7a7ae9a62a9e0f6658ba43fc6d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771654
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/702734Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506778}

BUG=none
TEST=none

Change-Id: I721fd9c401a987611773025349bea391928ca810
Reviewed-on: https://chromium-review.googlesource.com/693821
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506777}