GitLab

This is a roll-back to 6.1.534. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org

Change-Id: I0085971a1582686954bb23521db7e13647757d3b
Reviewed-on: https://chromium-review.googlesource.com/579370Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488224}

ContextualJsonRequest can build and send a Json request to fetch
contextual suggestions.
Contextual suggestions are suggestions based on a given URL.
A unit test verifies that a valid Json request is built.

Bug: n/a
Change-Id: Ic19def03c4080b42117624e9452376abbb68ffa5
Reviewed-on: https://chromium-review.googlesource.com/577540
Commit-Queue: Andre Gaschler <gaschler@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488223}

Bug: 739832
Change-Id: I374ef05f40aea76e5c33cf73395100e04f1ee6a2
Reviewed-on: https://chromium-review.googlesource.com/576429Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488222}

-- by checking for NULL pointer

Check for the pending_subkey_request_ pointer,
to make sure that it's not NULL.

Bug: 746041
Change-Id: I218245faf54a34eb87b3ebb90d53d710f8b8dc48
Reviewed-on: https://chromium-review.googlesource.com/577764
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488221}

Original CL: http://crrev.com/c/577593

Fixes: Suppress lint errors for downstream targets.

TBR=mthiesse@chromium.org,agrieve@chromium.org

Bug: 739746,746409
Change-Id: Ib069fed8e77d1a55d75ae71592cea6096c46ff47
Reviewed-on: https://chromium-review.googlesource.com/577966Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488220}

With ARC, there is no garanty that PasswordController will be
deallocated before WebState.
Detach it before the end of the test.

Bug: None
Change-Id: Ib16320cba8dcb59fe79f65c633e063e29a35a614
Reviewed-on: https://chromium-review.googlesource.com/579373Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488219}

Bug: 738881
Change-Id: I74f4c504cb2fc20b710b8b5011a649c50599e8ec
Reviewed-on: https://chromium-review.googlesource.com/575981
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488218}

- Add user policy EcryptfsMigrationStrategy which controls ecryptfs
  to dircrypto cryptohome migration.
- Implement a pre-signin policy fetch mechanism which tries to fetch cached
  policy first, and if there is valid cached policy, also tries to fetch
  fresh policy.
- Wire up the pre-signin policy fetch into existing_user_controller.cc to
  decide what to do when a ecryptfs user home is detected.

Fetching cached policy is done by mounting cryptohome to a temporary
location, reading policy from there, and then unmounting.

Fetching fresh policy is done using the dm_token/client_id from the
cached policy with a fixed timeout.

TEST=unit_tests --gtest_filter=PreSigninPolicyFetcherTest*
TEST=Manual test with ecryptfs cryptohome and YAPS
BUG=722371

Change-Id: I040cf3626257447e4e0dd2c70cf2d10604cb1977
Reviewed-on: https://chromium-review.googlesource.com/564609
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488217}

TBR=jdoerrie@chromium.org

Bug: 746926
Change-Id: I888ae3eddd83ac589a6430bd9b3355d97d14b825
Reviewed-on: https://chromium-review.googlesource.com/579387Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488216}

Now, when multiple entries contain the same content, multiple
table-of-contents entries will be created, but only one data region.

As of now, en-US.pak has ~3200 entries, and 350 of them are duplicates.

For MonochromePublic.apk, shrinks uncompressed .pak size by ~130kb, and
compressed .pak size by 32kb.

BUG=738566

Review-Url: https://codereview.chromium.org/2969123002
Cr-Commit-Position: refs/heads/master@{#488215}

This CL delays the binding of a ukm::SourceID to a URL in the
PasswordFormMetricsRecorder until the recorder is destroyed. The reason for
this is that long-lived tabs/WebContents would bind the URL at creation. But by
destruction (i.e. reporting time) the binding is purged and the data is
discarded.

Bug: 732846
Change-Id: I0a7c654ddc1a866e4abbe51206f62949500b5ba9
Reviewed-on: https://chromium-review.googlesource.com/577887
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488214}

In iOS 11, WKWebView has issues (time outs) when loading request if the
view is not part of the hierarchy. The WKWebView is now added to the
hierarchy but off screen.

Bug: 738435, 739390
Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
Reviewed-on: https://chromium-review.googlesource.com/577807
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488213}

This reverts commit 2cec5853.

Reason for revert: Likely Culprit of https://crbug.com/746941.

Original change's description:
> customtabs: Don't allow multiple background tabs concurrently.
> 
> BUG=742450
> 
> Change-Id: Ia767797d89022b862e38b7ae72949bed08d94c09
> Reviewed-on: https://chromium-review.googlesource.com/578067
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488171}

TBR=yusufo@chromium.org,lizeb@chromium.org

Change-Id: Id209518579ebc889cfe652d9eea8491a9ec909a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 742450
Reviewed-on: https://chromium-review.googlesource.com/579390Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488212}

Bug: 729738
Change-Id: Iff0d6dcfe202cad7dfbd2b111a160e37fb7aaa7e
Reviewed-on: https://chromium-review.googlesource.com/561680Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488211}

Bug: 730031
Change-Id: I98e7b16239b75549f8df558a8dff9a5c2e6c6265
Reviewed-on: https://chromium-review.googlesource.com/576384
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488210}

MidiTaskServiceTest.RunBoundTasks failing on v1 chromecast device.
This is because the test increments the count after signaling the event,
and it results in racy results because expectation check could run
before the count is incremented.
This patch fixes this problem and is expected to solve the problem
that RunBoundTasks failing on v1 chromecast device.

Bug: 744777
Change-Id: Id318353795025adbf204be90d381fa6b696d2390
Reviewed-on: https://chromium-review.googlesource.com/575325Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488209}

TBR=olivierrobin@chromium.org
NOTRY=true

Bug: 515462
Change-Id: I7289689de14ecb1936df5eb1c24aefcb5e8cad06
Reviewed-on: https://chromium-review.googlesource.com/579428Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488208}

[ES6 modules] Reduce number of MTLs by not creating MTL for sub-graph fetch already handled somewhere else

This CL makes unbundled moment.js benchmark [1] 19x faster (3.8s -> 200ms)
[1] https://sgom.es/posts/2017-06-30-ecmascript-module-loading-can-we-unbundle-yet/

Before this CL, we instantiated ModuleTreeLinker per module graph edge (== import stmt).
For module graphs which are close to fully connected, this resulted in exponential number of ModuleTreeLinker involved.
Each ModuleTreeLinker comes w/ multiple postTask cost and memory cost, thus this resulted in slow performance and high peak memory usage.

This CL drastically reduces the ModuleTreeLinker per module graph fetch, by creating one ModuleTreeLinker at most for each module graph node (== module script) involved.
This CL introduces ModuleTreeReachedUrlSet, which is instantiated per top-level module graph fetch, and shared among all descendant sub-graph ModuleTreeLinkers.
Before creating a new ModuleTreeLinker for descendant module graph fetch, ModuleTreeLinker::FetchDescendants now consults this ModuleTreeReachedUrlSet to find if there is an existing ModuleTreeLinker instance which it can delegate the sub-graph fetch.

Credits:
- nhiroki@ for the original algorithm.
- adamk@, hiroshige@ for extensive analysis.
- adamk@, ksakamoto@ for verifying the speed up.

Bug: 722728
Change-Id: I7af4206ece3c5613a3085e7483eddbd652718981
Reviewed-on: https://chromium-review.googlesource.com/578531Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488207}

BUG=734525

Change-Id: I75e4d4aef819f859d089b38af577a56bcbca314a
Reviewed-on: https://chromium-review.googlesource.com/576034Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488206}

Also remove X-button from the domain join screen

Bug: 739283
Test: manual
Change-Id: Ib0f39ee36a9bb23d1df86c25c9cc4be6e2846582
Reviewed-on: https://chromium-review.googlesource.com/577868Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488205}

It fails consistently.
NOTRY=true
TBR=olivierrobin@chromium.org

Bug: 515462
Change-Id: If1a3d1d4711b3ca609c167e6ff4319cdcde10b82
Reviewed-on: https://chromium-review.googlesource.com/579388Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488204}

Calculates the number of columns tiles are layed out in
at initialization and reorders the home page tile so that
it is pinned to the first row.
Follow-up issue: https://crbug.com/746274

BUG=732913

Change-Id: Ieeddf88e8262827c7a22787230c386fe3b43cc17
Reviewed-on: https://chromium-review.googlesource.com/567925
Commit-Queue: Ondrej Škopek <oskopek@google.com>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488203}

This CL introduces a transition API for animating contained view
controllers. It adds a concrete transitioning context to work with generic
animators.
The new API is used for CSChromium's FindInPage feature, with a new generic
animation controller object.

Bug: none
Change-Id: Ia1bf383a373e13766c4bd966e4ede04778357c9f
Reviewed-on: https://chromium-review.googlesource.com/552937Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488202}

Since PackageFormatOf() only needs the first 4 bytes, just copy them to
a local buffer.

BUG=728627

Change-Id: I19e65c95f4737968967fb63196b8ed6d07fa7fae
Reviewed-on: https://chromium-review.googlesource.com/577673Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488201}

Use a segment iterator insted.

BUG=728627

Change-Id: I6bb88a0696e920f2751181d4c8acc9d790787e26
Reviewed-on: https://chromium-review.googlesource.com/577672Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488200}

The passwords settings EG test uses PasswordStore. PasswordStore works on a
background task runner, and the test needs to ensure that it waits until
PasswordStore is finished.

Unfortunately, the test currently attempts to do this with
[[GREYUIThreadExecutor sharedInstance] drainUntilIdle];

As the name suggests, this waits for the UI thread, not for the background task
runner. There is no synchronisation with the password store currently and the
tests pass just by luck. Indeed, test configurations are possible to write
where PasswordStore is not done on time and the test fails.

Therefore this CL replaces the waiting for UI thread with a combination of
posting tasks to PasswordStore and using WaitUntilConditionOrTimeout to check
their completion. The timeout selected is 1 second. Using the pre-defined value
kSpinDelaySeconds turned out to be too short.

The CL not only replaces GREYUIThreadExecutor with the new synchronisation, it
also checks the state of the PasswordStore in more detail. Furthermore, it also
adds synchronisation with PasswordStore after the password list view loads,
because that view also depends on the response from PasswordStore.

Bug: 744058
Change-Id: I1a86c0cdfa9b60a609505005b7d2df5e1896dd54
Reviewed-on: https://chromium-review.googlesource.com/573540
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488199}

- Implement GetWebsiteSettingLastModified for the
NotificationChannelsAndroidProvider by storing channel creation
timestamp within the channel IDs.

- This also has the beneficial side effect that each time a channel
is created in response to permission grant, it will have a unique ID,
so that channels deleted when site data is cleared will not be
restored the next time permission is granted/blocked.

- Note that NCAP.GetWebsiteSettingLastModified is currently only
called from tests, but in a future patch it will be pulled up to a
new provider interface and called by the HostContentSettingsMap
where it currently only calls the Pref Provider. 

Bug: 700377
Change-Id: I5363ae2baa7e0c92bb7768361d459cd024622b32
Reviewed-on: https://chromium-review.googlesource.com/567153
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488198}

As copied, they are exactly same.

Bug: 739062
Change-Id: I96e564362c50a2519b6a4358b609ea58119c70a0
Reviewed-on: https://chromium-review.googlesource.com/578970
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488197}

The newer CrOS toolchains declare a new use_vaapi argument. Unless this
argument is declared in Chromium as well, gn gen will display this error
message:

ERROR at the command-line "--args":3:13: Build argument has no effect.
use_vaapi = true

The ninja files will be successfully generated nonetheless, but this is
still disturbing, so fix this by declaring this argument.

BUG=742069
TEST=Made sure Chromium was compiling with use_vaapi declared or not.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib10ac7d0762a09d13ba92391ba55585b786ad3f6
Reviewed-on: https://chromium-review.googlesource.com/579028Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488196}

Revert of Last_n: instrumentation tests to verify timely snapshot deletion. (patchset #7 id:120001 of https://codereview.chromium.org/2833653002/ )

Reason for revert:
Likely cause of https://crbug.com/746699.

testLastNPageIsDeletedUponNavigation is flaky.

Original issue's description:
> Last_n: instrumentation tests to verify timely snapshot deletion.
>
> Adds new tests to RecentTabsTest.java to verify that offline snapshots created
> by last_n are properly deleted when successfully navigating to another page and
> upon tab closure. These actions are important to comply with privacy
> requirements for this feature.
>
> This change re-adds instrumentation tests previously committed along with a
> related bugfix [1] that were reverted due to them being flaky. It seems that the
> underlying issue causing the flakyness has been fixed [2] [3] so these should
> now work as expected.
>
> [1] https://codereview.chromium.org/2824623002/
> [2] https://bugs.chromium.org/p/chromium/issues/detail?id=592961 (restricted)
> [3] https://bugs.chromium.org/p/chromium/issues/detail?id=738490
>
> BUG=711770
>
> Review-Url: https://codereview.chromium.org/2833653002
> Cr-Commit-Position: refs/heads/master@{#487727}
> Committed: https://chromium.googlesource.com/chromium/src/+/f6fd25d5826f1a62010b08037eb50c396b05d7a2

TBR=dewittj@chromium.org,carlosk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=711770

Review-Url: https://codereview.chromium.org/2983953002
Cr-Commit-Position: refs/heads/master@{#488195}

Bug: None
Change-Id: I967dcf8315ea3f40fc89cb0fe54da83499ab4b52
Reviewed-on: https://chromium-review.googlesource.com/574921Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488194}

Bug: 740821
Change-Id: I4fa17745613ac2c25efe260673dc324cf5f6df3a
Reviewed-on: https://chromium-review.googlesource.com/579249Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488193}

This CL delays the binding of a ukm::SourceID to a URL in the
PasswordManagerMetricsRecorder until the recorder is destroyed. The reason for
this is that long-lived tabs/WebContents would bind the URL at creation. But by
destruction (i.e. reporting time) the binding is purged and the data is
discarded.

Bug: 732846
Change-Id: I4d20385eb2de80c4ca5e53816d22b9652abb5b61
Reviewed-on: https://chromium-review.googlesource.com/577554Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488192}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/2048bc4..a7461e3

$ git log 2048bc4..a7461e3 --date=short --no-merges --format=%ad %ae %s
2017-07-19 pbos@webrtc.org Move temporal-layer properties to FrameConfig.
2017-07-19 zstein@webrtc.org Introduce RtpTransportInternal and SrtpTransport.
2017-07-19 ehmaldonado@webrtc.org Remove remains of webrtc/base
2017-07-19 tschumim@webrtc.org Disable flaky NoBandwidthDropAfterDtx test.
2017-07-19 sakal@webrtc.org Fix fromAndroidGraphicsMatrix to use column-major order for output.
2017-07-19 saza@webrtc.org Replace WEBRTC_TRACE logging in modules/audio_device/.. mac/ win/
2017-07-19 saza@webrtc.org Adds a histogram metric tracking for how long audio RTP packets are sent through streams related to a call object.
2017-07-18 mellem@webrtc.org Add texture support to HardwareVideoEncoder.
2017-07-18 mellem@webrtc.org Add texture support to HardwareVideoDecoder.
2017-07-17 zijiehe@chromium.org Mapping screen id from DirectX capturer to GDI capturer
2017-07-18 ehmaldonado@webrtc.org Enable tracing on rtcstats_integrationtest.cc
2017-07-18 aleloi@webrtc.org UBSan fuzzer bug in LowCutFilter::BiqueadFilter::Process
2017-07-18 sakal@webrtc.org Fix fullscreen scaling in AppRTCMobile.
2017-07-18 ehmaldonado@webrtc.org Increase the size of the buffer for type.name.id.
2017-07-18 saza@webrtc.org Patch set 1: Run a script to replace occurrences of WEBRTC_TRACE logging with the new style, on webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc.
2017-07-18 ehmaldonado@webrtc.org Trace stats in RTCStatsCollector.
2017-06-28 aleloi@webrtc.org Remove potential left shift of negative value in WebRtcSpl_AnalysisQMF
2017-07-18 gnish@webrtc.org Added implementation of three classes:

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Bug: 
Change-Id: If229bad76d63d07156f4ce48b707f3159834ec13
Reviewed-on: https://chromium-review.googlesource.com/579047Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488191}

Move same conditional expression AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function

This patch moves same conditional expression in
|AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries()| into
|ShouldAdjustPositionToAvoidCrossingEditingBoundaries()| to share code and
simplify if-statement for improving code health.

Change-Id: I05c4324d1758c991b75bf27dac3426479d8e30bb
Reviewed-on: https://chromium-review.googlesource.com/578755Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488190}

We want the initialisation of the home sheet to happen when the bottom
sheet opens and shows the home sheet. However, even though it's the
default sheet, the bottom sheet can also open to show omnibox
suggestions. In that case the home sheet is not shown and should not
be loaded.

This CL makes initialisation happen the first time the sheet is shown
since the opening of the bottom sheet.

Making the home sheet not be selected when the omnibox suggestions are
shown is out of scope and tracked in https://crbug.com/731128

Bug: 735945
Change-Id: I61406ea0ff4207370d86d3fd0712e339813b7ff7
Reviewed-on: https://chromium-review.googlesource.com/563309Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488189}

Follow-up to commit 4a301c5f ("Remove the
--allow-local-commits flag from wpt-import"), which broke wpt imports:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpFlAgpq/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpFlAgpq/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 55, in main
    if not self.checkout_is_okay():
  File "/mnt/data/b/rr/tmpFlAgpq/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 230, in checkout_is_okay
    ['git', 'log', '--oneline', 'origin/master..HEAD'])[1]
ValueError: need more than 0 values to unpack

(from https://luci-milo.appspot.com/buildbot/chromium.infra.cron/wpt-importer/346)

Tbr: qyearsley@chromium.org
Change-Id: Ic5849c25add80048d4e1e9f1c573031537243ff0
Reviewed-on: https://chromium-review.googlesource.com/579069
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#488188}

Also add validation to make sure 'ios' platform does not appear in
policy_templates.json.

Bug: 561499
Change-Id: Ic2c147fe772a1464ea734d12df179b3b1543fb72
Reviewed-on: https://chromium-review.googlesource.com/568148
Commit-Queue: Daria Iakovleva <yakovleva@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488187}

This reverts commit d4a5e982.

Reason for revert: regressed performance (crbug.com/739378, crbug.com/736714).

The main cause is that new heap format produces a lot more stack frames in
an attempt to dump all information in contrast with the old format, where
small stack branches are coalesced together. I'll that functionality to
the new format and reland it.

> [tracing] Switch to new heap dump format.
>
> This CL switches tracing to a new heap dump format, that offers the
> following advantages:
>
> 1. Dumps include all the information collected by Chrome's heap profiler.
>
> 2. The format is simpler and more compact.
>
> 3. The format can easily be extended to include additional per-entry data.
>
> 4. The format allows for post-processing (see recategorization from
>    crrev.com/2906413002 as an example).
>
> BUG=708930
>
> Review-Url: https://codereview.chromium.org/2650863003
> Cr-Commit-Position: refs/heads/master@{#480580}

TBR=mark@chromium.org

Bug: 708930, 739378, 736714
Change-Id: Ifc2b647aa1f57f4decae6e593ad032d72208b304
Reviewed-on: https://chromium-review.googlesource.com/575682
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488186}

Bug: 
Change-Id: I72bb8b8b547980e3097c23f1f64fc1da37929774
Reviewed-on: https://chromium-review.googlesource.com/578698
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488185}