GitLab

In android webview the selection handles are implemented in
PopupTouchHandleDrawable.java

In this CL we make this class an observer that listens to
display changes and keep the current dip scale as a member
instead of retrieving it from ContentViewCore.

We cannot update the bitmaps by the DisplayAndroid signal
(i.e. in onDIPScaleChanged()) because the resources are not
yet updated at the moment. Instead, we update the bitmap in the subsequent
onConfigurationChanged() that should follow the display change.

To make sure that the configuration corresponds to the display change
we check that the display density in resources is equal to the expected
value.

BUG=620929

Review-Url: https://codereview.chromium.org/2515343004
Cr-Commit-Position: refs/heads/master@{#435025}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d656dfb5..f796cb3f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2540553004
Cr-Commit-Position: refs/heads/master@{#435024}

BUG=642059

Review-Url: https://codereview.chromium.org/2530943002
Cr-Commit-Position: refs/heads/master@{#435023}

BUG=668208

Review-Url: https://codereview.chromium.org/2525993002
Cr-Commit-Position: refs/heads/master@{#435022}

View Frame Source for iframe of a file:// URL used to show the main frame's
filename instead of the expected title derived from the iframe's page URL in
the form of "view-source:url". This CL fixes this and adds a browser test.

BUG=659040
TEST=browser_tests --gtest_filter=ChromeNavigationBrowserTest.TestViewFrameSource

Review-Url: https://codereview.chromium.org/2501083004
Cr-Commit-Position: refs/heads/master@{#435021}

AXNodeData::state is a bitmask used for setting accessible state flags such as
ui::AX_STATE_DISABLED. It is initialised to 0xFFFFFF, which turns all flags on.
This is done in order to more easily catch bugs where no flags are set at all -
it must be cleared to 0x0 before use. Add a comment explaining this.

BUG=668569

Review-Url: https://codereview.chromium.org/2528103002
Cr-Commit-Position: refs/heads/master@{#435020}

Sometimes UsbDevice::product_string() returns empty string, and the
current WebUSB chooser uses it as the device name to be displayed.
This CL fixes the blank name issue by displaying, in decreasing order
of preference:
1. UsbDevice::product_string()
2. UsbIds::GetProductName()
3. "Unknown device from " + UsbIds::GetVendorName()
4. "Unknown device [$VID:$PID]"

BUG=665599

Review-Url: https://codereview.chromium.org/2539593002
Cr-Commit-Position: refs/heads/master@{#435019}

BUG=660868

Review-Url: https://codereview.chromium.org/2514483002
Cr-Commit-Position: refs/heads/master@{#435018}

Per discussion with UX.

Review-Url: https://codereview.chromium.org/2538573002
Cr-Commit-Position: refs/heads/master@{#435017}

BUG=629964

Review-Url: https://codereview.chromium.org/2535043002
Cr-Commit-Position: refs/heads/master@{#435016}

This updates from revision
4dcaacaf593dde7e2a34436913c24af3bf2bdb06 (2016-08-16)

to revision
b48ff55eab9b82ebc88762eed45277448d1f4f79 (2016-11-29)

R=pkasting@chromium.org
BUG=669314

Review-Url: https://codereview.chromium.org/2532913003
Cr-Commit-Position: refs/heads/master@{#435015}

https://skia.googlesource.com/skia.git/+log/e4cd00699167..e18c97b73a03

$ git log e4cd00699..e18c97b73 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 msarett Fix float/int bug in SkRawCodec

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2537113002
Cr-Commit-Position: refs/heads/master@{#435014}

BUG=

Review-Url: https://codereview.chromium.org/2533193002
Cr-Commit-Position: refs/heads/master@{#435013}

Note that webrtc.stress doesn't measure stats at all (yet), so that
needs to happen if we decide to go the Telemetry path. See discussion
in the bug.

BUG=632299

Review-Url: https://codereview.chromium.org/2522183002
Cr-Commit-Position: refs/heads/master@{#435012}

When merging, if we're given specifics that correspond to the local
guid, we try to access specifics object for the local guid in
|all_data_|. The problem with this, is that there isn't always an entry
there if reconcile has not happened yet. This only happens when the
initial sync round trip finishes before metadata loads from disk, but
this race is happening to users, see the bug.

The fix could be to check that |all_data_| actually contains an entry
for the local guid, but it really doesn't matter. Local data completely
cleared when sync is disabled, so reconcile will always create a local
entry with a fresh time stamp around the time merge is called. There's
no reason to complicate the logic inside of merge for no real benefit,
so I've simply removed the set_last_updated_timestamp call.

BUG=668938

Review-Url: https://codereview.chromium.org/2536043002
Cr-Commit-Position: refs/heads/master@{#435011}

BUG=668541
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2536873002
Cr-Commit-Position: refs/heads/master@{#435010}

This patch avoids updating layout tree in
AXNodeObject::determineAccessibilityRole().

Element::isFocusable() requires styles to be updated. However, when
layout code calls determineAccessibilityRole(), updating layout tree
should be avoided since it may destroy the calling object.

This patch replaces it to supportsFocus(), since the main purpose is
to give elements with tabIndex explicitly set get some role.

This is a speculative fix.

BUG=590369, 647602, 665168

Review-Url: https://codereview.chromium.org/2532023002
Cr-Commit-Position: refs/heads/master@{#435009}

The DCHECK is invalid because we can have a render surface between the
target of scroll parent and scroll child.

BUG=663499
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537053002
Cr-Commit-Position: refs/heads/master@{#435008}

The omnibox visibility timer should not be active during a page load; it
should be started only after loading finishes.

BUG=641508
TEST=Viewed a page that takes 10s to load; omnibox stays visible.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2534963002
Cr-Commit-Position: refs/heads/master@{#435007}

kPolicyVerificationKeyHash is the only possible value anyways (outside
of tests).

BUG=none

Review-Url: https://codereview.chromium.org/2537643003
Cr-Commit-Position: refs/heads/master@{#435006}

Introduces the ThreadSafeAssociatedInterfacePtrProvider class that
provides functionalities similar to the content::ThreadSafeSender.
You create it with a ChannelProxy and you can then retrieve
ThreadSafeInterfacePtr's from it that you can call methods on from any
thread and even before the actual channel is connected.

BUG=668317

Review-Url: https://codereview.chromium.org/2522333002
Cr-Commit-Position: refs/heads/master@{#435005}

Moves ivars to implementation files and moves the objc_property_releaser
include into implementation file, so that code built with  ARC can
depend on it.

BUG=None

Review-Url: https://codereview.chromium.org/2536073003
Cr-Commit-Position: refs/heads/master@{#435004}

No one is using it.

R=jochen@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2537753002
Cr-Commit-Position: refs/heads/master@{#435003}

This change updates ink drop ripples (especially, flood fill ripple) to
handle host view's size change to update their layer size. The main
change is that the flood fill ripple gets insets instead of bounds to
make it relative to the host's bounds. If a ripple is in progress, it
will snap to its final size immediately.

Ink drop highlight is still using a workaround to handle resize and will
be fixed in a follow-up CL.

BUG=666175
TEST=manual

Review-Url: https://codereview.chromium.org/2533053002
Cr-Commit-Position: refs/heads/master@{#435002}

Merge internal change: 139108411

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2518063007
Cr-Commit-Position: refs/heads/master@{#435001}

Add a new test target gl_unittests_ozonex that runs with
--ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with
both Ozone headless and Ozone X11.

The test requires an X server to be running on the bot. The mb.py script
is modified to look for GN arg use_ozone=true and runtime flag
--ozone-platform=x11. In this case, it runs the test using xvfb.

Original commit crrev.com/2493063003 was reverted due to
crbug.com/665895. There was no dependency on xdisplaycheck by the new
test target that needs it. This caused problems during the isolate step
when xdisplaycheck wasn't found.

BUG=664570

Review-Url: https://codereview.chromium.org/2509033006
Cr-Commit-Position: refs/heads/master@{#435000}

https://skia.googlesource.com/skia.git/+log/c51c18fd7837..e4cd00699167

$ git log c51c18fd7..e4cd00699 --date=short --no-merges --format='%ad %ae %s'
2016-11-29 dskiba Make GrMemoryPool play nice with bucketing allocators.

BUG=651872

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2536203002
Cr-Commit-Position: refs/heads/master@{#434999}

It appears that the the log error was dropped when the default mode enum
was added in change https://codereview.chromium.org/2475443004. Add a test
to ensure that it doesn't get dropped again.

BUG=667799

Review-Url: https://codereview.chromium.org/2536563003
Cr-Commit-Position: refs/heads/master@{#434998}

This removes the prefetch_results and reuse_instant_search_base_page parameters.

BUG=627483

Review-Url: https://codereview.chromium.org/2526753002
Cr-Commit-Position: refs/heads/master@{#434997}

The name of variable was causing no end of confusion about when it should be
passed into the various install* methods for origin trials, and when a dummy
object should be passed instead. Renamed to the more sensible 'instanceObject',
as a counterpart to 'interfaceObject' and 'prototypeObject', and now only
instantiate it when necessary (in Window and WorkerGlobalScope blocks).

Review-Url: https://codereview.chromium.org/2532213002
Cr-Commit-Position: refs/heads/master@{#434996}

Currently, the only time limitation on push message processing is the
service worker default timeout of 5 minutes. 99% of push messages are
processed in under 1 minute, so we want to reduce the timeout so that
outliers don't begin to rely on the long processing available.

BUG=646783

Review-Url: https://codereview.chromium.org/2506393003
Cr-Commit-Position: refs/heads/master@{#434995}

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new getter ThreadState::isWrapperTracingForbidden()
for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2532133003
Cr-Commit-Position: refs/heads/master@{#434994}

BUG=669420

R=anthonyvd@chromium.org, bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2538753002
Cr-Commit-Position: refs/heads/master@{#434993}

This CL lands server change 139914335 by diannahu.

BUG=488484

Review-Url: https://codereview.chromium.org/2535013002
Cr-Commit-Position: refs/heads/master@{#434992}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/928e6b56..d656dfb5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2540723002
Cr-Commit-Position: refs/heads/master@{#434991}

This CL ensures that the ArcSessionManager is alive during the whole
each ArcService's life time, by merging two class initialization
list in ArcSessionManager and ArcServiceLauncher.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.

Review-Url: https://codereview.chromium.org/2531543003
Cr-Commit-Position: refs/heads/master@{#434990}

Introduces a new "ios_launchscreen_assets_target" GN variable to select which
target provides assets for the launchscreen.

BUG=665966,666732

Review-Url: https://codereview.chromium.org/2537443002
Cr-Commit-Position: refs/heads/master@{#434989}

Path::apply doesn't pass a point along for the PathElementCloseSubpath
command. This would yield the wrong orientation on the last marker-mid
on the path (see crbug.com/633012#c1 for an example.)
Use m_subpathStart where needed instead.

BUG=633012

Review-Url: https://codereview.chromium.org/2539763002
Cr-Commit-Position: refs/heads/master@{#434988}

Make the updateFromPathElement "closure" a simple thunk-style function,
to make it a little less unwieldy. Also pass PathElement& rather than
PathElement*.

BUG=633012,450368

Review-Url: https://codereview.chromium.org/2540513005
Cr-Commit-Position: refs/heads/master@{#434987}

This patch updates W3CImportExpectations in order to import
the css-ui-3/ test suite.

40 new tests are imported on the following folder:
imported/csswg-test/css-ui-3/

27 pass and 13 are marked as failure on TestExpectations file.

BUG=669473

Review-Url: https://codereview.chromium.org/2539753002
Cr-Commit-Position: refs/heads/master@{#434986}