- 18 Jul, 2018 30 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6ddf1942ca0..302bb847d356 git log e6ddf1942ca0..302bb847d356 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jbudorick@chromium.org gclient: run cipd ensure in paranoid mode. 2018-07-17 ehmaldonado@chromium.org git_cache: Add tests for reset fetch config. 2018-07-17 ehmaldonado@chromium.org metrics: Fix countdown to metrics collection. Created with: gclient setdep -r src/third_party/depot_tools@302bb847d356 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860251,chromium:862547,chromium:832386 TBR=agable@chromium.org Change-Id: I654f3810c18eef26eda782285927c8bef5bfd3d7 Reviewed-on: https://chromium-review.googlesource.com/1140797Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575891}
-
Kurt Horimoto authored
Previously, TableViewURLCell always returned a lazily created a11y label created using the values of the UILabel subviews, which was squashing the custom a11y label provided by TableViewItems. Bug: 862306 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7210e683f4dfdcdbf0f2c60ecec3eb2a0683eeec Reviewed-on: https://chromium-review.googlesource.com/1136902Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#575890}
-
Christopher Cameron authored
Disabling it didn't fix the crashes. TBR=lgrey Bug: 863817 Change-Id: I6cf6ea476856b2e20cf37cf080c59aeec41119dd Reviewed-on: https://chromium-review.googlesource.com/1141330Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#575889}
-
Victor Costan authored
Bug: 167187 Change-Id: I4d26741ca9b41751ed8dc3b121fc3d6e7bff9d5b Reviewed-on: https://chromium-review.googlesource.com/1137916Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575888}
-
Tommy C. Li authored
See the bug for screenshots. Currently, the selection bounds in the Omnibox are not vertically symmetric. This is becoming a lot more noticeable with the MD Refresh redesign. This CL extends RenderText to allow expanding the selection bounds to be vertically symmetric with respect to the display rect. This CL only turns on this flag for the OmniboxViewViews. Bug: 249065 Change-Id: I031017335a0efb5e8842d137fc55efce5520e6cd Reviewed-on: https://chromium-review.googlesource.com/1140901 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575887}
-
Chris Hamilton authored
This will allow enterprises to opt-out or opt-in to lifecycles while the feature is under development. Change-Id: I68838306ac3d22fab1290f47011dc4d14c909c43 Reviewed-on: https://chromium-review.googlesource.com/1132299Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#575886}
-
Lei Zhang authored
Effectively removing them from Android, where there is no PPAPI. Also fix an "is_chromeos" typo. Change-Id: I1395ccf368c1d0f593352d1ae2755fcb5920468a Reviewed-on: https://chromium-review.googlesource.com/1140531Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575885}
-
Victor Costan authored
Bug: 112250 Change-Id: I63369b826307acea4b01f15fbc4cbef2f41514a1 Reviewed-on: https://chromium-review.googlesource.com/1137925Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575884}
-
Varun Khaneja authored
Default quota: 5 Bug: 853382,730646 Change-Id: Ib989a9053da93d7e083f3217082627fa8635da5e Reviewed-on: https://chromium-review.googlesource.com/1138864 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#575883}
-
Min Qin authored
This CL calls the InProgressDownloadManager to delete ResourceDownloader after response is completed. It also fixes the issue when download is cancelled. BUG=864189 Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7 Reviewed-on: https://chromium-review.googlesource.com/1138676 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575882}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/004af3cf8045..82b059ecb6a4 git log 004af3cf8045..82b059ecb6a4 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 vapier@chromium.org lint: fix singleton-comparison warnings 2018-07-17 vapier@chromium.org lint: fix no-value-for-parameter warnings Created with: gclient setdep -r src/third_party/chromite@82b059ecb6a4 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I45415863772236473072d5116dd8ac87caff7654 Reviewed-on: https://chromium-review.googlesource.com/1140613Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575881}
-
Dominick Ng authored
BUG=None. Change-Id: I3edc7ba50a20c6e1fb87cd950a9f73d5c9a6c724 Reviewed-on: https://chromium-review.googlesource.com/1140112 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#575880}
-
Takuto Ikuta authored
This is for following nearly 1 hour builds. * linux_chromium_tsan_rel_ng 3783s https://ci.chromium.org/b/8940786382570619168 * mac_chromium_compile_dbg_ng 3534s https://ci.chromium.org/b/8940786382570619152 * linux_chromium_compile_dbg_ng 3534s https://ci.chromium.org/b/8940786382570619056 Bug: 804251 Change-Id: If82c10b26628271dfc01011da204c59858395bd7 Reviewed-on: https://chromium-review.googlesource.com/1139934Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#575879}
-
Roberto Carrillo authored
R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv Bug: 787918 Change-Id: I0766fa1c9d575b9960d336152aa62c56a7a2b945 Reviewed-on: https://chromium-review.googlesource.com/1141117Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575878}
-
Luum Habtemariam authored
This service will serve the ARC CUPS API by accepting an IPP request via mojom calls, validate its format in a heavily restricted/jailed process, and return the result. This change just contains the scaffolding for the service, validation/jailing to follow soon. Test: WIP Bug: chromium:831913 Change-Id: I5cd88b82746d999743e3ebddfc6aef15e408506d Reviewed-on: https://chromium-review.googlesource.com/1121108Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#575877}
-
Victor Costan authored
0-based ref-counting is deprecated. 1-based counting is described in //base/memory/ref_counted.h. In summary, instaces must be created by base::MakeRefCounted<T> or (less ideal) base::AdoptRef(new T). This CL switches Connection::StatementRef to 1-based ref-counting, and std::move()'s scoped_refptr<StatementRef> in a few places where that avoids refcount churn. Bug: none Change-Id: I14755dc2482f18c8a9582066104f346c2873941d Reviewed-on: https://chromium-review.googlesource.com/1137848 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#575876}
-
Zach Helfinstein authored
Dictation is an accessibility feature that allows users who opt-in to have their speech transcribed into any text field in ChromeOS. Screenshot: https://screenshot.googleplex.com/EkLrrNDAohB.png BUG=850690 TEST=None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I11ca4051b38a4beec7876ba35899e337f36411e4 Reviewed-on: https://chromium-review.googlesource.com/1120852 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575875}
-
Hongchan Choi authored
Because AudioWorkletHandler is ThreadSafeRefCounted, wrapping with CrossThreadUnretained() when the handler is passed via CrossThreadBind() is unnecessary. Use scoped_refptr<> instead. Bug: 853520 Test: All existing layout/WPT tests pass. Change-Id: I83409b89e80a9bbb60ea98649b16efb59facbbd4 Reviewed-on: https://chromium-review.googlesource.com/1140744 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#575874}
-
Min Qin authored
if DownloadDB is enabled, there is no need to update incomplete download in history db. The DownloadDB should contain all information. BUG=863602 Change-Id: Idf20bbb91e8e5156aa21354695b0781493c723ef Reviewed-on: https://chromium-review.googlesource.com/1137235 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575873}
-
Christian Biesinger authored
This reverts commit 43df04fe. Looks like there is no need for a flag-specific expectation anymore for virtual/layout_ng_experimental/fast/multicol/flexbox-with-overflow-auto-child-crash.html Original change's description: > [layoutng] Use the correct layout algorithm to compute min/max sizes > > This also required adding a check in NGBlockNode::ComputeMinMaxSize > for whether we are inside of PerformLayout -- on Mac, we can > compute preferred sizes outside of layout; however, we can't do > actual layout in that case, so we have to fallback to legacy > min/max size in this case (c.f. RenderViewImpl::CheckPreferredSize()) > > Bug: 635619 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I0caf0c6c79264074ccaf9f45b83a420950dab715 > Reviewed-on: https://chromium-review.googlesource.com/1131562 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575545} Bug: 635619 Change-Id: I28ca2367e21327d9f911c75b9f9950d171d48e1b Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1140206Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#575872}
-
Becca Hughes authored
min() and max() are not supported and should throw a parse error when used with env() and var(). BUG=864435 Change-Id: I7e89607cc6bb41910131b35a72dabb979f10b7dc Reviewed-on: https://chromium-review.googlesource.com/1140746 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#575871}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: I0ff88b708c490cc760902e245e6473e90546c4b9 Reviewed-on: https://chromium-review.googlesource.com/1137750Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575870}
-
Xiaocheng Hu authored
Bug: 864797 Change-Id: I4becdf1fcbc4b9cfd9821ad61641753df14e1407 Tbr: afakhry@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1141136Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575869}
-
Weidong Guo authored
1. Add TransitionAnimationObserver to layout app list at the end of animation to make sure child views are in right position. 2. Replace old expand arrow icon with Skia-drawn arrow and implement the new transition. 3. Change the layout of apps grid and make the rows and cols adaptive to the width and height. 4. Enlarge the folder icon. Demo: https://drive.google.com/open?id=1xlGUpNv1X-s4D9mSjAPkyfZBMWhCjJag Change-Id: I3bc86870c66d0b35b36a801c16befb2624a33a55 Reviewed-on: https://chromium-review.googlesource.com/1121547Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575868}
-
Xiaocheng Hu authored
Bug: 830337 Change-Id: Ica61483028f3cd92787191d3115476f54b5f84c2 Tbr: achuith@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1140798Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575867}
-
Miguel Casas authored
Follow up and correction to crrev.com/c/1132112: we should only log those VideoFrames that are not supported _and_ that are not Textures/GMBs already. This CL adds the latter part. Bug: 787122 Change-Id: Ieb4e4fff0f2e14e9beb6949f1531507ac80733ce Reviewed-on: https://chromium-review.googlesource.com/1140834Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#575866}
-
CJ DiMeglio authored
This reverts commit fed7475d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable two flaky tests on ChromeOS > > Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList > Disable WindowSelectorTest.RoundedEdgeMaskVisibility > > Tbr: xiyuan, xdai > Bug: 864467, 864465 > Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167 > Reviewed-on: https://chromium-review.googlesource.com/1140683 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575707} TBR=zmin@chromium.org Change-Id: I2aaceb5588030a1b14edf9b0c1d2da6165cbf8f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864467, 864465 Reviewed-on: https://chromium-review.googlesource.com/1140460Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#575865}
-
Yuri Wiitala authored
With no other screen capture implementations dependent upon media::ScreenCaptureDeviceCore, ThreadSafeCaptureOracle, etc.; this change merges this code into ScreenCaptureMachineAndroid. Unused functionality has been stripped-out, and minor callpoint- and lint- related clean-ups were made. No behavior/functional changes. Testing: Built monochrome_public_apk, installed it to my phone, and confirmed Android screen capture from that Chromium build still works by running a demo app: https://paulkinlan.github.io/screenrecord/. Bug: 806366,487935 Change-Id: I3edb2603261b6ed60e31edf795ac8da9a2a8525c Reviewed-on: https://chromium-review.googlesource.com/1137733 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575864}
-
Min Qin authored
DownloadManagerService may start too early before full browser is started. In this case, downloadItem doesn't have a BrowserContext object assocuated, BUG=695115 Change-Id: Ie7dcc88bb63cdfc8af0d0e4d4670e808e22f175e Reviewed-on: https://chromium-review.googlesource.com/1140519Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575863}
-
Jinho Bang authored
This is one of several patches that will remove the sequence version of supportedMethods member. This patch stops using it by removing the related code in browser side. - [1/2] https://crrev.com/c/1078687 - [2/2] This patch Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU Bug: 754779 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia276a90240dc817e60ce8cf793454eb822e67a4e Reviewed-on: https://chromium-review.googlesource.com/1108057Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#575862}
-
- 17 Jul, 2018 10 commits
-
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed1bf6ade339..718bcd15ec60 Created with: gclient setdep -r src-internal@718bcd15ec60 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/79769347 TBR=mmoss@chromium.org Change-Id: Ib368183b3420bc4568814737cf57199b33937040 Reviewed-on: https://chromium-review.googlesource.com/1140538Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575861}
-
Kurt Horimoto authored
This CL updates ContentSuggestionsMostVisitedActionItem to support custom a11y labels that differ from their titles, and adds a custom label for the Reading List cell that states the number of unread articles. Bug: 862299 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I972b5996fb3398154f656b8ea056b9028d468af0 Reviewed-on: https://chromium-review.googlesource.com/1137027 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575860}
-
Vaclav Brozek authored
ScopedLayoutPreventer was used to avoid detecting visibility of form elements in situations when it was believed to cause pre-mature layout (see https://crbug.com/595078). Visibility is approximated through calling IsFocusable on the WebNodes corresponding to forms and their fields. Looking at recent documentation, though, the WebNode-based API seems robust enough to prevent such dangerous calls: (1) The contract of Element::IsFocusable() only states the need to call Document::UpdateStyleAndLayoutTree() beforehand. (2) Document::UpdateStyleAndLayoutTree() does not cause the layout. (3) WebNode::IsFocusable() causes calling Document::UpdateStyleAndLayoutTree() as necessary before delegating to Element::IsFocusable(). See https://crbug.com/855598#c14 for more context. As a result, ScopedLayoutPreventer blocked visibility checks unnecessarily, leading to bugs like https://crbug.com/851808. Therefore this CL removes ScopedLayoutPreventer. Bug: 855598,851808,595078 Change-Id: Ic415919be5c40821dfa965eeb16372ae92ba92d5 Reviewed-on: https://chromium-review.googlesource.com/1136531Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575859}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40bacee96a94..e6ddf1942ca0 git log 40bacee96a94..e6ddf1942ca0 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 bratell@opera.com Stop gclient sync from scrolling during progress output 2018-07-17 ehmaldonado@chromium.org gclient: Start reporting metrics. Created with: gclient setdep -r src/third_party/depot_tools@e6ddf1942ca0 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386 TBR=agable@chromium.org Change-Id: I9f5a812dba6fa48f05ee1ec16a19065b3bc4e255 Reviewed-on: https://chromium-review.googlesource.com/1140536Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575858}
-
Dominick Ng authored
Some types of user interactions are used as a signal to ResourceDispatcherHostImpl. Prior to https://crrev.com/1735833002, scrolling was not one of them, and part of that CL's work explicitly filtered out MouseWheel events from being passed to ResourceDispatcherHostImpl. It also changed user-initiated navigations to call the new DidGetUserInteraction method with the blink::WebInputEvent::Undefined type. However, only a limited subset of user-initiated navigations were passed through this method: Ctrl-R/refresh button reloads, omnibox navigations, and NTP/bookmark navigations. Other user-initiated navigations such as back/forward buttons were omitted. https://crrev.com/1776843003 introduced wheel gesture events that generalised touch and mouse scrolling into one concept. https://crrev.com/1748553002 updated the user interaction code to use the new GestureScrollBegin event in place of MouseWheel events, but did not update the type check for forwarding to ResourceDispatcherHostImpl. https://crrev.com/1964863002 introduced NavigationHandle::IsRendererInitiated, which returns true if a navigation was initiated by the renderer process, and false if it was initiated by the browser process (i.e. it was user-initiated). This is a broader scope that the existing user-initiated navigations signaled through DidGetUserInteraction, namely including back/forward navigations. This CL improves on the user gesture handling in WebContentsImpl by: * removing user-initiated navigations from DidGetUserInteraction, and updating clients to listen to Did{Start/Finish}Navigation and check NavigationHandle::IsRendererInitiated. This includes more types of user-initiated navigations. * restoring the user gesture signal to ResourceDispatcherHostImpl back to how it was prior to https://crrev.com/1748553002 - listening to keydown, mouse click, taps, and certain user-initiated navigations. BUG=827659 Change-Id: I639270b21446104f22c8ae9b8b939eb96af3cabd Reviewed-on: https://chromium-review.googlesource.com/1125703Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575857}
-
Alex Moshchuk authored
This should help investigate a theory that a message to create a RenderFrameProxy is sent when that proxy already exists in the renderer process. Bug: 794625 Change-Id: I2bf7dc1312dc3cbf8d307c8358ac64c8402fe875 Reviewed-on: https://chromium-review.googlesource.com/1139186Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#575856}
-
Chris Harrelson authored
This matches behavior already implemented in PaintLayerPainter, which was added to greatly simplify the problem of detecting clip property node invalidations upon change of clip (but not addition or removal of such clips). With the rollout of SPv175, invalidation under SVG transforms is also subject to this need. Before SPv175, non-composited transform mutations caused a forced subtree invalidation. Now there is an invalidation of the property on the PaintChunk under the transform, but the chunk itself is not re-painted. This requires the chunk to be complete and not partially culled out, which is why there is a requirement for an infinite cull rect. Note that this will increase performance of animations under SVG transform, which no longer need to paint the sub-content. (This same type of use case for CSS transform was another justification for the infinite cull rect in PaintLayerPainter). Bug: 862318 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibb65c7fd491b1be725a6aa05a33e9ba7cc03782d Reviewed-on: https://chromium-review.googlesource.com/1139583 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#575855}
-
Georges Khalil authored
Change-Id: I1bbeefa0bb68da658443e65ed1f9d63a510c4ed8 Bug: 826298 Reviewed-on: https://chromium-review.googlesource.com/1141050Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575854}
-
Darren Shen authored
In the new UI, we have to draw the keyboard drop shadow manually in the extension because of the non-rectangular geometry of the new floating keyboard. So we just disable shadows. When shadows are added in the extension, the keyboard window should resize correctly. Change-Id: I8530779930c109c834f33c5f673dbcc553ced6a2 Reviewed-on: https://chromium-review.googlesource.com/1139948 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#575853}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3229e65886a0..21a99d42c34f git log 3229e65886a0..21a99d42c34f --date=short --no-merges --format='%ad %ae %s' 2018-07-17 junov@chromium.org Fix validity check in SkSurface::MakeFromBackendTextureAsRenderTarget 2018-07-17 ethannicholas@google.com fixed SPIR-V memory layout 2018-07-17 allanmac@google.com Use std::chrono for measuring timing 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-17 ruiqimao@google.com fix MSAN dm failures Created with: gclient setdep -r src/third_party/skia@21a99d42c34f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:788439 TBR=bungeman@chromium.org Change-Id: I0d28ef2fa612e4d10cb0e778a4332769bba7aa49 Reviewed-on: https://chromium-review.googlesource.com/1140537Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575852}
-