GitLab

https://codereview.chromium.org/1019863002

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/1024523002

Cr-Commit-Position: refs/heads/master@{#321396}

This CL adds "Add $provider..." entries to the "Private network" and
"Add connection" drop-down menus on the Chrome OS settings page. The
contents of these menus updates dynamically as VPN providers are
added/removed.

BUG=460428
TEST=Manual

Review URL: https://codereview.chromium.org/1017443002

Cr-Commit-Position: refs/heads/master@{#321395}

Revert of https://codereview.chromium.org/1006003005/ and https://codereview.chromium.org/1001153002/.

We've already collected enough data to triage this bug.

BUG=464633

Review URL: https://codereview.chromium.org/1016183002

Cr-Commit-Position: refs/heads/master@{#321394}

All the major work has already been done. This CL just finishes flushing out
the documentation on tab.py and web_contents.py so that consumers know exactly
which exceptions can be thrown.

This CL contains one small behavioral change: InspectorBackend.IsInspectable()
catches DevToolsClientConnectionError and returns False. This is useful since
IsInspectable() gets called in the exception handling code, and no other
consumers of IsInspectable expect the method to throw an exception.

BUG=460625

Review URL: https://codereview.chromium.org/1007903004

Cr-Commit-Position: refs/heads/master@{#321393}

BUG=369661
TEST=tests should stay passing

Review URL: https://codereview.chromium.org/1010243002

Cr-Commit-Position: refs/heads/master@{#321392}

BUG=392620

Review URL: https://codereview.chromium.org/1006813005

Cr-Commit-Position: refs/heads/master@{#321391}

BUG=454815

Review URL: https://codereview.chromium.org/978913004

Cr-Commit-Position: refs/heads/master@{#321390}

BUG=462584
R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/1017243002

Cr-Commit-Position: refs/heads/master@{#321389}

BUG=
TBR=jamesr@chromium.org for third_party/mojo
TBR=dpranke@chromium.org for build

Review URL: https://codereview.chromium.org/1019173002

Cr-Commit-Position: refs/heads/master@{#321388}

BUG=b/13306957

Review URL: https://codereview.chromium.org/1015343002

Cr-Commit-Position: refs/heads/master@{#321387}

Path used to be a std::vector<std::string>. Now it is just a C array of size
PATH_MAX.

The code has a lot of nasty edge cases because it is trying to match the
previous behavior. Really, all this code should be axed -- it is incorrect to
handle paths the way nacl_io does currently. AFAICT, the only place that should
have to handle paths is the path lookup routine.

Fixing that is a much larger change.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/1016873004

Cr-Commit-Position: refs/heads/master@{#321386}

Original work around done in: crbug.com/455327 and crbug.com/459782

BUG=440601

Review URL: https://codereview.chromium.org/1019593002

Cr-Commit-Position: refs/heads/master@{#321385}

BUG=431230
TEST=manual

Review URL: https://codereview.chromium.org/1014913002

Cr-Commit-Position: refs/heads/master@{#321384}

Show the toolbar redesign bubble once per 24 hour period when the mouse
enters the toolbar, if and only if the user has not acknowledged it previously
and there is something new in the toolbar (i.e., and extension that was not
there previously).

BUG=461039

Review URL: https://codereview.chromium.org/1004063003

Cr-Commit-Position: refs/heads/master@{#321383}

BUG=467059
TBR=pfeldman

Review URL: https://codereview.chromium.org/1013753009

Cr-Commit-Position: refs/heads/master@{#321382}

Add a chrome.developerPrivate.updateExtensionConfiguration function, which allows
for setting particular extension traits.  Coalesce the existing allow file
access and allow incognito access into this, and add others.  Update the
chrome://extensions page to use the new function.

BUG=461039
(get past histogram presubmit warning)
NOTRY=true

Review URL: https://codereview.chromium.org/997183005

Cr-Commit-Position: refs/heads/master@{#321381}

Revert of Add RoutingIDIssuer to help track routing id issues. (patchset #4 id:60001 of https://codereview.chromium.org/999193003/)

Reason for revert:
We've already collected enough data to triage this bug.

Original issue's description:
> This is a re-land of https://codereview.chromium.org/643733002.
>
> This CL adds a RoutingIDIssuer that verifies that the routing IDs are being sent to the correct process.
>
> BUG=464633
> TBR=sky@chromium.org
>
> Committed: https://crrev.com/5ae65efdfd51de794fb544195fad271dd90ff0b1
> Cr-Commit-Position: refs/heads/master@{#320207}

TBR=nasko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464633

Review URL: https://codereview.chromium.org/1019913002

Cr-Commit-Position: refs/heads/master@{#321380}

Revert of Disable gpu_perftests on android. (patchset #1 id:1 of https://codereview.chromium.org/1014573007/)

Reason for revert:
Fixed already!

Original issue's description:
> Disable gpu_perftests on android.
>
> Failing on Nexus 4/5/7v2 and MotoE.
>
> TBR=dcastagna
> BUG=464373
>
> Committed: https://crrev.com/cbcf11d9fa9fd06dd81dd3faf7f69a0e8f54e54f
> Cr-Commit-Position: refs/heads/master@{#321367}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464373

Review URL: https://codereview.chromium.org/1016433004

Cr-Commit-Position: refs/heads/master@{#321379}

This CL should make IsRepeated more robust for a code that needs to create KeyEvent from native code, like key rewriter, or https://codereview.chromium.org/1013003002/

BUG=468442
TEST=covered by test, and also tested manually.

Review URL: https://codereview.chromium.org/1017323002

Cr-Commit-Position: refs/heads/master@{#321378}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/732bda7..2960bec

TBR=pilgrim@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1010433005

Cr-Commit-Position: refs/heads/master@{#321377}

This refactor removed a lot of unnecessary repeated code. The other guestview types (that currently do not have attributes modules) will be refactored to use guest_view_attributes as well in a subsequent patch.

BUG=466215

Review URL: https://codereview.chromium.org/1017863007

Cr-Commit-Position: refs/heads/master@{#321376}

This CL enables the WebNavigationApiTest.CrossProcess test, but disables
the crossProcessWithSameSiteCommit subtest, since it is flaky due to
imprecise ordering of navigation events.

BUG=467800

Review URL: https://codereview.chromium.org/1019133002

Cr-Commit-Position: refs/heads/master@{#321375}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/effcba4..647211f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1019243003

Cr-Commit-Position: refs/heads/master@{#321374}

BUG=468270

Review URL: https://codereview.chromium.org/1006173004

Cr-Commit-Position: refs/heads/master@{#321373}

The extra fields in DisplayState were only used internally and we don't
need to keep track of them. We can simply compute them when performing
the display configuration.

This is a refactor, no functional change intended.

BUG=none

Review URL: https://codereview.chromium.org/1019623002

Cr-Commit-Position: refs/heads/master@{#321372}

This variable isn't supported any longer.

BUG=446865

Review URL: https://codereview.chromium.org/1008023002

Cr-Commit-Position: refs/heads/master@{#321371}

BUG=467918

Review URL: https://codereview.chromium.org/1015333002

Cr-Commit-Position: refs/heads/master@{#321370}

R=inferno@chromium.org,tsepez@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/1000373004

Cr-Commit-Position: refs/heads/master@{#321369}

This introduces the MemoryAllocatorDump which defines the ground data
model that every allocator MemoryDumpProvider must comply with in order
to get a coherent snapshot of the various allocators inside the trace.
Furthermore, MemoryDumpProvider(s) can specify further attributes that
will be attached to each dump point using the MemoryAllocatorAttributes
map.

BUG=466141

Review URL: https://codereview.chromium.org/987043003

Cr-Commit-Position: refs/heads/master@{#321368}

Failing on Nexus 4/5/7v2 and MotoE.

TBR=dcastagna
BUG=464373

Review URL: https://codereview.chromium.org/1014573007

Cr-Commit-Position: refs/heads/master@{#321367}

BUG=440843

Review URL: https://codereview.chromium.org/1019033003

Cr-Commit-Position: refs/heads/master@{#321366}

The fake device used to just CHECK when it failed to read the file,
but I noticed those checks don't make it into the logs for official
builds. This makes the --use-file-for-fake-audio-capture flag a bit
user-hostile, which has also shown up in Chrome crash reports. This
way there will be an entry in the log and the device will be silent
instead of crashing.

BUG=466408

Review URL: https://codereview.chromium.org/1018293002

Cr-Commit-Position: refs/heads/master@{#321365}

This reverts commit b55be9ed.

This broke layout of the filter box in the events tab.

Reverted CL description:

The problem:

1. Initially all the tabs are visible
2. A layout happens
3. index.js is run and it sets all the tabs to display: none
This results in the flickering.

By initially giving div main-tab-contents the style display: none and
removing that in initTabs_() we can prevent the flickering.

BUG=466068
Committed: https://crrev.com/b55be9ede35c10a2623c3c348768db92069d7f10
Cr-Commit-Position: refs/heads/master@{#320264}

TBR=eroman@chromium.org, alexclarke1@chromium.org

Review URL: https://codereview.chromium.org/1019303002

Cr-Commit-Position: refs/heads/master@{#321364}

This patch adds a "Second batch JS" benchmark and a code generator for
creating synthetic Javascript content for the different variants of the
benchmark.

The benchmark flow is:

1. Load an initial page quickly. We also start a continuous animation
   which gauges the responsiveness of the main thread.
2. Start loading Javascript asynchronously.
3. When the loading completes, wait 1 second and click on a button
   which causes about 5% of the Javascript to execute.

The aim is to keep the page responsive during loading and minimize the
latency of the click handler. There are three variants with a small (15K),
medium (150K) and large (1.2M) amount of Javascript.

The generated Javascript consists of half top-level closures, half top-level
functions, each of which calls a varying number of inner functions to
perform arithmetic.

Note that currently the benchmark only measures the responsiveness of the
click handler, but eventually it will be able to track this over the entire
interaction flow (crbug.com/460206).

BUG=428350
R=rmcilroy@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/b0a90f4b6c81fc65dd0c57ebc00b0ba6fe784b22

Review URL: https://codereview.chromium.org/1000203002

Cr-Commit-Position: refs/heads/master@{#321363}

The test is flaky.

BUG=468753
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1018343002

Cr-Commit-Position: refs/heads/master@{#321362}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1a5041e..effcba4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1019463004

Cr-Commit-Position: refs/heads/master@{#321361}

This will only land after a corresponding change in CQ will land.

R=phajdan.jr@chromium.org
BUG=408675

Review URL: https://codereview.chromium.org/1007323004

Cr-Commit-Position: refs/heads/master@{#321360}

These browser tests verify that we can load notification icons from
data: URLs and blobs when displaying Web Notifications.

R=johnme@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1019803002

Cr-Commit-Position: refs/heads/master@{#321359}

Redesign of MD introduce strange tabfocus behavior around searchBox. This patch fixes it.

BUG=467872
TEST=browsertets pass

Review URL: https://codereview.chromium.org/1017863005

Cr-Commit-Position: refs/heads/master@{#321358}

It's no longer necessary. And the handler is fired unexpected timing after unminimized and causes the issue (see the issue for detail). This patch removes it.

BUG=462065
TEST=browsertest passes

Review URL: https://codereview.chromium.org/1018953002

Cr-Commit-Position: refs/heads/master@{#321357}