- 03 May, 2018 15 commits
-
-
Mark Pilgrim authored
Bug: 714018 Change-Id: I4c0c9935a6c2864717eb9a0f995591d85e3d2a15 Reviewed-on: https://chromium-review.googlesource.com/1039947 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555629}
-
Victor Vasiliev authored
Merge internal change: 194843554 R=rch@chromium.org Change-Id: Ia7c236db9045f3ea59df088b0f18d3717dbc32cc Reviewed-on: https://chromium-review.googlesource.com/1038023Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#555628}
-
Joel Einbinder authored
This was attempted before, but the ExecutionContextChanged event is actually for when the name of an execution context changes, not for when a new one is selected by the user (or the page is reloaded). Also added a safety clear on DebuggerResumed Change-Id: I4c9360139fe90beee2fa3d8a82317fc3aed1e6ae Reviewed-on: https://chromium-review.googlesource.com/1040906Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#555627}
-
Alexey Kozyatinskiy authored
Some source map does not contain entry exactly at the end of the line, so our frontend fails to find a mapping and ignores current line. This CL tunes sourcemap to return last mapping in the line if there is no mapping with offset greater then passed column. R=dgozman@chromium.org Bug: chromium:836440 Change-Id: I0da57992ca2c94101084aef2ed21c5b5ba6edc0a Reviewed-on: https://chromium-review.googlesource.com/1028510 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL adds a null check to BrowserActionsContainer::Layout() and updates browser_non_client_frame_view_ash_browsertest.cc to cover --top-chrome-md=material-refresh. The existing HostedAppNonClientFrameViewAshTest.BrowserActions test catches this crash with the material-refresh flag enabled. Bug: 838581 Change-Id: I263b3cd3551a3171f5acc010c1c99f0daef47998 Reviewed-on: https://chromium-review.googlesource.com/1039209Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555625}
-
Tarun Bansal authored
This does not affect OFFLINE preview type. Change-Id: Ia7dbec31a7eb1434fc1b46bc6895eab5d32f9086 Bug: 838969 Reviewed-on: https://chromium-review.googlesource.com/1039160 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555624}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/90864a21c4ab..0caef298c2ff $ git log 90864a21c..0caef298c --date=short --no-merges --format='%ad %ae %s' 2018-05-02 liyuqian Let each threaded device in the ThreadSink own its SkExecutor 2018-05-02 egdaniel Add internal grsurface flag to track if using gl rectangle or external texture. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I87cb60797b453af519fa18b8d3c2369232bb9432 Reviewed-on: https://chromium-review.googlesource.com/1041066 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555623}
-
Xiangjun Zhang authored
Add MessageDispatcher to handle sending/receiving cast messages. Bug: 734672 Change-Id: I1941ba72107b4629da8c47f0b726484d800b2891 Reviewed-on: https://chromium-review.googlesource.com/1008729 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555622}
-
Fredrik Hubinette authored
For unknown reasons, IMFTransform::ProcessOutput sometimes return E_FAIL. It seems that in most of those cases, we can still keep playing the video. A previous CL changed all unknown errors from IMFTransform::Processoutput to be reported back as decode errors, this CL makes an exception for E_FAIL. Bug: 839057 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4b3edb118728347da7cf5364cbcec8b9b7d8b03b Reviewed-on: https://chromium-review.googlesource.com/1038643 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555621}
-
Noel Gordon authored
Add comment about class DriveTestVolume pointer member ownership (none are owned). Initialize these members. Add EXPECT cases when creating the test Drive integration service. Use nullptr in place of NULL. Covered by existing tests: Transfer/FileManagerBrowserTest.Test* Bug: 833834 Change-Id: I04d132e36d8293627f388469138ee7c58e453538 Reviewed-on: https://chromium-review.googlesource.com/1039211 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#555620}
-
Joel Hockey authored
Bug: 834103 Change-Id: Ib4fd72617f0648e99de0f6f84c03b1b65498e978 Reviewed-on: https://chromium-review.googlesource.com/1039109Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#555619}
-
Evan Stade authored
Bug: 834092 Change-Id: I0676206a08de89cb6f4a8d0884228357b9576d60 Reviewed-on: https://chromium-review.googlesource.com/1028982Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555618}
-
Scott Chen authored
this CL adds styling to make cr-checkbox looks like the md-refresh mock. Also added a slot to cr-checkbox for allowing labels. Also replaced one checkbox in reset-profile-dialog as a pilot demo. There will be a follow-up CL to replace all paper-checkbox to cr-checkbox. Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia55925bc91c95407abe5b775758f1b9b4ef97b05 Reviewed-on: https://chromium-review.googlesource.com/1033346 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555617}
-
Jinsuk Kim authored
https://goo.gl/AgkxzN caused a bug of omnibox not disappearing when a new page is opened from NTP. The change missed setting control bar height in such case. This CL fixes it by removing the check for native page which is not necessary. Bug: 837791 Change-Id: I84a9e5324280d6ca161bb8f99c51fb93baa0ca80 Reviewed-on: https://chromium-review.googlesource.com/1034051Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#555616}
-
John Budorick authored
Bug: 731426,826895 Change-Id: Ia71d026639c2138770ca80461a32c77bee737d0a Reviewed-on: https://chromium-review.googlesource.com/1040285Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555615}
-
- 02 May, 2018 25 commits
-
-
Bret Sepulveda authored
This updates MdTextButton to draw 32dips high and with 4dip corner radii when refresh is on. Also updates LayoutProvider:: GetControlHeightForFont even though it's not used by MdTextButton, to avoid the two getting out of sync. Also moves empahsis methods to LayoutProvider so that general views code can access them. Bug: 822073 Change-Id: Ia3038ccafdddd79ca42837dc1de4f726894377e2 Reviewed-on: https://chromium-review.googlesource.com/1031551 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Previously, the drag threshold calculation had a bug. The last-click event was stored as a root_location, which was tested against the drag event's location relative to the View origin. This CL makes both the stored last-click and the current drag event use the root_location. Using root_location is most robust, since the View itself can move in response to edit-in-progress state. It also updates the API of textfield to make more explicit that the stored last click location is a root_location rather than relative to the position of the View. This CL also adds a test. Bug: 838830, 797354 Change-Id: Iedff486a3c6e842bc5c87c6fd597e1faf7a2930d Reviewed-on: https://chromium-review.googlesource.com/1040347 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555613}
-
Sergey Volk authored
Earlier CL https://codereview.chromium.org/2518403004 replaced most of __FUNCTION__ usage with __func__. But a few more places used it since then. Let's replace those as well. Bug: none Change-Id: Ieef098e9e4061c9261f9d044b82c5fd71ad81918 Reviewed-on: https://chromium-review.googlesource.com/1040771Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#555612}
-
https://webrtc.googlesource.com/src.git/+log/c3d8bb1c522d..219958059034 $ git log c3d8bb1c5..219958059 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:752720 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib4c32b2a27f0c4f4effd47b6b14888408b2973c6 Reviewed-on: https://chromium-review.googlesource.com/1040740Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555611}
-
Mounir Lamouri authored
This adds a virtual/video-surface-layer/ that runs with the feature enabled and uses a flag to properly do pixel comparison using browser compositor in addition of the renderer compositor. Bug: 838128 Change-Id: I2bd7306b156b1e49e1404f5f3b3803b8e6771d4b Reviewed-on: https://chromium-review.googlesource.com/1034289 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#555610}
-
Joel Einbinder authored
* Enter accepts the current suggestion in the console. * History suggestions are not auto-selected. The user must use the arrow keys or manually click to select them now. Previously we worried about that the user would accidentally select a suggestion in the console when they actually wanted to run the command as is. Due to recent improvements in autocomplete, this is less of a problem. Autocomplete showing up on an already complete expression should be extremely rare. The only exception is history completions, which are no longer autoselected. Change-Id: Id9d567ae69f4c29c63e875a1f3285448adbd7ce3 Reviewed-on: https://chromium-review.googlesource.com/1026838Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id4966159c87aa8ac29090e97ba437a10874007ef Reviewed-on: https://chromium-review.googlesource.com/1041135Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#555608}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9533249349a7..456cff40ed21 $ git log 953324934..456cff40e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I995ac137cf6887870b962ed51efeff36d39d955f Reviewed-on: https://chromium-review.googlesource.com/1040910Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555607}
-
Fredrik Hubinette authored
Also fixes the logic. Before it the code would default to rec601, and because of a bug it would *always* use the default. Now it defaults to rec709, unless rec601 is specified. Bug: 754986 Change-Id: I94773a3bf0dfeae18e6a2ee8bc36ca884ba590b5 Reviewed-on: https://chromium-review.googlesource.com/998842 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#555606}
-
Matt Reynolds authored
Several fields of the blink::Gamepad object are only modified when the device is first connected. This is done under the assumption that these device properties cannot change while the device is connected. However, in some cases we expose a gamepad to a page before we have determined the haptic capabilities of the gamepad. Once the capabilities are known, the gamepad object is updated but the new value is not propagated. Instead, the page still sees the null value. This changes the vibrationActuator caching behavior to allow a one-time update from null to non-null after the gamepad is initially connected. BUG=749295 Change-Id: I45eb23a02a26681617d9e0f769c01acfaed21135 Reviewed-on: https://chromium-review.googlesource.com/952221Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#555605}
-
Joel Einbinder authored
It makes more sense for the filesystem icon to show the file path, and for the file tab itself to continue to refer to the network URL. Change-Id: I1e5c4fce1733efe841ad6912b17905f49b959071 Reviewed-on: https://chromium-review.googlesource.com/1040825Reviewed-by:
-
Nick Harper authored
This change includes defaulting Channel ID to be off in //net, with it being turned on via the network session configurator. The network session configurator enables Channel ID if the base::Feature is enabled, which it currently defaults to be enabled. This also makes some changes so that when both Channel ID and Token Binding are disabled, there will be no ChannelIDService exposed that can be used by the extension API that provides Channel ID information. Design doc: https://docs.google.com/document/d/1phCknRCnrad7M4cgGusLpKz5A1lLzq0oShahlMgY29Q/edit Change-Id: Iff3cee901e5b13d4c6b10c7636a89b138ce74b78 Reviewed-on: https://chromium-review.googlesource.com/1026630 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#555603}
-
Hirokazu Honda authored
BUG=None TEST=None Change-Id: Idead4ef4897465c6e9950cac26859d548b326289 Reviewed-on: https://chromium-review.googlesource.com/1039111Reviewed-by:
-
Bailey Forrest authored
- Automatically deduce WriteType based on properties - Set initial connected State on RemoteDevice BUG=internal b/75967216 TEST=cast_bluetooth_unittests. Manual Change-Id: I7b06f2cfaae180b4e76322675a02712fdff69d04 Reviewed-on: https://chromium-review.googlesource.com/1038754 Commit-Queue: Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555601}
-
Joshua Bell authored
Chrome has a "should remain available" disk space threshold; when less than this amount is free, the effective quota for each origin drops to 0 so new writes will fail. This is present to avoid Chrome being responsible for filling the disk which generally makes devices unhappy. Similarly, Chrome has a "must remain available" threshold at which point data starts being evicted - keeping the device functional, but potentially losing user data. In r538818 and r539735 in M66 the thresholds were changed from 10% and 1% to a fixed 2GB and 1GB respectively, to reduce the amount reserved on high-end devices - 10% of a 1TB machine is a lot! But this did not account for the impact on low end devices, e.g. 16GB or even 8GB, where the reserve substantially increased, reducing the usability of Chrome. Change the algorithm to use min(fixed, ratio) where fixed values remain 2GB/1GB and the ratios revert back to 10%/1%, restoring the previous availability on storage on low end devices. Bug: 838816 Change-Id: I7d60ae614d6be7a99cfaaa29f2aac9ce25ce861e Reviewed-on: https://chromium-review.googlesource.com/1039879 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#555600}
-
Zhiling Huang authored
Bug: 837790 Change-Id: I8d1b8d1bebea194021d4473a960fdf7529e5e571 Reviewed-on: https://chromium-review.googlesource.com/1040774Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#555599}
-
Xiaohan Wang authored
interface supported by ClearKeyCdm. Widevine EncryptedMediaTest will keep using CDM_9 for now until a newer CDM using CDM_10 is checked in. ECKEncryptedMediaTest will still cover CDM_9, CDM_10 and CDM_11. Bug: 733821 Test: The ExternalClearKey EncryptedMediaTest will start to use CDM_10 Change-Id: Ifa822d0d9c0ff73ec27313d596649f5953b4a91a Reviewed-on: https://chromium-review.googlesource.com/1023171 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555598}
-
Shimi Zhang authored
Previously we have a reflection check for not delaying onCreateInputConnection() for |ThreadedInputConnectionProxyView| and |TestInputMethodeManagerWrapper|. we replaced this reflection by setting a flag from caller directly and calls onCreateInputConnection(), and then reset the flag after. Bug: 636474 Change-Id: I7563f38d333a32ea9ccddec69446d1758275300f Reviewed-on: https://chromium-review.googlesource.com/1038793 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555597}
-
Rayan Kanso authored
Getting this data will require a service worker storage query when we move to full persistent storage. It's easier to get the number by passing down the value to the controller object. Bug: 826257 Change-Id: I00962c1b31c8768baea276ea9d2845b84b2cc506 Reviewed-on: https://chromium-review.googlesource.com/1030632 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555596}
-
Matthew Jones authored
This reverts commit 480d1516. Reason for revert: Suspected cause of Nougat Phone Tester failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6164 Original change's description: > Scroll support for hosted dialogs in VR > > Now that VR supports html <select>, we should send scroll events > to dialogs. > > Bug: 836292 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr > Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288 > Reviewed-on: https://chromium-review.googlesource.com/1028584 > Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555454} TBR=vollick@chromium.org,bshe@chromium.org,asimjour@chromium.org Change-Id: I09843e204345ef1d42a17320e5bc05c386fc8eaa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836292 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1041048Reviewed-by:
-
Xiaocheng Hu authored
The above mentioned function uses parameter as iteration runner. This patch improves it by using a separate runner variable. Change-Id: I856dda5903d994468e5020b4f6d061f7c00c1003 Reviewed-on: https://chromium-review.googlesource.com/1031673 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555594}
-
James Hawkins authored
This is actually the count of enabled devices, not eligible devices. The existing metric, EligibleDevicesCount, will be logged to in a follow-up CL. R=hansberry@chromium.org Bug: 831371 Test: none Change-Id: I38e8a57678f8a9b9d9c23186431147b0961fad43 Reviewed-on: https://chromium-review.googlesource.com/1031182 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#555593}
-
Alex Moshchuk authored
Previously, DidCommitProvisionalLoad dropped commits when either the frame was in pending delete state or when the tab was being closed. The latter case proved to be problematic: if the tab was closed just before a commit from a speculative RFH, the speculative RFH was left hanging around in speculative state. This meant that any subsequent IPCs sent to that RFH before the tab closed would be coming from the renderer process where the navigation had already committed, yet would be processed by a still-speculative RFH. One concrete problem this caused was a renderer kill 4 in OnForwardResourceTimingToParent, where we've assumed that the proxy for the frame in the parent's SiteInstance should always exist, but in this case it won't exist because it should've been created in SwapOutOldFrame() as part of the commit that was dropped. To fix this, this CL allows navigations from non-pending-delete RFHs to commit even when the tab is being closed, so that subsequent IPCs won't see the RFH in a weird state. Bug: 805705 Change-Id: I74f96b63f4fcd2f8c71ecfac8037ccfa3959892f Reviewed-on: https://chromium-review.googlesource.com/1040542 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555592}
-
rbpotter authored
PrinterListCloudEmpty became a duplicate of PrinterList when the separate cloud printers list was removed from the destinations dialog. Bug: None Change-Id: Id70008da998d0e9e509e46b19d00ba6dc776fea3 Reviewed-on: https://chromium-review.googlesource.com/1040541Reviewed-by:
-
Mark Pilgrim authored
Bug: 773295 Change-Id: Iab242c8f235ee2f60ee511d9843d4d259b4e2dcc Reviewed-on: https://chromium-review.googlesource.com/1035543Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
