- 28 Nov, 2018 40 commits
-
-
Dave Tapuska authored
Type was a char but should be a char[] BUG=909692 Change-Id: I2151ab95a0ec0bbefd913f32de1b3e4d51cce6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1354058Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611694}
-
Antonio Gomes authored
Note that the CL is able to use gaia IDs from AccountInfo, rather than hardcode them. BUG=903878 Change-Id: I03dd2f0bd271e969be00aa23005a6bd8960062e0 Reviewed-on: https://chromium-review.googlesource.com/c/1351157 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611693}
-
Shawn Gallea authored
Change OnDisplayMetricsChanged to create new ManagedDisplayInfo for display if OnDisplayAdded was never called for the display. This is needed for the initial display on cast. Bug: 896710 Test: None Change-Id: I3b7d4829874b61b2115d25071a0de7bb74dba246 Reviewed-on: https://chromium-review.googlesource.com/c/1329859 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611692}
-
Victor Vasiliev authored
Merge internal change: 223015666 Merge internal change: 223024889 Merge internal change: 223044144 R=rch@chromium.org Change-Id: I83e3a5662499e716bd02698fd95488edc14593b3 Reviewed-on: https://chromium-review.googlesource.com/c/1351102 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#611691}
-
Luke Zielinski authored
This is in preparation for supporting manual interactions on testdriver. By setting this field to true, unimplemented APIs will fail early rather than waiting for user input (and timing out). https://github.com/web-platform-tests/wpt/pull/11173 Change-Id: Ie409b683755358fb7978989bf3894e7b45b05239 Reviewed-on: https://chromium-review.googlesource.com/c/1352571 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#611690}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I6d254d90004514c867f66f3f49465a25c717a212 Reviewed-on: https://chromium-review.googlesource.com/c/1352754Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611689}
-
Tanja Gornak authored
Bug: 903276 Change-Id: Id679d9ae73535fa4f5f168c2745cdd65991c66cc Reviewed-on: https://chromium-review.googlesource.com/c/1352311 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#611688}
-
Etienne Pierre-Doray authored
Reland "[TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc" This is a reland of 50b50793 This CL changes ScopedAllowBaseSyncPrimitives to ScopedAllowBaseSyncPrimitivesOutsideBlockingScope in StackSamplingProfiler. Original change's description: > [TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc > > base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more > explicit counterpart. > > It should have been replaced by : > * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. > * base::ScopedAllowSyncPrimitives in non-test files > * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads > that don't allow blocking > The last one is strongly frowned upon but this CL aims to document existing > behavior rather than address it. Owners are encouraged to follow-up by fixing > unnecessary waits and more particularly unnecessary waits > outside-blocking-scope. > > Note: The non-for-testing versions require friend'ing in thread_restrictions.h > but care was taken to add these friends ahead of git cl split (since it wasn't > possible to do a line-by-line associated CL split). > Refer to the top-level CL if necessary : > https://chromium-review.googlesource.com/c/chromium/src/+/1288533 > > Please CQ if LGTY! > > This CL was uploaded by git cl split. > > R=wittman@chromium.org > > Bug: 766678 > Change-Id: I2c45612b77a49ca5720da95093b0cdd8845b6f03 > Reviewed-on: https://chromium-review.googlesource.com/c/1325191 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606478} Bug: 766678, 907177 Change-Id: I45b48e57040721e5ff3c2bdaac62237ed7ae429e Reviewed-on: https://chromium-review.googlesource.com/c/1349633Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#611687}
-
Hans Wennborg authored
The code previously looked like this: #if defined(COMPILER_GCC) && defined(_FORTIFY_SOURCE) if (!__builtin_constant_p(dst_end - dst) || (!(dst_end - dst))) memset(dst, val, dst_end - dst); #else memset(dst, val, dst_end - dst); #endif The #ifdef was added a long time ago, in http://crrev.com/7728f5076b20 with the motivation: > There is a warning in memset in glibc that gets triggered through a > warndecl when the fill-value of memset is a non-zero constant and the > size is zero. This warning is enabled when building with > -D_FORTIFY_SOURCE=2. This patch fixes the warning. The idea was presumably to skip the memset if the size is a constant zero. However, that's not what the code is doing. It's skipping the memset if the size is constant *non-zero*. How did this ever work? I don't know about GCC, but until recently, Clang would not return true for the __builtin_constant_p expression, so the memset would always run. However, Clang gained support for this in r347417, and now webkit_unittests started failing in builds that use FORTIFY_SOURCE. The desired code would be: if (!__builtin_constant_p(dst_end - dst) || (dst_end - dst != 0)) memset(dst, val, dst_end - dst); But since I couldn't reproduce any warning about memset getting called with zero size, I think it's better to drop the whole thing and simplify the code. Bug: 908372 Change-Id: I166b88af27ca8beacba746892d5fde09ecf1c326 Reviewed-on: https://chromium-review.googlesource.com/c/1352363 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611686}
-
Georges Khalil authored
This patch adds the serial number to base::SysInfo::HardwareInfo on Windows only, where it represents the BIOS serial number. This is grabbed through a WMI call. Other platforms will follow. Bug: 907518 Change-Id: I1b2b23c00cda286f325a0a09722dbfc5e974eb77 Reviewed-on: https://chromium-review.googlesource.com/c/1346869Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#611685}
-
Tim Schumann authored
According to the flakiness dashboard it got flaky on all platforms except Mac. TBR=lazyboy@chromium.org Bug: 909570 Change-Id: I404a5d2ba392aa521fdf99c6892580f208086775 Reviewed-on: https://chromium-review.googlesource.com/c/1352193Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611684}
-
Gauthier Ambard authored
This CL moves the existing AutofillDataItem to legacy and creates a new item compatible with UITableView. Bug: 894791 Change-Id: Id3d7af497b08e99d8977e2f77385ea5e55f5c22b Reviewed-on: https://chromium-review.googlesource.com/c/1350953 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611683}
-
Saman Sami authored
Bug: 907720 Change-Id: Id3ec824af0023ba9fa4bb053717741c345c15b45 Reviewed-on: https://chromium-review.googlesource.com/c/1352052Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#611682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af0c7c5e6e24..f16618125056 git log af0c7c5e6e24..f16618125056 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 primiano@google.com Merge "Add support for periodic flushes" Created with: gclient setdep -r src/third_party/perfetto@f16618125056 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I69643914963df59545d102d6588dd694fe6df37b Reviewed-on: https://chromium-review.googlesource.com/c/1351486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611681}
-
Tim Schumann authored
TBR=yosin@chromium.org Bug: 909694 Change-Id: Ie6fd36ef024ce524152d5b718fbbc848b1735f05 Reviewed-on: https://chromium-review.googlesource.com/c/1353958 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
David Jean authored
This is a reland of 30e1dd18 Adding feature flags to slimnav. Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970 Original change's description: > [ios] add credit card test for manual fallback > > Also adds AutofillManualFallbackPhaseTwo to test bots. > > Bug: 845472 > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d > Reviewed-on: https://chromium-review.googlesource.com/c/1337347 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: David Jean <djean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611171} TBR=rohitrao@chromium.org Bug: 845472,908970 Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29 Reviewed-on: https://chromium-review.googlesource.com/c/1352328 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611679}
-
David Jean authored
So the user doesn’t unlock a card through CVC just to be told that it cannot be injected in current field. Bug: 908789 Change-Id: Ie255d36f794c94d90b0fd1e01bf80d608ef757f6 Reviewed-on: https://chromium-review.googlesource.com/c/1352759 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80526a9b..94c524df Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59aac4c65547d1d8876347797ae400dff8a512e2 Reviewed-on: https://chromium-review.googlesource.com/c/1352984Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611677}
-
Gauthier Ambard authored
This CL makes sure that the animation when the Switch to Open Tab button is used is only triggered when the TabStrip isn't shown. Bug: 908875,908876,908878 Change-Id: I04f4f71ca2a78c62fa99a860aa0baa8fdf012290 Reviewed-on: https://chromium-review.googlesource.com/c/1352787Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#611676}
-
Gauthier Ambard authored
This CL adds support for Dynamic Type in the AutofillEditItem. Bug: 894791 Change-Id: I1e25084fed4cb176b332fc7fa7e4af0e7957323c Reviewed-on: https://chromium-review.googlesource.com/c/1346454 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Stephen McGruer authored
The initial implementation of this histogram used 0 as the default setting. This will incorrectly count cases where the flag is missing as 'animation disabled'. This CL fixes this by splitting the default case into its own enum. In order to preserve correct data, the old histogram is obsoleted and a new histogram is created. Bug: 722548 Change-Id: I031ca38cf70ddc8b51c9a150f31e25a305b9fc7a Reviewed-on: https://chromium-review.googlesource.com/c/1351273Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611674}
-
Keishi Hattori authored
Convert T*, U* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: Ib5c347738f538b42019314a7e2ce65b230d840e2 Reviewed-on: https://chromium-review.googlesource.com/c/1352073 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9e2ac7b3cbb..62103075707c Created with: gclient setdep -r src-internal@62103075707c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia1987b77d0f28f5887be1f88625e3de808f6c847 Reviewed-on: https://chromium-review.googlesource.com/c/1352502Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611672}
-
Denis Kuznetsov authored
TBR: alemate@chromium.org Bug: 854101 Change-Id: I0119223034d6399dfd6fd50d3fb0e4821c356f65 Reviewed-on: https://chromium-review.googlesource.com/c/1243195 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#611671}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cf714a81c86e..596d6fe00db7 git log cf714a81c86e..596d6fe00db7 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 cwallez@chromium.org Result: Fix documentation and a typo Created with: gclient setdep -r src/third_party/dawn@596d6fe00db7 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iefbca39f6f500032f47b95bd5d0e051e887c24a2 Reviewed-on: https://chromium-review.googlesource.com/c/1352501Reviewed-by:
-
Tim Volodine authored
The AwSettingsTest.testCacheMode is now passing due to: https://chromium-review.googlesource.com/c/chromium/src/+/1339720 BUG=893570,841556 TBR=ntfschr@chromium.org,cduvall@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Icd210dcfaf8d5830f1128834e3ea16d58c179569 Reviewed-on: https://chromium-review.googlesource.com/c/1352786 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611669}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff43a0af6b51..e9e2ac7b3cbb Created with: gclient setdep -r src-internal@e9e2ac7b3cbb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id63d991882e94ca5b1bf999fa9bafd000f8d7b2e Reviewed-on: https://chromium-review.googlesource.com/c/1352499Reviewed-by:
-
Tim Schumann authored
Examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73206 A similar treatment fixed a problem when interacting with the BrowserAccessibilityComWin object for content/browser/accessibility/browser_accessibility_unittest.cc browser_accessibility_win_unittest.cc is facing problems with accessing invalid memory and also interacting with BrowserAccessibilityComWin -- there's a chance these problems are related. Error message: Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: RtlInitUnicodeString [0x77DEE41B+499] RtlFreeHeap [0x77DEE023+126] free_base [0x737CDCF7+39] calloc_base [0x737CAF0B+2875] free_dbg [0x737CD6DC+124] free [0x737CDCA0+32] uprv_free_63 [0x731F1900+80] icu_63::UnicodeSet::releasePattern [0x732C2067+39] icu_63::UnicodeSet::~UnicodeSet [0x732C2026+230] icu_63::UnicodeSet::`scalar deleting destructor' [0x732C11B5+37] std::default_delete<icu_63::UnicodeSet>::operator() [0x725F76C4+52] std::unique_ptr<icu_63::UnicodeSet,std::default_delete<icu_63::UnicodeSet> >::~unique_ptr<icu_63::UnicodeSet,std::default_delete<icu_63::UnicodeSet> > [0x725F763D+61] base::subtle::NoBarrier_Load [0x725F75EB+59] base::subtle::Acquire_Load [0x725F7593+67] base::i18n::NormalizeFileNameEncoding [0x725F7512+818] base::internal::FunctorTraits<void (__cdecl*)(void *),void>::Invoke<void (__cdecl*const &)(void *),void * const &> [0x71605AD7+55] base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*const &)(void *),void * const &> [0x71605A0A+58] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void *),void *>,void __cdecl(void)>::RunImpl<void (__cdecl*const &)(void *),std::tuple<void *> const &,0> [0x716059CA+74] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void *),void *>,void __cdecl(void)>::Run [0x7160587F+63] base::RepeatingCallback<void __cdecl(void)>::Run [0x71601F51+49] base::AtExitManager::ProcessCallbacksNow [0x71601951+337] base::AtExitManager::~AtExitManager [0x716012AB+363] std::default_delete<base::AtExitManager>::operator() [0x050F1AA7+39] std::unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> >::~unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> > [0x050EF57D+61] base::TestSuite::~TestSuite [0x050EF0AB+91] content::ContentTestSuiteBase::~ContentTestSuiteBase [0x050E339F+15] content::ContentTestSuite::~ContentTestSuite [0x050E337E+46] content::ContentTestSuite::`scalar deleting destructor' [0x050E3535+37] std::default_delete<base::TestSuite>::operator() [0x050E3F14+52] std::unique_ptr<base::TestSuite,std::default_delete<base::TestSuite> >::~unique_ptr<base::TestSuite,std::default_delete<base::TestSuite> > [0x050E3C6D+61] content::UnitTestTestSuite::~UnitTestTestSuite [0x050E3B63+115] main [0x050E2B0D+269] invoke_main [0x0510A6DE+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:78) __scrt_common_main_seh [0x0510A841+337] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) __scrt_common_main [0x0510A90D+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326) mainCRTStartup [0x0510A918+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x7783337A+18] RtlInitializeExceptionChain [0x77DF92B2+99] RtlInitializeExceptionChain [0x77DF9285+54] TBR=nektar@chromium.org Bug: 909062 Change-Id: Ic5cb5fc26aed105dfebbffa05be06f822d7d14df Reviewed-on: https://chromium-review.googlesource.com/c/1352130Reviewed-by:
-
Raphael Kubo da Costa authored
This fixes the build with GCC, which was complaining with error messages such as: ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:60:13: error: explicit specialization in non-namespace scope ‘class blink::CallSetupStateTrackerTest’ template <> ^ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:65:13: error: explicit specialization in non-namespace scope ‘class blink::CallSetupStateTrackerTest’ template <> ^ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:66:17: error: ‘blink::AnswererState blink::CallSetupStateTrackerTest::current_state() const’ cannot be overloaded with ‘blink::OffererState blink::CallSetupStateTrackerTest::current_state() const’ AnswererState current_state() const { ^~~~~~~~~~~~~ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:61:16: note: previous declaration ‘blink::OffererState blink::CallSetupStateTrackerTest::current_state() const’ OffererState current_state() const { ^~~~~~~~~~~~~ For current_state(), move the template specializations outside of CallSetupStateTrackerTest. Having them in CallSetupStateTrackerTest officially requires C++17 (specifically, C++ DR727). While clang has implemented DR727 for other -std= options, GCC is stricter and only builds that code in C++17 mode. For NoteStateEvent, drop the template bits altogether: the two NoteStateEvent() functions work as regular overloads and do not need any templates. Bug: 819294 Change-Id: I3f839d9a70670de1f52db14efcbd10b3a199b84e Reviewed-on: https://chromium-review.googlesource.com/c/1352256 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: -
Vaclav Brozek authored
Cleaning TODO(vabr) in the extensions-related code: * removing obsolete ones, and * redirecting others to a bug Bug: 908813, 218451, 121325, 238179 Change-Id: I47fb081201743473d0fdea23bca2a9f5278fa067 Reviewed-on: https://chromium-review.googlesource.com/c/1352162 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#611665}
-
Henrique Grandinetti authored
Bug: 908158 Change-Id: I178b4660b937a675afa865818645af75b2d50cc3 Reviewed-on: https://chromium-review.googlesource.com/c/1349592Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#611664}
-
David Jean authored
Bug: 908776 Change-Id: I14d17f328ae4ebbf158c03a9628c55f7a97f58e8 Reviewed-on: https://chromium-review.googlesource.com/c/1350928 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
This CL rewrites #include lines of web_task_runner.h, which is now deprecated. Instead of web_task_runner.h, new include lines of post_cancellable_task.h and/or post_cross_thread_task.h are inserted, depending on what's used in each file. This CL only touches #include lines and nothing else. Bug: 826203 Change-Id: I931acf1f18af1bc34f4e13b6914f2a054671f1d2 Reviewed-on: https://chromium-review.googlesource.com/c/1351204Reviewed-by:
-
Gauthier Ambard authored
This CL converts the ViewController, keeping the same features. Bug: 894791 Change-Id: I8cd336a878d42d6a69bed10e3b22c56d842e5c0d Reviewed-on: https://chromium-review.googlesource.com/c/1345974 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
David Jean authored
Also refactor gray line separator into cell utils. Change-Id: Ia47aba4717c30510c06979618640967c87fb8f11 Reviewed-on: https://chromium-review.googlesource.com/c/1350913 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Use the MakeGarbageCollected bottleneck to flag objects as being under construction while their constructor is executed. can be recovered once we are done moving to MakeGarbagecollected by opening the scope in the allocator (HoH ctor). Binary-Size: Increase due to adding scope to constructors. Roughly 50% Bug: 843903 Change-Id: I0a5182481534922ba14c6c12ed7138dadbcadea5 Reviewed-on: https://chromium-review.googlesource.com/c/1350128 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611659}
-
Antonio Gomes authored
BUG=907515 Change-Id: I62fc67e47f53306f3dfcbbe2e3dc19383551d98b Reviewed-on: https://chromium-review.googlesource.com/c/1348672Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#611658}
-
Sami Kyostila authored
Bug: 891670 Change-Id: Ief7d0b3902c23b6037867e64bf74e7899c53ab1d Reviewed-on: https://chromium-review.googlesource.com/c/1350829 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab168019..80526a9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4187fc9baf4a616704babac61b75ce810e040ac9 Reviewed-on: https://chromium-review.googlesource.com/c/1352982Reviewed-by:
-
Eric Seckler authored
Adds a new DataSource for the CrOS system tracing agent and enables the corresponding TracingController test on CrOS for perfetto. TBR=oysteine@google.com Bug: 900603 Change-Id: I6652ccedc077f2c036ee5e94b68e725d461e656c Reviewed-on: https://chromium-review.googlesource.com/c/1341835Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#611655}
-
