- 14 Jul, 2020 40 commits
-
-
Jian Li authored
This reverts commit 9819cecd. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/6434 Original change's description: > Avoid testRunner.eventSender in > paint/invalidation/table/table-overflow-scroll-in-overflow-scroll-scrolled.html > > Bug: 1047176 > Change-Id: Iba4344ebc6d44f6e122c3871cb0fee5454553a9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297100 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788218} TBR=wangxianzhu@chromium.org,lanwei@chromium.org Change-Id: I10e2320a515fa2b5162248ac32667b0e1a622077 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298347Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#788374}
-
Sorin Jianu authored
This reverts commit 1d114582. Reason for revert: it is breaking the Android tests https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%209%29/27588 Original change's description: > Fix sequence checker asserts in CrxDownloader. > > The code crashes because there is a race condition between > the main sequence and another task runner when the instances > of the CrxDownloader are destroyed. > > On the main sequence, the CrxDownloader is being used to > download a file, then the reference to this instance > is released. The CrxDownloader is using a task runner > to run a blocking task, which validate the file it has just > downloaded. This task runner receives a closure which holds a > reference to the CrxDownloader. > The reference is released after the task is run, and therefore, > it results in a race when the dtor of CrxDownloader is being > invoked. > > Besides removing the offending sequence checkers of the > destructors of the CrxDownloader classes, this CL changes > where the timer of the BackgroundDownloader is destroyed. > The timer has sequence affinity and it must always > be destroyed on the main sequence. > > Bug: 1105289,1105460 > Change-Id: I78e002502ce6f5501c78d1e849f51b47bf3dc092 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297696 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788330} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: I87c30dbc1542c14e18c69c0806f138508f99bf9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105289, 1105460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298439Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788373}
-
Weilun Shi authored
It moves the implementation part to base/strings/escape and makes functions in net/base/escape as an interface and call the same function in base/strings/escape. This cl also updates callers in net// to use functions in base/strings/escape instead of interfaces in net/base/escape. Callers outside of net// still uses interfaces and they should be migrated in the follow up cl. Bug: 1068052 Change-Id: I6826ac4d132d8e460cfb778255ffac9fb888ecb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275365Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#788372}
-
Sammie Quon authored
See attached bug for screenshots/specs. The first users will be the new desk button and the close desk buttons respectively. This CL is assuming there will be many future buttons converted to this style so it adds two decorator helpers to apply ash styles on ImageButton and LabelButtons. Also modifies GetRippleAttributes to match the spec. Left out adding background blur to the close button for now as it may have a performance impact that may want to be discussed. Also left out the wallpaper updates as depending on the not yet released wallpaper spec may be implemented in a certain way. Test: manual Bug: 1103739 Change-Id: I3e446e627366fd89d67948571aee04de5a2e93c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293576Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#788371}
-
Lukasz Anforowicz authored
Since r774391 the dropped link opens in a new tab (via NavigationPolicy::kNavigationPolicyNewForegroundTab). This means that it doesn't matter which frame is used to initiate the navigation, since the navigation should always translate into an OpenURL with WindowOpenDisposition::NEW_FOREGROUND_TAB and handled in the new window/frame. After this CL, the navigation will be always initiated through the local frame that is handling the dropped URL. This helps avoid RemoteFrame::Navigate which doesn't know how to handle NavigationPolicy. and let's us restore the test asserts in the DragAndDropBrowserTest.DropValidUrlFromOutside test. Fixed: 1087898 Change-Id: Icc6b2d8da37f181a32663917a02850a72d9c5297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290705 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#788370}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic6d2666e7c4f4b0883e6b8749f8769218936bd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298035Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788369}
-
Andrew Comminos authored
Similar to RenderWidgetHostInputEventRouter, attribute touch events to the frame ID that contains the first touch point. Bug: 910421 Change-Id: I6e1671a4133c367d813bf33214b683967b955ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283493Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#788368}
-
Yuri Wiitala authored
Leave all protobuf messages/enums/fields in-place in the protobuf definition, but deprecate them all. Then, remove all C++ code related to DRM. (This is a feature that never launched.) Bug: 1102847 Change-Id: Iae7ce89e35d22e50c1360d2f4618981f8a79e682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285875 Commit-Queue: Yuri Wiitala <miu@chromium.org> Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#788367}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594752201-0c95582c1872e1e49765b4de426f33851485714b.profdata to chrome-mac-master-1594758783-89b5869eda45090ee3c154382bf0c8063de97283.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9509269a478cf8623b266495d4bcfc9478bf8c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298283Reviewed-by:
-
Alex Gough authored
Bug: 1102447 Change-Id: I9f19ff9903a88fa0ff01fa1c7f42e2772e49baa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298039Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#788365}
-
Miguel Casas authored
crrev.com/c/2292813 (in 86.0.4202.0) removed one of the multiple calls to VaapiWrapper::PreSandboxInitialization(), concretely the one in the main() function, leaving only one in the test SetUp() method. This broke the graphics.VAAPIUnittest.* in the CQ eve. This CL fixes that by leaving a single call to said static method, in the main() function. Bug: 1105335, 1040291 Change-Id: I0b1bfa14f8768c6111697f591b0c8ff120c46e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298263 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788364}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iba361e63fcd6d68b4034e7cdac08cc5d17924c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298222Reviewed-by:
-
Sean Topping authored
Introduces a set of mojo APIs for creating Web UI pages in the Cast browser. Clients to the mojom::WebUi interface can provide Web UI resources over IPC, and can also control the Web UI page remotely. Merge-With: eureka-internal/356806 Bug: internal b/147754908 Test: CQ, build/run Chromecast Change-Id: I0671a8477dd41eeec171cf5c4537cfe0c99fc9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042636 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788362}
-
Muyao Xu authored
Bug: 687380, b/154273698 Change-Id: I0b143744da0581abd82251ef001ae02da5d250b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280389 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#788361}
-
Robert Ogden authored
The connect-timing UMA isn't being populated, this is why. Bug: 1105219 Change-Id: Ie59f81dd899e8ec5253b8885397dd6a15a351154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298165Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#788360}
-
Tom Anderson authored
* Remove usage of Xlib from //ui/ozone. Also replace Xlib types with XProto types in function signatures that are used in //ui/ozone. * Rewrite and simplify software non-SHM codepath for drawing images. * Moved PutARGBImage from x11_types.h into x11_util.h and renamed to DrawPixmap since it now takes an SkPixmap. * xcbproto: replaced BYTE with void in PutImage/GetImage so that base::RefCountedMemory can be used. * Got rid of x11_util_internal.h and moved it into x11_util.h. It was originally added to prevent including Xlib.h in x11_util.h, which caused conflicts due to macros, however this no longer appears to be an issue. BUG=1066670 R=nickdiego Change-Id: Ieff52b3748945fbb6a5a42bbd496550ad7862e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285287 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#788359}
-
James Long authored
Vue SFCs (Single File Components) offer many benefits (see website: https://vuejs.org/v2/guide/single-file-components.html). This highly mechanical CL migrates the current Vue components to SFCs by taking the following steps: For each file in src/vue_components: * Rename the file to .vue. * Move the `template` field into a <template/> tag. * Move the imports to the top of a <script/> tag. * Assign the rest of the component to a const in the <script/> tag. * `export default` the previous const at the end of the <script/> tag. Caveat: Sometimes ${} notation was used to insert constants into the template literals. This cannot be done in the <template/> tags, so constants are redeclared as a computed property of the component. For each of the .css files: * If the selector is for part of a component, move it into a scoped <style/> tag in that component. * If the selector is part of a component, but affects a child of that component (eg. autocomplete or d3's auto-generated svg elements), move it into a non-scoped <style/> tag in that component. Bug: 1093962 Change-Id: Id4b6307109cb06bbe195e7ac5668b08782cd487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293180 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#788358}
-
Emily Stark authored
This CL removes the "edit bump" for simplified domain field trials. The edit bump is the tendency of the selection or cursor to move around once you start editing and the URL unelides. We can avoid this in the simplified domain field trials by uneliding to the full URL on hover. This means that most of the time, by the time the user has made a selection, the URL has already been unelided and there is no jump. (Technically it is still possible for the user to select before the animation has finished, resulting in a bump, but the user would have to be rather speedy to do this.) This is implemented by pushing the elision logic from LocationBarModelImpl into OmniboxViewViews (when the field trials are enabled, to avoid introducing any bugs in Chrome's default state). OmniboxViewViews now has the full unelided URL as its display URL, which is what it unelides to on hover. When computing what to elide to, it strips the www subdomain from the host and elides to the result (or to the registrable domain if configured). There is more work to do after this CL for when reveal-on-interaction is enabled. Currently, with this CL and with that flag enabled, we'll unelide and show the full URL on page load (eliding to the simplified domain after interaction). This is a bit of a regression on simplicity/UX; the desired behavior instead is to show the URL with scheme+trivial subdomains elided on page load, and then expand to the full unelided URL if there is a hover before interaction. I'll implement this in a follow-up CL. Bug: 1101486 Change-Id: If7fb9c0418099acdf6016e44171f8a0b3d613a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289218 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#788357}
-
Reilly Grant authored
This change cleans up all the calls to base::Bind() so that they are either base::BindOnce() or base::BindRepeating(). It also catches a few cases where base::BindRepeating() was used when base::BindOnce() would have worked. Bug: 834319 Change-Id: I8d63b425633feed42fdcb2267e2495fede6bb84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298119 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788356}
-
Moe Ahmadi authored
Adds a timing histogram in LocalHistoryZeroSuggestProvider to record the time it takes to query normalized search terms from the keyword search term database and sort them. This is added to identify potential performance regressions for the larger age thresholds for local history zero-suggest. Bug: 1096615 Change-Id: Iaa079cc84a496e1eeeab8138a7d5208118e99bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296344Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Garrett Beaty authored
mac-osxbeta-rel was removed from the branches because it is an FYI builder that is not the mirror of any try builders and is red on the branches so it is a distraction for sheriffs. Removing it from the branches causes 'Mac Builder' to fail on the branches when attempting to trigger it. The no-op scheduler job will allow the trigger to succeed. Bug: 1105569 Change-Id: I219a89c559b06106b75921ba678d2ab9eb69ea06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298168 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#788354}
-
Nico Weber authored
Bug: 1105559 Change-Id: Id5f55eb63b83212ceac0dfbd61c22f42a6ee3d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298181 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#788353}
-
Roger Tawa authored
Bug: 1088131 Change-Id: Ib27159284cdacbd83ff5e240905fd0a94d7a9705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296825Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#788352}
-
Katie D authored
AX-Relnotes: N/A Bug: 1103753 Change-Id: Id84fc1d2166f8c451639dc529ad7df6852cc91af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293000 Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#788351}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68978076fdb7..fad2090a5e81 2020-07-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ied36addf615dd1444752039cbbaef4ea77fe87c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298032Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1068786 Change-Id: I464ecae57cd2e2922bd5e1176e0cea10db4c109c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295999Reviewed-by:
-
Rakib M. Hasan authored
This command line argument will be used to put the wpt_update_expectations.py script into Android mode without having to use the --android-product command line argument. Bug: 1102480 Change-Id: Ia95f7057ee370c03bfc694c1b1e405d891960582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293013Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#788348}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d25eebad303d185dde76679412d2b9a8ddfaea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296896Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:889460,v8:10442 Change-Id: I76c38ecc99e237e72b2be46907e0d4bbeed926ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297960 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#788346}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/91280009..8db0c721 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8466561625c25bf93357cf3b1881124092df392e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298100Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788345}
-
Joel Hockey authored
Fix code to invoke the CrostiniSuccessCallback if there is an error in OnCrostiniRestarted, or if we show the upgrade dialog. In order to handle the callback for the error case and also call LaunchApplication, the code for OnCrostiniRestarted needed to inline into LaunchCrostiniAppImpl. Removed redundant display_scaled param. Bug: 1092657 Change-Id: Id4928ee5e903b1c2297d6b33c4820516644ed0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294938 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#788344}
-
Mary Ruthven authored
This change adds the version strings for 0.5.4, 0.5.5, 0.6.2, 0.6.3, 0.6.4, and 0.6.5. tpm_hash_gen.py was used to generate version strings for all images. It also updates the 0.3.26 and 0.4.26 descriptions to reflect that we rereleased signed with 0.5.0 and 0.6.0. BUG=chromium:728134 TEST=None Change-Id: I7e102ab36f157c64f74b717b7de398aa82a73a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298025Reviewed-by:
-
James Long authored
A webpack config has been added, allowing us to serve the project locally for development and also build it for distribution. CDN-based dependencies have been removed in favor of using Webpack to bundle local ones from NPM. Bug: 1093962 Change-Id: I5a802449ff1d497c72417fb77b8c502e8af0a419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293214 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
-
Sami Kyostila authored
This reverts commit 0daa7a58. Reason for revert: Made angle_perftests start failing: crbug.com/1105609 Original change's description: > Roll ANGLE from e5c184751160 to d98afb787a24 (2 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/e5c184751160..d98afb787a24 > > 2020-07-13 m.maiya@samsung.com Vulkan: Enable VK_KHR_get_memory_requirements2 extension > 2020-07-13 enga@chromium.org Revert "Refactor DisplayGbm::generateConfigs" > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC jonahr@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: chromium:1105208 > Tbr: jonahr@google.com > Change-Id: Ica3ea9561d8d0c52a252a34f26f8d832165aab18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296188 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#788041} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,jonahr@google.com Change-Id: I05a963371e856b93b49e75846e43b9671cb88add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1105208 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297963Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#788341}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594749428-a9bf8891c97f732f274a0fa0ac7b0886b75624ed.profdata to chrome-mac-master-1594752201-0c95582c1872e1e49765b4de426f33851485714b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifc6cea1792b49163e45bcce28ef13d96e1ee679d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298033Reviewed-by:
-
Sebastien Marchand authored
This synthetic Finch trial will allow measuring the impact that the segment heap has on performance. Bug: 1014701 Change-Id: I614f4b94fc11e43878d0d2f16af018490fc170f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283241 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cd0af6456eb1..2490b1ae774d 2020-07-14 capn@google.com Undefine Bool after the headers that define them If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I444eb6b3558a4b6ece8f265acaffb1e4f87d4366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298062Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ec6dea4ea19..dcda36de8344 2020-07-14 brgoddar@microsoft.com Grid Testing: Update Elements Test Runner for new Grid Overlay Testing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I349cd802695b8ffd309f4146ec2e1458c56de628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297733Reviewed-by:
-
Dave Tapuska authored
Guidance is to use the mojo enum types directly. We don't have to triply define this enumeration. BUG=1097816 Change-Id: Icb70b2981cefd15c23eedb1fe4611b0a2f44f75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295679Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#788336}
-
Alex Chau authored
- All nearby code are now under chrome/services/sharing/nearby Change-Id: Ibbf5102f20b86fd12d8f5da25dd071b584fe73c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297645 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#788335}
-
