GitLab

As the H264Accelerator can return a result indicating that additional data
(independently provided) is needed in order to proceed (e.g. a key is
required before the frame can be decrypted), pass the accelerator's result
up to H264Decoder::Decode() so that it can return the appropriate
result to the caller.

This CL also changes Decode() so that subsequent calls (after a
retryable result like kTryAgain or kRanOutOfSurfaces, but not kError)
resume by calling the method that previously failed again. If it
succeeds, then execution resumes from that point.

BUG=837455
TEST=new media_unittests pass

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7fe9a8218df76aee15478d7bbf2ea516d6d2be83
Reviewed-on: https://chromium-review.googlesource.com/1117839
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575754}

This change fixes a bug where shares mounted with a hostname rather than
an ip address are not remounted when a user logs out and back in.

Previously, we were storing the unresolved share_path rather than the
resolved share path that is used to mount the share.

Bug: 863513, 757625
Change-Id: I183200d9193c439f46a1609074706c5b2e2c0355
Reviewed-on: https://chromium-review.googlesource.com/1136863Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575753}

Continuation of work in bug 646094.

Preparing to activate an errorprone check to flag
context#getApplicationContext calls. The goal is to prevent storing the
resulting context as a class property, and instead use ContextUtils.

Bug: 846456
Change-Id: I059c13769179010146530e75b554acc29260abaa
Reviewed-on: https://chromium-review.googlesource.com/1140511Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#575752}

All implementations of this function do the same thing so we can just
call the constructor directly.

Change-Id: I9f1dfb6682302bf6294666895a7ffd2b716c1e58
Reviewed-on: https://chromium-review.googlesource.com/1139226Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575751}

Currently, when SafeBrowsing is disabled, CanSendPing sets the reason
for not sending a ping to "URL_NOT_VALID_FOR_REPUTATION_COMPUTING". This
CL creates a separate reason for SafeBrowsing disabled, for more accurate
reporting.

Bug: 864265
Change-Id: I63318a4c8639af3e564a4cc8e4cb371d091ca87e
Reviewed-on: https://chromium-review.googlesource.com/1139109Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575750}

Add IsPlatformDecoder() API to media::VideoDecoder, and also to
media::AudioDecoder for symmetry. This value will be used by
media::DecoderStream to decide when to fall back to software decode for
low-resolution video.

Bug: 684792
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I778ebdcaa84a9cabfc74be9729969db53b2aad7a
Reviewed-on: https://chromium-review.googlesource.com/1139097
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575749}

Correctly migrate the usages of |net::URLRequestContext| to
|network::SimpleURLLoader| in:

  - Chrome OS Account Manager
  - Chrome OS OAuth Delegate
  - Chrome OS Account Manager's account addition page

This basically reverts (and migrates) parts of
http://crrev.com/c/1091533 and re-lands parts of
http://crrev.com/c/1105777

Bug: 864605, 820046
Change-Id: I921dbb4c5fbf4ea9801d80d20ce1c96718eddc4b
Reviewed-on: https://chromium-review.googlesource.com/1140714Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575748}

This reverts commit 3cf9eadf.

Reason for revert: Will fix errors

Original change's description:
> Revert "Reland "Reland "gtest perf tests: Output well formed test results json"""
>
> This reverts commit 4da4a0c8.
>
> Reason for revert: Failing on mac and windows.  I will add more comments to crbug.com/855234
>
> Original change's description:
> > Reland "Reland "gtest perf tests: Output well formed test results json""
> >
> > This reverts commit 89c5e790.
> >
> > Reason for revert: Testing possible fixes
> >
> > Original change's description:
> > > Revert "Reland "gtest perf tests: Output well formed test results json""
> > >
> > > This reverts commit f02c92e1.
> > >
> > > Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315
> > >
> > > Original change's description:
> > > > Reland "gtest perf tests: Output well formed test results json"
> > > >
> > > > This reverts commit 9eeaba4e.
> > > >
> > > > Reason for revert: Will re-land with fix
> > > >
> > > > Original change's description:
> > > > > Revert "gtest perf tests: Output well formed test results json"
> > > > >
> > > > > This reverts commit 71b865f4.
> > > > >
> > > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307)
> > > > >
> > > > > Original change's description:
> > > > > > gtest perf tests: Output well formed test results json
> > > > > >
> > > > > > This CL changes the run_gtest_perf_test.py script to output well formed
> > > > > > test results json.
> > > > > >
> > > > > > Bug: 855234
> > > > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/1112635
> > > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/master@{#570943}
> > > > >
> > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > > >
> > > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: 855234
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1118238
> > > > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > > > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > > > > Cr-Commit-Position: refs/heads/master@{#571083}
> > > >
> > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > >
> > > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 855234
> > > > Reviewed-on: https://chromium-review.googlesource.com/1118789
> > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#571245}
> > >
> > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > >
> > > Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 855234
> > > Reviewed-on: https://chromium-review.googlesource.com/1119445
> > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#571321}
> >
> > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> >
> > Change-Id: I25bc4bb1f77031d95dd70347bfed886112b76218
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 855234
> > Reviewed-on: https://chromium-review.googlesource.com/1120798
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#571968}
>
> TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
>
> Change-Id: I031c5d6204e0b53fa2719168a38292455d676167
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 855234
> Reviewed-on: https://chromium-review.googlesource.com/1124539
> Reviewed-by: Emily Hanley <eyaich@chromium.org>
> Commit-Queue: Emily Hanley <eyaich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572183}

Change-Id: I6c994148908ed9a223b8b59219b6b4a6957cd9ca
Bug: 855234
Reviewed-on: https://chromium-review.googlesource.com/1125420
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575747}

This makes the detached bookmarks items vertically centered.

Bug: 863697
Change-Id: Icf6529ec0b33255dc8072d5bfacc2f32b0495f93
Reviewed-on: https://chromium-review.googlesource.com/1139191Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575746}

TBR=rockot

Bug: 863166
Change-Id: I518cd477f1a4fbcd501d419479dd58c4e53be9ae
Reviewed-on: https://chromium-review.googlesource.com/1140787Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575745}

New colors:
* Inactive normal: #E7EAED
* Inactive incognito: GoogleGrey800

Bug: 863094
Change-Id: Ifb11031efffcf9116a8d076cc20f71c6cc4f0117
Reviewed-on: https://chromium-review.googlesource.com/1139041Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575744}

<foreignObject> is the only element which can be replaced normal flow stacking,
and this element cannot be z-indexed.

Bug: 862635

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia82a7c648da1d407b38330b7daa280d2baf39d49
Reviewed-on: https://chromium-review.googlesource.com/1137351
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575743}

This reverts commit 06d88933.

Reason for revert: Flaking test has been refactored in such a way that
we believe it will no longer flake.  (Sheriffs: Please re-land the CL below if the test starts to flake again!)

Original change's description:
> Disable flaky LifecycleTest (Exe_TerminateProcess) on Fuchsia
> 
> TBR: jam@chromium.org
> Bug: 863166
> Change-Id: I9e31154c0ba8cdc5fff7af5130c8a06029a4bdaa
> Reviewed-on: https://chromium-review.googlesource.com/1136029
> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574942}

TBR=kpaulhamus@chromium.org, rockot@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863166
Change-Id: I7a816e991cccb0559dcf8e0a43c96920a933352b
Reviewed-on: https://chromium-review.googlesource.com/1140873Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575742}

This was found sometime last year, but has recently been tickled with a
higher frequency due to session restore changes.

BUG=784306

Change-Id: I1d200f94f3fdb4e5fb2989f9f0be11a4dec3606a
Reviewed-on: https://chromium-review.googlesource.com/1138867Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575741}

This CL fixes a bug where the hashed device ID instead of the real
device ID is used to get video input formats for
InputDeviceInfo.getCapabilities().
This bug caused the capabilities to be computed with the fallback list
of video formats instead of the real list.

Bug: 863426

logging

Change-Id: I46b3eb6c22fe43548206d81efaf7a15b99c54456
Reviewed-on: https://chromium-review.googlesource.com/1138154
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575740}

This fixes a flaky test on ChromeOS, in which a mouse exit event can be
received by a row after the popup is hidden (in the test in case, this
happened when the frame that contained the dropdown was deleted).

The solution here consists of not giving rows direct access to the
controller; now they need to use an accessor method in the native view,
which will return nullptr after the popup is hidden.

As a safety measure, also protected other accesses to the controller,
except on CreateContent(), which is called when a row is being created,
and the controller's existence is guaranteed.

Bug: 864477
Change-Id: I8be9be974065543ca9da6ea165365ed7777e70b7
Reviewed-on: https://chromium-review.googlesource.com/1140284
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575739}

This patch has the BottomToolbarMediator implement SceneChangeObserver
rather than making it an anonymous class. This change also allows us
to remove the observer when the mediator is destroyed.

Change-Id: I045058f434e8638bc6c114dff4d1f0ed85059714
Reviewed-on: https://chromium-review.googlesource.com/1136988
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575738}

This CL includes the implementation class for the abstract class
CountDownLatch defined in the Nearby library. It is a synchronization
aid that allows one or more threads to wait until a set of operations
being performed in other threads completes.

Because the actual Nearby library has yet to be merged into the CrOS
directory, this CL includes stand-in Nearby abstract classes under
the temporary directory //chromeos/components/nearby/library.
This directory will be removed after the Nearby library gets imported
to //third_party (in-progress CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1113198).

Bug: 861813
Change-Id: I8d018e16a83760fae23acb0f2f3d92dee88ce9bc
Reviewed-on: https://chromium-review.googlesource.com/1123017
Commit-Queue: Kyle Qian <kyleqian@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575737}

Bug: 833380
Change-Id: I9973c37de42b89f06157b97b30458e5a77f349cc
Tbr: kenrb@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1140617Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575736}

https://pdfium.googlesource.com/pdfium.git/+log/ff402c2c4ce8..a97a660d47cd


git log ff402c2c4ce8..a97a660d47cd --date=short --no-merges --format='%ad %ae %s'
2018-07-17 rharrison@chromium.org Reserve space for result in ::FilterContents


Created with:
  gclient setdep -r src/third_party/pdfium@a97a660d47cd

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:863295
TBR=dsinclair@chromium.org

Change-Id: If9d901d30f2c836e6f849a5e960deb99710f4582
Reviewed-on: https://chromium-review.googlesource.com/1140534Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575735}

Bug: 848955
Change-Id: I685ff122d8ab0a8b8a529e7d381442e7ac5d9838
Reviewed-on: https://chromium-review.googlesource.com/1140679
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575734}

This fixes a regression introduced in r567901. The issue is that the
paint property tree now includes the visual viewport transform. This
means the paint method used by the disambiguation popup (and other)
feature would unexpectedly have the pinch zoom transform applied and
thus show the wrong area (or none at all).

This patch fixes the issue by starting painting at the LayoutView's
property tree state.

Bug: 854086
Change-Id: I5baae162e65d93f2c9a6f46b3af1a5c04af6fc63
Reviewed-on: https://chromium-review.googlesource.com/1128900
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575733}

This prevents using the mobile-viewport and the
Android-style scrollbars for pages in tablet mode.
This gives a better UX on tablets and prevents
unexpected page layout changes when switching to
tablet mode.

BUG=831473
TEST=Manually by visiting old.reddit.com/r/chromeos
     and switching to tablet mode. Page layout should
     not change to the mobile one, and ChromeOS
     scrollbars should remain in use.
     Also modified modified browser_tests.

Change-Id: Id858c03d37515f48b0f3515f099853999e3aafdd
Reviewed-on: https://chromium-review.googlesource.com/1139075Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575732}

 - Update most visited and search icon image.
 - Change hint text to go from 17pt to +.15 scale
 - Center hint text.
 - Make fake omnibox pill-like.
 - Tweak omnibox fade on RxR.

Bug: 857433, 854093, 860414
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie236f03daf20b074cb4b4382b3c70e79fc9eca9f
Reviewed-on: https://chromium-review.googlesource.com/1138347
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575731}

This to let App Launcher correctly rank app and prevent coming these
apps to the recent list.

TEST=Manually + unit_test
BUG=757639

Change-Id: Ifff93cc7089531d2450d2584baedd8a6002ec353
Reviewed-on: https://chromium-review.googlesource.com/1138748Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#575730}

This causes any pending Touch ID consent prompt to be dismissed when the
authenticator is deleted, e.g. because the transaction was cancelled.
Otherwise the dialog sticks around until the OS lets it time out.

(See https://developer.apple.com/documentation/localauthentication/lacontext/1514192-invalidate?changes=_2.)

Bug: 678128
Change-Id: Ic4102b54ec78781ed869fa6a7827885ace5345e1
Reviewed-on: https://chromium-review.googlesource.com/1137218Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#575729}

https://skia.googlesource.com/skia.git/+log/94fee93c9b23..b609e6dc6a02


git log 94fee93c9b23..b609e6dc6a02 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 ruiqimao@google.com added byte and ubyte types to SKSL
2018-07-17 bsalomon@google.com Remove crash when shader linking fails.
2018-07-17 brianosman@google.com Remove SkTransferFunctionBehavior
2018-07-17 bsalomon@google.com Reland "Remove interpolants are inaccurate workaround for Adreno 3xx."
2018-07-17 caryclark@skia.org polish picture and rrect docs
2018-07-17 robertphillips@google.com Revert "Reduce arbitrary opList splitting when sorting"


Created with:
  gclient setdep -r src/third_party/skia@b609e6dc6a02

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:861956,chromium:847984
TBR=bungeman@chromium.org

Change-Id: Ic674df2072110895987466c86baa4f96ab849cee
Reviewed-on: https://chromium-review.googlesource.com/1140413Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575728}

Notify the component extension whether WebUI or Views Cast dialog is
being used. The extension will log this info.

Move the ShouldUseViewsDialog() method from
media_router_dialog_controller_views.cc to media_router_feature.h.

b/111209425

Change-Id: I671f330088bfe959df487cd8b7947225940692d8
Reviewed-on: https://chromium-review.googlesource.com/1134186Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575727}

Change-Id: I9271490f9a5b68129797ba6b9062247d1b1b2c2a
Reviewed-on: https://chromium-review.googlesource.com/1135324Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575726}

This reverts commit 9f8158c1.

Reason for revert: Culprit of failed VR tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6884

Original change's description:
> VR: Ensure we remove black overlay if VR is exited while entering.
> 
> This fixes a failure mode where we shutdownVR after handling the VR NFC
> broadcast, and fail to properly cancel VR entry.
> 
> Also does some other random cleanup of comments/visibility.
> 
> Bug: 862829
> Change-Id: Ic382692d7255aa5893391a602a6c949b4b4d498b
> Reviewed-on: https://chromium-review.googlesource.com/1138726
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575388}

TBR=mthiesse@chromium.org,tiborg@chromium.org

Change-Id: Ibe67ee8c09dc44ac34d40c3eaf890884b400fc24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862829
Reviewed-on: https://chromium-review.googlesource.com/1140813Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575725}

We could run NGFlexLayoutAlgorithm for nodes that weren't
LayoutNGFlexibleBox when they had display:flex. We'd been assuming that
all display:flex elements would get a LayoutNGFlexibleBox node, but not
so -- the <details> element always gets a BlockFlow no matter what its
display value is.

That should also probably be changed, but needs an intent to ship and
risks compat issues, so just fix the LayoutNG crash for now.

Bug: 862797
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ibc42e76f9ea312b6458ca7f7798b8ca6ba69cfdd
Reviewed-on: https://chromium-review.googlesource.com/1139401
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575724}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I432045209798b3008f4a55c962873daa37fc5e06
Reviewed-on: https://chromium-review.googlesource.com/1138798Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575723}

ThreadSafeAssociatedPtr is only supposed to be used by the IPC
conversion system.  In addition, it has a tendancy to post all
calls to MediaLog::AddEvent, which can have the side-effect of
ordering them after the (Mojo)VideoDecoder is destroyed since that
happens synchronously when VideoDecoder::Initialize fails.  So, we
don't get messages that describe why the failure happened, since
MojoVideoDecoderService has torn down the binding by then.

Instead, we make MojoMediaLog thread safe, and avoid the extra post
in the process.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I50fdb27c169c4b68222aa92f46c41a9ff23b4413
Reviewed-on: https://chromium-review.googlesource.com/1139080
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575722}

In jumbo build experiments, two (identical but small)
GetActiveTextureUnit() functions ended up in the same translation
unit which caused the compiler to fail.

This patch moves the useful function into a shared utility file.

Bug: 801580
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id6f8f1002db18593150bec30f1e8b7092f464e13
Reviewed-on: https://chromium-review.googlesource.com/1136308Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#575721}

This re-lands commit a6dc11ea
which was reverted for leaking (caught by lsan bot).
Fix: unref custom cursors created in CursorData::ToNativeCursor

Go through CursorFactoryOzone to load the PlatformCursor (which
confusingly could be CursorData, but for now is X11CursorOzone). Also
set fields on the cross-platform Cursor type so that code which relies
on it such as CursorWindowController::UpdateCursorImage will work.
That code path can be exercised with --ash-enable-cursor-motion-blur
although there is currently no use of custom cursors with ws2.

TBR=sky@chromium.org, tsepez@chromium.org

Change-Id: I1d6324a6049d83850185171a42c164f7679f5a5e
Reviewed-on: https://chromium-review.googlesource.com/1120860
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575720}

Bug: 844016
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I20115592c139201348980f835bc16154f656eadf
Reviewed-on: https://chromium-review.googlesource.com/1136658Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575719}

Bug: 864458
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia2f18a1fc92a35d0a09cde3ad4f42e4c2e7936a4
Reviewed-on: https://chromium-review.googlesource.com/1140362Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575718}

Add a Layout.DisplayCutout.StateChanged UKM event that
is recorded when display cutout state changes.

BUG=825890

Change-Id: I7b134117ea847505e62f3690d0ac45ab02db8e1f
Reviewed-on: https://chromium-review.googlesource.com/1117638Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575717}

Using wpt-import in Chromium de0b602f.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21500

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc
alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org:
  external/wpt/generic-sensor
bajones@chromium.org:
  external/wpt/gamepad
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
bokan@chromium.org:
  external/wpt/visual-viewport
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-cascade
  external/wpt/css/css-conditional
  external/wpt/css/css-namespaces
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
chongz@chromium.org:
  external/wpt/pointerlock
  external/wpt/touch-events
chongz@chromium.org, yosin@chromium.org:
  external/wpt/input-events
cvazac@akamai.com, igrigorik@chromium.org:
  external/wpt/server-timing
dcheng@chromium.org, scottmg@chromium.org:
  external/wpt/domparsing
dgrogan@chromium.org:
  external/wpt/css/css-tables
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
drott@chromium.org:
  external/wpt/css/css-text-decor
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
dtapuska@chromium.org:
  external/wpt/uievents
eae@chromium.org, szager@chromium.org:
  external/wpt/intersection-observer
ecobos@igalia.com:
  external/wpt/css/css-display
ericwilligers@chromium.org:
  external/wpt/css/motion
eroman@chromium.org, rsleevi@chromium.org:
  external/wpt/WebCryptoAPI
fmeawad@chromium.org, panicker@chromium.org:
  external/wpt/device-memory
foolip@chromium.org:
  external/wpt/compat
  external/wpt/fullscreen
garykac@chromium.org:
  external/wpt/clipboard-apis
  external/wpt/keyboard-map
garykac@chromium.org, joedow@chromium.org:
  external/wpt/keyboard-lock
guidou@chromium.org:
  external/wpt/mediacapture-streams
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
hta@chromium.org:
  external/wpt/webrtc
igrigorik@chromium.org, panicker@chromium.org:
  external/wpt/performance-timeline
igrigorik@chromium.org, yoav@yoav.ws:
  external/wpt/preload
jfernandez@igalia.com:
  external/wpt/css/css-align
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler
jochen@chromium.org, estark@chromium.org:
  external/wpt/referrer-policy
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/IndexedDB
  external/wpt/encoding
  external/wpt/storage
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI
  external/wpt/webstorage
kojii@chromium.org:
  external/wpt/css/css-rhythm
  external/wpt/css/css-scoping
  external/wpt/css/css-writing-modes
kojii@chromium.org, ksakamoto@chromium.org:
  external/wpt/css/css-font-loading
kojii@chromium.org, mstensho@chromium.org:
  external/wpt/css/CSS2
kozyatinskiy@chromium.org:
  external/wpt/console
kpaulhamus@chromium.org:
  external/wpt/webauthn
ksakamoto@chromium.org:
  external/wpt/resource-timing
mcasas@chromium.org:
  external/wpt/geolocation-API
  external/wpt/mediacapture-record
meade@chromium.org:
  external/wpt/web-animations
mek@chromium.org:
  external/wpt/webmessaging
mkwst@chromium.org:
  external/wpt/mixed-content
  external/wpt/secure-contexts
  external/wpt/upgrade-insecure-requests
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mkwst@chromium.org, jochen@chromium.org:
  external/wpt/subresource-integrity
mlamouri@chromium.org:
  external/wpt/mediasession
  external/wpt/remote-playback
  external/wpt/screen-orientation
msisov@igalia.com:
  external/wpt/webvtt
msramek@chromium.org, mkwst@chromium.org:
  external/wpt/clear-site-data
mstensho@chromium.org:
  external/wpt/css/css-break
  external/wpt/css/css-multicol
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
ortuno@chromium.org:
  external/wpt/bluetooth
panicker@chromium.org:
  external/wpt/longtask-timing
  external/wpt/page-visibility
  external/wpt/user-timing
panicker@chromium.org, tdresser@chromium.org:
  external/wpt/paint-timing
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store
rego@igalia.com:
  external/wpt/css/css-grid
  external/wpt/css/css-ui
  external/wpt/css/selectors
rijubrata.bhaumik@intel.com, mcasas@chromium.org:
  external/wpt/html-media-capture
rmcilroy@chromium.org:
  external/wpt/requestidlecallback
rob.buis@samsung.com:
  external/wpt/quirks
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-method-basic-card
  external/wpt/payment-method-id
  external/wpt/payment-request
skobes@chromium.org:
  external/wpt/css/css-scroll-anchoring
smcgruer@chromium.org:
  external/wpt/css/css-position
tdresser@chromium.org:
  external/wpt/hr-time
  external/wpt/navigation-timing
timvolodine@chromium.org:
  external/wpt/battery-status
timvolodine@chromium.org, reillyg@chromium.org:
  external/wpt/orientation-event
worker-dev@chromium.org:
  external/wpt/workers
  external/wpt/worklets
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=foolip

No-Export: true
Change-Id: I1635c3d7fa89e779585adc775200ef6bd8b55e65
Reviewed-on: https://chromium-review.googlesource.com/1140494
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575716}

The local_card_migration_manager is the manager to control the local card migration flow, which is similar to the credit_card_save_manager class. The FormDataImporter will trigger the migration when user submit a form using a local card or a server card.

If the user is signed-in and sync, and have [more than one local card when use a local card] or [at least one valid local card when use server card], migration will start to fetch legal docs. When successfully fetch the legal docs, it will pop-up first round window to ask user whether to migrate local card. If user agree, it will pop-up second window with all valid local card for upload. If user agree on the second window, we will sequentially upload valid local cards.

In this CL, we mainly solve the triggering logic for the migration. The logic is mainly in the FormDataImporter and the ShouldOfferLocalCreditCardMigration() in LocalCardMigrationManager. If the migration requirements are met, we will fetch legal docs from the server. If we successfully fetch the legal docs, we will trigger the first round pop-up window to the user. We also add experimental flag in this CL to enable/disable the migration.

For the unittest, we use a variable in the test class as an observer and it is True when successfully fetch the legal docs. We check this variable to test whether the migration is triggered or not. And we also create new constructor in the test_autofill_manager and test_form_data_importer for the new local_card_migration_manager for testing.

The triggered two-round pop-ups windows together with their callback functions will be included in the following CLs.

Bug: 852904
Change-Id: Iadd17b4e36e12bc9ef17075d0703b796d37ed334
Reviewed-on: https://chromium-review.googlesource.com/1111569
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#575715}