GitLab

All these targets have come online for iOS, and build successfully.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10832006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148320 0039d316-1c4b-4281-b951-d872f2087c98

Similar to http://crrev.com/148150, but only triggers when uploading.

TBR=aa@chromium.org
BUG=111465,92466
TEST=Uploading CLs that update the extensions docs don't trigger the warning anymore


Review URL: https://chromiumcodereview.appspot.com/10830007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148319 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach@chromium.org
BUG=97818
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10827006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148318 0039d316-1c4b-4281-b951-d872f2087c98

R=erg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10818027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138866
TEST=see bug

Review URL: https://chromiumcodereview.appspot.com/10805055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148316 0039d316-1c4b-4281-b951-d872f2087c98

vector does not have a virtual destructor, see Item 7 from of Effective STL from
Scott Meyers for a detailed explanation.

BUG=135335
R=markusheintz@chromium.org,willchan@chromium.org
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10796081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138930

TEST=content_unittests


Review URL: https://chromiumcodereview.appspot.com/10826007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148313 0039d316-1c4b-4281-b951-d872f2087c98

These tests are suppressed downstream, syncing those suppressions
upstream.

BUG=138933
TEST=ui_unittests


Review URL: https://chromiumcodereview.appspot.com/10834003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148310 0039d316-1c4b-4281-b951-d872f2087c98

Now it monitors mouse/touch/gesture events and hides the tooltip if necessary.
Previous CL (crrev.com/148079) was reverted since it causes use-after-free error.
It happens when the 'LauncherTooltipBubble' widget exists but LauncherTooltipManager
is already released.  In that case, the widget's release will cause WindowClosing()
which calls host_->OnBubbleClosed(), but host_ is already released.
Thus I'd make sure to introduce a method to set host_ to NULL in case that
LauncherTooltipManager explicitly clean-up the Bubble.

R=derat@chromium.org
BUG=137678
TEST=manually checked on linux, aura_shell_unittests passed with asan


Review URL: https://chromiumcodereview.appspot.com/10808102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148308 0039d316-1c4b-4281-b951-d872f2087c98

r147862 added dependencies on CoreText and CoreGraphics to foundation_utils,
so those frameworks now need to be linked on iOS.

TBR=
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10821009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138228
TEST=


Review URL: https://chromiumcodereview.appspot.com/10807089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148304 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148303 0039d316-1c4b-4281-b951-d872f2087c98

Remove code for histograms which aren't yielding additional useful
info.  Cleanup naming slightly.

BUG=71832
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10802098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148301 0039d316-1c4b-4281-b951-d872f2087c98

 We probably want to change this for window dragging and/or drag&drop.

BUG=123160
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10826005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148300 0039d316-1c4b-4281-b951-d872f2087c98

Intending to use this to track down suspected memory corruption.

BUG=71832
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10818042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148299 0039d316-1c4b-4281-b951-d872f2087c98

Added debug only shortcut to activate screen locker.

BUG=123160
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10800095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148297 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=138857

R=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10820008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148296 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mihaip@chromium.org,rsesek@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10820010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138873
TEST=ash_unittests:BaseLayoutManagerTest.BoundsAfterRestoringToMaximizeFromMinimize

Review URL: https://chromiumcodereview.appspot.com/10821008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148294 0039d316-1c4b-4281-b951-d872f2087c98

It turned out these shortcuts were accidentally added to the global shortcuts.
This CL reverts the part of adding keyboard shortcuts in the CL below.
http://src.chromium.org/viewvc/chrome?view=rev&revision=147127

TBR=xiyuan@chromium.org
BUG=137708
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10809088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148293 0039d316-1c4b-4281-b951-d872f2087c98

first, we don't create file on disk when it is selected anymore (since we can't really know exact file path for drive files), we just setup permissions for the file.

second, we have to give read permissions for drive cache paths as well in order to enable file reading. 

TEST=existing
BUG=138089

Review URL: https://chromiumcodereview.appspot.com/10664002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148292 0039d316-1c4b-4281-b951-d872f2087c98

(Separated from a bigger patch: https://chromiumcodereview.appspot.com/10810053)

BUG=138022
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10817006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148291 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=92148

Also, while I'm here, don't include the webkit .cur files on
platforms other than windows.

BUG=137588
TEST=Cursors show up fine in component builds.

Review URL: https://chromiumcodereview.appspot.com/10817031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148290 0039d316-1c4b-4281-b951-d872f2087c98

The details was a boolean indicating whether this is the last browser window closing. As part of this change the logic for saving pinned tabs has been changed to not use the boolean in the details, and has been updated to handle the case where a user exit or closing of the last window is cancelled by an onbeforeunload event.

Also as part of this change, both the pinned tab and multi profile features have been updated to handle cases of the browser process not being closed due to background mode or (in the future) packaged apps, and then more browser windows being opened.

BUG=None
TEST=Test shutdown 


Review URL: https://chromiumcodereview.appspot.com/10800031

TBR=benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148289 0039d316-1c4b-4281-b951-d872f2087c98

linux-release-lowmem/bloat-http/times: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/bloat-http/report.html?history=150&rev=-1

TBR=cmp
BUG=138894
Review URL: https://chromiumcodereview.appspot.com/10828004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148288 0039d316-1c4b-4281-b951-d872f2087c98

For Android, it doesn't use views but use skia natively.

BUG=
TEST=run_tests.py -s ui_unittests


Review URL: https://chromiumcodereview.appspot.com/10817025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148287 0039d316-1c4b-4281-b951-d872f2087c98

This adds the ability to change the value of the WebKit runtime flag added in http://trac.webkit.org/changeset/121229


Review URL: https://chromiumcodereview.appspot.com/10815069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138739
TEST=Manually check debug shortcuts work with --ash-debug-shortcuts enabled and do not work otherwise.

Review URL: https://chromiumcodereview.appspot.com/10825002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148285 0039d316-1c4b-4281-b951-d872f2087c98

UninitCondition
Conditional jump or move depends on uninitialised value(s)
  media::mp4::TrackRunIterator::Init(media::mp4::MovieFragment const&)
    (media/mp4/track_run_iterator.cc:134)
  media::mp4::TrackRunIteratorTest_BasicOperationTest_Test::TestBody()
    (media/mp4/track_run_iterator_unittest.cc:114)
Uninitialised value was created by a stack allocation
  media::mp4::TrackRunIteratorTest::CreateFragment()
    (media/mp4/track_run_iterator_unittest.cc:62)

BUG=none
TEST=media_unittests + valgrind.


Review URL: https://chromiumcodereview.appspot.com/10825005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148284 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148283 0039d316-1c4b-4281-b951-d872f2087c98

linux-release-lowmem/dom_perf/total/score:
http://build.chromium.org/f/chromium/perf/linux-release-lowmem/dom_perf/report.html?history=150&rev=148265

TBR=cmp
BUG=138877
Review URL: https://chromiumcodereview.appspot.com/10829004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148282 0039d316-1c4b-4281-b951-d872f2087c98

The details was a boolean indicating whether this is the last browser window closing. As part of this change the logic for saving pinned tabs has been changed to not use the boolean in the details, and has been updated to handle the case where a user exit or closing of the last window is cancelled by an onbeforeunload event.

Also as part of this change, both the pinned tab and multi profile features have been updated to handle cases of the browser process not being closed due to background mode or (in the future) packaged apps, and then more browser windows being opened.

BUG=None
TEST=Test shutdown 


Review URL: https://chromiumcodereview.appspot.com/10800031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148281 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, cmd.exe crops the command-line string for build_nexe.py and build_nexe.py does not get all base files now. This change removes all files not needed by build_nexe.py on Windows to prevent cmd.exe from cropping the command-line string to build_nexe.py.

BUG=138687
TEST=build Chromium without errors.

Review URL: https://chromiumcodereview.appspot.com/10806082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
TBR=tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10805092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148279 0039d316-1c4b-4281-b951-d872f2087c98

Encoding the wallpaper to png from a skia is something we'll need to do from at least one more place (the screensaver images source) so it makes sense to refactor this code to pull out the encoder so it's usable from other places too.

R=bshe@chromium.org,csilv@chromium.org
BUG=None.
TEST=Tested with the lock screen to verify that the background set for the user is pulled and displayed.


Review URL: https://chromiumcodereview.appspot.com/10790084

TBR=rkc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148278 0039d316-1c4b-4281-b951-d872f2087c98

chrome/test/data/plugin was moved to content/test/data/plugin
Update tests

BUG=138857
TEST=pyauto tests

R=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148275 0039d316-1c4b-4281-b951-d872f2087c98

Expected images of following tests are update by WebKit r123302.
* fast/forms/number/number-appearance-rtl-expected.html
* fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.html
* fast/forms/number/number-appearance-spinbutton-layer-expected.html

TBR=atwilson@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10795085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148274 0039d316-1c4b-4281-b951-d872f2087c98

linux-release/dom_perf/total score: http://build.chromium.org/f/chromium/perf/linux-release/dom_perf/report.html?history=550&rev=148261

TBR=cmp
BUG=138877
Review URL: https://chromiumcodereview.appspot.com/10820006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148273 0039d316-1c4b-4281-b951-d872f2087c98

Encoding the wallpaper to png from a skia is something we'll need to do from at least one more place (the screensaver images source) so it makes sense to refactor this code to pull out the encoder so it's usable from other places too.

R=bshe@chromium.org,csilv@chromium.org
BUG=None.
TEST=Tested with the lock screen to verify that the background set for the user is pulled and displayed.


Review URL: https://chromiumcodereview.appspot.com/10790084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148272 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-dual-core/moz/vm_peak_r: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=200&rev=148240&graph=vm_peak_r

TBR=cmp
BUG=138877
Review URL: https://chromiumcodereview.appspot.com/10822005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148271 0039d316-1c4b-4281-b951-d872f2087c98