GitLab

We have stopped using (Get|Set)LargestChangestamp in favor of
(Get|Set)StartPageToken. This CL removes the code and fixes the UI
to display the start page token instead.

We leave (Get|Set)LargestChangestamp in resource metadata storage to
facilitate DB upgrades, where we write the existing largest changestamp
to the start page token field.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I57c8f61e3914cdfd3ea15046c8551f0456f9e636
Reviewed-on: https://chromium-review.googlesource.com/1071149Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561623}

UINavigationBar renders incorrectly when pushViewController:animated: is called
from within viewDidLoad.  Sidestep this by pushing every
BookmarkHomeViewController onto the navigation stack before making the Bookmarks
UI visible.

In cases where the BookmarkModel has not yet been loaded and a spinner is shown,
we fall back to the original logic of recursively pushing new view controllers.
That does not trigger the UIKit bug because viewDidLoad has already completed.

BUG=None

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id9535f6cb9e93fb85d27d4627adeb404d8564dc4
Reviewed-on: https://chromium-review.googlesource.com/1070793
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561622}

Pak symbols were not getting their full name propagated to name and
template_name, making it harder to see their names in the diffs.

Bug: 842728
Change-Id: Id98edbc246239f053ab48d398adf3a058a022514
Reviewed-on: https://chromium-review.googlesource.com/1072496
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561621}

It's an initial implementation of the feature.

See the UI mock: https://docs.google.com/presentation/d/1zCV2v5rXFUndWC5ECMKj06i5WNbRJ-uZWyZTFxU8dEE/edit#slide=id.g21b4c071a9_0_116

See Doc for expected behaviors: https://docs.google.com/document/d/1rm8_JyTY883IiNNis6LGtI1jsx_WHCWm5KY7hwAGOe8/edit#heading=h.i5t24a7vxw8j

See recorded video: https://drive.google.com/open?id=1KcqAyHrxj6zheSEkgGz-ozlg7mILrmxT

1) Add a new feature flag --enable-features=DragTabInTabletMode And also expose
   it to chrome flag --enable-drag-tabs-in-tablet-mode
2) Only tab(s) area can be dragged.
3) For a maximized window, its tab(s) can be dragged out to create a new window
   to either be maximized or snapped to one side of the screen, or can also be
   merged back to the original window
4) For a snapped window, its tab(s) can be dragged out to create a new window to
   snap to either side of the split, or can also be merged to an existing window
   to either side of the split

Change-Id: Ieb2e8921d5c116a83e1b7998d992f8e32a904099
Reviewed-on: https://chromium-review.googlesource.com/1020294
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561620}

As refactoring CLs for Issue 842349 landed, this is no longer used.

Bug: 842349
Change-Id: I94af990ce81e1d67ded2913e18c4b92e327fa856
Reviewed-on: https://chromium-review.googlesource.com/1069688
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561619}

Bug: 839597
Change-Id: I58bca8a3af6ab1b130876a6f5c373ee522b09664
Reviewed-on: https://chromium-review.googlesource.com/1043353Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561618}

https://chromium.googlesource.com/angle/angle.git/+log/22a5f5f01f70..0f8aab8b5421

$ git log 22a5f5f01..0f8aab8b5 --date=short --no-merges --format='%ad %ae %s'
2018-05-24 brandon1.jones Remove unused files from libGLESv2.gpyi
2018-05-24 lfy Revert "GLES1: Entry points for lighting and materials"
2018-05-17 lfy GLES1: Entry points for lighting and materials
2018-05-02 brandon1.jones Implement EGL_ANGLE_explicit_context
2018-05-18 courtneygo Add support for EGL_PLATFORM_ANGLE_EGL_HANDLE_ANGLE
2018-05-23 geofflang Don't double-terminate a display.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I376f4bad131018a484bbb149d6e74eca89750c37
Reviewed-on: https://chromium-review.googlesource.com/1072269
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561617}

* We use plane properties on legacy DRM to get some details (plane
type, in_formats). Read the properties in HardwareDisplayPlane and
check that the required properties are available in DRM atomic.
* Split dummy plane into its own class to clean up code.
* Remove test plane since we can now create the real objects via
injected state in DrmDevice.
* Cleanup plane initialization.
* Remove MockHardwareDisplayPlaneManager and rely on MockDrmDevice to
inject the necessary state.

BUG=839487
TEST=Ran unittests

Change-Id: I03c91620557dcf7426629cf97bb989d8d7e83c68
Reviewed-on: https://chromium-review.googlesource.com/1048585
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561616}

This CL removes content_source_id in VisualProperties which is no longer
used. It also renames |local_surface_id_| to |local_surface_id_from_parent_|
in RenderWidget to clarify where the viz::LocalSurfaceId is coming from.

A previous version of this CL also

1. Did not embed renderer that have not navigated yet.
2. Always allocated a new LocalSurfaceId for navigation.

1. Broke combobox popups because they're renderers that never navigate
2. Caused new tab page flickering because the browser would submit a
   CompositorFrame that refers to no content until navigation which
   can cause SurfaceAggregator to flash the background color.

The fix to 1. and 2. is to embed LocalSurfaceIds even if they did not navigate,
and to not allocate a new LocalSurfaceId on the first navigation as before (so
we block on new tab page to show the new content).

This CL will likely cause an improvement to the timeToFirstPaint metric (and
other navigation to paint metrics) because it will not block frame submission on
allocating a new LocalSurfaceId anymore. However, the browser will still
allocate a new LocalSurfaceId on DidNavigate. There is a race here which might
cause Chrome to do a bit more work than it would otherwise (generate one more
frame than it would otherwise) but that should be pretty small.

Bug: 672962
TBR: kenrb@chromium.org, piman@chromium.org
Change-Id: I9754ff7b9330c99a0a1106b8d02aef98a26b1318
Reviewed-on: https://chromium-review.googlesource.com/1070476
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561615}

It is no longer necessary to add this include path. Skia itself no
longer adds include/gpu/vk to its own set of include directories so Skia
will now consistently use the "vk/" prefix as needed on such includes.

Change-Id: I7c2ffead7bfb0386614c43b035142ae22bdbf270
Reviewed-on: https://chromium-review.googlesource.com/1070339
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561614}

ClientFrameSinkVideoCapturer will survive gpu crashes.

Bug: 806377
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I53492851e1092729a3e331fddabf69602e1a0dc7
Reviewed-on: https://chromium-review.googlesource.com/1071769Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561613}

This patch generalizes RenderedPosition to store an AbsoluteInlineBox,
so that it also works with LayoutNG. As a result, bidi adjustment for
SelectionController is enabled in LayoutNG.

Bug: 811502
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I27d2ebe8e091173c4d298f15eb47b60f76c15312
Reviewed-on: https://chromium-review.googlesource.com/1070564Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561612}

This reverts commit d911f7ff.

Reason for revert: crbug.com/846426

Original change's description:
> [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load
> 
> We would like to see more Memory_Experimental UKM after page load.
> We are thinking that renderer memory usage will quickly grow after page load.
> However, currently Memory_Experimental UKM is reported every 30 minutes, and
> is not related to any page load.
> 
> ProcessMemoryMetricsEmitter's change was https://chromium-review.googlesource.com/1032150
> and submitted.
> 
> Bug: 837498
> Change-Id: I16eb5997879fb9a16b647969dc9e73503211065c
> Reviewed-on: https://chromium-review.googlesource.com/925987
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560948}

TBR=chrisha@chromium.org,tasak@google.com,erikchen@chromium.org,fmeawad@chromium.org,haraken@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837498, 846426
Change-Id: I45a2e3df525617e797680f4ddf14582b6f35df0e
Reviewed-on: https://chromium-review.googlesource.com/1072328
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561611}

This CL adds a method to unload a previously loaded
extension.

Bug: b/73383411
Test: None
Change-Id: Id9f801c5c0296ba9748bfbd4417797f7f4eddb6d
Reviewed-on: https://chromium-review.googlesource.com/1070457Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561610}

This reverts commit 57fd44c7.

Reason for revert: suspect for messing up symbols on Win7 bot
                   @ crbug.com/846313

Original change's description:
> Fixed SDK lookup for non C:\ Windows installation.
>
> Bug: None
> Change-Id: Ia0aa186d1d39b1beac8ce0152683f774ad5d2eaf
> Reviewed-on: https://chromium-review.googlesource.com/1066065
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561063}

TBR=jochen@chromium.org,yura.yaroshevich@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 846313
Change-Id: Id93a965aea5555961c539d47e05e79410894eff8
Reviewed-on: https://chromium-review.googlesource.com/1072307
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561609}

TimeDeltaToInternalRepresentation can't return a constexpr because it
uses TimeDelta::InSeconds which can't be evaluated at compile time,
remove the |kZeroIntervalInternalRepresentation| value as this doesn't
provide any clear value here.

Bug: 773382,846431
Change-Id: I6b2df260742c239cc664e8476c726d4ba15731dc
Reviewed-on: https://chromium-review.googlesource.com/1072347
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561608}

Instead of expanding UMA_HISTOGRAM_ENUMERATION macro in 19 places, use a
single static method to log this histogram.  The motivation for this
change is to avoid binary bloat.

This is a follow-up to https://crrev.com/c/1055949.

This CL results in 2384 byte decrease in binary size for locally
compiled release build on Linux, and no change for debug build.

Bug: 831536
Change-Id: I0b5e741e29529c9f6ae22336b3a6c3d194042249
Reviewed-on: https://chromium-review.googlesource.com/1071731Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561607}

Some of these new passing tests may be related to:
https://chromium.googlesource.com/chromium/src/+/5d4b496fb58d979f8b511519e93f8c6284f7bf25

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees
Change-Id: I0ee575c1b0f2fca9a996c12db1cedd9fd2282e6a
Reviewed-on: https://chromium-review.googlesource.com/1071770Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561606}

This adds the WebAuthenticationTouchId feature flag (default disabled).
If enabled, the FidoRequestHandler tries to instantiate a
TouchIdAuthenticator on supported platforms for the current request.

Bug: 678128
Change-Id: Iddc4ea00b3247b6ffbe875e280e1bf30488ca81f
Reviewed-on: https://chromium-review.googlesource.com/1064921
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561605}

Using wpt-import in Chromium cf60c7cb.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18508

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

TBR=kereliuk

No-Export: true
Change-Id: I0fb7c55f909eeb5beacd15b2352433cac91b443e
Reviewed-on: https://chromium-review.googlesource.com/1072151
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561604}

Otherwise any call after the initial SetPlaceholderText won't render.

R=jdufault@chromium.org

Bug: 846388
Test: none
Change-Id: If3de184b8f7367658e9e0d920c9edbc45ee5d0f3
Reviewed-on: https://chromium-review.googlesource.com/1072227Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561603}

This adds the availableInlineSize, availableBlockSize, to the layout
constriants options dictionary.

This also makes the children "shrink-to-fit" if they are inside a
custom layout pass. Additional logic was needed to *not* "shrink-to-fit"
children during the layout fallback if any occurred, so
LayoutCustomPhaseScope was added to handle this.

The tests that were added test a new BFC with inline children to
see if shrink to fitting works as expected.

Bug: 726125
Change-Id: Ic86d51579b680d871c66040f54e532bc47d79979
Reviewed-on: https://chromium-review.googlesource.com/1069252
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561602}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4e9b50ab86b9..0115c356f675

$ git log 4e9b50ab8..0115c356f --date=short --no-merges --format='%ad %ae %s'
2018-05-24 justincohen Roll mac_toolchain to 478dc9dbb
2018-05-23 agable Remove old git-cherry-pick-upload documentation

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:841910,chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I7498707ef960c6bee4e121bcae531e6a0c1022d4
Reviewed-on: https://chromium-review.googlesource.com/1072046
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561601}

http://crrev.com/1cecc36 broke DevTools eyedropper tool.

Bug: 846379
Change-Id: I812b66c32192166b3c34582bf6b63407709ba784
Reviewed-on: https://chromium-review.googlesource.com/1072034Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561600}

BUG=792308

Change-Id: I151965cc99c4bd757176c3af87971e28f6c347da
Reviewed-on: https://chromium-review.googlesource.com/1069560Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561599}

Percentages are not allowed in rect() (arguments are '<length> | auto'.)
Move the old test to clip-invalid.html and replace it with one that
doesn't use percentages.

Bug: 843084
Change-Id: I3cadd99da0d302ac5a0cd012450dd7ade233681c
Reviewed-on: https://chromium-review.googlesource.com/1071469
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561598}

When the size of the to-be-encoded-image is larger than the maximum
size supported by the encoder, we need to crop the image beforehand.
Otherwise, we might end up in heap buffer overflow.

Bug: 844872
Change-Id: Ibea765a8b094a845a2a47f8d3e539fc53176ffb1
Reviewed-on: https://chromium-review.googlesource.com/1070326Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561597}

If the contextual suggestions bottom sheet is closed by user click on
the close button, we don't show the sheet again until the page is
reloaded or a new URL is loaded. This state is stored in memory and
will be cleared on restart.

Bug: 838950
Change-Id: I64ddb66cbbca7ce1831baf9a65fa676d4c951770
Reviewed-on: https://chromium-review.googlesource.com/1070750Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561596}

As part of moving devices to a mojo interface, the browser process needs
to make some decision synchronously, so we need some state management
browser-side.  The browser should be deciding which sites are presenting,
and which pages can receive various events, including activation.

BUG=795510

Change-Id: I38282b71b5134938c6670f016acd303851adc5da
Reviewed-on: https://chromium-review.googlesource.com/1060637Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561595}

TBR=kbr@chromium.org
NOTRY=true  # net_unittests flake

Bug: 846289
Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36
Reviewed-on: https://chromium-review.googlesource.com/1071868
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#561594}

Bug: 823534

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I062d1ef97feb3778622e48dfc75d353e0a4dd1e9
Reviewed-on: https://chromium-review.googlesource.com/1067682
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561593}

https://github.com/w3c/webauthn/issues/907 notes that there are three
status values for tokenBinding in webauthn, including "not-supported",
but that tokenBinding itself is optional. Rather than having two ways to
indicate that it's not supported, we're going to eliminate the
"not-supported" status and represent that by omitting the value.

This matches with Firefox's behaviour. Spec change in
https://github.com/w3c/webauthn/pull/914.

Change-Id: If47bd218d61dc71eeddab3cc0d22da953b4cc370
Reviewed-on: https://chromium-review.googlesource.com/1062188Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561592}

This CL moves RecommendationRestorer class to ash. The class exposes
an ObservePrefs method to let caller start observing recommended values
for a pref name.

TBR=bartfab@chromium.org

Bug: 839150
Test: covered by tests and enterprise-enrolled device test
Change-Id: I57b80c49ff8b0d5ab27102abf57b9a21b6b95c0a
Reviewed-on: https://chromium-review.googlesource.com/1023158
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561591}

This CL allows proto db to take a filter to filter out returned entries
Test is also included.
This will facilitate the in-progress download database work.

BUG=842245

Change-Id: I63426527743811ab31560e74a8dc45f922333a00
Reviewed-on: https://chromium-review.googlesource.com/1067149
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561590}

Bug: 845484
Change-Id: I154783db471a25436451490fe3ad93ddcc4222c5
Reviewed-on: https://chromium-review.googlesource.com/1069259
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561589}

This patch removes the !RLS codepaths in CompositedLayerMapping (CLM)
and background_image_geometry now that Root Layer Scrolling (RLS) has
launched.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id07239b22bb96fa7e4d0d3c41d82b61aa9eb5090
Reviewed-on: https://chromium-review.googlesource.com/1071871
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561588}

When the "Download Location" flag is set, we show a dialog allowing
the user to pick which directory is used for downloads.  Offline Pages
should use the directory that the user picked.  This change will get
the directory from downloads, and use that when publishing downloaded
offline pages.

Bug: 758690
Change-Id: I74ba4a1fb2c99fb986ba2273fc4b11f8fad60ba9
Reviewed-on: https://chromium-review.googlesource.com/1069423Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561587}

This patch fixes 'vertical-align' values that need font metrics:
  vertical-align: sub
  vertical-align: super
  vertical-align: middle
to use parent's font instead of the box that has 'vertical-align'
applied.

The CSS2 'vertical-align'[1] defines to use parent's font for
the 'middle' value, and matches to our current code.

It looks like no CSS2 test suites test this condition, but some
tests in css-writing-modes do.

Rebaselines look to be more correct.

[1] https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaaa7448687173a9ecf0c39b55914a0fad4834318
Reviewed-on: https://chromium-review.googlesource.com/1069955
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561586}

Do not send PRIORITY frames when SpdyStream priority changes because
SpdyHttpStream or WebSocketHttp2HandshakeStream priority is changed.
(Keep sending PRIORITY frames when the pushed stream is matched with a
request of different priority.) This CL a stop-gap to avoid crashes
until SpdyWriteQueue is augmented to properly handle priority changes.

This CL partially reverts https://crrev.com/c/1045988.

Bug: 841511
Change-Id: I871511306e96cfc2c1a3e62c8563003cdd4bb821
Reviewed-on: https://chromium-review.googlesource.com/1070655Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561585}

When subscript or superscript styles or HTML tags are used, expose the
accessibility semantics. In IA2, use the text-position text attribute.

TBR=tsepez@chromium.org,spang@chromium.org,kinuko@chromium.org

Bug: 843744
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie0dd8ef801f11548d1284ac433c08605129817d0
Reviewed-on: https://chromium-review.googlesource.com/1068994
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561584}