GitLab

NOTRY=true

Review URL: https://codereview.chromium.org/100183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238275 0039d316-1c4b-4281-b951-d872f2087c98

NativeDesktopMediaList provides list of native screens and windows. Another
implementation of DesktopMediaList interface will be used for Ash screens
and windows.

BUG=295102
R=sky@chromium.org

Review URL: https://codereview.chromium.org/89683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238274 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the shared prefixes used a count which would (often) cause
multiple prefixes to end up within 2^16 of each other.  Modify the setup
to explicitly generate both denser and sparser clusters, to allow
reducing the overall number of prefixes required.

BUG=65151

Review URL: https://codereview.chromium.org/99883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238273 0039d316-1c4b-4281-b951-d872f2087c98

Added a verbose option so the rationality of the above can be checked.

BUG=None
TEST=local, and on non-static build.

Review URL: https://codereview.chromium.org/95903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238272 0039d316-1c4b-4281-b951-d872f2087c98

This makes cc::LayerAnimationController support animating scroll offset.
This is needed for implementing the CSSOM View smooth scroll API.

BUG=243871

Review URL: https://codereview.chromium.org/95763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238271 0039d316-1c4b-4281-b951-d872f2087c98

1. Introduce a platform API for video capture.
2. Implement that API for KitKat+ releases of Android.
3. Refactor speed index metric to have Paint Rect and Video impls. Use video
   when available.

BUG=323813

Review URL: https://codereview.chromium.org/93733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238270 0039d316-1c4b-4281-b951-d872f2087c98

Metrics themselves were added here:
https://chromiumcodereview.appspot.com/23245004

BUG=262567

Review URL: https://codereview.chromium.org/74943008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238269 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238267 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=162992:163007&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/93953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238266 0039d316-1c4b-4281-b951-d872f2087c98

Most of that flow has been rewritten since it was disabled, so assume it's safe to re-enable. The trybot will run the test.
Also change the tests to raise MeasurementFailures, since we keep track of failures and errors separately.


BUG=288631
TEST=Mac trybot

Review URL: https://codereview.chromium.org/83003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=derat@chromium.org

Review URL: https://codereview.chromium.org/95403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238264 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165
TEST=manual
R=nhiroki@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/98803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238263 0039d316-1c4b-4281-b951-d872f2087c98

- Show enrollment screen by default after OOBE if the device is set
  to auto enrollment and is not yet enrolled;
- Update screen loading code to defer Initialize() call for async
  loaded screen until the assets are loaded;

BUG=322666
TEST=LoginUITest.ShowEnrollmentFirst

Review URL: https://codereview.chromium.org/83293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238262 0039d316-1c4b-4281-b951-d872f2087c98

Impulses are an efficient way to handle certain types
of activity from extensions. E.g. the work in progress
to keep NaCl plugins in background pages alive. An
Increment / Decrement approach would require extensive
and fragile instrumentation of all APIs. Impulses
can be sent upon any api activity and act as an
implicit increment with a timed out decrement.

See design doc:
https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit#

BUG=298339

Review URL: https://codereview.chromium.org/60613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238261 0039d316-1c4b-4281-b951-d872f2087c98

Probably due to submit order conflict this seems to have broken
Linux chromeos build (compile):
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/60931

> Fix dragging supported files to tab strip.
> 
> Use the inferred MIME type of download items, rather than the server value,
> when deciding if the tab strip can allow a drop. Get the MIME type
> asynchronously so we don't crash (IO must be allowed in the call to
> GetMimeTypeFromFile).
> 
> Also check the profile's plugins when determining whether a MIME type is
> supported.
> 
> Regardless of whether a file is supported, the dragging operation should
> still be allowed so that spring-loaded tabs work with file drags.
> 
> BUG=274288
> R=asanka@chromium.org, sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/68133020

TBR=michaelpg@chromium.org

Review URL: https://codereview.chromium.org/100773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238260 0039d316-1c4b-4281-b951-d872f2087c98

R=rsleevi@chromium.org, eranm@google.com
BUG=309578
TEST=none

Review URL: https://codereview.chromium.org/100543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238259 0039d316-1c4b-4281-b951-d872f2087c98

Right now this is empty other than IPC related methods. We can start using this to replace RenderViewObservers. Eventually we will remove RenderViewObserver.

BUG=245126
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/100363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316397

Review URL: https://codereview.chromium.org/99263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238257 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238256 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12445: (jvoung) Remove newlib header workaround for run_posix_memalign_test.
r12446: (sbc) Allow opening on char and block devices as well as regular files.
r12447: (mcgrathr) Remove unwind_trace test
r12448: (jfb) Mark iconv test as unbroken on NaCl x86
r12449: (mseaborn) PNaCl: Add script for testing Git changes (for LLVM etc.) via the trybots
r12450: (dschuff) Make toolchain_build friendlier for local PNaCl use.
r12451: (jfb) Build UTF-16LE and UCS-4LE for ARM newlib too
r12452: (jfb) Fix pnacl-ld's private library handling once more.
r12453: (dschuff) buildbot_pnacl_toolchain: don't make Windows bot red for new-style build failure
r12454: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12455: (eliben) Fix build.sh sync-sources and consistently name legacy-repo-sync option target.
r12456: (mseaborn) Add more C++ exception handling tests
r12457: (jvoung) Adjust nacl perf expectations to give margin to uncontended mutex lock.
r12458: (jfb) Update ARM toolchain, and mark iconv test as fixed on ARM
r12459: (phajdan.jr) GTTF: Add option for JSON machine-readable summary output to nacl_integration tests.
r12460: (sbc) Add rt/tst-aio8 to list of known glibc failures.
r12461: (jvoung) Add more margin to perf expectations for UncontendedMutexLock on win32 too.
r12462: (halyavin) Add validator test for F2 66.
r12463: (eliben) Pass -w option through to clang
r12464: (sbc) Add struct flock to newlib fcntl.h.
r12465: (sbc) Disable several glibc tests.

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/93203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238255 0039d316-1c4b-4281-b951-d872f2087c98

There are separate chrome.webrtc.castSendTransport.create and
chrome.webrtc.castUdpTransport.create methods. However these objects
are never used alone. They require a session to operate and having them
separate is confusing.

Instead unify the session creation in one factory method:
chrome.cast.streaming.session.create(
  WebMediaStreamTrack audioTrack,
  WebMediaStreamTrack videoTrack,
  CreateCallback);

The above method will construct a session and create objects for
the RTP streams and the UDP transport. These streams can then be
configured by existing APIs.

Another change is the new cast.streaming namespace. Eventually
everything in chrome.webrtc will be moved there so we have a mix for
now. But we'll unify all the namespaces to cast.streaming in a couple
patches.

To summarize:

The following two APIs are removed:
1. chrome.webrtc.castSendTransport.create
2. chorme.webrtc.castUdpTransport.create

The following API is new:
1. chrome.cast.streaming.session.create

BUG=301920

Review URL: https://codereview.chromium.org/83043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238254 0039d316-1c4b-4281-b951-d872f2087c98

Use the inferred MIME type of download items, rather than the server value,
when deciding if the tab strip can allow a drop. Get the MIME type
asynchronously so we don't crash (IO must be allowed in the call to
GetMimeTypeFromFile).

Also check the profile's plugins when determining whether a MIME type is
supported.

Regardless of whether a file is supported, the dragging operation should
still be allowed so that spring-loaded tabs work with file drags.

BUG=274288
R=asanka@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/68133020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238253 0039d316-1c4b-4281-b951-d872f2087c98

Reason: it is too easy to misuse this and end up leaking a handle.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/99913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238252 0039d316-1c4b-4281-b951-d872f2087c98

On Windows they would hit resource contention issues
otherwise and run slower than serially.

Run time is in seconds anyway.

BUG=236893
R=jeremy@chromium.org

Review URL: https://codereview.chromium.org/93663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238251 0039d316-1c4b-4281-b951-d872f2087c98

Transitions are generally capped at 250ms. Most are faster. Make this one 150ms instead of 500ms.

Also, almost every transition uses the default timing function (ease).

BUG=none

Review URL: https://codereview.chromium.org/99223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238250 0039d316-1c4b-4281-b951-d872f2087c98

Using the accessibility inspector on the Mac App Launcher in Mavericks
currently causes Chrome to crash. This is due to an AppKit bug that
triggers an unrecognized selector exception to be thrown on
-[NSButtonCell item], inside NSCollectionView code.

This adds a method to the NSButtonCell subclass used by the app launcher
for its NSCollectionView that provides a dummy implementation of the
method AppKit tries to call.

BUG=324365
TEST=Open Mac's Accessibility Inspector, then show the App Launcher.
Hovering over items in the grid should not crash Chrome.

Review URL: https://codereview.chromium.org/96103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238249 0039d316-1c4b-4281-b951-d872f2087c98

Touchscreen devices typically have a 'touch slop', i.e. a certain distance a
pointer has to move before it is considered moving. The touch slop is subtracted
from the distance a pointer moves. So if the touch slop is 10 pixels and a
pointer moves by 100 pixels on the screen, the resulting move is registered as
having covered only 90 pixels.

This patch adds the 'GetTouchSlopInDips' to SyntheticGestureTargets. This value
is used by the gestures to increase the distances covered by touch pointers. For
example, to scroll 100 pixels with a touch slop of 10 pixels, the pointer will
cover 110 pixels.

Touch-based synthetic gestures are updated to take the touch slop into account.

BUG=321114

Review URL: https://codereview.chromium.org/95153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238248 0039d316-1c4b-4281-b951-d872f2087c98

Tooltips for requestAutocomplete should use the Chrome bubble look.

BUG=315966

Review URL: https://codereview.chromium.org/84343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238247 0039d316-1c4b-4281-b951-d872f2087c98

This makes base, ui, and net compile without the "using base::string16" directive that's currently checked in.

BUG=

Review URL: https://codereview.chromium.org/100303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238246 0039d316-1c4b-4281-b951-d872f2087c98

There were a couple of issues here:
* make doesn't support spaces, so you have to escape them.
* xterm doesn't exist on mac, use osascript to create a new Terminal window instead.

Also, use the correct basename/default paths for Chrome on each platform.

BUG=322549
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/86053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238245 0039d316-1c4b-4281-b951-d872f2087c98

This feature has not landed, the button should not be shown.

BUG=chromium:324078
TEST=manual
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/93273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238244 0039d316-1c4b-4281-b951-d872f2087c98

Move the code that checks whether the command-line flag or
pref to disable extensions is set into
ExtensionsBrowserClient, and make ExtensionPrefFactory work
with a BrowserContext instead of requiring a Profile.

BUG=313284

Review URL: https://codereview.chromium.org/89253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238243 0039d316-1c4b-4281-b951-d872f2087c98

When a field is modified, the dialog must update the 'editable' status
for all fields in the section.

BUG=321331
TEST=See bug. CVC should now be editable after editing expiration.
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/88943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238242 0039d316-1c4b-4281-b951-d872f2087c98

* Fix button class detection (added CustomButton::AsCustomButtton)
* Removed obsolete touch specific color scheme. Instead, use
 NativeTheme as that's what MenuItemView is using.

BUG=177228

Review URL: https://codereview.chromium.org/82113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238241 0039d316-1c4b-4281-b951-d872f2087c98

> CHECK for adding duplicate converter inputs.
>
> CHECK to see if we're getting into weird states due to inputs
> being added twice.
>
> BUG=233026
> TEST=none
>
> Review URL: https://chromiumcodereview.appspot.com/14083011

TBR=scherkus
NOTRY=true

Review URL: https://codereview.chromium.org/100583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/99783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238238 0039d316-1c4b-4281-b951-d872f2087c98

vpx_video_decoder does not allow odd videos with odd height/width
to playback since it is not valid YV12. But ffmpeg currently
supports it by merely rounding up (and so does the libvpx library).
Changing vpx_video_decoder to behave the same way as ffmpeg and
getting rid of the Checks.

BUG=315817
TEST=media_unittests

Review URL: https://codereview.chromium.org/92073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238237 0039d316-1c4b-4281-b951-d872f2087c98

Allows a tab dragged out of a maximized browser to get properly side-snapped (similar to how docking is allowed).

BUG=319205

Review URL: https://codereview.chromium.org/80323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238236 0039d316-1c4b-4281-b951-d872f2087c98

There's currently a #include cycle between view.h and border.h

Also removes some redundant forward-declares in view.h

BUG=None

Review URL: https://codereview.chromium.org/93843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238235 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 6aa58b85.

Fixed double-close issue when ending recording.

> Revert 237280 "Remove TraceController"
>
> Seems to have broken trace-based telemetry benchmarks on android.
>
> BUG=323749
>
> > Remove TraceController
> >
> > TraceController is obsoleted by TracingController.
> > Changed all remaining clients to use TracingController.
> >
> > BUG=none
> >
> > Review URL: https://codereview.chromium.org/67683003
>
> TBR=wangxianzhu@chromium.org
>
> Review URL: https://codereview.chromium.org/89753004
>
> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98

TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/99103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238234 0039d316-1c4b-4281-b951-d872f2087c98