GitLab

This CL adds methods to get all DownloadEntry from InProgressCache,
convert them, and adding them back to the DownloadDB.
This migration step allows us to move from InProgressCache to DownloadDB.

BUG=870502

Change-Id: Id56346886b1cea2df6fa25954c89cdfb4db167d4
Reviewed-on: https://chromium-review.googlesource.com/1161487
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580695}

Change-Id: Id1fee120b7d61cc41cd359389bf5d05f28dac674
Reviewed-on: https://chromium-review.googlesource.com/1162430Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580694}

1. Autocomplete works on apps and playstore suggestions.
2. Autocomplete no longer works with less than 2 characters.

Bug: 865543
Change-Id: Ib438083463d76b7dbd4106b8cf8ae574a47fafcc
Reviewed-on: https://chromium-review.googlesource.com/1161511Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#580693}

Moved the feature flag to the mirroring service so that it can be
conveniently accessed by multiple components in coming CLs.

Bug: 734672
Change-Id: I4626b5240592a8d0ccee146675f034bbde8700db
Reviewed-on: https://chromium-review.googlesource.com/1162634Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580692}

Make SearchBoxViewBase have the option to record searchbox activation.

Override RecordSearchBoxActivationHistogram at app_list SearchBoxView.

Bug: 864790
Change-Id: I91001aaf188193f11d7448cb31ee75c76c1c8d6c
Reviewed-on: https://chromium-review.googlesource.com/1142575
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580691}

TBR=jdburocik@chromium.org

Change-Id: I5791bf6a4473815cd5c8577af6e431649c49f3b7
Reviewed-on: https://chromium-review.googlesource.com/1162834Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580690}

Telemetry tests are not idempotent. The original implementation:
https://codereview.chromium.org/1424693002 marked every IsolatedScriptTest as
idempotent=False. This incorrectly marked subsequently added IsolatedScriptTests
such as webkit_layout_tests as idempotent=False. This CL explicitly calls out
telemetry tests as idempotent=False -- other tests will default to
idempotent=True.

This CL adds the flag directly to test_suites.pyl for *telemetry_unittests*,
*telemetry_perf_unittests* and *telemetry_gpu_unittests*. For gpu telemetry
integration tests, the flag is added via generate_gpu_telemetry_test().

Change-Id: Ibd3839c0f24a418e7a87ed3b7bc0cec73963c062
Bug: 549140
Reviewed-on: https://chromium-review.googlesource.com/1161461
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580689}

https://chromium.googlesource.com/webm/libvpx.git/+log/2d79df494088..6fd9d0244c7d

$ git log 2d79df494..6fd9d0244 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 marpan vp9: Add screen-content mode to overshoot detection.
2018-08-03 marpan vp9: Adjust qp_thresh on slide change overshoot detection
2018-08-02 marpan vp9: Add zero_temp_sad count to scene detection.
2018-08-02 marpan vp9: Increase min_thresh for slide change detection
2018-08-02 huisu Refactor vp9_full_pixel_search()
2018-08-02 marpan vp9: Disable re_encode_overshoot feature for speed >= 6.
2018-08-01 huisu Handle partition cost better in RD search
2018-07-31 jingning Use mesh full pixel motion search to build the source ARF
2018-08-01 jianj vp9 svc: Adjust overshoot threshold in datarate test.
2018-08-01 jianj vp9: Refactor nonrd pickmode: new mv search
2018-07-30 jianj vp9: Refactor nonrd pickmode: interp filter.
2018-07-30 jianj vp9: Refactor nonrd pickmode: tx_size.
2018-07-31 jianj vp9 svc: Fix the scaling factor in intra only test for 1 SL.
2018-07-31 jzern vp9_encoder: make setup_tpl_stats() static
2018-07-31 marpan vp9: Clamp tx_size in model_rd_large
2018-07-31 jzern vp9: enable tpl model in high-bitdepth w/8-bit output
2018-07-31 jianj vp9: Disable aq mode for some datarate tests.
2018-07-31 marpan vp9: Remove assert from model_rd in non-rd pickmode.
2018-07-27 jingning Add frame pointer to support recon frames in tpl model
2018-07-27 jingning Move frame pointer assignment outside block loop in tpl model
(...)

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

BUG=b/112123926

Change-Id: I5adddb62cf63654739a3dc8f8ebe398fd5c744e4
Reviewed-on: https://chromium-review.googlesource.com/1162719Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#580688}

Previously, if a user was removed from the Login screen, all the other users' state was reset. This meant that |show_pin|, which is updated only once by a call to PinBackend::CanAuthenticate(), was reset to false even if PIN was enabled for that user.

Bug: 863480
Change-Id: I8824068f58413f8f561cd73836241840747dee27
Reviewed-on: https://chromium-review.googlesource.com/1161398
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580687}

This CL does two things(although looking huge):
- Adds a new MediaStreamType to specify getDisplayMedia() requests.(PS#2)
- Renames existing MEDIA_TAB* and MEDIA_DESKTOP* enums by adding
GUM to their name to distinguish these cases that originate from
calls to extension APIs and getUserMedia().(PS#1)

Bug: 326740
Change-Id: I1c4b47f1cb6c2fed478dcd265f9b1d9525efb4cb
Reviewed-on: https://chromium-review.googlesource.com/1160000
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580686}

This CL addresses an inconsistency in behaviour between explicitly
tapping "Cancel" in the add to home screen dialog and tapping outside
the dialog to dismiss it (also effectively cancelling).

Explicitly tapping on "Cancel" allowed the site to receive a new
beforeinstallpromptevent to trigger a new dialog, but tapping outside
the dialog did not. This CL removes the inconsistency by eliminating the
AddToHomescreenDialog.Delegate#onDialogCancelled() method (previously
only called when explicitly tapping "Cancel"), and maintaining state in
the AppBannerUiDelegateAndroid to determine whether or not to call
AppBannerUiDelegateAndroid#nativeOnUiCancelled(). This ensures a fresh
beforeinstallpromptevent is dispatched when the dialog isn't accepted -
whether it was explicitly cancelled or implicitly dismissed by tapping
elsewhere on the screen.

BUG=867465

Change-Id: I4e37d4a34e2b25797ee5bc386010de0b995e3d93
Reviewed-on: https://chromium-review.googlesource.com/1157945
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580685}

On cold start with a NTP opened as current tab and header is collapsed,
the suggestions status can be updated to explicitly disabled after the
UI is initialized, which removes the entire section including the
expandable header.

We should add the section back if necessary on status changed to
explicitly disabled.

Bug: 851516
Change-Id: Ied7c7737dfb22b3dc22f4a059c48f1b0793b681a
Reviewed-on: https://chromium-review.googlesource.com/1097226Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580684}

The suggestion container fades in and translates up on entry. It fades
out on exit.

See bug for spec/demo.

Bug: b:112145361
Change-Id: Id6abad171a22920658ce5b760b545c8d29cbed9f
Reviewed-on: https://chromium-review.googlesource.com/1160928
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580683}

Adds support for dynamically changing VrCore's settings during VR tests
using the VR settings service instead of only relying on them being
statically set before the test suite starts. Most tests still use the
old method since dynamic settings have additional overhead. However,
less standard test configurations such as enabling the DON flow are good
candidates for using this functionality.

Also changes the test suites that ran with the DON flow enabled to be
a generic "run with dynamic settings" test suite, which currently only
includes the DON flow tests.

Bug: 870782
Change-Id: I81482c959f0197c743e9a5a827d80c1b30a56757
Reviewed-on: https://chromium-review.googlesource.com/1162352Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580682}

We received a report that key events being delivered to JS did not
have the repeat field set correctly when KB lock was engaged, but
only on Windows.  It turns out this is becuase a low-level KB hook
on Windows is not given any params / flags which would indicate
whether the key event received was a repeat or not.

In order to address this problem, I've added some logic which tracks
the last key seen and compares it to the current event to see if we
should mark the event as a repeat or not.

BUG=869865

Change-Id: I0b3501ebd768e9c8b4c3c792d41b06e3de23eaf4
Reviewed-on: https://chromium-review.googlesource.com/1161458Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580681}

Bug: 80048435
Test: User EQ on video device w/ mixer
Change-Id: Iccd7ffb26e1cc75fbc79ec0bb1db04dc6551ee08
Reviewed-on: https://chromium-review.googlesource.com/1159694
Commit-Queue: Benjamin Shaya <bshaya@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580680}

Removes:
- not_site_per_process_interactive_ui_tests
- not_site_per_process_sync_integration_tests
- not_site_per_process_unit_tests

Bug: 870761,843511
Change-Id: I498ae273ffcef62698f0992783dbea89f1bbe7d1
Reviewed-on: https://chromium-review.googlesource.com/1161975Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580679}

This is a follow-up to https://crrev.com/c/1122489, which removed
the BattOr PowerTracingAgent from Chrome.

R=oysteine@chromium.org, dcheng@chromium.org

Bug: 859514
Change-Id: Ib4324289fcf9d1d0e3d34f828550a488a694644b
Reviewed-on: https://chromium-review.googlesource.com/1162626
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580678}

This is straight forward except for understanding what's up
with Restore. I've added a comment there, it may be
worth resolving in this change.

Bug:851762

Change-Id: I45b56b3f10dd96dae2b6c502030ced8e8ace026b
Reviewed-on: https://chromium-review.googlesource.com/1161178
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580677}

This reverts commit 0856d23e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Reland "[Sync::USS] Bookmark sync conflict resolution""
> 
> This is a reland of a445460b
> because it was reverted by mistake.
> 
> TBR=mastiz@chromium.org
> 
> Original change's description:
> > Reland "[Sync::USS] Bookmark sync conflict resolution"
> >
> > This is a reland of 553ec6da
> >
> > Original change's description:
> > > [Sync::USS] Bookmark sync conflict resolution
> > >
> > > This patch addresses the problem of conflict in bookmarks upon
> > > receiving a remote update for a node that has local changes.
> > >
> > > The general polic that is implemented is that server wins except in
> > > case of deletion.
> > >
> > > Bug: 516866
> > > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1
> > > Reviewed-on: https://chromium-review.googlesource.com/1157006
> > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#580436}
> >
> > Bug: 516866
> > Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e
> > Reviewed-on: https://chromium-review.googlesource.com/1161861
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580496}
> 
> Bug: 516866
> Change-Id: I285dfa50ae5374bc82840b6d140f99f7edddd552
> Reviewed-on: https://chromium-review.googlesource.com/1162181
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580553}

TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org

Change-Id: Ibd5c2c5ddd40a916dd8a2e04866ddedd46458da1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 516866
Reviewed-on: https://chromium-review.googlesource.com/1162841Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580676}

I made it so that clearDeviceOrientationOverride() delegates
to disable(), which is now more careful about clearing out the state.

For reference the PR that introduced the new
InspectorSessionState / InspectorAgentState / Fields
was https://chromium-review.googlesource.com/c/chromium/src/+/1149201.
We're migrating things from state_ to this new mechanism,
which allows incremental updates to flow back to the browser
process.

Bug:851762

Change-Id: I388198b01da77e04943a4c23e90f521e25aeab94
Reviewed-on: https://chromium-review.googlesource.com/1159697
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580675}

Uses CGAffineTransformMakeRotation to do a 180 rotation of
the collection cells accessoryView whenever a chevron is
being used on RTL.

Bug: 869142
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic10ebc0067e34a7fe8d593d4aafeb25dca4f9e99
Reviewed-on: https://chromium-review.googlesource.com/1162428
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580674}

This reverts commit e8b14cdd.

Reason for revert: Mistakenly reverted.

Original change's description:
> Revert "chromeos: splits ash's file list into public/sources sections"
> 
> This reverts commit 2e803140.
> 
> Reason for revert: speculative revert, seems to have introduced the following failure: https://bugs.chromium.org/p/chromium/issues/detail?id=870827
> Original change's description:
> > chromeos: splits ash's file list into public/sources sections
> > 
> > I'm putting all the '.h' files into public. We can refine the list as necessary
> > later.
> > 
> > I'm doing this as I would like to have private headers that other targets can't
> > include (well, except tests).
> > 
> > BUG=none
> > TEST=none
> > 
> > Change-Id: I84ab155a1449d969076dcd94feaa0150f3e9ad85
> > Reviewed-on: https://chromium-review.googlesource.com/1161498
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580581}
> 
> TBR=jamescook@chromium.org,sky@chromium.org
> 
> Change-Id: Icfed283e1b854f9639fe111fbd83b948b8d6147f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: none
> Reviewed-on: https://chromium-review.googlesource.com/1162207
> Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580630}

TBR=jamescook@chromium.org,sky@chromium.org,robertocn@chromium.org

Change-Id: I66a38be64c22fb1b6a6f808bfee64517f912e7ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1162212Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580673}

This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox

Bug: 850878
Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
Reviewed-on: https://chromium-review.googlesource.com/1152080Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580672}

Also use the correct type, size_t, for its size.

Some code cleanup and simplification.

Bug: 817982
Change-Id: I42f4d4230a60d64de8ea483450159c92475e3e4b
Reviewed-on: https://chromium-review.googlesource.com/1157649
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580671}

With error page isolation, navigations that result in a chrome error
page (as opposed to HTTP errors such as 404) are isolated in their own
process.

This CL adds some validations at commit time to ensure that invariants
we expect are enforced by the browser. It only includes some of the
possible checks, as more investigations are needed to understand the
behavior of HTTP layer errors.

Bug: 866549
Change-Id: I8389629eb68213681983b37d1cfc945832e35ea7
Reviewed-on: https://chromium-review.googlesource.com/1160877
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580670}

Make these polymorphic types so that we can provide a fake implementation
of libgbm for test purposes.

Bug: 869206
Test: ozone_unittests
Change-Id: I773cdac62bade798fbcddac54a2d5557ce1da8ce
Reviewed-on: https://chromium-review.googlesource.com/1162655
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580669}

This requires deleting WindowSelectorItem::RoundedContainerView.

screenshot: https://screenshot.googleplex.com/Gu5wG5LOPHY

Test: manual, run WindowSelectorTests
Bug: 839477
Change-Id: I933d0de5ba38a9c829d2266f945cc62fd2b5d7c9
Reviewed-on: https://chromium-review.googlesource.com/1161482
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580668}

https://webrtc.googlesource.com/src.git/+log/d54f5f5c763c..50eb4c44ad92


git log d54f5f5c763c..50eb4c44ad92 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 srte@webrtc.org Adds BBR field trial to CallTest.
2018-08-03 sakal@webrtc.org Fix remaining target name for AppRTCMobile_stubbed_video_io_test_apk.
2018-08-03 buildbot@webrtc.org Roll chromium_revision 06e87fb3..62642dd6 (580149:580526)
2018-08-03 oprypin@webrtc.org Remove Syzygy from deps
2018-08-03 oprypin@webrtc.org Fix gitignore pattern to never exclude sha1 files


Created with:
  gclient setdep -r src/third_party/webrtc@50eb4c44ad92

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iaf357cc4b58e9f9be30d6dd57fd3cbf51940b8d1
Reviewed-on: https://chromium-review.googlesource.com/1162386Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580667}

Bug: 869921, 854321,869955
Change-Id: I9d9ae5aa5c590cf0200e6953054dff1833fc7b76
Reviewed-on: https://chromium-review.googlesource.com/1161176
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580666}

Bug: 747557
Change-Id: I2997faa2de1cb384287afc5d4eb23c352b8ea7a5
Reviewed-on: https://chromium-review.googlesource.com/1157864Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580665}

This code is no longer hit after the switch to ws2.

BUG=none
TEST=none

Change-Id: I7ad3607d1db7f5d670c69e0bdcd386876ae2e942
Reviewed-on: https://chromium-review.googlesource.com/1162718Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580664}

The smooth-scroll animations are local frame root concepts. This move
will avoid a nested OOPIF same process with a parent to use the same
sequencer so their animations are independently scheduled.

Bug: 865446
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic07c22eef5d7a6ec25fe51c32d3e22e056398522
Reviewed-on: https://chromium-review.googlesource.com/1159189
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580663}

This CL contains following changes :
1 - Moved the storage summary text out of toolbar into RecyclerView due
    to font size issues.
1 - Renamed StorageSummary to StorageSummaryProvider which will provide
    the updated storage info through a delegate.
2 - Added StorageCoordinator which will own the provider, model, view
    and viewbinder and create the storage summary view to be shown
    inside RecyclerView.
3 - StorageSummaryProvider will be observing offline items and update the
    storage info on Add/Removes. Updates are ignored due to high
    frequency of updates.

Bug: 868547
Change-Id: I50a2f8c14d95b3f29aeec49fa34b08618b3bf3ba
Reviewed-on: https://chromium-review.googlesource.com/1157868
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580662}

This makes the views-login dialog more consistent with how the webui version looks.

Change-Id: I1c931623ae9c8b6408debe315ab7cac8d4cac742
Reviewed-on: https://chromium-review.googlesource.com/1162745Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580661}

This reverts commit 22333d92.

Reason for revert: suspected of breakage in 'generate_build_files': https://bugs.chromium.org/p/chromium/issues/detail?id=870827#c3

Original change's description:
> Fix missing dependencies with RLZ target.
> 
> chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly.
> 
> This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc
>  will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work.
> 
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
> Change-Id: I85d78d25b1905c68524e0636cec3006102d17749
> Reviewed-on: https://chromium-review.googlesource.com/1161610
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580579}

TBR=avi@chromium.org,jam@chromium.org

Change-Id: I5bca5200d639f01dbba1ed582d9dccb3290cf0c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Reviewed-on: https://chromium-review.googlesource.com/1162211Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580660}

ShowInactive() is usually used to make a hidden window visible without having it
also take key focus. It can also be used to raise an already-visible window
higher in the window stacking order (also without taking focus).

However, a quirk of AppKit is that calling orderWindow: will also trigger a
Space switch to the desktop containing that window, if Chrome is the active
application. Since we never want ShowInactive() to do that, and since child
windows can not control their stacking order, skip the call to orderWindow
for child windows, if the window is already visible.

Bug: 866760
Change-Id: I984c2ce8b0cb1754ee68e0392524c64739253ab9
Reviewed-on: https://chromium-review.googlesource.com/1161701Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580659}

Previously, each tab had its own SuggestedTextTouchBarController. Now,
because of http://crrev/c/1151613, there is only one
SuggestedTextTouchBarController per window. Because the controller does
not maintain the state of each tab, as a user switches tabs, the
controller needs to update its state to match the tab. When the
controller's WebContents change, new suggestions should be generated
for the selected text in the current tab.

The methods -webContentsTextSelectionChanged:range: and
-webContentsFinishedLoading were combined into a singular method,
-updateTextSelection:range:, because they had very similar
functionality.

The parameters for -requestSuggestionsForText:inRange: were removed
because they were always |text_| and |selectionRange_|.

A new method was created, -webContentsChanged, to get a tab's current
text and selected range and then call -updateTextSelection:range: with
the proper parameters.

When the controller gets a new pointer to a WebContents, the pointer
may be null. To avoid calling WebContents::IsFocusedElementEditable()
on a null pointer, a method -isTextfieldFocused was created to check
that |webContents_| is not a null pointer and that an editable element
is focused.

A new SuggestedTextTouchBarControllerBrowserTest was written,
SetWebContentsTest, to test that the SuggestedTextTouchBarController
properly updates its current text selection based on the new
WebContents.

This CL is the same as http://crrev/c/1153728 with the following
changes:
  - Browser tests for methods that are not restricted to MacOS 10.12.2+
    were modified to also run on earlier versions of MacOS. The
    expected behavior for different MacOS versions is accounted for in
    the tests.
  - A call to UnfocusTextfield() was added to SetWebContentsTest to
    ensure that a later call to FocusTextfield() works as intended and
    focuses an editable element.

Bug: 717553
Change-Id: Id061e392dd279e7a3cc9a34a023eb9bd97e52940
Reviewed-on: https://chromium-review.googlesource.com/1160929Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Cr-Commit-Position: refs/heads/master@{#580658}

Internal keyboard and touchpad events are previously locked when entering
tablet mode and unlocked when leaving. Now, when we attach a mouse, it
will exit tablet mode, but the keyboard should not stay locked as the
keyboard will be facing downwards in the case of flip chromebook. The
lock should instead be controlled by the hinges regardless if change in
hinge causes tablet mode to change.

Also rename EnterTabletMode to AttemptEnterTabletMode as it does not
always enter.

Test: ash_unittests TabletModeControllerTest.LeaveTabletModeWhenExternalMouseConnected
Bug: 870757
Change-Id: I38a537871aa6a1e7cd94311308d421af3dfc2ad1
Reviewed-on: https://chromium-review.googlesource.com/1162512
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580657}

Adding a glFlush at the end of every batch of decoded commands in
GLES2DecoderImpl::DoCommandsImpl eliminated this crash, but that is
somewhat egregious and hacky.

This adds a glFlush to every place where we switch virtual contexts,
doing the flush both before and after the state restore (and also
before switching away from a virtual context, just for good measure).

If the crashes don't re-appear then we can leave it at this. We will
eliminate virtual contexts when OOP-D and OOP-R are enabled. If this
isn't sufficient to eliminate the crashes, then we can go back to doing
a glFlush at the end of every GLES2DecoderImpl::DoCommandsImpl call, at
least for merging to Chrome 69.

Bug: 863817
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie8b4531ea800918eac42083ceecd5e65b9c02301
Reviewed-on: https://chromium-review.googlesource.com/1162516
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580656}