GitLab

Eliminate some duplicate code now that PermissionContextBase is the base class
for all other permission contexts and we have a helper function
GetPermissionContext to obtain the proper permission context class depending
on permission type. Also move PermissionToContentSetting to anonymous namespace.

BUG=

Review URL: https://codereview.chromium.org/896173002

Cr-Commit-Position: refs/heads/master@{#314866}

As some kind of optimization the yuv decoder replaced some pointers
to point to decoder-internal memory when an API user asked for
yuv data. That often worked, but failed if the data needed to
outlive the decoder. It was also a violation of the API contract.

This replaces that with a buffer copy. It will be slower but will avoid
random bitmap errors that also happened randomly on cq try bots.

This is a stopgap solution while a better solution is designed, coded and
tested.

BUG=455235
R=sugoi@chromium.org,dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/901573004

Cr-Commit-Position: refs/heads/master@{#314865}

BUG=455818

Review URL: https://codereview.chromium.org/872433005

Cr-Commit-Position: refs/heads/master@{#314864}

Spacing adjusted according to spec: http://goo.gl/vGZOmm
See screenshot(fixed version) at http://imgur.com/xptLuWK

BUG=452940
R=felt@chromium.org

Review URL: https://codereview.chromium.org/905543002

Cr-Commit-Position: refs/heads/master@{#314863}

This fixes some cases of the cursor disappearing temporarily after a
bounds change that started after r313336 ("Constrain the cursor when
overscan insets are set").

We hide the cursor during bounds changes, so we must make sure to show
it again afterwards.

BUG=427619
TEST=On link_freon, change the display resolution via Ctrl+Shift+Plus or
Ctrl+Shift+Minus, and make sure the cursor is visible afterwards.

Review URL: https://codereview.chromium.org/896343002

Cr-Commit-Position: refs/heads/master@{#314862}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/de358a9..797f58a

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/897343002

Cr-Commit-Position: refs/heads/master@{#314861}

The IME code in ui/base/ime depends on ui/ozone to support keyboard
control (via the InputController interface). This dependency is
currently missing from the build.

Unfortunately, we cannot simply add this dependency, because ui/ozone
depends on code from ui/base/cursor and ui/base/resource
(for cursor bitmaps).

Break this cycle by componentizing ui/base/ime & add a dependency
from the new ui/base/ime component to ui/ozone.

This also helps clean things up a bit because iOS builds ui/base
but not ui/base/ime. So there is already a fault line here.

The handful of IME tests are left as part of ui_base_unittests.

BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
  ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)
TBR=jam

Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82
Cr-Commit-Position: refs/heads/master@{#314815}

Review URL: https://codereview.chromium.org/889323003

Cr-Commit-Position: refs/heads/master@{#314860}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/481edde..abac64f

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/897233005

Cr-Commit-Position: refs/heads/master@{#314859}

The uploaded trace is currently inaccessible because of the stray
newline.

BUG=455782
TEST=upload a feedback report with trace & download tracing.zip

Review URL: https://codereview.chromium.org/869853004

Cr-Commit-Position: refs/heads/master@{#314858}

There is a lot of change here for relatively little effect.
That effect is important, however, for moving forward.

This depends on https://codereview.chromium.org/880653004/.

1) Move Picture::RecordingMode to RecordingSource, because
   Display List recording does not use Picture.
2) Add a new recording mode for disabled caches, which has
   meaning in Display List recording. Picture recording falls
   back to normal recording, while Display List recording
   uses painting disabled mode when null canvas is specified,
   because null canvas has no meaning for Display Lists.
3) Rename the enum in ContentLayerClient to reflect the new
   painting control modes and the changes in
   WebContentLayerClient.
4) Adjust all the code that uses these settings.
5) Adjust the benchmark code to make use of the new modes.

R=ajuma,vmpstr
BUG=451448

Review URL: https://codereview.chromium.org/900043002

Cr-Commit-Position: refs/heads/master@{#314857}

BUG=435063

Review URL: https://codereview.chromium.org/856353006

Cr-Commit-Position: refs/heads/master@{#314856}

BUG=455227

Review URL: https://codereview.chromium.org/892393006

Cr-Commit-Position: refs/heads/master@{#314855}

Can't repro this locally so maybe some more info will help understand
it.

R=enne, vmpstr
BUG=446751

Review URL: https://codereview.chromium.org/878743005

Cr-Commit-Position: refs/heads/master@{#314854}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/897773002

Cr-Commit-Position: refs/heads/master@{#314853}

Remove methods to get/set headers by "ID", which were never
implemented and have existed since initial commit.

Also remove GetAllResponseHeaders, which returns all response
headers in a single string with NULL characters between headers.
Shockingly, nothing is using this method.

BUG=455744

Review URL: https://codereview.chromium.org/905503003

Cr-Commit-Position: refs/heads/master@{#314852}

For developers who have opted in to showing a user-visible UI change on
every push (in exchange for showing the user a less scary permission
prompt), we currently[1] enforce that each push shows a notification.

This patch allows one in ten pushes to show no notification, so
occasional bugs in developer push handlers don't needlessly spam the
user.

Specifically, it keeps track of whether the last (up to) 10 push
messages showed a notification (ignoring pushes didn't show a
notification but were exempt, e.g. due to https://crrev.com/866443003)
and only shows a forced notification if one of those (up to) 10 also
failed to show a notification.

[1]: (since https://crrev.com/842233003)

BUG=437277

Review URL: https://codereview.chromium.org/883743002

Cr-Commit-Position: refs/heads/master@{#314851}

BUG=414438

Review URL: https://codereview.chromium.org/897953002

Cr-Commit-Position: refs/heads/master@{#314850}

BUG=none
R=jpmedley@chromium.org
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/901083002

Cr-Commit-Position: refs/heads/master@{#314849}

This CL is based on the blink patch https://chromiumcodereview.appspot.com/861773003/ and refactors the sudden termination API so that the presence of BeforeUnload and Unload handlers preventing it is accounted on a per-frame basis instead of a per-process basis.

BUG=365039

Review URL: https://codereview.chromium.org/857213003

Cr-Commit-Position: refs/heads/master@{#314848}

* Introduce TypeList as helpers.
* Drop bind_internal.h.pump and replace generated codes with Variadic Templates version.

BUG=433164

Review URL: https://codereview.chromium.org/743853002

Cr-Commit-Position: refs/heads/master@{#314847}

BUG=417532

Review URL: https://codereview.chromium.org/859413003

Cr-Commit-Position: refs/heads/master@{#314846}

We have now moved to a better place where we no longer swizzle
NSThemeFrame's drawRect, and use a subview instead
(TabStripBackgroundView).

We also no longer add subviews to NSThemeFrame (with the
exception of TabStripBackgroundView), and use a full-size
content view instead.

This is a clean-up of code that relies on outdated assumptions.
For example, FramedBrowserWindow was unnecessarily calling
setNeedsDisplay and setNeedsDisplayInRect.

BUG=453996

Review URL: https://codereview.chromium.org/871423004

Cr-Commit-Position: refs/heads/master@{#314845}

Do not re-select active device if a lower priority device is hotplugged in and user has already selected active device previously.

BUG=447826

Review URL: https://codereview.chromium.org/872303003

Cr-Commit-Position: refs/heads/master@{#314844}

Add AlternateProtocol (port and protocol) to
HttpServerPropertiesImpl::broken_alternate_protocol_list_ and
HttpServerPropertiesImpl::broken_alternate_protocol_list_ in preparation for
supporting multiple AlternateProtocols per host.  See draft at
https://crrev.com/665083009 for how this fits into a larger picture.

BUG=392575

Review URL: https://codereview.chromium.org/888943003

Cr-Commit-Position: refs/heads/master@{#314843}

See bug description for more info.

BUG=455523

Review URL: https://codereview.chromium.org/901093003

Cr-Commit-Position: refs/heads/master@{#314842}

BUG=454828
TBR=maruel@chromium.org,thestig@chromium.org

Review URL: https://codereview.chromium.org/868313006

Cr-Commit-Position: refs/heads/master@{#314841}

This fixes a client side issue that contributes to crbug.com/439110.

The code that updates Sync Data with meta info from bookmark model is changed
to verify whether the new meta info is equivalent to the original one to avoid
doing an unnecessary mutation due to reordering of entries. The reordering occurs
due to sorting by key when MetaInfo is retrieved from BookmarkSpecifics in the
first place and added to MetaInfoMap.

BUG=455291

Review URL: https://codereview.chromium.org/896073002

Cr-Commit-Position: refs/heads/master@{#314840}

Update the Chromium uses of the Blink Web Notification-related API headers
to match the new locations of these files.

This is part of a three-sided patch:
  [1] https://codereview.chromium.org/872313003/
  [2] This patch.
  [3] https://codereview.chromium.org/869343005/

BUG=453032

Review URL: https://codereview.chromium.org/893993002

Cr-Commit-Position: refs/heads/master@{#314839}

Used to check if a package has been installed.

BUG=453170

Review URL: https://codereview.chromium.org/897063004

Cr-Commit-Position: refs/heads/master@{#314838}

BUG=453626

Review URL: https://codereview.chromium.org/903713002

Cr-Commit-Position: refs/heads/master@{#314837}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/528f97f..de358a9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/904703002

Cr-Commit-Position: refs/heads/master@{#314836}

Chrome Data Reduction Proxy stores proxy URLs as proxy server objects
instead of GURLs. This enables us to support QUIC based proxies.

BUG=454576

Review URL: https://codereview.chromium.org/863203009

Cr-Commit-Position: refs/heads/master@{#314835}

1. Remove ppb_image_capture_config_private.
2. Remove PPB_ImageCapture_Private.{Set|Get}Config
3. Remove PPB_ImageCapture_Private.CaptureStillImage

BUG=387547
TEST=None

Review URL: https://codereview.chromium.org/884483007

Cr-Commit-Position: refs/heads/master@{#314834}

When an affiliated per-profile invalidation service becomes available,
the AffiliatedInvalidationServiceProviderImpl should:
1) tell consumers to stop using the device-global invalidation service
2) destroy the device-global invalidation service

These two steps were swapped, causing a crash as the consumers did not
get a chance to remove their handlers from the device-global
invalidation service before it is destroyed.

BUG=455504
TEST=Extended unit test to protect against regressions

Review URL: https://codereview.chromium.org/897113003

Cr-Commit-Position: refs/heads/master@{#314833}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/43cf606..481edde

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/902493007

Cr-Commit-Position: refs/heads/master@{#314832}

BUG=455750

Review URL: https://codereview.chromium.org/884123003

Cr-Commit-Position: refs/heads/master@{#314831}

This CL removes the RequestNavigation IPC. Instead, browser-side navigation
will now send a BeforeUnload IPC to the renderer if needed and wait for a
BeforeUnloadACK to proceed with navigations.

BUG=376006

Review URL: https://codereview.chromium.org/872473003

Cr-Commit-Position: refs/heads/master@{#314830}

Review URL: https://codereview.chromium.org/895933005

Cr-Commit-Position: refs/heads/master@{#314829}

This make sure that if it has been decided that MJPEG should be used in DirectShow
after enumerating the device capabilities, the input pin enumerates MJPEG as the onle and only format.

BUG=454869

Review URL: https://codereview.chromium.org/900233002

Cr-Commit-Position: refs/heads/master@{#314828}

I'm taking over the implementation of this API from mkosiba, who has
written a large part of this change here:
https://codereview.chromium.org/784343002/

Review URL: https://codereview.chromium.org/831903004

Cr-Commit-Position: refs/heads/master@{#314827}