- 02 Jan, 2018 40 commits
-
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/5f99e656792b..9185bde7ee18 $ git log 5f99e6567..9185bde7e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iab56978335dd5bfee1870112686970df593a53b2 Reviewed-on: https://chromium-review.googlesource.com/846525Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526500}
-
kapishnikov authored
BUG=719977 Change-Id: Ia72e8bd5c4825fc66aedab5b6b4b1b7bd2964644 Reviewed-on: https://chromium-review.googlesource.com/846299Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526499}
-
Sylvain Defresne authored
The placeholder does not interact with high-level UI from chrome, and from of the point of view of chrome is a web-level API, so it make sense to have the tab helper be self-contained. Bug: none Change-Id: I12c7f9601aaf3e86d4d57bdd40ae4760ece03b5d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/842547 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526498}
-
Jonathan authored
When adding telemetry_perf_unittests_viz I thought the isolate would just run the targeted script. However it also tries to build a target of the same name. Since this is an override, there is no target. This change adds the executable override to the isolate definition. TBR=dpranke@chromium.org Bug: 795760 Change-Id: I2482275fffd3cfdee542ddb509f287d37fb75d1a Reviewed-on: https://chromium-review.googlesource.com/847420Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#526497}
-
Stephen White authored
Remove the GR_TESSELLATOR_LEGACY_INVERSION_HANDLING #ifdef. This enables the partial straight skeleton (phase 2) in Skia. BUG=756823,754612,754293,723980,728070 Change-Id: I70b4daef016dc950002cb0e98073bc90696b2ab9 Reviewed-on: https://chromium-review.googlesource.com/843082Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#526496}
-
Boris Sazonov authored
Bug: None Change-Id: I497e5e058d148610bfeb813b287e6bd1961b17ee Reviewed-on: https://chromium-review.googlesource.com/839601Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526495}
-
Jan Krcal authored
This CL fixes a crash when trying to clear on-demand icons when the databases haven't been inited yet. Since this is a non-critical task that can be arbitrarily delayed, we use a simple early return in this case. Bug: 794299 Change-Id: Ie4c0945a7f2d1136bfbb91428f4f815617ad9a83 Reviewed-on: https://chromium-review.googlesource.com/824238 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#526494}
-
Jinho Bang authored
Should use std::make_unique directly instead of using base::MakeUnique since August[1]. So, this change removes usages of base::MakeUnique in //components/npt_snippets. [1] https://chromium-review.googlesource.com/c/chromium/src/+/616016 Bug: 755727 Change-Id: I7628bd96729646ee03b94835e220021b04564eb7 Reviewed-on: https://chromium-review.googlesource.com/846644 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#526493}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/adc78d52024f..8716b50aae94 $ git log adc78d520..8716b50aa --date=short --no-merges --format='%ad %ae %s' 2017-12-27 brianosman Update per-geo color after simplifying FPs in GrAtlasTextOp Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I6441ebb8706a905d256d68059f42813dca38a447 Reviewed-on: https://chromium-review.googlesource.com/846432Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526492}
-
Danyao Wang authored
WebState::IsEvicted() returns [CRWWebController isViewAlive]. The latter is true if there is a presented web view or native view. With WKBasedNavigationManager, a web state may be incorrectly considered evited when transitioning from NTP to a web URL: the native controller is already freed at this point, but the web view is not yet presented. This is not a problem in LegacyNavigationManager because web view is created after the navigation for the web URL starts and is immediately presented. With WKBasedNavigationManager, web view is created when loading the NTP (placeholder page). When loading the web URL, because a web view already exists, |-displayWebView| is not called again even though it should. The bug causes incorrect page load counts in TabUsageRecorder. Bug: 789993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I68433c477cedebda29d08ec9716b0e92cb9d6442 Reviewed-on: https://chromium-review.googlesource.com/831049Reviewed-by:
-
Gauthier Ambard authored
The accessibility is now done downstream. Bug: 798075 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71243ea8769212737d1b6d4650254b4363e364ab Reviewed-on: https://chromium-review.googlesource.com/846987Reviewed-by:
-
Colin Blundell authored
In preparation for introducing more implementations of this interface, this CL gives the three methods empty implementations. The soon-to-be-added implementations of this interface need to override only one of the methods. Change-Id: I76e547a2ca3d2e56f361195071beb23481566707 Reviewed-on: https://chromium-review.googlesource.com/844634Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#526489}
-
Vadym Doroshenko authored
In HTML 5 there is an option to have input elements that are not inside <form> tag, but which are associated to some <form> with form attribute. An example is changes in this CL in password_controller_unittest.mm. This CL replaces usage of form.getElementsByTagName('input') which returns only elements that are inside form to call corresponding function from common.js (which uses form.elements under hood) in order to get associated elements. Bug: 775831 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20f0f7b49b2bccd31db473a38b110802e28b24f1 Reviewed-on: https://chromium-review.googlesource.com/846768Reviewed-by: -
Torne (Richard Coles) authored
This was missed when upstreaming O-specific changes to WebView, and is required for Instant Apps to be able to use WebView. Add it as a jinja variable instead of to the template to avoid a downstream breakage (will clean up in followup. Bug: 797014 Change-Id: I21f94eb5f84388421804562d820fbfcdec1ca19b Reviewed-on: https://chromium-review.googlesource.com/843167Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#526487}
-
Ian Vollick authored
With this change, pressing "b" in the test app will dump the scene hierarchy with a text representation of the bindings. The extra strings are not included in release builds. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iab31e5d81ad7c594c903555fad28e8eae978205d Reviewed-on: https://chromium-review.googlesource.com/847278 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#526486}
-
John Chen authored
Fix the implementation of get local storage keys and get session storage keys functions. Bug: chromedriver:2177 Change-Id: Iac8e8155081190d92dc14a54f9c367337f2ebe86 Reviewed-on: https://chromium-review.googlesource.com/844354Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526485}
-
Jeremy Roman authored
It is unimplemented and unused. Change-Id: I8b832a13db4d460d926dd3bd84a84ecd3acc7fb7 Reviewed-on: https://chromium-review.googlesource.com/844020Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526484}
-
Torne (Richard Coles) authored
We use commas to pass multiple types across the JNI boundary as a single string (in aw_web_contents_delegate.cc), but then try to split using semicolons on the Java side, so file upload pickers only worked correctly for the case of a single acceptable file type. Use comma instead when splitting. Bug: 780826 Change-Id: I4e360e81e71f9d565005fd026b889a74240b3795 Reviewed-on: https://chromium-review.googlesource.com/842926Reviewed-by:
-
Juan Antonio Navarro Perez authored
Test has been consistently failing on webview bots. Bisect was unable to find culprit. TBR=nednguyen@google.com NOTRY=true Bug: 797261 Change-Id: Ia0bf67071777bc98e5aea77c729ce5d7f2971e2d Reviewed-on: https://chromium-review.googlesource.com/847575Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#526482}
-
John Budorick authored
Moving over from chromium_tests configurations. Change-Id: Ia5fa5f4a3d8b0d8bd66fe08446a202748bd1d576 Reviewed-on: https://chromium-review.googlesource.com/845128Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#526481}
-
maxmorin authored
Bug: 798116 Change-Id: I3e13b4f313edac0a951d417b919df0be4332778a TBR: Reviewed-on: https://chromium-review.googlesource.com/847478Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526480}
-
Mark Cogan authored
For most of the TabModel notifications, the only observer is the BVC, which is already a TabModelObserver. This CL starts the process of folding all of the TabModel notifications into TabModelObserver calls. All of the changes in this CL are straightforward: instead of sending a notification, instead the caller calls a method on TabModel (in the same pattern as -notifyTabChanged), which calls TabModelObserver methods that map to the old notifications. The BVC's notification handling code is moved into these new methods and relocated as appropriate, but is otherwise unchanged. This removes all but two of the notifications. Follow-up CLs will remove the others. Bug: 320877 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1d17178181b69f9b083aed137856c11255b94429 Reviewed-on: https://chromium-review.googlesource.com/847532 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
maxmorin authored
Bug: 780555 Change-Id: I2868681e763958b200735bb27a6c423b170393f4 Tbr: peconn Reviewed-on: https://chromium-review.googlesource.com/846991Reviewed-by:
-
Robert Hogan authored
Bug: 797185 Change-Id: I2521e1cf552be56abba6513eada51cad571d2cca Reviewed-on: https://chromium-review.googlesource.com/844074Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#526477}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7fc07bf6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/9445 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol TBR=foolip No-Export: true Change-Id: I1132285ea830bb082b493e1c551d2c083f0c908a Reviewed-on: https://chromium-review.googlesource.com/847412 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526476}
-
Jochen Eisinger authored
We pass the suggested filename along with the request and use that as a signal that the navigation should result in a download. The next step will be to ignore this hint for cross origin downloads, so that only files with a content-disposition will end up being downloaded. Bug: 714373,797292 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I508d7abe1cba9b75d65132b0688984cdebfc6fd4 Reviewed-on: https://chromium-review.googlesource.com/758236 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Min Qin(OOO 12/7-1/10) <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526475}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a06e01c8..bfbaf6ac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I07666a0f22f945ab1b10572c5a343329cab92ea9 Reviewed-on: https://chromium-review.googlesource.com/847416Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526474}
-
Mike West authored
Chrome is failing 7 cookie tests. Amazingly, Firefox and Safari are failing the same tests! How shocking. This patch fixes the tests, which were broken in three ways: 1. `fetch()` needs to accept credentials explicitly via a `credential` parameter. 2. Invalid `path` components default to the directory of the file setting the cookie, which was distinct between `//cookies/path/echo-cookie.html` and `//cookies/resources/set-cookie.py`. 3. `ws://` is blocked when requested from HTTPS. Change-Id: I0a8f0869e35c2e8316fb36e796d4c657d931b967 Reviewed-on: https://chromium-review.googlesource.com/839520Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#526473}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-cues-missed.html 2. track-cues-pause-on-exit.html 3. track-cues-seeking.html 4. track-cues-sorted-before-dispatch.html Bug: 782555 Change-Id: I5d80f910a048b74702625806dea148096ac89fc2 Reviewed-on: https://chromium-review.googlesource.com/847396Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526472}
-
maxmorin authored
fast/history/history-back-twice-with-subframes-assert.html flakily times out. Bug: 798121 Change-Id: Idfb693776a84ca1946ec0771fcd2fd2f71a80f10 Tbr: Reviewed-on: https://chromium-review.googlesource.com/846990Reviewed-by:
-
Daniel Bratell authored
Several files include highcontrast_classifier.h so jumbo builds got duplicate instances of everything in the header file. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ibfe824f52d4b1f6046b75e4621f662ce0bf1d0c3 Reviewed-on: https://chromium-review.googlesource.com/847572Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#526470}
-
k2.nagaraju authored
updated the line, position and size properties to double updated test cases and expected results Bug: 699063 Change-Id: Icc179032077e0e1351efed64cc5a965ee254ca09 Reviewed-on: https://chromium-review.googlesource.com/836576Reviewed-by:
-
Mythri Alle authored
Now V8 has an API to request code cache. Earlier, we had to request code cache along with compile requests. Since we have an explicit API to request code cache, we want to decouple compile and code caching. As a part of this, we want to change v8::ScriptCompiler::CompileOptions by removing kProduceCodeCache, kProduceFullCodeCache and adding kCompileEager. To smoothly integrate these changes into chromium, introducing a default case in the switch statements using CompileOptions. This will be removed once the V8 roll that adds these options is rolled into chromium. Bug: chromium:783124 Change-Id: Ia4e72e2a00f72f81e21949f6e892250bf4bfb7c5 Reviewed-on: https://chromium-review.googlesource.com/831951Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#526468}
-
Daniel Bratell authored
There are two identical GetImageInfo functions in the blink/html code and only one of them is used. This patch deletes the unused one. This was noticed in a non-standard jumbo configuration because both instances ended up in the same translation unit. Change-Id: I4b0959fcc1bf9a0902a6d8574023e9b59de60375 Reviewed-on: https://chromium-review.googlesource.com/847474Reviewed-by:
-
maxmorin authored
These tests are now very flaky. Bug: 775415, 787809, 787938, 791022, 796047 Tbr: phoglund@chromium.org Notry: True Change-Id: I3ace2542e573d533aab6cfbc1558e4a7ebccce30 Reviewed-on: https://chromium-review.googlesource.com/846882Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526466}
-
Mounir Lamouri authored
Bug: 797901 Change-Id: Ifd4e4d658777d22e78117eedd9251f120ea48e24 Reviewed-on: https://chromium-review.googlesource.com/845684Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526465}
-
Rune Lillesveen authored
Change-Id: Ia61e2fdc14d5df0f8ba05a93509667565b834261 Reviewed-on: https://chromium-review.googlesource.com/846764Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3cbf26e8..a06e01c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I48c74700800382d39318cc76a458cadf6311811f Reviewed-on: https://chromium-review.googlesource.com/847452Reviewed-by:
-
Becca Hughes authored
Single tap on controls to toggle the UI instead of play/pause. BUG=794592 Change-Id: Idfc6ea6eb1ade43344955a48512385db083a06ba Reviewed-on: https://chromium-review.googlesource.com/833915 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526462}
-
maxmorin authored
Bug: 798253 TBR: kinuko Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I98878c3452c00dccaecfd1c73223176f474d782c Reviewed-on: https://chromium-review.googlesource.com/847434Reviewed-by:
-
