- 28 Mar, 2019 40 commits
-
-
Mike Wittman authored
The frame that's currently executing can be immediately recorded from the values in the register context, independent of any unwinding. This change separates the initial frame recording from the recording within the native unwinding, which will be required to support restarting native unwinding after v8 unwinding. Also adds comments documenting the overall structure of the frame unwind algorithm. Bug: 909957 Change-Id: I981fe7c7c8b6019d8fc34dcdb08c22ec744b08ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540314 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#645310}
-
Pavel Shmakov authored
CustomTabActivityTabController Extracting CustomTabNavigationController will consist of (at least) two steps: - Extracting navigate() method - Extracting back/close navigation This CL is the first step. Currently the url navigation code is in CustomTabActivityTabController#loadUrlInTab. In addition to exposing this public method, the TabController also calls it itself to load the initial url when the tab is ready. Both of these things are not good from single responsibility perspective, and need a separate class each. To achieve that it became necessary to expose the way the initial tab was created and update the Observer interface correspondingly. To keep things tidy, holding onto the Tab, the creation method, and observer management was extracted into CustomTabActivityTabProvider (this is something we were planning to do eventually anyway). In this CL the code becomes structured as follows: TabController - minds the tab creation and initialization business, no longer navigates to any urls. Updates TabProvider (via package-local methods). TabProvider - hold the current tab and information about how the initial tab was created. Dispatches changes to observers. Typically, the features should only need to use TabProvider, but not TabController. NavigationController - navigates to urls. Will also contain back/close navigation in future. InitialPageLoader - observes TabController and commands NavigationController to navigate to the initial url. Bug: 916528 Change-Id: Ic26ef955ab8e3e0bd926461c71ef740361686f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530884 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#645309}
-
Ehsan Karamad authored
Removing unused methods and includes. TBR=wjmaclean@chromium.org Bug: None Change-Id: I2464652110bfa2fd9a2749d48c9ddcca5add92b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543449Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#645308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a82d8927e675..68845f14d6d5 Created with: gclient setdep -r src-internal@68845f14d6d5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I425976b759b0a07a707b0a73e90abd25b3335475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645307}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/events, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ifeab051f00cf5846910c14e2aebdb7183fc16646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541550Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#645306}
-
Elly Fong-Jones authored
This change removes: * video-rotate-to-fullscreen * video-fullscreen-orientation-lock and their backing features, as well as every dependency on them. Bug: None Change-Id: Iaed3f8f7de68c034527e3be2a4ef1d568b594748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540301 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#645305}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1ba2cb8589a8..339bd9d4470d git log 1ba2cb8589a8..339bd9d4470d --date=short --no-merges --format='%ad %ae %s' 2019-03-28 cwallez@chromium.org Add dawn_wire entrypoints to inject texture in the wire 2019-03-28 yunchao.he@intel.com Vulkan: Fix layout of destination image of T2T copies 2019-03-28 yunchao.he@intel.com Some small optimizations and style issues for input state 2019-03-28 cwallez@chromium.org Make Wire tests more strict w.r.t. expectations Created with: gclient setdep -r src/third_party/dawn@339bd9d4470d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:941543,chromium:941543 TBR=cwallez@chromium.org Change-Id: I507c9197e8f4afa8e44f4e005023836e00667602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645304}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I183ad53789b6b179b0f8979a329c59c9db8fca8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1461039Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#645303}
-
Robert Flack authored
Describe the creation flow of newly started compositor animations with a dotty diagram. Change-Id: I893ad2fbe781af4e49c6adbf0af139298080165f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540540 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#645302}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ce584cf1d926..e5cc85b5c53f git log ce584cf1d926..e5cc85b5c53f --date=short --no-merges --format='%ad %ae %s' 2019-03-28 titovartem@webrtc.org Introduce dynamic endpoints 2019-03-28 henrik.lundin@webrtc.org NetEq fuzzer: shorten the maximum fuzzer input 2019-03-28 nisse@webrtc.org Refactor VideoEncoderWrapper, to let EncodedImage own the data buffer. 2019-03-28 nisse@webrtc.org Delete unused methods from VCMReceiveStatisticsCallback Created with: gclient setdep -r src/third_party/webrtc@e5cc85b5c53f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942886 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I480ffd5d40ef501dd6bbd92043164d74aa1e5844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543119Reviewed-by:
-
tsrwebgl authored
Status bubbles for short URLs now match the width of the URL Tested by mousing over various links to make the status bubble appear. Bug: 936144 Change-Id: Ia6e4735a84e4d02f560b860b93e6dbc2066ff63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529187 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#645300}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1fae2e20. With Chromium commits locally applied on WPT: 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If419a8e566c586aa1b0f9ab7c29298628ad7b806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543327Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645299}
-
Vincent Boisselle authored
Query requests can have a different request signature between version A and B, we want to serve the same response cached at the moment of capture. The replayer generates a cache-lookup key that is likely to remain stable across versions. The cache replayer reuses the WPR capture file. There is no need for extra test artifacts. Bug: 945929 Change-Id: I504a407265a4b1d8e62dfbaf3135a8abbd1fdac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531574 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#645298}
-
Robert Flack authored
Bug: 947013 Change-Id: Iaef076ff7fbca30c0b1879b79e4926d45123d319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543024 Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#645297}
-
Noel Gordon authored
Flakes [ Timeout Pass ] on Win7 Release. Tbr: findit@ No-try: true No-presubmit: true Bug: 946700 Change-Id: I226069041f5a0d802f3863fca001537c13f342cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543372Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#645296}
-
Laís Minchillo authored
Fix 2 instances of MediaControlsNonTouchImpl that should have been renamed to MediaControlsTouchlessImpl in http://crrev.com/c/1540290 Bug: 946985 TBR: jazzhsu@chromium.org Change-Id: Id1d18471c95630802307ff918e5905b429e9540d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543392Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#645295}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e51181387f76..78a282f49b55 git log e51181387f76..78a282f49b55 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 bratell@opera.com Add an include guard to SkottieShaper.h Created with: gclient setdep -r src/third_party/skia@78a282f49b55 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Id93a8b47c388bcba69515a3f0f8e386e3399adf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541741Reviewed-by:
-
Oleh Prypin authored
This compiler config is used by other projects, and at least WebRTC is not switching to component builds. `build_with_chromium` variable is supposed to be true only when the current root project is Chromium, so do the check only then. Bug: 945515 Change-Id: I37076a8724a0b9a067b20dec9186d551e41fc898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543251Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645293}
-
Hans Wennborg authored
instead of costly virtual functions. This saves on code size, data size, number of dynamic relocations, and makes accessing these properties faster. Bug: none Change-Id: I1750f8d8e03c1ff4925a86778c6f65ae7125a566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538527 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#645292}
-
David Jean authored
Moved feature_engagement metrics to browser level (already existing through notification) Changed inIncognito to isUserInitiated on new tab notifications (specific notifier are already tied to a browserState which knows its incognito state) Bug: 907527 Change-Id: I86fa5cef147c5c59765f03887a9d18866d2a7f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528974 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#645291}
-
Noel Gordon authored
Flakes [ Pass Timeout ] in release. Tbr: findit@ No-try: true No-presubmit: true Bug: 946699 Change-Id: I5f579ec62365b7d2185df5badbeed1a184426a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543371Reviewed-by:
-
Gauthier Ambard authored
This CL moves the location bar's notifications to the LocationBar folder. Bug: 944008 Change-Id: I11c31a38d7155dec089bbdef40fe513e2dff0d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541225Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that when the user long presses on an element displayed on the NTP, we unfocus the omnibox before showing the popup menu. Bug: 928237 Change-Id: I271e2eb5ca0965b05cbba8f35ef8f08e8f8ba578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541172 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#645288}
-
Karolina Soltys authored
Bug: 863341 Change-Id: I85344234e260c41c6aea326fa2d1e31ce2012c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541248Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#645287}
-
Richard Knoll authored
A recent change (http://crrev.com/c/1521961) broke the workaround we need to prevent recreating the ink drop on bound changes. This now creates a custom InkDropImpl that overrides HostSizeChanged to fix it again. Also finally added a test for this by checking whether the animation is still running after changing the widget bounds to spot this in future. Bug: 915222 Change-Id: I4ace1c6fceea7d7f6c0527e0538b39079ce054a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538430Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#645286}
-
Noel Gordon authored
Flakes [ Timeout Pass ] in release. Tbr: findit@ No-try: true No-presubmit: true Bug: 946714 Change-Id: Ib40f9ca49c08b43dba52ebacd1900d271400aff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541555Reviewed-by:
-
Dominic Battre authored
This is the beginning of writing a README for the password_manager. The purpose is not to replace inline documentation but to serve as a reference for new-comers or to refresh your mental picture of some highlevel aspects. Change-Id: I5dae87a1d789e3542805212b849014b5231fa056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541186Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: Ib92f11319ee77ac372a33b80c950385b96474d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532340 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#645283}
-
Mohamed Abdelhalim authored
This is a preliminary change to merge the navigation states inside NavigationRequest::NavigationState. Bug: 916537 Change-Id: Ic5cdbaa9915ce3567abb6997327275ba266aa8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541080 Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#645282}
-
Jonah Ryan-Davis authored
This reverts commit 78b558a1. Reason for revert: 1 tests failed: ['vulkan_content_browsertests on (nvidia-quadro-p400-ubuntu-stable) GPU on Linux'] https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20Release%20%28NVIDIA%29/9112 Original change's description: > Add SkiaOutputDeviceGL > > This CL moves some platform specific logic out of > SkiaOutputSurfaceImplOnGpu and into SkiaOutputDeviceGL. I also added the > hooks to support partial swaps and tested on an i7 gLinux laptop. > > Bug: 920344 > Change-Id: I77b86442fef2340094de9fa93057f1fa2af2f50b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539792 > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645059} TBR=penghuang@chromium.org,backer@chromium.org Change-Id: I6eff445f1e0c9d4b250267c89b2b937f71270e2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542422Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#645281}
-
arthursonzogni authored
With RenderDocument: https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit# a new RenderFrameHost is used after every navigations, not only the cross-process ones, but also the same-process ones. This CL updates tests so that they don't assume the RenderFrameHost to be preserved. Bug: 936696 Change-Id: I222e6a76cb9d16b68cb4802a09bc41ebd9d1bd9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538295 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#645280}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I307964b426acb4f67937e991eac2d979df97290e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542372Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4ae7c804a8ed3688d276d6fbdb30f7a54bc282bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542318Reviewed-by:
-
Hans Wennborg authored
We used to have a version number for the plugin in this CMake file, so changing it should cause things to be rebuilt, but that hasn't been the case for some time. As Nico figured out, this way of versioning the plugin was removed in https://codereview.chromium.org/975503002 Bug: 416124 Change-Id: If4808ea8447e1b39435059021657536afb65db35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541238 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7b7d2ef..4f260ee2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab17fdcdec28c5c396cd2bafc65af5b99f87c6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543023Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645276}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: None Change-Id: I870b79a125c874212027336343a86a1d5cc83043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541656Reviewed-by:
-
Gabriel Charette authored
This reverts commit 1e4fa9e1. Reason for revert: root caused fixed by crrev.com/644548 as mentioned @ https://bugs.chromium.org/p/chromium/issues/detail?id=938126#c42 Original change's description: > Disable MediaInternalsAudioLogTest.AudioLogCreateStartStopErrorClose > > Disable the test on Android, Linux and Fuchsia due to flaky. > > Tbr: petewil@chromium.org > Bug: 938812 > Change-Id: I96504518c8556d5e8cdfb60a9e74c5dc8e1040ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506380 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638226} TBR=zmin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 938812 Change-Id: I68c426318ecab6994fdd9588d32edcc620719dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542038 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#645274}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3993b18795b5..ce584cf1d926 git log 3993b18795b5..ce584cf1d926 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 eladalon@webrtc.org Remove Remb::kFeedbackMessageType 2019-03-28 danilchap@webrtc.org Remove CreateVideoStreamEncoder version that uses GlobalTaskQueueFactory Created with: gclient setdep -r src/third_party/webrtc@ce584cf1d926 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If5e8f46e135b68ba154786556fe9fdfed76c0d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542375Reviewed-by:
-
Noel Gordon authored
external/wpt/content-security-policy/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow.html The test flakes timeout-pass on most bots. Update expectations. Tbr: foolip@ No-try: true No-presubmit: true Bug: 945774,626703 Change-Id: Ibc96e4939b264f9dd85def363c4148e3a5b592a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541554Reviewed-by:
-
Ramin Halavati authored
Seperator addition policy in profile menus was wrongly set in crrev.com/c/1499457 to add the separator only before the first group while the correct behavior is to add it before all groups except the first. Bug: 934689 Change-Id: I5c7a515199c526b259912a67c5ac84e097ac191d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543256 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#645271}
-
