- 19 Sep, 2017 33 commits
-
-
Xiaochu Liu authored
It exposes a dbus method call LoadComponent that calls component updater API to install a chrome os component. BUG=chromium:763415 TEST=dbus-send is working on chrome os, component is downloaded. Change-Id: Iffd98416484b960352f4aa5724b7759a7936569f Reviewed-on: https://chromium-review.googlesource.com/668739Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502754}
-
Sidney San Martín authored
Change several small things after a review by bettes@: - Make the shelf slightly shorter. - Align the menu with the edges of the menu button. - Ditch the download started animation. - Update the look of Harmony buttons. - Use slightly darker icon colors. - Make the progress indicator stroke slightly thinner and move it inside the circle. Also: - Fix broken hover button active states (a switch statement was missing some `break`s). - Fix a hang on 10.11 (-viewWillDraw happens too late in the update cycle for some changes, -layout is early enough). Bug: 589943, 517992 Change-Id: I4f10f5267b676f4f7e5f9b53d80991efe3960423 Reviewed-on: https://chromium-review.googlesource.com/671144Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#502753}
-
Daniel Park authored
Saves the current date in a SharedPreference when Chrome Home is first enabled. Removes the preference if Chrome Home is disabled. Bug: 739952 Change-Id: I6f0b1bd9693a7532616bdda8b4ad4bf74fdadaef Reviewed-on: https://chromium-review.googlesource.com/663832 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#502752}
-
Daniel Erat authored
Make ash::PowerButtonController force the backlights off three seconds after screen locking starts when the --force-clamshell-power-button flag is set. This avoids a long, awkward period where the display is on with the lock screen visible. The behavior on convertible and clamshell devices that don't have the flag is unchanged. Bug: 758574 Change-Id: I5a645def1205948419d7cbb711fbdbc2daaaf9e7 Reviewed-on: https://chromium-review.googlesource.com/671669Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#502751}
-
Daniel Cheng authored
This should only be called for local main frames, so just change the checks to DCHECKs. Change-Id: Ie82b446ab78ab06c9f6e741b6b4f1cb0a8f1a24d Reviewed-on: https://chromium-review.googlesource.com/665877 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#502750}
-
kapishnikov authored
Do not enforce ICronetEngineBuilder.setLibraryLoader() in Java and Native builder implementations by default. Instead introduce a new NativeCronetEngineBuilderWithLibraryLoaderImpl class that enforces the library loader. BUG=766248 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ie78383084cd68b31f4a87463763891bd30368d21 Reviewed-on: https://chromium-review.googlesource.com/671416Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#502749}
-
Rob Buis authored
Remove default value for title parameter in createHTMLDocument IDL as it is not mentioned in the spec [1]. In order not to break the binding provide a default value in the createHTMLDocument implementation. [1] https://dom.spec.whatwg.org/#ref-for-dom-domimplementation-createhtmldocument Bug: 335871 Change-Id: I3ae8cc5e4ccc191610bf29e997af0eeab70bac40 Reviewed-on: https://chromium-review.googlesource.com/669391Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#502748}
-
Mark Pearson authored
Previously these keyword would not be recognized because we try to clean up the user's input before checking to see if it matches a keyword. This changelist makes use only try various cleaning of the user's input until we get a match (or tried all the cleaning steps we have). For example if the input such as "wiki:" matches a keyword, we don't do any cleanup. Tested amply with unit tests. Also tested interactively. Some key interactive cases: * typing an unusual keyword and pressing tab enters keyword mode. * typing an unusual keyword and pressing space enters keyword mode. * putting the cursor in the middle of a string and pressing space in a while that would make the left side into an unusual keyword puts the user into keyword mode * backspacing out of keyword mode works correctly * these suggestions for unusual keywords appear in the dropdown when the user types a prefix of them. * when the user is in keyword mode for one of these unusual keywords, switching tabs and switching back keeps the user in keyword mode. * when typing an unusual keyword with an additional thing that can be cleaned up (for example www.wiki: or http://wiki:), pressing space at the end of the keyword does NOT enter keyword mode. This seems reasonable to me. Pressing tab at the end of the keyword does enter keyword mode. Yay for fixing a four-digit bug. (It's one of the ~40 oldest existing bugs in chromium.) Bug: 2740 Change-Id: Ie53089421956acf5eb58fe1d1b53932e10169178 Reviewed-on: https://chromium-review.googlesource.com/664251 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#502747}
-
Rob Buis authored
From the comment it is clear loop should be tested here, not scrollDelay, ehich was already tested earlier. Bug: None Change-Id: I7b5c6c11f5c6f8bf41cd31c9b8d56c0e345b80d4 Reviewed-on: https://chromium-review.googlesource.com/671324Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#502746}
-
Dan Beam authored
R=dpapad@chromium.org BUG=749296,761258 Change-Id: I214b60157dc8eb7bcda1d214b8433f003aad8bb6 Reviewed-on: https://chromium-review.googlesource.com/669683Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#502745}
-
Morten Stenshorne authored
Bug: 766315 Change-Id: I791ae5a12f0602c95194a60659e29e572dce5c8a Reviewed-on: https://chromium-review.googlesource.com/668441Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502744}
-
Jialiu Lin authored
After user finishes changing their Gaia password, update password reuse info bubble to a regular phishing/social engineering info bubble. And some minor refactoring on GetPasswordProtectionService() Bug: 762738 Change-Id: I20f3b3dd513ff9e292d4a8b138622c6b6cdbacda Reviewed-on: https://chromium-review.googlesource.com/663761 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#502743}
-
Alex Chu authored
layers. Change-Id: I22890aa54b375e4d40b9acbd9c5b47056be7432c Bug: 736726 Reviewed-on: https://chromium-review.googlesource.com/651752 Commit-Queue: Alex Chu <alexchu@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502742}
-
Steven Bennetts authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I79847520659cac0b4598089b03dbd23e422fa68d Reviewed-on: https://chromium-review.googlesource.com/671461Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502741}
-
Steven Bennetts authored
This removes an undesired (and problmenatic) <html> wrapper from the element and a font include that was causing problems across the Settings UI. It also fixes an assert on startup when the feature is enabled. Bug: 760751 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icf647dab081c5edd51b1f1029fac22e4eaa0c303 Reviewed-on: https://chromium-review.googlesource.com/671464Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502740}
-
Derek Cheng authored
When attempting to cast via the dialog, clear previous non-blocking issues. This ensures issues are cleared on a successful cast, or that the newest issue is displayed if otherwise. This patch also simplifies the MediaRouter API by replacing the various Issues-related API in MediaRouter with GetIssueManager(). GetIssueManager() is implemented in MediaRouterBase, making it also available on Android. Also combined the Issues and their auto-dismiss callbacks in IssueManager into an Entry maintained in a single container. Bug: 763432 Change-Id: Iaa79f991760fa31e28ec50d0e23cbf8b9f39a28a Reviewed-on: https://chromium-review.googlesource.com/663104 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502739}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c5e4e7437af9..c86d0794ed37 $ git log c5e4e7437..c86d0794e --date=short --no-merges --format='%ad %ae %s' 2017-09-18 reed Revert "try to remove google3 flag" 2017-09-18 reed try to remove google3 flag 2017-09-18 fmalita Revert "Reland "Fix SkImageSource::filterBounds()"" 2017-09-18 angle-deps-roller Roll skia/third_party/externals/angle2/ f3d574545..10ce2d284 (1 commit) Created with: roll-dep src/third_party/skia BUG=None Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I4672a53c8fff4ff212db54191ba63d8f1158f817 Reviewed-on: https://chromium-review.googlesource.com/671653Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502738}
-
kelvinp@chromium.org authored
Tbr: nasko@chromium.org Bug: 766378 Change-Id: I3c0909c32f0ad64c96ce7a12b09602a0c279bc56 Reviewed-on: https://chromium-review.googlesource.com/671666Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#502737}
-
Fady Samuel authored
When a parent first embeds a child, it picks a LocalSurfaceId for the child and embeds it. During that bootstrapping process, there is no fallback surface to provide because the child hasn't yet submitted a CompositorFrame to viz. Prior to this CL, if a primary surface isn't available and there is no fallback then SurfaceAggregator would report a warning, and the surface would simply be dropped. This CL addresses this bootstrapping problem. It introduces the notion of a "default background color" specified by the parent when the primary Surface is unavailable and there is no fallback yet. In that case, SurfaceAggregator will use the "default background color" to create a SolidColorDrawQuad in place of the primary Surface. This CL implements this color and plumbs it all the way from SurfaceLayer, to SurfaceLayerImpl, SurfaceDrawQuad, serialization/deserialization to SurfaceAggregator, ultimately where it decides whether or not to create a SolidColorDrawQuad in lieu of a surface or not. All unit tests along this plumbing have been updated accordingly. Bug: 766013 TBR: boliu@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I367f7eab7b0189d438926dea407076ef6007f0a4 Reviewed-on: https://chromium-review.googlesource.com/669444 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#502736}
-
Bret Sepulveda authored
This bubble was still passing margins to BubbleFrameView after that was handled by DialogClientView instead, which led to the margins being applied twice. Bug: 763137 Change-Id: Ifbdb5baa56cc6405b9434742602cdac6a9003f01 Reviewed-on: https://chromium-review.googlesource.com/671927Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#502735}
-
Ted Choc authored
Also fixes a javadoc to not make eclipse sad. BUG= Change-Id: I6196b08b96104a27dca2377303fb38322da0fae0 Reviewed-on: https://chromium-review.googlesource.com/671806Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#502734}
-
Raphael Kubo da Costa authored
Add the [LegacyUnenumerableNamedProperties] extended attribute to both IDL files so that they follow what the DOM and HTML specs mandate. Since the attribute is inherited, it also applies to both HTMLOptionsCollection and HTMLFormControlsCollection. Both HTMLAllCollection and HTMLCollection already implemented the required enumeration and query callbacks (in other words, they already implemented the specs' definitions of "supported property names" for each interface). The user-visible difference is that all named properties were previously enumerable, while with this CL they are not: they are no longer returned by Object.keys() or iterated by for-in loops, but Object.getOwnPropertyNames() and Object.getOwnPropertyDescriptors() still include them. The value of the "enumerable" property of the property descriptors returned is now false. WebKit did the same thing in r210667 from January 2017 (was already marking the properties as not enumerable before), and Gecko did the same in bug 1270349 in May 2016 (the properties were already not enumerable before that, as explained in the Intent to Implement email). Some tests in fast/dom were removed, as they only served to test the previous behavior and the new, expected behavior is coverted by web-platform-tests. Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YbsMn7DL1cg/rdkA-It1AgAJ Bug: 703990, 719703 Change-Id: Id6c899c1715f22a426f24c30f0ad3f527beb14d5 Reviewed-on: https://chromium-review.googlesource.com/654837Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502733}
-
kelvinp@chromium.org authored
No-Try: true Tbr: dcheng@chromium.org Bug: 766404 Change-Id: Iead01f0b639a27ab11b077f7fa06dbbb2524b5df Reviewed-on: https://chromium-review.googlesource.com/671940Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#502732}
-
kylechar authored
Remove the deprecated function that uses default InitParams. Add the params in the remaining callsites and set |single_process| correctly for tests. video_decode_accelerator_unittest.cc sets |single_process| to false, as the test runs with Ozone DRM on CrOS devices. Bug: 620934, 700142 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaac92d25eba7c9e052c250e84fdef2f46ecea7ee Reviewed-on: https://chromium-review.googlesource.com/667720 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#502731}
-
Tao Bai authored
This patch add basic class for autofill test and a simple test. more tests will be added. But unfortunately, we will not have Android O trybot until 2018, This test will not be run in any trybot. Bug: 717658 Change-Id: I60672a318fc5a6c8a1e3ad1212cd0fe54f7fbb8c Reviewed-on: https://chromium-review.googlesource.com/655769Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#502730}
-
erikchen authored
Confirming leaks requires two synchronization steps. The browser process must flush all the allocations and ensure that the messages are sent to the profiling process. This is done by performing 68,000 flushing allocations, and was already implemented. The profiling process must finish processing all the messages it receives on the connection thread for the browser process. It typically has a large backlog of tasks posted onto the connection thread's task queue. DumpProcess() now hops onto the connection thread's task queue, and back onto the IO thread before dumping allocations to a file. This ensures that all previously posted tasks are processed first. Bug: 753218 Change-Id: I08e7f49f597fadc24617bcf3612ab147eb3a458c Reviewed-on: https://chromium-review.googlesource.com/671192 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#502729}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1b94de3b819f..441164c72d1c $ git log 1b94de3b8..441164c72 --date=short --no-merges --format='%ad %ae %s' 2017-09-18 xunjieli [netlog-viewer] Point Polymer imports to Polymer 1.9.1 Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2a7ceab5a2c04cfaffb8e14ce2578929e9327805 Reviewed-on: https://chromium-review.googlesource.com/671771 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502728}
-
Frank Barchard authored
ninja -v -C out/Release libyuv Bug: 766322, libyuv:723 Test: gn gen out/Release "--args=is_debug=false is_clang=false target_os=\"android\" target_cpu=\"arm64\" libyuv_include_tests=true libyuv_use_gflags=false" Change-Id: Ib1fa9c4eaa3d7db2e089112f38dcf755a97d5ca4 Reviewed-on: https://chromium-review.googlesource.com/671208 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#502727}
-
Nick Carter authored
An earlier refactor of this code appears to have stripped out the DISABLED prefix when building into the |test_locations_| map, but when that map is queried, the DISABLED prefix was still present in the keys. This caused a crash, at least in Windows debug builds it did. TBR=seanmccullough@chromium.org Bug: 754441 Change-Id: Ie78294dfeb7369c3ad9573a2017a29e5e3787708 Reviewed-on: https://chromium-review.googlesource.com/611139Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#502726}
-
Tom Anderson authored
BUG=764079 TBR=dgozman@chromium.org Change-Id: I7dd8dc4605011e0e1fa1392a6d15f39be5985167 Reviewed-on: https://chromium-review.googlesource.com/671539Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#502725}
-
Gregory Chatzinoff authored
Removes the BrowserCommands dependency from the PageInfoViewController so that it is easier to integrate into ios/clean. Bug: none Change-Id: I12508c86c767ddd0933226a316787eab7ce8a97e Reviewed-on: https://chromium-review.googlesource.com/669961Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502724}
-
Tao Bai authored
This reverts commit 7844944f. Reason for revert: it broke x86 builder https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/22715 Original change's description: > [Android] Allow __NR_process_vm_readv under Seccomp. > > Bug: 766245 > Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d > Reviewed-on: https://chromium-review.googlesource.com/671556 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502714} TBR=torne@chromium.org,rsesek@chromium.org Change-Id: I31ab91b3572c1e109699ceabcdfbd06cc0c54e39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766245 Reviewed-on: https://chromium-review.googlesource.com/671658Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#502723}
-
Victor Costan authored
Change-Id: Ice4f62c8a17310aa4757d03bc2c14d7d150690c7 Reviewed-on: https://chromium-review.googlesource.com/668197 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#502722}
-
- 18 Sep, 2017 7 commits
-
-
Gauri Manikpure authored
Bug: chromedriver:1887, chromedriver:2002 Change-Id: I327ba44051de581075b6c14132b63d1422556847 Reviewed-on: https://chromium-review.googlesource.com/578609 Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#502721}
-
Alex Newcomer authored
Two small fixes: 1. The fling velocity threshold needs to be lowered to 6. 2. Dragging up on the launcher sometimes transitions to peeking, this is because we check that abs(drag_offset) > drag_threshold, but don't check the sign of the offset. Bug: 765845 Change-Id: I22270e4caea5b4aab22b347b1ce28e98a5df03fe Reviewed-on: https://chromium-review.googlesource.com/669944 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#502720}
-
Kelvin Poon authored
This reverts commit a5f2d27e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Adds class level documentation to generated property APIs. > > Includes APIs for both properties and descriptors. Does not include > CSSPropertyAPIApplyAtRule or CSSPropertyAPIVariable which are not > properties or descriptors. > > Also cleans up make_css_property_api_headers a bit. > > Diff of generated files: > https://gist.github.com/49b9974fa1e6b5a5fc97c1582ebb495c/revisions > > Bug: 545324 > Change-Id: I6f1ddcbc02816595512fddf04cbfbfbbc36afe32 > Reviewed-on: https://chromium-review.googlesource.com/666363 > Commit-Queue: Bugs Nash <bugsnash@chromium.org> > Reviewed-by: Renée Wright <rjwright@chromium.org> > Reviewed-by: meade_UTC10 <meade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502708} TBR=rjwright@chromium.org,meade@chromium.org,bugsnash@chromium.org Change-Id: I25750855db88917f077e9fc1e0714c802bd6c94b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 545324 Reviewed-on: https://chromium-review.googlesource.com/671657Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#502719}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5278cebc468e..29b7891d920f $ git log 5278cebc4..29b7891d9 --date=short --no-merges --format='%ad %ae %s' 2017-09-08 art-snake Remove useless code. 2017-09-08 art-snake Use CPDF_ReadValidator to request linearized data. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I457c81e541cd74b479ee79d6ff7745a9e1ca4ca7 Reviewed-on: https://chromium-review.googlesource.com/671532 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502718}
-
Sergey Ulanov authored
Updated local-sdk.py to call build-zircon.sh instead of build-magenta.sh . Change-Id: I2ae2000edf9c4c487ae2b4b8ece61764f1a2ba51 Bug: 765754 Reviewed-on: https://chromium-review.googlesource.com/671536 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#502717}
-
Rob Buis authored
Rename starAtom, nullAtom and emptyAtom in comments to the new names created after the great Blink rename. Bug: None Change-Id: Ibad34e8aa6316d6fb22863292ed35bfcec3d492a Reviewed-on: https://chromium-review.googlesource.com/671191Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#502716}
-
Eric Noyau authored
Bug: None Change-Id: Ie8af629d902c0da861c6e826a867ab2e59339c64 Reviewed-on: https://chromium-review.googlesource.com/671232Reviewed-by:
Ramya Sharma <ramyasharma@chromium.org> Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#502715}
-