- 03 Sep, 2018 11 commits
-
-
Jinsuk Kim authored
Tab doesn't have to keep the reference to DisplayCutoutController now that it is managed by UserDataHost, and can be obtained via |DisplayCutoutController#from(this)|. This CL removes the reference from Tab class. Bug: 877878 Change-Id: Ib7fa3b7e16d49e594324e632140d1864b4be996e Reviewed-on: https://chromium-review.googlesource.com/1195177Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588309}
-
Kai Ninomiya authored
This reverts commit de9497de. Reason for revert: flake continued after revert, so this change wasn't responsible. Original change's description: > Revert "Use unverified sync tokens in PaintCanvasVideoRenderer" > > This reverts commit 228446ba. > > Reason for revert: Potentially causing flakes in virtual/android/fullscreen/video-fixed-background.html > > Bug: 876466 > > Original change's description: > > Use unverified sync tokens in PaintCanvasVideoRenderer > > > > PaintCanvasVideoRenderer::CopyVideoFrameTexturesToGLTexture > > unnecessarily used verified sync tokens to pass textures between > > Skia's context and WebGL's context. Verification isn't needed > > because these two clients are being used synchronously from the > > same process and thread. > > > > Changing these sync tokens to be unverified gives us a nice > > speedup - on a simple mp4-to-WebGL case on Linux, the texImage2D > > blocking time drops from ~1.25 ms to ~0.70ms (~80% speedup). > > > > Bug: 871417 > > Change-Id: I38c246fdb49588eccc87211fa06a2abf00e55c5c > > Reviewed-on: https://chromium-review.googlesource.com/1164163 > > Reviewed-by: Dan Sanders <sandersd@chromium.org> > > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584840} > > TBR=sandersd@chromium.org,kainino@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 871417 > Change-Id: I51d3e5f9308eadf08babec4e1c99b1d51c4a3b90 > Reviewed-on: https://chromium-review.googlesource.com/1192129 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586500} TBR=sandersd@chromium.org,kainino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 876466, 871417 Change-Id: Ic5c2206901239695b8289f0fa3e63f925094444d Reviewed-on: https://chromium-review.googlesource.com/1200487Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#588308}
-
Ned Nguyen authored
TBR=csharrison@chromium.org, nyquist@chromium.org Bug: 879922 Change-Id: I5237d1478aef9245fb6c30dc4b8e052f6d5a0edc Reviewed-on: https://chromium-review.googlesource.com/1201322Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#588307}
-
xlou authored
Added callback handling when pagesPerSheet > 1. Added more fields to print messages to support N-up printing. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: Ic24fef1b49f21dd35fcbc334736b62128e7edd98 Reviewed-on: https://chromium-review.googlesource.com/1182615 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588306}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Icc74a0d64ebef7d6e9c19d09a5780a34c815142f Reviewed-on: https://chromium-review.googlesource.com/1201163 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588305}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88fc6da3e28c..37386b0205f4 git log 88fc6da3e28c..37386b0205f4 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 jmadill@chromium.org Vulkan: Cache object pointers in ContextVk. Created with: gclient setdep -r src/third_party/angle@37386b0205f4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I483261432b1205e95de1dee171a02af30e392bd4 Reviewed-on: https://chromium-review.googlesource.com/1201382Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588304}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8e12e89c46b..8534723c7be1 git log e8e12e89c46b..8534723c7be1 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@8534723c7be1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Idb9e0b58888b339bc3ae6d74d67e8e37c2f2e13a Reviewed-on: https://chromium-review.googlesource.com/1201144Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588303}
-
Kurt Horimoto authored
This CL updates the traits of the page control buttons to be selected for the selected page. Bug: 876868 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I466ae32f70768ddb0d8ffa23faba22fbf1456a32 Reviewed-on: https://chromium-review.googlesource.com/1200482Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#588302}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e0a58f83..9f511b4e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d84565a9d1b7c7ec40c1af1bf07332c904f3181 Reviewed-on: https://chromium-review.googlesource.com/1201162Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588301}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c5ef97683754..c8323dce1f50 git log c5ef97683754..c8323dce1f50 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 dgarrett@google.com gen_luci_scheduler: Update help messages. Created with: gclient setdep -r src/third_party/chromite@c8323dce1f50 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I708379e3aab91c8897be2ce6c0cfcff587df7735 Reviewed-on: https://chromium-review.googlesource.com/1201143Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588300}
-
Rijubrata Bhaumik authored
This CL adds focusDistance to ImageCapture API. This was added to the spec in https://github.com/w3c/mediacapture-image/pull/175 Layout tests and mock tests are updated to support the same. Support for Android is added. TEST= run the demo in https://codepen.io/rijuB/pen/NzWpxG use slider to change focusDistance. BUG=732807 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oNxzXaFY9c8 Change-Id: I9b7cbf3c85fd35741a8c7ed229910a996e14ee8f Reviewed-on: https://chromium-review.googlesource.com/1124839Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#588299}
-
- 02 Sep, 2018 2 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I49a889426870c053c5c522fcbe120dddafcee970 Reviewed-on: https://chromium-review.googlesource.com/1200870Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#588298}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1203870d6c79..c5ef97683754 git log 1203870d6c79..c5ef97683754 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 vapier@chromium.org build_dlc_unittest: fix bad mode/shebang usage 2018-09-02 tikuta@chromium.org cros_setup_toolchains: keep compiler path relativeness in shell wrapper for python sysroot wrapper 2018-09-02 dgarrett@google.com sync_stages/lkgm_mananger: Lint fix. Created with: gclient setdep -r src/third_party/chromite@c5ef97683754 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I65e8a396f4a3683bb242e83b0dd326325f43c773 Reviewed-on: https://chromium-review.googlesource.com/1201062Reviewed-by:
-
- 01 Sep, 2018 27 commits
-
-
Joel Hockey authored
Tbr: nverne@chromium.org Bug: 878324 Change-Id: I704546dd8e20aa6584cea53c1e7567c2f4d22bb2 Reviewed-on: https://chromium-review.googlesource.com/1200667Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#588296}
-
Avi Drissman authored
BUG=867553 Change-Id: Id49631322c7c5ecbf05a26760989d53cfa82a346 Reviewed-on: https://chromium-review.googlesource.com/1199574 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#588295}
-
Manu Cornet authored
(After chatting with kejiashao@ offline, we agreed that showing tooltips during a drag operation is distracting and not useful.) Bug: 879535 Change-Id: I2c092380560372ec568d25e55d984828b93d6839 Reviewed-on: https://chromium-review.googlesource.com/1199496Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#588294}
-
Ned Nguyen authored
TBR=dpranke@chromium.org, jbudorick@chromium.org Bug: 828465 Change-Id: Ia46324aa7343123c5bad2880631179a9b10f3ab0 Reviewed-on: https://chromium-review.googlesource.com/1200833Reviewed-by:
-
Ned Nguyen authored
Revert "Update milo entry of 'Android arm64 Compile Perf' buildbot to 'android_arm64-builder-perf' LUCI" This reverts commit c2aa1125. Reason for revert: updated wrong entry. Should be 'Android arm64 Compile Perf' Original change's description: > Update milo entry of 'Android arm64 Compile Perf' buildbot to 'android_arm64-builder-perf' LUCI > > TBR=dpranke@chromium.org, jbudorick@chromium.org > > Bug: 828465 > Change-Id: I75cd0ab9740d44fd99470b9a2b8b31f2bf3ad1ed > Reviewed-on: https://chromium-review.googlesource.com/1200822 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#588284} TBR=dpranke@chromium.org,nednguyen@google.com,jbudorick@chromium.org Change-Id: I099f076a926da6e72abc216b761267fa14cdfda3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828465 Reviewed-on: https://chromium-review.googlesource.com/1200832Reviewed-by:
-
Siddhartha authored
Change-Id: Ia57ff34ef3ef34fe361885b5aab68fd8eb83507e Reviewed-on: https://chromium-review.googlesource.com/1200324 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#588291}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 30e36bcc. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23808 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic911c4c0921a8f931b4d205611aaac49b4ed21c0 Reviewed-on: https://chromium-review.googlesource.com/1200826 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588290}
-
Greg Thompson authored
These functions are only used by the installer, so they belong there. BUG=879568 Change-Id: I6f934c86bd1f9f94ff3f02ae7e8b465c4070be66 Reviewed-on: https://chromium-review.googlesource.com/1199575 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#588289}
-
Avi Drissman authored
BUG=867553 Change-Id: I96804621e5ed33b991eb9870480f142e87e50050 Reviewed-on: https://chromium-review.googlesource.com/1199816 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Eric Karl authored
WebGL has performance issues on Adreno 3xx when we switch contexts from/to the WebGL context mid-frame. To avoid this issue, we can bump scheduler priority for the WebGL stream to high, avoiding most mid-frame interruptions. In local testing this (in combination with a backpressure fix) addresses known issues. Bug: 879649, 835353 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I896456b29f3b80e3e443720b9ce444e6825c1c03 Reviewed-on: https://chromium-review.googlesource.com/1200242Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#588287}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e95d045. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23803 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iff0078c74069caf5647e37fab306cfc3885df2e7 Reviewed-on: https://chromium-review.googlesource.com/1200824 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Ned Nguyen authored
TBR=kouhei@chromium.org, ksakamoto@chromium.org NOTRY=true Bug: 879833 Change-Id: If9e6285c7643af3ff05731b392302e92d5de7a8b Reviewed-on: https://chromium-review.googlesource.com/1200823Reviewed-by:
-
Ned Nguyen authored
TBR=dpranke@chromium.org, jbudorick@chromium.org Bug: 828465 Change-Id: I75cd0ab9740d44fd99470b9a2b8b31f2bf3ad1ed Reviewed-on: https://chromium-review.googlesource.com/1200822Reviewed-by:
-
Joel Hockey authored
Change running_vms_ to be a map rather than set and store VmInfos for running VMs.. Bug: 878324 Change-Id: I159a0c201a9f35ba64d81b57e0687cb95f2eec6f Reviewed-on: https://chromium-review.googlesource.com/1193386 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#588283}
-
Joel Hockey authored
Change-Id: I8f26e68d3043f0d6efe3a474ecebaa7ca738f143 Reviewed-on: https://chromium-review.googlesource.com/1200422 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#588282}
-
Joel Hockey authored
Bug: 878324 Change-Id: I101f442f23baf5d3b023a24556c196b002486f19 Reviewed-on: https://chromium-review.googlesource.com/1193167 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#588281}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe9d0eac. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23787 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic379fcc5c81fe712fc791c48b64b94d8cbdab638 Reviewed-on: https://chromium-review.googlesource.com/1200702 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Joel Hockey authored
FilesApp will share folders with crostini container using 9p fileserver. Bug: 878324 Change-Id: I7e10af12cab26f050fe95073f667f1d1104f7392 Reviewed-on: https://chromium-review.googlesource.com/1193166Reviewed-by:
-
Ned Nguyen authored
** PERF SHERIFFS: this CL will cause regressions on many bots that are non bisectable ** Run: ./tools/perf/generate_perf_sharding ./tools/perf/generate_perf_data Bug: 877669, 877643 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ifcd60511ce3647616672056d7f46e9ac53b00c54 Reviewed-on: https://chromium-review.googlesource.com/1199934 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#588278}
-
Maxim Kolosovskiy authored
|(element.Form() == generation_element_.Form())| in PasswordGenerationAgent::TextDidChangeInTextField causes a crash. |element| or |generation_element_| is null. Probable reason: That code assumes that |generation_element_| must be non-null if |password_is_generated_| is true. But in PasswordGenerationAgent::DidCommitProvisionalLoad, |generation_element_| is cleared while |password_is_generated_| stays the same. So, it is possible that |generation_element_| is null while |password_is_generated_| is true. TBR=dvadym@, vasilii@, ioanap@ Bug: 879713 Change-Id: I4b8a42ab8aebb1474f7a3b57c9fa63ab15dcd610 Reviewed-on: https://chromium-review.googlesource.com/1200642 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#588277}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6487e5ca6f10..e8e12e89c46b git log 6487e5ca6f10..e8e12e89c46b --date=short --no-merges --format='%ad %ae %s' 2018-09-01 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 253038d8d13b..88fc6da3e28c (1 commits) Created with: gclient setdep -r src/third_party/skia@e8e12e89c46b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ic794f6024409ad85d25276cf80e3453cbb74e9b7 Reviewed-on: https://chromium-review.googlesource.com/1200602Reviewed-by:
-
Guido Urdaneta authored
Bug: 860311 Change-Id: Ifd314660829cc7434621e22b8d709e6ef233973f Reviewed-on: https://chromium-review.googlesource.com/1193849 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#588275}
-
Eric Karl authored
This reverts commit 370c8bc2. Reason for revert: This is breaking desktop sites (SW raster) on Android when OOP-R is enabled. see crbug.com/879823 Original change's description: > Use GL_COMMANDS_ISSUED_CHROMIUM query for shared memory GpuMemoryBuffers > > GL_COMMANDS_ISSUED_CHROMIUM is sufficient for shared memory > GpuMemoryBuffers because they're uploaded using glTexImage2D (see > GLImageMemory::CopyTexImage). > > This should reduce the number of idle wakeups in the GPU process, and > reduce the CPU time spent on such queries which is quite high on > Windows. > > Bug: 830084, 622491 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I8111b3d7f12abbf900383d45e2a74394848e83fd > Reviewed-on: https://chromium-review.googlesource.com/1189126 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587695} TBR=sunnyps@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830084, 622491, 879823 Change-Id: I7c78d2cc92e9ad274e8f443969d2a72d2410d5db Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1199629Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#588274}
-
Victor Costan authored
This CL only handles the files in //chrome. The files in //net were tackled in https://crrev.com/c/1188959. Parallel CLs will tackle other directories. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL is mechanical, to avoid introducing any behavior changes. The difficult cases will be tackled by follow-up CLs. The following transformations were performed. * new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args) * new IOBufferType => base::MakeRefCounted<IOBufferType>() * scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) => scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) * scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) => base::MakeRefCounted<IOBufferType>(args) * In comments: creates a new IOBufferType => creates an IOBufferType (so it wouldn't trigger future searches for "new BufferType") * Instantiated static members in HttpResponseBodyDrainer, HttpNetworkTransaction, HttpProxyClientSocket, WritersTest, UDPSocketTest, TestDelegate, UDPSocketPerfTest (needed to fix linker errors) * arraysize -> base::size (where needed to pass presubmit checks) * git cl format Change-Id: Ia77ede36d452982213f01b953d0e579e97889738 Reviewed-on: https://chromium-review.googlesource.com/1200413Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I99dcd18546028da70850d3e953de370e645b9126 Reviewed-on: https://chromium-review.googlesource.com/1200392 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Lei Zhang authored
While generating the print preview, the renderer now must send the list of page numbers in the DidStartPreview message. The browser can then use the list to validate the DidPreviewPage messages. Also combine calls to PrintPreviewUI methods to encapsulate more. Change-Id: If50199d14a61fa60e5e657fab6459fa80a7f0d88 Reviewed-on: https://chromium-review.googlesource.com/1188242 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588271}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee3f5c44326d..1203870d6c79 git log ee3f5c44326d..1203870d6c79 --date=short --no-merges --format='%ad %ae %s' 2018-09-01 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-01 lannm@chromium.org Add chromite.lib.repo_manifest 2018-09-01 bhthompson@google.com Update gen_luci_scheduler with R70 branch Created with: gclient setdep -r src/third_party/chromite@1203870d6c79 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I999ec2f4d536aea4ccad09fc5f7fe601219073af Reviewed-on: https://chromium-review.googlesource.com/1200174Reviewed-by:
-
