- 18 Jul, 2018 40 commits
-
-
Suproteem Sarkar authored
R=nektar@chromium.org,dmazzoni@chromium.org Bug: 847971 Change-Id: Id18111cedd06a6c5964682e114de03fc9c0d9567 Reviewed-on: https://chromium-review.googlesource.com/1130161Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#575921}
-
Matt Falkenhagen authored
It wasn't used since inception in commit 292a9172. Change-Id: Ib64e6f70a1779a6710dfcabb989089f3f598d8a7 Reviewed-on: https://chromium-review.googlesource.com/1126180 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#575920}
-
Peter Beverloo authored
An implementation of BackgroundFetchDelegate has been provided to content shell which enables Background Fetches, without UI, to finish. It uses the Download Service through a new dependency. This dependency will be removed once the Download Service has been servicified, as //content can depend on it directly from that point forward. In context of the WPT tests, additional machinery has been added to enable communication with the Service Worker, required for it to tell the test about the result of the various Background Fetch events. The "fetch.https.window.js" file now verifies the behaviour and results of a single fetched file. Bug: 864561 Change-Id: If53e6755ae8ea924712f5bdace4df4f658bc53d7 Reviewed-on: https://chromium-review.googlesource.com/1135536 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#575919}
-
Christopher Lam authored
This CL adds the checks_only flag to JS Closure Compilations that are only doing type checking to improve build time. Before: 5869.41s user 189.50s system 3350% cpu 5861.34s user 190.37s system 3284% cpu After: 4143.98s user 159.46s system 3020% cpu 4184.40s user 158.95s system 3073% cpu Bug: 632206 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I68ebdce5a4cf98176d3f55b971e33fc62848d2d4 Reviewed-on: https://chromium-review.googlesource.com/1139840Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#575918}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d563855ac72b..8e0c0dbc4876 git log d563855ac72b..8e0c0dbc4876 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 asweintraub@google.com Add Deleter and Scoper for FPDF_PAGELINK. 2018-07-17 hnakashima@chromium.org Limit recursion depth for CXFA_DocumentParser::NormalLoader(). Created with: gclient setdep -r src/third_party/pdfium@8e0c0dbc4876 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:849143 TBR=dsinclair@chromium.org Change-Id: I690589dba2241ff7f211a6c753a0ed74c57bd0a3 Reviewed-on: https://chromium-review.googlesource.com/1140539Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575917}
-
Orin Jaworski authored
The URL path, parameters, etc. (LOCATION_BAR_TEXT_DIMMED) were being lightened to GG700 but now get GG600 per spec. The RESULTS_ICON and RESULTS_TEXT_DIMMED using the same colors remain intact. Bug: 863474 Change-Id: I1dc2efb763642d88cbc27d832b0411a10c3310c8 Reviewed-on: https://chromium-review.googlesource.com/1141294 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#575916}
-
David Benjamin authored
Prefer signing smaller SHA-2 hashes over larger ones. This aligns with BoringSSL's current defaults. In particular, we got a report of problems with TPM-protected client certificates on Windows that cannot sign SHA-512. Absent a way to reliably query hash preferences, SHA-256 is more likely to be compatible. Bug: 863147 Change-Id: Icaef85a2639ba3cc95846ff932bd829226e7aa7b Reviewed-on: https://chromium-review.googlesource.com/1135299Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#575915}
-
Zhongyi Shi authored
Rename the load flag LOAD_DISABLE_CONNECTION_MIGRATION_TO_CELLULAR to LOAD_DISABLE_CONNECTION_MIGRATION_TO_CELLULAR. This CL does not change the behavior of the flag, it merely renames the flag to reflect the semantics we would like it to have. A subsequent CL will make the behavior changes. Bug: 769526 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6261e60fb44661a9b3de944e8f87bd660caeb761 Reviewed-on: https://chromium-review.googlesource.com/1136972 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#575914}
-
Leonard Grey authored
I add this every time I'm debugging an a11y issue, let's save me and everyone else some time :) Change-Id: I12ee9d4bfb320f5da067d63f038d1f4d393975ce Reviewed-on: https://chromium-review.googlesource.com/1131572 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Scott Haseley authored
FrameTaskQueueController creates and manages the task queues used by FrameSchedulerImpl. It is responsible for tracking the mappings from QueueTraits to MainThreadTaskQueues. This CL adds FrameTaskQueueController and basic task queue management. Refactoring FrameSchedulerImpl to use this new class will be added in a follow-up CL. Design Doc: https://docs.google.com/document/d/1Jm4xLPqv013VfZswgmnoQ7-ghJK92Uf3hIT7WcNcFck/edit?usp=sharing Bug: 859963 Change-Id: Ie9fefaaad83c30f06a13c427e38d54089fc362a4 Reviewed-on: https://chromium-review.googlesource.com/1132691 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575912}
-
Bill Orr authored
environmentIntegration is the new flag, which is now queried when requesting sessions. Plumbing to the browser process will happen in a followup. Now that both AR and VR can be supported simultaneously in tests, WebXRHitTest is made experimental and the ar_hittest layout test passes. BUG=828321 Change-Id: I4d8f13cc7c836c608d1f4d69d07813d163cea18f Reviewed-on: https://chromium-review.googlesource.com/1132427 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#575911}
-
Sheng-Hao Tsao authored
This CL creates a persistent camera icon in launcher. When users click on it, whether to open Chrome camera app or Google camera app is determined dynamically. CCA or GCA based on whether consolidation is done and whether ARC is enabled. Bug: 861952 Test: Tested on eve that there's always one camera icon shown and opens Change-Id: I93835bbae6791a7fc712bea07f3f85b1b83d3185 Reviewed-on: https://chromium-review.googlesource.com/1137054 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#575910}
-
chrome://safe-browsingDaniel Rubery authored
Just a cosmetic change, because I was tired of scrolling through many sections. Render: https://screenshot.googleplex.com/mgoTZ4qfD0n Change-Id: Idaf6b98eb9835f3f9cf440f800985da154fefb10 Reviewed-on: https://chromium-review.googlesource.com/1140528 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#575909}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/21a99d42c34f..59113645075d git log 21a99d42c34f..59113645075d --date=short --no-merges --format='%ad %ae %s' 2018-07-17 ruiqimao@google.com fixed ASAN dm errors 2018-07-17 ruiqimao@google.com fixed ASAN dm errors 2018-07-17 herb@google.com MakeAsDrawText for SkTextBlob 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-17 brucewang@google.com Implement scaled color emoji using PNG format fonts. 2018-07-17 bungeman@google.com Move SkNoncopyable to include/private. Created with: gclient setdep -r src/third_party/skia@59113645075d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I613300dc03782aed953fd6114f3fd26c4da7dea0 Reviewed-on: https://chromium-review.googlesource.com/1141244Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575908}
-
Ahmed Fakhry authored
Allowing a browser window to be resized such that the contents view's size is 0x0 caused the contents view's window to become invisble and stop it from being able to accept events. Instead we use a minimum size of 1x1 for the contents. BUG=847179 Change-Id: I7790d5e2e4862fce8bb19a5c7d3134b45c6a0c63 Reviewed-on: https://chromium-review.googlesource.com/1141344Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#575907}
-
Dmitry Gozman authored
This is a small wrapper around NSKillRing functions, solely used by editing code. There is no need to put it separately from the rest of editing. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie529f834464a413bd252fcf0a45778ae17b48a61 Reviewed-on: https://chromium-review.googlesource.com/1140509Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575906}
-
Orin Jaworski authored
This CL addresses a performance concern with the way a font list was being derived with size delta, applies minor style changes to entity suggestions, and simplifies the logic for presenting styled answers. Now answers and entities will always be styled to spec, regardless of the flag determining whether to reverse content/descriptions fields. Change-Id: Idb604f655ccbdcffdbe08e99c7d8c1462c636d18 Reviewed-on: https://chromium-review.googlesource.com/1140620 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
-
Justin Cohen authored
CIPD packages: infra_internal/ios/xcode/mac 10l213o infra_internal/ios/xcode/ios 10l213o TBR: hinoka@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I66bf9c3544bee0d3d67634b17fdbcf49a92058ac Reviewed-on: https://chromium-review.googlesource.com/1140836 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575904}
-
Kim Paulhamus authored
Bug: 678885 Change-Id: I7d9f7d7776171f702bf1d79b4ad0e740c68511b8 Reviewed-on: https://chromium-review.googlesource.com/1139577 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575903}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c64e737. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21503 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Id62f43a405a6d6f3a9a331b8cff94b7ab94c6d0d Reviewed-on: https://chromium-review.googlesource.com/1141183 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575902}
-
David Black authored
This builds off of DialogPlate motion spec part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1137843 This CL: - Fixes issue which caused settings to fade in/out. Previously we used two settings buttons, now we use a single button which exists outside of the layout containers being animated. - Implements translation phase of the animation. See bug for spec/demo. Bug: b:111500701 Change-Id: I269666dafa815018e0cf65df299aa734eaf80b79 Reviewed-on: https://chromium-review.googlesource.com/1139031 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575901}
-
Maks Orlovich authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Bug: 840378 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie318335f2d3a21cac1042862fd6a49e62cc931a4 Reviewed-on: https://chromium-review.googlesource.com/1124771 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#575900}
-
Kurt Horimoto authored
Bug: 851962 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I355a361c16f679b39a0b6bec5a68df0e89248ed5 Reviewed-on: https://chromium-review.googlesource.com/1136012 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575899}
-
Dominick Ng authored
BUG=None Change-Id: Ida08d49ff1a8b642ce8004fd3ac5d5c931810079 Reviewed-on: https://chromium-review.googlesource.com/1140343Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575898}
-
Theresa authored
Wait to request a texture capture until a layout pass, ensuring that the toolbar buttons container has the proper width. BUG=863819 Change-Id: I52b6288c1970ed16427e0231c092af13a228e9bc Reviewed-on: https://chromium-review.googlesource.com/1141172Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575897}
-
Rohit Rao authored
This reverts commit 9441c306. Reason for revert: Breaks ExternalURLSSLTestCase/testMixedContentWarning in the downstream tree. https://browsingtest.appspot.com/mixedContent.html does not show a mixed content warning. Original change's description: > [Nav Experiment] Skip SSL status update when webview is loading. > > -webViewSecurityFeaturesDidChange is meant to update the SSL status of > the last committed item. With WKBasedNavigationManager, on a back/forard > navigation, there exists a small window between web view starts loading > and -webView:didStartProvisionalNavigation is triggered that > WKBasedNavigationManager::GetLastCommittedItem() returns the pending > item instead of the last committed item. > -updateSSLStatusForCurrentNavigationItem must not be called in this > window, otherwise the wrong navigation item will be used. > > Bug: 842151 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I57eb96f74c3a6a133b1fdad6559de093f5d125c5 > Reviewed-on: https://chromium-review.googlesource.com/1141054 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575803} TBR=kkhorimoto@chromium.org,danyao@chromium.org Change-Id: Ia764eeca4fcb26cc3cf9cd8778fe4cedb5e98c3f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1141384Reviewed-by:
-
Devlin Cronin authored
Extract chrome api sources from chrome/common/extensions/api/BUILD.gn to a separate gni file at chrome/common/extensions/api/api_soruces. This allows us to pull the api registration step of generation out from chrome/common and into chrome/browser. This is helpful, since it is a purely-browser dependency (and has browser dependencies itself). Also make this step a public dependency of chrome/browser/extensions so embedders do not need to explicitly depend on it themselves. Bug: None Change-Id: I6f2f973a5ba1c04b01aa36b096de847b73964148 Reviewed-on: https://chromium-review.googlesource.com/1139394 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#575895}
-
Douglas Creager authored
Per https://w3c.github.io/reporting/#try-delivery, the field in a JavaScript report object that contains the body is called `body`, not `report`. Bug: 704259 Change-Id: Iba3186a0104c2192ced5e4233d55e042e05908f3 Reviewed-on: https://chromium-review.googlesource.com/1140193Reviewed-by:
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/718bcd15ec60..664261cb3f4d Created with: gclient setdep -r src-internal@664261cb3f4d The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853946 TBR=mmoss@chromium.org Change-Id: Ic50448d8ff622c644d4ab673deb2629034e63a51 Reviewed-on: https://chromium-review.googlesource.com/1140621Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575893}
-
Scott Chen authored
This CL cleans up some remnant of paper-input, now that paper-input is mostly removed. Bug: 720276 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id17298df731d1fbfc111fdb6db40202e1036dd4a Reviewed-on: https://chromium-review.googlesource.com/1139086Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6ddf1942ca0..302bb847d356 git log e6ddf1942ca0..302bb847d356 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jbudorick@chromium.org gclient: run cipd ensure in paranoid mode. 2018-07-17 ehmaldonado@chromium.org git_cache: Add tests for reset fetch config. 2018-07-17 ehmaldonado@chromium.org metrics: Fix countdown to metrics collection. Created with: gclient setdep -r src/third_party/depot_tools@302bb847d356 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860251,chromium:862547,chromium:832386 TBR=agable@chromium.org Change-Id: I654f3810c18eef26eda782285927c8bef5bfd3d7 Reviewed-on: https://chromium-review.googlesource.com/1140797Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575891}
-
Kurt Horimoto authored
Previously, TableViewURLCell always returned a lazily created a11y label created using the values of the UILabel subviews, which was squashing the custom a11y label provided by TableViewItems. Bug: 862306 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7210e683f4dfdcdbf0f2c60ecec3eb2a0683eeec Reviewed-on: https://chromium-review.googlesource.com/1136902Reviewed-by:
-
Christopher Cameron authored
Disabling it didn't fix the crashes. TBR=lgrey Bug: 863817 Change-Id: I6cf6ea476856b2e20cf37cf080c59aeec41119dd Reviewed-on: https://chromium-review.googlesource.com/1141330Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#575889}
-
Victor Costan authored
Bug: 167187 Change-Id: I4d26741ca9b41751ed8dc3b121fc3d6e7bff9d5b Reviewed-on: https://chromium-review.googlesource.com/1137916Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575888}
-
Tommy C. Li authored
See the bug for screenshots. Currently, the selection bounds in the Omnibox are not vertically symmetric. This is becoming a lot more noticeable with the MD Refresh redesign. This CL extends RenderText to allow expanding the selection bounds to be vertically symmetric with respect to the display rect. This CL only turns on this flag for the OmniboxViewViews. Bug: 249065 Change-Id: I031017335a0efb5e8842d137fc55efce5520e6cd Reviewed-on: https://chromium-review.googlesource.com/1140901 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575887}
-
Chris Hamilton authored
This will allow enterprises to opt-out or opt-in to lifecycles while the feature is under development. Change-Id: I68838306ac3d22fab1290f47011dc4d14c909c43 Reviewed-on: https://chromium-review.googlesource.com/1132299Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#575886}
-
Lei Zhang authored
Effectively removing them from Android, where there is no PPAPI. Also fix an "is_chromeos" typo. Change-Id: I1395ccf368c1d0f593352d1ae2755fcb5920468a Reviewed-on: https://chromium-review.googlesource.com/1140531Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575885}
-
Victor Costan authored
Bug: 112250 Change-Id: I63369b826307acea4b01f15fbc4cbef2f41514a1 Reviewed-on: https://chromium-review.googlesource.com/1137925Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575884}
-
Varun Khaneja authored
Default quota: 5 Bug: 853382,730646 Change-Id: Ib989a9053da93d7e083f3217082627fa8635da5e Reviewed-on: https://chromium-review.googlesource.com/1138864 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#575883}
-
Min Qin authored
This CL calls the InProgressDownloadManager to delete ResourceDownloader after response is completed. It also fixes the issue when download is cancelled. BUG=864189 Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7 Reviewed-on: https://chromium-review.googlesource.com/1138676 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
