GitLab

Instead of expanding UMA_HISTOGRAM_ENUMERATION macro in 19 places, use a
single static method to log this histogram.  The motivation for this
change is to avoid binary bloat.

This is a follow-up to https://crrev.com/c/1055949.

This CL results in 2384 byte decrease in binary size for locally
compiled release build on Linux, and no change for debug build.

Bug: 831536
Change-Id: I0b5e741e29529c9f6ae22336b3a6c3d194042249
Reviewed-on: https://chromium-review.googlesource.com/1071731Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561607}

Some of these new passing tests may be related to:
https://chromium.googlesource.com/chromium/src/+/5d4b496fb58d979f8b511519e93f8c6284f7bf25

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees
Change-Id: I0ee575c1b0f2fca9a996c12db1cedd9fd2282e6a
Reviewed-on: https://chromium-review.googlesource.com/1071770Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561606}

This adds the WebAuthenticationTouchId feature flag (default disabled).
If enabled, the FidoRequestHandler tries to instantiate a
TouchIdAuthenticator on supported platforms for the current request.

Bug: 678128
Change-Id: Iddc4ea00b3247b6ffbe875e280e1bf30488ca81f
Reviewed-on: https://chromium-review.googlesource.com/1064921
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561605}

Using wpt-import in Chromium cf60c7cb.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18508

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

TBR=kereliuk

No-Export: true
Change-Id: I0fb7c55f909eeb5beacd15b2352433cac91b443e
Reviewed-on: https://chromium-review.googlesource.com/1072151
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561604}

Otherwise any call after the initial SetPlaceholderText won't render.

R=jdufault@chromium.org

Bug: 846388
Test: none
Change-Id: If3de184b8f7367658e9e0d920c9edbc45ee5d0f3
Reviewed-on: https://chromium-review.googlesource.com/1072227Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561603}

This adds the availableInlineSize, availableBlockSize, to the layout
constriants options dictionary.

This also makes the children "shrink-to-fit" if they are inside a
custom layout pass. Additional logic was needed to *not* "shrink-to-fit"
children during the layout fallback if any occurred, so
LayoutCustomPhaseScope was added to handle this.

The tests that were added test a new BFC with inline children to
see if shrink to fitting works as expected.

Bug: 726125
Change-Id: Ic86d51579b680d871c66040f54e532bc47d79979
Reviewed-on: https://chromium-review.googlesource.com/1069252
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561602}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4e9b50ab86b9..0115c356f675

$ git log 4e9b50ab8..0115c356f --date=short --no-merges --format='%ad %ae %s'
2018-05-24 justincohen Roll mac_toolchain to 478dc9dbb
2018-05-23 agable Remove old git-cherry-pick-upload documentation

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:841910,chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I7498707ef960c6bee4e121bcae531e6a0c1022d4
Reviewed-on: https://chromium-review.googlesource.com/1072046
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561601}

http://crrev.com/1cecc36 broke DevTools eyedropper tool.

Bug: 846379
Change-Id: I812b66c32192166b3c34582bf6b63407709ba784
Reviewed-on: https://chromium-review.googlesource.com/1072034Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561600}

BUG=792308

Change-Id: I151965cc99c4bd757176c3af87971e28f6c347da
Reviewed-on: https://chromium-review.googlesource.com/1069560Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561599}

Percentages are not allowed in rect() (arguments are '<length> | auto'.)
Move the old test to clip-invalid.html and replace it with one that
doesn't use percentages.

Bug: 843084
Change-Id: I3cadd99da0d302ac5a0cd012450dd7ade233681c
Reviewed-on: https://chromium-review.googlesource.com/1071469
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561598}

When the size of the to-be-encoded-image is larger than the maximum
size supported by the encoder, we need to crop the image beforehand.
Otherwise, we might end up in heap buffer overflow.

Bug: 844872
Change-Id: Ibea765a8b094a845a2a47f8d3e539fc53176ffb1
Reviewed-on: https://chromium-review.googlesource.com/1070326Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561597}

If the contextual suggestions bottom sheet is closed by user click on
the close button, we don't show the sheet again until the page is
reloaded or a new URL is loaded. This state is stored in memory and
will be cleared on restart.

Bug: 838950
Change-Id: I64ddb66cbbca7ce1831baf9a65fa676d4c951770
Reviewed-on: https://chromium-review.googlesource.com/1070750Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561596}

As part of moving devices to a mojo interface, the browser process needs
to make some decision synchronously, so we need some state management
browser-side.  The browser should be deciding which sites are presenting,
and which pages can receive various events, including activation.

BUG=795510

Change-Id: I38282b71b5134938c6670f016acd303851adc5da
Reviewed-on: https://chromium-review.googlesource.com/1060637Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561595}

TBR=kbr@chromium.org
NOTRY=true  # net_unittests flake

Bug: 846289
Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36
Reviewed-on: https://chromium-review.googlesource.com/1071868
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#561594}

Bug: 823534

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I062d1ef97feb3778622e48dfc75d353e0a4dd1e9
Reviewed-on: https://chromium-review.googlesource.com/1067682
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561593}

https://github.com/w3c/webauthn/issues/907 notes that there are three
status values for tokenBinding in webauthn, including "not-supported",
but that tokenBinding itself is optional. Rather than having two ways to
indicate that it's not supported, we're going to eliminate the
"not-supported" status and represent that by omitting the value.

This matches with Firefox's behaviour. Spec change in
https://github.com/w3c/webauthn/pull/914.

Change-Id: If47bd218d61dc71eeddab3cc0d22da953b4cc370
Reviewed-on: https://chromium-review.googlesource.com/1062188Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561592}

This CL moves RecommendationRestorer class to ash. The class exposes
an ObservePrefs method to let caller start observing recommended values
for a pref name.

TBR=bartfab@chromium.org

Bug: 839150
Test: covered by tests and enterprise-enrolled device test
Change-Id: I57b80c49ff8b0d5ab27102abf57b9a21b6b95c0a
Reviewed-on: https://chromium-review.googlesource.com/1023158
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561591}

This CL allows proto db to take a filter to filter out returned entries
Test is also included.
This will facilitate the in-progress download database work.

BUG=842245

Change-Id: I63426527743811ab31560e74a8dc45f922333a00
Reviewed-on: https://chromium-review.googlesource.com/1067149
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561590}

Bug: 845484
Change-Id: I154783db471a25436451490fe3ad93ddcc4222c5
Reviewed-on: https://chromium-review.googlesource.com/1069259
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561589}

This patch removes the !RLS codepaths in CompositedLayerMapping (CLM)
and background_image_geometry now that Root Layer Scrolling (RLS) has
launched.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id07239b22bb96fa7e4d0d3c41d82b61aa9eb5090
Reviewed-on: https://chromium-review.googlesource.com/1071871
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561588}

When the "Download Location" flag is set, we show a dialog allowing
the user to pick which directory is used for downloads.  Offline Pages
should use the directory that the user picked.  This change will get
the directory from downloads, and use that when publishing downloaded
offline pages.

Bug: 758690
Change-Id: I74ba4a1fb2c99fb986ba2273fc4b11f8fad60ba9
Reviewed-on: https://chromium-review.googlesource.com/1069423Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561587}

This patch fixes 'vertical-align' values that need font metrics:
  vertical-align: sub
  vertical-align: super
  vertical-align: middle
to use parent's font instead of the box that has 'vertical-align'
applied.

The CSS2 'vertical-align'[1] defines to use parent's font for
the 'middle' value, and matches to our current code.

It looks like no CSS2 test suites test this condition, but some
tests in css-writing-modes do.

Rebaselines look to be more correct.

[1] https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaaa7448687173a9ecf0c39b55914a0fad4834318
Reviewed-on: https://chromium-review.googlesource.com/1069955
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561586}

Do not send PRIORITY frames when SpdyStream priority changes because
SpdyHttpStream or WebSocketHttp2HandshakeStream priority is changed.
(Keep sending PRIORITY frames when the pushed stream is matched with a
request of different priority.) This CL a stop-gap to avoid crashes
until SpdyWriteQueue is augmented to properly handle priority changes.

This CL partially reverts https://crrev.com/c/1045988.

Bug: 841511
Change-Id: I871511306e96cfc2c1a3e62c8563003cdd4bb821
Reviewed-on: https://chromium-review.googlesource.com/1070655Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561585}

When subscript or superscript styles or HTML tags are used, expose the
accessibility semantics. In IA2, use the text-position text attribute.

TBR=tsepez@chromium.org,spang@chromium.org,kinuko@chromium.org

Bug: 843744
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie0dd8ef801f11548d1284ac433c08605129817d0
Reviewed-on: https://chromium-review.googlesource.com/1068994
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561584}

This debugging reporter will cache metrics events that will be used
for debugging purposes. The reporter is currently configured to cache
5 items (controlled by a static variable BUFFER_SIZE).

Bug: 843251
Change-Id: I09a63200db01819df56474c831ad9260f75d9432
Reviewed-on: https://chromium-review.googlesource.com/1056413
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561583}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I6f0403c2f3366a00d18b4bf8c64c7cfbad9cd85a
Reviewed-on: https://chromium-review.googlesource.com/1072206Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561582}

Also its deps: SequencedTaskSource and LazyNow.

Bug: 783309
Change-Id: Iee4c753beaa08f1373f5bac73bee31b78f338c10
Reviewed-on: https://chromium-review.googlesource.com/1061696Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561581}

This reverts commit 89d0b86d.

Reason for revert: Suspected cause of Win x64 build failure:
https://ci.chromium.org/buildbot/chromium/Win%20x64/22844

Original change's description:
> Adjust gn and ifdefs to make Perfetto available
> 
> Chrome has seven #ifdefs that decide whether Perfetto tracing is
> available or not. This change consolidates those into two and then
> enables Perfetto on Windows.
> 
> This change also updates two .gn files to enable Perfetto.
> 
> This change makes no difference unless the command-line option
> --enable-features=TracingPerfettoBackend is specified.
> 
> Note that this change will fail to run unless the Assert in Angle's
> AddTraceEvent function in event_tracer.cpp is removed. This is
> being investigated.
> 
> Bug: 844421
> Change-Id: Ia978eb69bed77bda68202fdbec7a306fdb9886bc
> Reviewed-on: https://chromium-review.googlesource.com/1064371
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561556}

TBR=primiano@chromium.org,oysteine@chromium.org,brucedawson@chromium.org

Change-Id: Ia94b6d81d56af41dd010adcc436f11882887864f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844421
Reviewed-on: https://chromium-review.googlesource.com/1072327Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561580}

https://boringssl.googlesource.com/boringssl/+log/69271b5d4fed328eb61b86b013937ce22549fee5..5601bdac1ae594169e56515fe34956ec89bbffbf

This needed a fix to QUIC. BoringSSL is usually initialization-less, but
Chromium is allergic to static initializers, so we build it in a mode where
the caller is expected to call CRYPTO_library_init. (Chromium's
EnsureOpenSSLInit is exactly the same as CRYPTO_library_init.) Code in
net/third_party/quic previously wasn't initializing things, which meant
tests were running with uninitialized BoringSSL. That snuck by until
a change in this most recent roll tickled it.

(I'm not super thrilled about this arrangement as it's rather obnoxious
on consumers. We're sniffing at doing the call ourselves internally. In
the meantime, Chromium has typically placed EnsureOpenSSLInit near
where BoringSSL is used, so I've matched that here.)

BUG=none

Change-Id: I99c183c2ddb1fcf9c376de8d1d46d1f274bb9605
Reviewed-on: https://chromium-review.googlesource.com/1070648Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561579}

Add behind-a-feature-flag functionality to throttle tasks on the worker
thread to 1Hz.

R=alexclarke@chromium.org
BUG=776416

Change-Id: I1698aea8788f8688027e01af4d5e72405e2c1a23
Reviewed-on: https://chromium-review.googlesource.com/1070983Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561578}

Additionally, add the ability for FakeMultiplexedChannel to run a
callback in its destructor.

Bug: 824568, 752273
Change-Id: I1dd571d79c3e73228481efb2b68b210dbeb041f1
Reviewed-on: https://chromium-review.googlesource.com/1072164Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561577}

This was requested as a follow-up in a previous review:
https://chromium-review.googlesource.com/c/chromium/src/+/1033336/3/content/browser/webauth/authenticator_impl.cc#836

Change-Id: I672fa5ac74bed7c70c680a8cd1b88b4d0f059277
Reviewed-on: https://chromium-review.googlesource.com/1069707
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561576}

When BubbleDialogDelegateView::SizeToContents() is called,
it doesn't take into account that the bounds from
GetBubbleBounds() doesn't include the NSWindow's style.
This causes the SizeToContents() to potentially set the
bubble window's bounds to an incorrect value.

Bug: 839709
Change-Id: I6e27ff4f30673b5f7c26b68459be1e1cdac51587
Reviewed-on: https://chromium-review.googlesource.com/1069541
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561575}

Change-Id: Ibec20968f901353dd96b0273e06723a3fcbbda9e
Reviewed-on: https://chromium-review.googlesource.com/1070712
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561574}

Bug: 563816
Change-Id: I22d22fcd06d6bbb9de94dc891fb4b4f327720881
Reviewed-on: https://chromium-review.googlesource.com/1070210
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561573}

This reverts commit 27f8891c.

Reason for revert: suspect for crbug.com/846417

Original change's description:
> Migrate ContentHashFetcher to SimpleURLLoader
> 
> This CL migrates ContentHashFetcher away from URLRequestFetcher to
> SimpleURLLoader.
> 
> In order to accomplish this, a few other related changes are also performed:
> 
> 1) The regular flow of the code is ContentVerifier -> ContentHash ->
>    ContentHashFetcher. In ContentVerifier, for instance, UI, IO and
>    "File tasks" threads take place.
>    Previously, the URLRequestFetcher logic residing in ContentHashFetcher
>    executed in the "file tasks" thread.
> 
>    As part of the migration from URLRequestFetcher to SimpleURLLoader
>    machinery, this CL also changes the ContentHashFetcher logic to
>    execute to the IO thread.
>    Note that it could be possible to keep the new SimpleURLLoader logic
>    in the "file tasks" thread. However, this would impose a way bigger change,
>    and require unittests to be considerably rewritten as well (see for
>    patchsets 7, 8 and 9.
>    The issue is that mojo objects are not thread safe. We could create a new
>    URLLoaderFactory for the extensions thread, but then we'd need to create a
>    new one when the network service crashes (Something this SharedURLLoaderFactory
>    one, already bound to the IOThread, magically handles), but that would be
>    significantly more complicated.
> 
> 2) content_verifier_hash_fetch_behavior_browsertest.cc was changed
>    to support running with the network service feature both enabled
>    and disabled. This is a pattern that is also present in various other
>    unittests.
> 
> In summary, the migration to use SimpleURLLoader performed here includes
> also a change in the thread that ContentHashFetcher runs on, but no
> functionality change is expected from this CL.
> 
> BUG=773295,844926
> 
> Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf
> Reviewed-on: https://chromium-review.googlesource.com/1056587
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561480}

TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,tonikitoo@igalia.com

Change-Id: I31235cf26cfff34aac0ff1e4047575ed2881722b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295, 844926, 846417
Reviewed-on: https://chromium-review.googlesource.com/1072110Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561572}

Change-Id: I143904a7dec28ffbe506f29b88ef3ac83ce5e980
Reviewed-on: https://chromium-review.googlesource.com/1071112Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jimmy Hastings <jhastings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561571}

changes:
- Add #enable-app-shortcut-search flag and develop behind it.
- Chrome side framework to support searching app shortcuts.
- Reuse GetAppShortcutItems mojo API. When specified |package_name| is empty, it
  is aimed on global query.

Video demo:
https://drive.google.com/file/d/14y70Bn0gFrZqmqJtsCS8xPLUEC0twFwh/view?usp=sharing
https://drive.google.com/file/d/1LUyzoX0dLpy3rkAx420oqznZEO9Lyyww/view?usp=sharing

Bug: 842947
Test: manual test with Android change
Change-Id: I8d6f62f12d215d464815dd4ff6c31c1e6af9e2c5
Reviewed-on: https://chromium-review.googlesource.com/1058681
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561570}

Some Posix-only instances were missed when disabling the OS_POSIX
macro for the Fuchsia build.

Bug: 836416
Change-Id: I291465a50813e984bdca223b1e533c2ad624062c
Reviewed-on: https://chromium-review.googlesource.com/1070625Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561569}

This is the first in a multi-part cleanup, detailed in the bug.

BUG=846374

Change-Id: I76331ceb7469f1262a2c934a956fdd96410c1a19
Reviewed-on: https://chromium-review.googlesource.com/1071884Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561568}