GitLab

The fallback logic in GetActiveUserOrOffTheRecordProfileFromPath
should cover the case when the user profile loading has not started.
So that it does not creates/loads user profile accidentally without
going through UserSessionManager.

BUG=728683,718734
TEST=ProfileManagerTest.UserProfileLoading

Review-Url: https://codereview.chromium.org/2918203002
Cr-Commit-Position: refs/heads/master@{#478735}

BUG=729106

Review-Url: https://codereview.chromium.org/2928653003
Cr-Commit-Position: refs/heads/master@{#478734}

The issue (crbug.com/719011) indicate that it is hard to interact with
the content under the the scrollbar because the scrollbar will fade in
while mouse moves in the hover fade in region of scrollbar.

In this patch, we prevent fade in overlay scrollbar when user mouse
down. 3 behaviors changed:

1. When mouse move in hover fade in region of scrollbar with mouse
   press, we don't trigger delay fade in.
2. When mouse down after a delay fade in triggered, cancel the delay
   fade in.
3. When mouse up in hover fade in region of scrollbar, trigger a delay
   fade in.

BUG=719011
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2931703002
Cr-Commit-Position: refs/heads/master@{#478733}

Bug: 732432
Change-Id: Id9b1ef6f89c03b3bddc2d3b5a4a8ed1d901dae98
Reviewed-on: https://chromium-review.googlesource.com/531664
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478732}

Most callers already call through WebLocalFrame (sometimes without
realizing this, so the CL changes types to WebLocalFrame in a few
places).  The only exception is in CapturePixelsForPrinting function
in content/shell/test_runner/pixel_dump.cc - the CL adds a CHECK to
verify that layout tests do not run into a scenario unsupported by
the current layout tests harness.

Additionally this CL renames PrintPagesWithBoundaries method
into PrintPagesForTesting.

No intended behavior change.

BUG=416660

Review-Url: https://codereview.chromium.org/2923343005
Cr-Commit-Position: refs/heads/master@{#478731}

SHA-1 was successfully disabled by default in M56 for publicly trusted
CAs. Remove the metrics that measured the impact of that disabling.

BUG=703458

Review-Url: https://codereview.chromium.org/2931313003
Cr-Commit-Position: refs/heads/master@{#478730}

A WebState attempts to cancel its dialogs in its destructor.  However,
the BVC uninstalls itself as the WebStateDelegate before the WebState
is deallocated, so the WebStateImpl doesn't have access to its
JavaScriptDialogPresenter to handle the cancellation.

This CL adds a call to |-cancelDialogForWebState:| when the delegates
are uninstalled for a Tab to ensure that alerts aren't queued in the
DialogPresenter for WebStates that have been deallocated.

BUG=720778

Review-Url: https://codereview.chromium.org/2926413004
Cr-Commit-Position: refs/heads/master@{#478729}

Currently SavePackage uses DownloadJobImpl as its DownloadJob implementation.
However, DownloadJobImpl will be refactored to handle all regular downloads.
So SavePackage should have its own DownloadJob implementation.

BUG=726487

Change-Id: I18b842982c9fe89226868f822030463128cbc4b0
Reviewed-on: https://chromium-review.googlesource.com/528497Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478728}

This patch changes ShapingLineBreaker behavior when there is no break
opportunity within the range, and all glyphs can fit in the available
space.

NGLineBreaker expects the ShapeResult to the end of the range, and
handles breakability between the next item by itself in such case.

It used to expect whether there's a break opportunity at the end or not,
and the mock computed it anyway. The semantics was changed since
ShapingLineBreaker does not produce as part of other computation.

This patch enables ShapingLineBreaker by default, while keeping the mock
under #ifdef to ease the isolation of problems.

Most of test failures are ignorable, crashes turn to failures, minor
differences in measuring widths, or caused by other problems (e.g.,
innerText.)

spelling-huge-text.html looks problematic. ShapingLineBreaker is more
than 10 times slower for long lines (30k characters in single text node
in this case.) I have some hypothesis, but I'd like to defer the perf
until we get more real safe-to-break. Current mock safe-to-break
requires to reshape a lot, which is good to test reshape code, but is
not appropriate to look at the perf problems.

BUG=636993

Review-Url: https://codereview.chromium.org/2879093002
Cr-Commit-Position: refs/heads/master@{#478727}

Back in the mists of time, Indexed DB in the browser
ran on a "webkit thread". We slimmed that down to being
a dedicated IDB thread, but it's now possible to ditch
that and use the task scheduler APIs, e.g. to avoid
thrashing.

BUG=552552

Review-Url: https://codereview.chromium.org/1504033007
Cr-Commit-Position: refs/heads/master@{#478726}

A regression was introduced in [1] where LayerTreeHost::ApplyViewportDeltas
would not apply inner viewport scroll deltas due to an extra "!" and no
existing tests of this code.

I confirmed this unbreaks scrolling with viewport hiding locally. A patch
will follow with a test.

[1] https://chromium-review.googlesource.com/c/527346

Bug: 732327
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8f69ea90a6793348cf1f35a5d616988ea48a6d8c
Reviewed-on: https://chromium-review.googlesource.com/531650Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478725}

This patch adds initial support for letter-spacing and word-spacing.

ShapeResultSpacing is templatized to share the code with TextRun.

This patch does not support ShapingLineBreaker yet. When it reshapes,
we need to apply spacing to reshaped parts. I'll work on it in following
patches.

Justification in LayoutNG is not supported yet either. It will be
following work too.

BUG=636993

Review-Url: https://codereview.chromium.org/2924263003
Cr-Commit-Position: refs/heads/master@{#478724}

This will ease reuse of this code in other classes.

Bug: 730170
Change-Id: I13b59fa864c0b1ddecef5e66d4ff0cf6a14d6fcb
Reviewed-on: https://chromium-review.googlesource.com/530984
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478723}

We are monitoring grid container's style change to detect cases where
some grid items may be shrunk or stretched. In those cases we are
marking the item for layout, which implies a considerable impact on
performance.

Current code assumes, wrongly, that if grid container's old style had
'stretch' as value for its align-items property it may affect some of
its children's Self Alignment properties. This assumption led to an
unnecessary overhead of evaluating every child's align-self property
to detect stretching or shrinking behaviors.

It's obvious that if grid container's Default Alignment change didn't
imply stretching or shrinking, we don't need to evaluate its children
at all.


Bug: 729236
Change-Id: I0b21f09b1d1c16e06374c2d20d150fd2829711f0
Reviewed-on: https://chromium-review.googlesource.com/524043
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#478722}

https://swiftshader.googlesource.com/SwiftShader.git/+log/399a298..3b9e1ea

BUG=swiftshader:62
BUG=swiftshader:64

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Iac2a755683e27f0c01014e55ea9ca9fbe2cb1821
Review-Url: https://codereview.chromium.org/2930373002
Cr-Commit-Position: refs/heads/master@{#478721}

The existing ChromiumEnv class retries several methods on failure for a
bit, this CL adds that same retry logic to the new MojoEnv leveldb env.

Bug: 586194
Change-Id: I6d3805ed8e0db6cbd1363a85b087ee0753000cfb
Reviewed-on: https://chromium-review.googlesource.com/528294
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478720}

This will prevent the accumulation of translate events when UMA recording is not enabled.

Also:
 - clear the event_cache when recording is disabled.
 - Change 'return' to 'continue' in translate_ranker_metrics_provider in case only a subset of browser states don't have a valid ranker.

BUG=730032

Review-Url: https://codereview.chromium.org/2930433004
Cr-Commit-Position: refs/heads/master@{#478719}

Bug: 635031
Change-Id: If116b73922b27263fc5934f85939a95ad861ffd0
Reviewed-on: https://chromium-review.googlesource.com/528374
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478718}

SequenceLocalStorageMap allows storing and then retrieving arbitrary values to/from a sequence.
It stores the values itself and their destructors. When the SequenceLocalStorageMap object is
destroyed, the values are also destroyed by their associated destructors.

This change will make it easier to migrate from SingleThreadTaskRunner
to SequencedTaskRunner for components that use thread-local-storage.

Reference: https://chromium-review.googlesource.com/c/525834/

Bug: 695727
Change-Id: I4f8558cd21aa30e7932bdd039ca618c6ff9c6de9
Reviewed-on: https://chromium-review.googlesource.com/527299
Commit-Queue: Jeffrey He <jeffreyhe@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478717}

For getSearchEnginePromoShowType to be accurate the TemplateUrlService
needs to be loaded (otherwise it is not possible to correctly determine
the current default search engine).

This adds a helper function that runs an action when the template
url service is loaded and reduces the boiler plate code we had to do
that in three different places.

BUG=730776

Review-Url: https://codereview.chromium.org/2930063002
Cr-Commit-Position: refs/heads/master@{#478716}

This is a prerequisite cl for the feature to customize the order of picker Tabs.
By adding source type to DesktopMediaList, the DesktopMediaList users can know
the type (screen/window/tab) of the list and do the relevent processing.

Bug: 728866
Change-Id: I73ecb3034ce1860bf7d76c6259325813daaa9cf7
Reviewed-on: https://chromium-review.googlesource.com/526854Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478715}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b97695f8e05e..2d797e034329

$ git log b97695f8e..2d797e034 --date=short --no-merges --format='%ad %ae %s'
2017-06-07 nya chromeos_config: Sync and build Chrome in Android PFB.
2017-06-08 tbroch Revert "Upload licensing file as artifact in ArchiveStage"
2017-06-09 dgarrett Revert "paygen: increase EndToEnd timeout to 1200 seconds"
2017-06-09 akeshet swarm_mon: add SuccessCounter
2017-05-25 jrbarnette Rename 'arc-bvt-cq' to 'bvt-arc'
2017-06-07 laszio daisy: Build kernel with AutoFDO
2017-06-07 bhthompson chromeos_config: refactor experimental paladin list
2017-06-09 nya cbuildbot: Record build IDs in TKO job keyvals.
2017-06-05 hidehiko Extract main implementation of GenericRetry into a class.
2017-06-02 achuith cros_vm: Fixes for VM.WaitForBoot() on non-KVM.
2017-06-08 grundler paygen: increase EndToEnd timeout to 1200 seconds
2017-06-08 chrome-bot Update config settings by config-updater.
2017-06-07 pprabhu Revert "chromeos_config: Make cyan-paladin experimental (workaround)."
2017-06-06 yunlian use stable version for a set of cros- packages.
2017-06-07 nya chromeos_config: Make tests aware of nyc-android-pfq.
2017-06-05 mikewu Upload licensing file as artifact in ArchiveStage
2017-06-07 davidriley som_alerts_dispatcher: And master-nyc-android-pfq to SoM builds.
2017-05-27 nxia Consider CQs passed in history in SubmitPartialPool
2017-06-06 laszio quawks: Build kernel with AutoFDO
2017-06-07 haddowk [autotest] Mark moblab paladin as not important.
2017-06-07 chrome-bot Update config settings by config-updater.
2017-05-26 nxia Consider CQs passed in history in TriageRelevantChanges.
2017-06-02 nxia Record relevant_to_slave action to CIDB for relevant changes.
2017-06-07 chrome-bot Update config settings by config-updater.
2017-06-06 davidriley prebuilts_unittest: Temporary disable cyan test.
2017-06-06 dgarrett chromeos_config: Make cyan-paladin experimental (workaround).
2017-06-07 nya chromeos_config: Move boards to NYC Android PFQ.
2017-06-06 bhthompson Deprecate strago paladin
2017-06-06 bhthompson Deprecate veyron_pinky paladin
2017-06-06 bhthompson Promote various paladins to important
2017-06-06 bhthompson Add veyron_tiger paladin
2017-06-06 bhthompson Add veyron_jaq paladin
2017-06-06 chrome-bot Update config settings by config-updater.

Created with:
  roll-dep src/third_party/chromite chromiumos/chromite.git

BUG=

Review-Url: https://codereview.chromium.org/2933003002
Cr-Commit-Position: refs/heads/master@{#478714}

BUG=b/27447486

Change-Id: Ie08130329f12f34b6af4538aba56eb4e942abf3c
Reviewed-on: https://chromium-review.googlesource.com/530766Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478713}

Currently Update call will create a new unique pointer and destroy the
existing one. This will cause crash if we get the same object, change
the states and call Update again.

This CL also removes the cache in model, since we should support pass
the same object into Model::Update call.

Bug: 731994
Change-Id: I35ea73bf8b32f7f2a08d2e212dc738cfc4d155d9
Reviewed-on: https://chromium-review.googlesource.com/530484
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478712}

Remove LineBoxListPainter::InvalidateLineBoxPaintOffsets
Deadcode from https://crrev.com/9200103f3f0c21d9bd88c669159a43097ba185ed

Remove InlineTextBoxPainter::PaintCompositionBackgrounds
Deadcode from https://crrev.com/81808f5a2947e0a2c6d895fe59438ac7e3af04c8

Remove BoxPainter::IsFillLayerOpaque
Deadcode from https://crrev.com/e3ab046fcbe969bd1b38a0361f7d583998365c2c

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icfa5df530d09bbb13aed0946f6bb2c114027ada7
Reviewed-on: https://chromium-review.googlesource.com/530038Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478711}

Bug: 732241
Change-Id: Ie525bd9ca1811581a1d8fbe4a9c02be768032ed9
Reviewed-on: https://chromium-review.googlesource.com/531066Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478710}

Up until now, there has been little help in debugging the
feature_engagement_tracker component other than seeing how the UI
behaves.

This has meant that some things are harder to evaluate and debug,
and developers typically have to add manual logging, particularly for
the check for whether in-product help should trigger.

This CL adds support for writing the ConditionValidator::Result struct
to an std::ostream using the operator<<. In addition, it makes use of
that in DVLOG(2) statements.

It also adds some extra debugging information related to startup
initialization and tracking of events.

By adding the following to the chrome command line, the extra logging
would appear in debug builds:
--vmodule=feature_engagement_tracker_impl*=2,model_impl*=2,availability_store*=2

BUG=None

Change-Id: Ifc4194d19fdec9230ad372b1d6296ffca45d5ee0
Reviewed-on: https://chromium-review.googlesource.com/526013Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478709}

Adding 4 strings that will be used for incognito mode on ARC's intent
picker.

Bug: 678141
Test: Build
Review-Url: https://codereview.chromium.org/2912133002
Cr-Commit-Position: refs/heads/master@{#478708}

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignments in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1] https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubidi.h?type=cs&q=UBiDiDirection&l=419
[2] https://google.github.io/styleguide/cppguide.html#Function_Names

Review-Url: https://codereview.chromium.org/2925293003
Cr-Commit-Position: refs/heads/master@{#478707}

It provides a concise syntax for using CreateDataProperty to create
data objects without invoking any setters that may exist on the
prototype chain. Most call sites were doing this already via
SafeSetV8Property, but DataObjectBuilder is clearer.

gin::DataObjectBuilder is extended to accept indices in addition to
string keys.

Bug: 689396
Change-Id: I0ef4119a73a0d6a6739b8f9e871bcc665c7543f2
Reviewed-on: https://chromium-review.googlesource.com/524243Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478706}

During refactoring, the wrong value was recorded.  Record the correct value.

BUG=725740

Review-Url: https://codereview.chromium.org/2925113004
Cr-Commit-Position: refs/heads/master@{#478705}

SpdySessionPool::OnNewSpdySessionReady() calls
HttpStreamFactoryImpl::Request::Complete() repeatedly while there are
any Requests in the map.  This relies on
HttpStreamRequest::Delegate::OnStreamReady() destroying the Request,
which in its destructor calls
HttpStreamFactoryImpl::JobController::OnRequestComplete(), which calls
HttpStreamFactoryImpl::JobController::CancelJobs(), which calls
HttpStreamFactoryImpl::JobController::RemoveRequestFromSpdySessionRequestMap(),
which calls SpdySessionPool::RemoveRequestFromSpdySessionRequestMap().
However, if HttpStreamRequest::Delegate::OnStreamReady() does not
destroy the Request, that results in DCHECK(!completed_) triggering in
HttpStreamFactoryImpl::Request::Complete() in a debug build, and an
infinite loop in production build.

This CL fixes this by explicitly calling
RemoveRequestFromSpdySessionRequestMap() in
SpdySessionPool::OnNewSpdySessionReady().

This revives https://crrev.com/2784143003, which was abandoned to do all
the necessary cleanup first.  Kudos to xunjieli@ for paving the way.

BUG=706974

Review-Url: https://codereview.chromium.org/2930323002
Cr-Commit-Position: refs/heads/master@{#478704}

https://chromium.googlesource.com/android_tools.git/+log/cb6bc2110..023e2f654

023e2f6 Roll NDK to pick std::deque patch.

BUG=674287

Review-Url: https://codereview.chromium.org/2904813005
Cr-Commit-Position: refs/heads/master@{#478703}

BUG= 672257

Review-Url: https://codereview.chromium.org/2932373002
Cr-Commit-Position: refs/heads/master@{#478702}

This moves the tearing down of VR UI into onStop instead of onPause.
However, this means we have to handle cases where Chrome pauses without
stopping while in VR. The only case I'm aware of where this is possible
is when the user enters multi-window mode while in VR.

(Even if there are other unhandled cases, the only problem is we keep
showing VR UI where we would prefer not to, and the user would have to
more explicitly exit VR)

Bug: 673528
Change-Id: Ia890875e1cf813b47443c4bb0883401506e6e55d
Reviewed-on: https://chromium-review.googlesource.com/527379
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478701}

We decided that it is possible to have answer cards in Launcher even
before full-screen launcher is implemented.

As answer cards dictate the design of the whole search result page, new
search result page design will be applied when answer-card flag is on,
even without the full-screen flag.

The full-screen launcher comes with a total redesign of everything,
including search results page, so the new design for search results page
will be applied if full-screen flag is on, even without answer-card
flag.

This means that old design of search results page will be preserved only
when both flags are off.

Also, removing some unnecessary code.

Bug=712331

Review-Url: https://codereview.chromium.org/2933673002
Cr-Commit-Position: refs/heads/master@{#478700}

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2932913003
Cr-Commit-Position: refs/heads/master@{#478699}

BUG=729164

Review-Url: https://codereview.chromium.org/2930113002
Cr-Commit-Position: refs/heads/master@{#478698}

BUG=583440

Review-Url: https://codereview.chromium.org/2930353002
Cr-Commit-Position: refs/heads/master@{#478697}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f1ec7517..de09009b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2932383002
Cr-Commit-Position: refs/heads/master@{#478696}