- 05 Nov, 2018 40 commits
-
-
Shu Chen authored
Bug: 859432 Change-Id: I2fb4b30fffac5db5c2d5a31e7bf96b74e2bcbc89 Reviewed-on: https://chromium-review.googlesource.com/c/1317074Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605509}
-
Nate Fischer authored
This creates a mostly default NetworkContext. This duplicates the work provided by the content-layer implementation, but will later be extended to provide more functionality. The main addition beyond content layer is this configures WebView's HTTP cache. R=changwan@chromium.org, mmenke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Bug: 887538 Test: No major issues with NetworkService feature enabled. Change-Id: I9cc1823f144d9ffc96fca917b0763b74e36a53d7 Reviewed-on: https://chromium-review.googlesource.com/c/1314133 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605508}
-
Jared Saul authored
The tests in this CL have been landed and reverted a couple of times; they work, but end up being a little flaky on Win7. We've had a hard time getting a reproducible setup, and the Chrome testing team have verified our feature works as intended, so for the time being we're marking the tests as flaky on Windows and will follow up. (Sheriffs: If somehow the landing of this CL causes additional flakes, feel free to revert. Flake analysis hasn't shown anything outside of Win7.) Bug: 884817 Change-Id: Iec545cb861bfc1aa3d50746c3a413257c9a9ec82 Reviewed-on: https://chromium-review.googlesource.com/c/1316666 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#605507}
-
Aaron Leventhal authored
Also: - Fixes a bug where updating tabindex on a node did not update its focusable state. - Removes hack for hiding objects from NVDA virtual buffer by providing a null accName. It turns out that using a hidden:true object attribute works and is preferred by NVDA, which for historical reasons ignores the INVISIBLE state. Bug: 900982 Change-Id: I7611d3c3e2da3d6b3f22e40e69189579d15b580e Reviewed-on: https://chromium-review.googlesource.com/c/1312675 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#605506}
-
Luciano Pacheco authored
NOTE: This CL can introduce FLAKINESS, because the number of metadata call depends on multiple async calls. I'll watch the bots and update these tests accordingly. |equal1PercentageMargin| wasn't checking properly the 1% margin, because it was comparing to |desiredValue| instead of |value|, this was causing it to always return true. :-( Change this function to have ceil/floor so it accounts to at least 1 full unit for min and for max values. Changed it to log the values when it returns false which is helpful for debugging failing tests. Change |metadataLargeDrive| test to be more lenient for |fromCache| metadata calls, because calls to cached metadata are cheap we don't have to be too strict and running locally it flaked ranging from ~40 to < 70. Fix small typo. Bug: 899664 Change-Id: I6c6654684a5b341a3ac7378774cb6fe9b7affe4c Reviewed-on: https://chromium-review.googlesource.com/c/1317223Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605505}
-
David Tseng authored
- ensure we exit Learn Mode for any conceivable user input we capture - improve intro and outtro announcements Bug: 884541 Change-Id: Id2c81cb4e11c5c0a100a065de5f13ba6857eead1 Reviewed-on: https://chromium-review.googlesource.com/c/1313055Reviewed-by:
Zach Helfinstein <zhelfins@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#605504}
-
yileili authored
This is a reland of 08f4508d Original change's description: > Add cast http apis for assistant services. > > Bug: b:118193766 > Test: Manual > Change-Id: I6da9d8458a59701ae7c9ed642d16094e2f36782b > Reviewed-on: https://chromium-review.googlesource.com/c/1304489 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yilei Li <yileili@google.com> > Cr-Commit-Position: refs/heads/master@{#605395} Bug: b:118193766 Change-Id: I56fe71e0c29cb78500d0f6f9164be126e55ff8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1318186Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#605503}
-
Hector Carmona authored
Missed this in previous CL. TBR=scottchen@chromium.org Bug: NONE Change-Id: I484d67c17d35daf6e643739eb28f157aa3cf9ec2 Reviewed-on: https://chromium-review.googlesource.com/c/1316114 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff3c10197ad5..f742ea814813 Created with: gclient setdep -r src-internal@f742ea814813 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:448088 TBR=mmoss@chromium.org Change-Id: I753819a1857e958854ad9d46f01c0b53dc273317 Reviewed-on: https://chromium-review.googlesource.com/c/1318156Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605501}
-
chrome://flagsMatt Reynolds authored
The default polling rate has been changed to 250 Hz, and the chrome://flags option is no longer necessary. BUG=857522 Change-Id: I4852a67ecd8b8426de0386cdedcadafacd81f1e8 Reviewed-on: https://chromium-review.googlesource.com/c/1317864Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#605500}
-
Robert Flack authored
Bug: 895883 Change-Id: I377cc6aaf8c9231a81eb100a720e83fa04b9d9a7 Reviewed-on: https://chromium-review.googlesource.com/c/1318570Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605499}
-
Becca Hughes authored
This CL moves any existing uses in Android of MediaMetadata to the new version in the media_session service. BUG=875004 Binary-Size: Adding duplicate classes that will be removed in https://crrev.com/c/1241554 Change-Id: I8ed9afd45a37e515ae89d5d82a542a6f4c139136 Reviewed-on: https://chromium-review.googlesource.com/c/1241466 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#605498}
-
Liquan(Max) Gu authored
Last Image Paint takes the last image based on the order of first paint index. In the initial implementation, the first paint index was the time the image is attached to DOM tree. As an alternative, the first paint index can also be the time the image is loaded. By observation, we find that it's more natural for users to regard the last image as the last one being loaded other than the last one being attached to the tree, as the latter may not be visible to users yet. Therefore, this CL is to change the definition of "last" in Last Image Paint to the last image being loaded. Bug: 869924 Change-Id: Ib5d0addf10c32668b38297c2efe5e73b7e1e7a33 Reviewed-on: https://chromium-review.googlesource.com/c/1316360 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#605497}
-
Xiyuan Xia authored
- Add a ScopedAllow helper class that SystemEventRewriter allows event to pass through when there are instances of it; - Use ScopedAllow helper to allow fake gesture events to pass through under mash; Bug: 884360 Change-Id: I940398b0920505743ad7adbe08e12e1394fb55c0 Reviewed-on: https://chromium-review.googlesource.com/c/1292400Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605496}
-
Dmitry Titov authored
TBR: mdjones@chromium.org Bug: 901986 Change-Id: Id217b2021bad98a79e344de5ad647d0638233842 Reviewed-on: https://chromium-review.googlesource.com/c/1318675Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605495}
-
Kent Tamura authored
Bug: 889726 Change-Id: I7994d14f8651f0ebcacc4e7485eabe4f28379dea Reviewed-on: https://chromium-review.googlesource.com/c/1317419Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605494}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I8d6f6c87fc92ef3924ca9406e519e60fc7ff0035 Reviewed-on: https://chromium-review.googlesource.com/c/1317417Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/03ce64d28832..6b1f256782eb git log 03ce64d28832..6b1f256782eb --date=short --no-merges --format='%ad %ae %s' 2018-11-05 sergiyb@chromium.org Default to reduced timeout to ensure logs on timeout Created with: gclient setdep -r src/third_party/catapult@6b1f256782eb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899721 TBR=sullivan@chromium.org Change-Id: Idaec1143ad77151864c0627a64244ba3390e3ede Reviewed-on: https://chromium-review.googlesource.com/c/1318542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605492}
-
Caleb Rouleau authored
TBR=nednguyen@google.com NOTRY=true Bug: 902064 Change-Id: Ic9f91ba4b263fb4ed435ac7a9dc1a096aa452516 Reviewed-on: https://chromium-review.googlesource.com/c/1318586Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#605491}
-
Tatiana Buldina authored
Bug: chromedriver:1994 Change-Id: Ic15edd6634d5a8cc118703a86155a90eda602a7d Reviewed-on: https://chromium-review.googlesource.com/c/1292407Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#605490}
-
Saman Sami authored
Frame eviction is intended to allow only a handful of tabs to keep their tiles alive while in background. Before site isolation, there used to be only one surface per tab that needed to be evicted, but now cross-site iframes have their own surfaces too, so if we want to avoid linear growth in tile memory as the number of tabs increases, these surfaces must be evicted too. Make DelegatedFrameHost grab all SurfaceIds in the frame tree on eviction and evict them all, as opposed to only evicting the surface of the top-level renderer. The next time the tab is visible, notify all evicted RenderWidgets so that they can allocate new SurfaceIds for their children. Bug: 893793 Change-Id: I3dfbba961a6ae696d4207f7c0728a195fe8275a4 Reviewed-on: https://chromium-review.googlesource.com/c/1307252 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605489}
-
Scott Graham authored
Bug: 883496 Change-Id: I2745399b530564c05e95f4375e04cac978454372 Reviewed-on: https://chromium-review.googlesource.com/c/1313417 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605488}
-
Xing Liu authored
The download file name can be null in some cases when the file name is set to empty by the users. In these cases, AlertDialogEditText may return null when calling getText(). Since we lose the suggested file path, the download should be canceled. Bug: 901783 Change-Id: I4989006b0a0b038fa51eacd070f7dfb542c1b2bd Reviewed-on: https://chromium-review.googlesource.com/c/1318369Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605487}
-
Wez authored
Bug: 893229 Change-Id: I509c18dcc30c7962bd5a496396556dd8cbf9af06 Reviewed-on: https://chromium-review.googlesource.com/c/1318578Reviewed-by:
James Robinson <jamesr@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605486}
-
Paul Dyson authored
AppSourceUrlRecorder does not belong in components/ukm/content/ and would be better placed in /components/ukm. This will allow AppSourceUrlRecorder to be called from ash. Bug: 899123 Change-Id: I26838e3de938740743a00316ba71ad9afc6d9466 Reviewed-on: https://chromium-review.googlesource.com/c/1300817Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#605485}
-
David Tseng authored
- observe lifetime of the view and invalidate our weak pointer to it when it is being deleted - clean up strange useage of AXUniqueId TBR=slan@chromium.org Bug: 859190 Change-Id: I15b45750ddecde7d20c4c91502411690e4025c07 Reviewed-on: https://chromium-review.googlesource.com/c/1316440 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
James Darpinian authored
http://crrev.com/c/567306 added support for LUMINANCE, ALPHA, and LUMINANCE_ALPHA formats to the CopyTextureCHROMIUM implementation. This also enables that support on OpenGL ES 3 contexts for Android. Fixes WebGL conformance tests: conformance/textures/video/tex-2d-alpha-alpha-unsigned_byte.html conformance/textures/video/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html conformance/textures/video/tex-2d-luminance-luminance-unsigned_byte.html Bug: 878920 Change-Id: Iee4a5189662c1c820ec2fc99b676a1b4e1beb1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1302825 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605483}
-
Jacob Dufault authored
TBR=dtseng@chromium.org Bug: 899777 Change-Id: I2301630944dbd19198a9d09d4030dde2ddacb587 Reviewed-on: https://chromium-review.googlesource.com/c/1303051 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#605482}
-
Becca Hughes authored
This CL moves the MediaMetadata and MediaImage mojo types from Blink to the Media Session service along with their mapped types in content. This is the first of four parts. BUG=875004 Change-Id: Ie862229bbeb474a60ccc4d2f82d8c4e1f8017b74 Reviewed-on: https://chromium-review.googlesource.com/c/1227401Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chrome://flags/#enable-site-per-processLukasz Anforowicz authored
site-per-process has shipped on desktop platforms in M67. Therefore, chrome://flags/#enable-site-per-process is not needed on desktop platforms (since the default already is to enable site-per-process). Bug: 901522 Change-Id: I0d0bceb3706453683362ae4c7efa41d78a9104d8 Reviewed-on: https://chromium-review.googlesource.com/c/1316649 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605480}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c22f551842df..ee49f7087f93 git log c22f551842df..ee49f7087f93 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 philipel@webrtc.org Remove VideoEncoder::SetChannelParameters. Created with: gclient setdep -r src/third_party/webrtc@ee49f7087f93 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I12a8d3786cb7b0e0e0f858cbe3c808f216caab0b Reviewed-on: https://chromium-review.googlesource.com/c/1318153Reviewed-by:
-
Takuto Ikuta authored
Whitelist the files only for component_build. Bug: 900696 Change-Id: Ie85e9d963b6d28f8187abc2d7223d78c3851bc89 Reviewed-on: https://chromium-review.googlesource.com/c/1318510 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605478}
-
Michael Lippautz authored
This is a fixup after commits related to crbug.com/887148 Tbr: haraken@chromium.org No-try: true Bug: chromium:843903 Change-Id: I58530721a40968bd31db08ce5adda9a7b87a9157 Reviewed-on: https://chromium-review.googlesource.com/c/1317898Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605477}
-
David Bokan authored
When the URL bar is being actively scrolled out of view, the browser is exposing a new region of the page at the bottom of the screen. Since the render/Blink hasn't been resized yet, PictureLayerImpl has some code to rasterize this new region despite the fact it falls outside the layer's bounds. As part of https://crrev.com/77b67445ba6e415e8b41b5b6fd5c016c7195206d, I changed this code to raster the exact amount the URL bar is hidden. However, this caused a perf regression as we would now raster the region in pieces as the URL bar scrolled away, rather than in one go. So in https://crrev.com/b2d410710e7ea7c5a33798ff6b5d5191b1951b5e I undid that change and rastered the entire region as before. However, I kept some the other changes made in the first CL. One of those changes was to do this only when browser_controls_shrink_blink_size is true (meaning the renderer has received a resize as a result of the URL bar being shown) but no longer look if we're in an active scroll. Not looking at whether we're actively scrolling regresses the metric in the linked bug. It's more correct to look at both these bits. We should only expand the raster region when we're going from controls shown to hidden (so look at browser_controls_shrink_blink_size) but we should also only do this when we're in a scroll. i.e. If the user isn't hiding the URL bar, there's no need to raster additional content. Bug: 900928 Change-Id: I373ebe8879b832616780996f9afdd16092538fdd Reviewed-on: https://chromium-review.googlesource.com/c/1315699Reviewed-by:
enne <enne@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605476}
-
Rayan Kanso authored
Major changes: - The scheduler owns the job controllers. It is also the data manager / service worker observer now instead of BackgroundFetchContext. - The job controller itself is in charge of processing a fetch. This simplifies the `abort` workflow thanks to weak_ptrs. The scheduler can still be extended to process multiple requests though. - The scheduler cleanup process for a job controller handles the registration cleanup and event dispatching. - The UpdateUI DB tasks and checks and associated checks were removed since the UI can only be updated once when the registration fails/succeeds. - Scheduler::Controller was removed since it doesn't make sense to have anymore now that the scheduler directly owns the controllers (also RequestProvider because it added no value). - There were some other minor readability cleanups along the way. Bug: 850512 Change-Id: Icff68da7ccc20d8112d283843dd2ad6c6d1a9a26 Reviewed-on: https://chromium-review.googlesource.com/c/1297412Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#605475}
-
Matthew Cary authored
If an adb command fails during profiling, dump logcat through logging.error. This will aid with debugging. Bug: 898979 Change-Id: I4178579e2e69d5d43eb2b12b8eafad1c8038396f Reviewed-on: https://chromium-review.googlesource.com/c/1317916Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#605474}
-
Brian White authored
This is a further attempt to determine why two subsequent calls to this method with the same parameters sometimes produce different outputs. Bug: 836238 Change-Id: I3960fe0bd27976ae4678a4f96bad61870c22342c Reviewed-on: https://chromium-review.googlesource.com/c/1314648Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#605473}
-
Joshua Pawlicki authored
In some cases I could not find the old keys, so I have created and checked in new keys. This resulted in ID rotation. These test CRXs are not signed with publisher proofs - some of them will likely need to have a publisher proof added in the future. Bug: 740715 Change-Id: I8534c8bcdc387d9c04e92300480e845819e129f4 Reviewed-on: https://chromium-review.googlesource.com/c/1313551Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#605472}
-
danakj authored
This is a reland of 1c6f831f This CL made a number of flaky tests more visibly flaky. We've fixed or disabled tests as a result of that. (See crbug.com/899073) TBR=dcheng@chromium.org, piman@chromium.org Original change's description: > Don't SetVisible on swapped out RenderWidgets, and drop gpu resources. > > When a RenderWidget is created for a RenderViewImpl, it may be > considered "swapped out". This means the main frame for this > RenderView's frame tree is not local, the RenderView exists to > hold some other local subframe, which will be composited and have > a RenderWidget. Thus the RenderWidget attached to the RenderViewImpl > is not actually used, there is no output from the remote main frame > in this tree. I like to refer to these swapped out RenderWidgets as > zombies. > > During navigations, a RenderViewImpl's main frame may change to or > from being local, in which case the RenderWidget attached to it changes > to or from being a zombie. > > When becoming a zombie, the WebFrameWidget attached to the > RenderViewImpl (wrapping the WebViewImpl) is destroyed, and this > marks the compositor as SetVisible(false) on the RenderWidget > (via the WebViewImpl). > > When becoming alive again, a new WebFrameWidget is attached to the > RenderViewImpl, and the WebFrameWidget marks the compositor as > SetVisible(true) on the RenderWidget (via the WebViewImpl). > > While a zombie, the WebViewImpl is also told not to allow any > visibility changes to be passed along to the RenderWidget. This is > because as the local subframe becomes visible with the Page, we'd > tell the WebView about this, to tell the Page. But since the > WebView now has a zombie RenderWidget, it shouldn't also tell that. > > Note when the RenderViewImpl is created and initially swapped out > it creates a RenderWidget but nothing tells its compositor about the > zombie state of affairs, so it becomes visible, which makes it > acquire a Gpu channel and start its scheduler etc. Woops. > > This CL rearranges things a bit. > - A new RenderWidget does not SetVisible(true) if swapped out. > - RenderViewImpl directly marks it SetVisible(false) when removing the > WebFrameWidget. > - RenderViewImpl *also* removes the LayerTreeFrameSink to drop the > Gpu channel since we don't need to be fast at becoming visible (the > RenderWidget is a zombie!) > - RenderViewImpl directly marks it as SetVisible(true) when getting > a new WebFrameWidget as the RenderWidget stops being a zombie. > - WebViewImpl stops calling SetVisible on the RenderWidget when its > main frame is not visible. In the future the RenderWidget should be > a member of the main LocalFrame, and thus won't even exist when the > main frame is not local. > > R=dcheng@chromium.org, piman@chromium.org > > Change-Id: I87a5d0dfeaaf08cb91c9348b26b4205db55b3a81 > Bug: 894899, 419087 > Reviewed-on: https://chromium-review.googlesource.com/c/1290140 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602389} Bug: 894899, 419087 Change-Id: Iaea605af085c2c866fc183bb317e98aa15cb4ab3 Reviewed-on: https://chromium-review.googlesource.com/c/1318382 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Philip Rogers authored
This patch stops changing the cc::Layer hierarchy when the GraphicsLayer hierarchy changes. Instead, we rely on cc::Layers being updated in PaintArtifactCompositor (PAC). Bug: 898668 Change-Id: Ib1abb05bc1d8dc7d12ec5f88c8518cf75d077f74 Reviewed-on: https://chromium-review.googlesource.com/c/1313415Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605470}
-
