- 09 Jul, 2018 40 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1354048c8fa8..c3833b4c152a git log 1354048c8fa8..c3833b4c152a --date=short --no-merges --format='%ad %ae %s' 2018-07-09 bsalomon@google.com Revert "Add genIDs from all contributing elements to GrReducedClip's mask key." 2018-07-09 herb@google.com Update SkSpan to match the standard more closely 2018-07-09 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 8fbd9d96e68b..c2136b67f69d (1 commits) 2018-07-09 brianosman@google.com Update mandrill PNGs to be sRGB (rather than gamma 2.2) 2018-07-09 meisterdevhwan@gmail.com More workarounds on Windows Debug DLL crash. 2018-07-09 bungeman@google.com Remove SK_IGNORE_WIN_EMOJI_FIX 2018-07-09 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6a990f8b1a93..6a6692214c26 (1 commits) 2018-07-09 brianosman@google.com Remove some linear-blending sRGB logic from sk_app 2018-07-09 brianosman@google.com Always unpremul nonlinearly before writing PNGs in DM Created with: gclient setdep -r src/third_party/skia@c3833b4c152a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: If8084c869fe666d9b93f5f2e1c8b974617e3e611 Reviewed-on: https://chromium-review.googlesource.com/1129640Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573502}
-
Maggie Chen authored
The comman line switch --disable-gpu-process-for-dx12-vulkan-info-collection is added to layout tests and browser test so the non-sandboxed gpu process, which is used for DX12 and Vulkan info collection and histograms, can be disabled to avoid interference. The info collection process is not needed for these tests. BUG=852796,856398 Change-Id: I7fac317987996aeb4a5ea37e473468f69ef3d89a Reviewed-on: https://chromium-review.googlesource.com/1123167Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#573501}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I538205f53ba84bf5b2aaf4104a09c080e9aab375 Reviewed-on: https://chromium-review.googlesource.com/1126162Reviewed-by:Erik Chen <erikchen@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573500}
-
Helen Li authored
These two histograms are unused. The related histograms have already been deprecated. This essentially reverts crrev.com/466197. Bug: 859569 Change-Id: Idfbe20823425576aff4eaed54fdc67339c24e007 Reviewed-on: https://chromium-review.googlesource.com/1129827Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#573499}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27f6e148..cae2929d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c5f15dfad2e8721e1c6ce61a214c7a024d289e6 Reviewed-on: https://chromium-review.googlesource.com/1130018Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573498}
-
Karan Bhatia authored
This CL performs the following changes: - extension_with_rulesets_ holds ExtensionsIds instead of Extension pointers. - file_task_runner_ uses the central Extension file task runner now instead of creating its own. - RulesMonitorService declares explicit dependencies on ExtensionRegistry, ExtensionPrefs and ExtensionSystem. This refactoring is in preparation for a subsequent CL which will handle indexed ruleset corruption. This CL does not introduce any behavior change. BUG=852058 Change-Id: Ia3a6a234836ac23f1571bb7b062ebf7bf6fc98ba Reviewed-on: https://chromium-review.googlesource.com/1128387 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573497}
-
Khushal authored
Add memory dumps for ServiceTransferCache. Note that this is expected to come up as a regression in memory reported by the GPU process since this data was not being reported until now. R=ericrk@chromium.org Bug: 859419 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03de3eef4ef688b62b4714897c1f301f98d63e74 Reviewed-on: https://chromium-review.googlesource.com/1125524Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#573496}
-
Yutaka Hirano authored
This CL: - introduces Segment to remove ad-hoc AllocateSegment / FreeSegment calls, - removes the const qualifier from Data to remove mutable from members, - inlines some functions, and - includes miscellaneous algorithmic simplification. This CL doesn't change the behavior, and is not expected to improve or regress performance. Bug: None Change-Id: If1700dd4ae430edbfbd8985836cd73505d441eb4 Reviewed-on: https://chromium-review.googlesource.com/1127573 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#573495}
-
Daniel Murphy authored
When using the Clear Browsing Dialog, this can call a DeleteAll in SessionStorage backend code. There were DCHECKs around being bound to a renderer, but this doesn't need to be the case when using the Clear Browsing Data Dialog. This CL removes those DCHECKs for DeleteAll. R=mek@chromium.org Bug: 859876 Change-Id: Iee4e3027ad1a1c396f1b7f746aec0e844a8f64b1 Reviewed-on: https://chromium-review.googlesource.com/1125023Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#573494}
-
Tommy Steimel authored
This CL adds a method in MediaViewerUtils to selectively enable or disable the MediaLauncherActivity, enabling if the device is an Android Go device and if a new HandleMediaIntents feature flag is enabled. This new flag is enabled by default. This CL also calls this new method when Chrome is started via the ProcessInitializationHandler. Bug: 856693 Change-Id: I80f03481e399ac163a3dd10720771d6404b8d56d Reviewed-on: https://chromium-review.googlesource.com/1121577 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#573493}
-
James Cook authored
https://chromium-review.googlesource.com/c/chromium/src/+/1127028 changed content/public/app/BUILD.gn to always package the font service manifest at the //content level. We no longer need to package it at the //chrome level. This fixes the "all" build: autoninja -C out/Default # (no target) Bug: none Change-Id: I6a22e06f95baf0905b1bab3c4352ed5fa8a5a5ca Reviewed-on: https://chromium-review.googlesource.com/1130009Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#573492}
-
Peng Huang authored
On Linux X11, the GLSurface may have different compatibility key. We have to have to create different GLContext and GrContext based on the compatibility key. Becasue GLContext::MakeCurrent(GLSurface*) will not work if they are not compatiable. On other platforms, the compatibility key is always 0. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If36e218963f59c9dd7001c6fe7a7b133fd435434 Bug: 838899 Reviewed-on: https://chromium-review.googlesource.com/1125084 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573491}
-
Yannic Bonenberger authored
This CL removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. It also fixes a bug in //tools/clang/base_bind_rewriters which caused commas to be wrongfully removed if base::AdaptCallbackForRepeating is not the first parameter. Change-Id: Ic90bfcef4496fa0a22a083e2c8506066cffd5b95 Reviewed-on: https://chromium-review.googlesource.com/1123819 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#573490}
-
Aga Wronska authored
Right now flow consists of: * Demo preferences screen where user can select language related options * Chrome OS Eula that has to be accepted * Demo setup screen that shows progress and result of demo setup More screens will be added later. BUG=827376 TEST=Run tests in wizard_controller_browsertest.cc Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifa4c86201a0ef7b0a6c41b5805ba0c3fde1d791a Reviewed-on: https://chromium-review.googlesource.com/1108356 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573489}
-
Darren Shen authored
Follow up on r1124735. TBR=blakeo@chromium.org Bug: 845780 Change-Id: If2e40e0884fe46f5cf874f5eb5d1aeb4e479c722 Reviewed-on: https://chromium-review.googlesource.com/1130199Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#573488}
-
Reilly Grant authored
This GAIA method is unused. Removing the infrastructure for handling the result of calling it. Bug: 844982 Change-Id: I85598a2535346046e2f34a0f0126eca8a7acc70a Reviewed-on: https://chromium-review.googlesource.com/1111115Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573487}
-
Florin Malita authored
[1] added a couple of asserts, assuming the outer/inner radii are always following border invariants. But the same code path is also triggered for outline painting, which overrides some border properties to force rectangular outlines. Also, GraphicsContext is not a good place to make outer/inner geometry assumptions. Remove the asserts and replace with explicit width/height checks. [1] https://chromium.googlesource.com/chromium/src/+/e2eef42958b177eaf8cbbdae667c481d0789421c Bug: 861529 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7deb45c42f2fef8dec2caf4cc90c0b52ee1b5f51 Reviewed-on: https://chromium-review.googlesource.com/1129328Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#573486}
-
Tarun Bansal authored
The mojom call is send only when resource loading hints feature is enabled and the connection is slow. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib57d656406db6f63200ffbf5dbbe83c356d464ca Bug: 854666 Reviewed-on: https://chromium-review.googlesource.com/1112925 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#573485}
-
Nico Weber authored
Mac doesn't have touch UI, and the test doesn't really make too much sense on cast, but the code under test is built there and the test is small and fast, so might as well run it. Maybe one day the test should move to chromium_gtests_for_devices_with_graphical_output instead. Bug: 843511 Change-Id: I1792ee0d57a9f039dba71bb6b28d33e272ab5236 Reviewed-on: https://chromium-review.googlesource.com/1129580Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573484}
-
Takuto Ikuta authored
This can reduce build steps in incremental build. Bug: 810298 Change-Id: I8ef6c3aa908f5d6e2e8c57edf8d29ed80a0d1993 Reviewed-on: https://chromium-review.googlesource.com/1126892Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#573483}
-
Quan Nguyen authored
Also shifts the user menu right in this case so that the dropdown arrow remains visible. Bug: 861791 Change-Id: I65b0be969c1f15936ce3b86df5bae4eb7c200ed6 Reviewed-on: https://chromium-review.googlesource.com/1129847Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#573482}
-
Ian Clelland authored
This adds a couple of tests which were missing previously for features which are defined in code, but not available for use in feature policy, being used to construct policies. Change-Id: Ib3c860d3a0613606b5672c682559fec608696d12 Reviewed-on: https://chromium-review.googlesource.com/1126327Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#573481}
-
Alex Newcomer authored
This reverts commit f69edefd. Reason for revert: Bug is fixed by adding VIEWS_EXPORT to MenuSeparator. https://chromium-review.googlesource.com/c/chromium/src/+/1129999 Original change's description: > Revert "cros: Add a double separator above context menu notifications" > > This reverts commit 1c822163. > > Reason for revert: > > Linker failures: > obj/ash/app_menu/app_menu/notification_menu_view.o:notification_menu_view.cc:function ash::NotificationMenuView::NotificationMenuView(ash::NotificationItemView::Delegate*, message_center::SlideOutController::Delegate*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&): error: undefined reference to 'vtable for views::MenuSeparator' > ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function > > Bug: 861885 > > Original change's description: > > cros: Add a double separator above context menu notifications > > > > Add and remove a double separator with NOTIFICATION_CONTAINER. > > > > Bug: 843761 > > Change-Id: I45fb095079aaaf108a9a18958ab4e431072e588d > > Reviewed-on: https://chromium-review.googlesource.com/1121243 > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Reviewed-by: James Cook <jamescook@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#573418} > > TBR=jamescook@chromium.org,msw@chromium.org,newcomer@chromium.org > > Change-Id: I10ce18a75e80116fa8d7a530d18e979a2dfbb395 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 843761 > Reviewed-on: https://chromium-review.googlesource.com/1129661 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573429} TBR=jamescook@chromium.org,msw@chromium.org,newcomer@chromium.org Change-Id: I70f5742583a5531d43ea5ff5b6c2815e691506da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861885, 843761 Reviewed-on: https://chromium-review.googlesource.com/1130140Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#573480}
-
Khushal authored
Include memory dump from GrContext used for OOP raster in the GPU process in traces. R=bsalomon@chromium.org, ericrk@chromium.org, sadrul@chromium.org TBR=bsalomon@google.com Bug: 859419 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie010e1c567626343d5698b02c45776d215640da0 Reviewed-on: https://chromium-review.googlesource.com/1123894 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573479}
-
Aaron Leventhal authored
We must expose radiogroup/group names as a description, instead of as a title, so that VoiceOver speaks them. Bug: 861552 Change-Id: I743edfcfef8f5362984c69097cff8720e4228c07 Reviewed-on: https://chromium-review.googlesource.com/1129331 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#573478}
-
Alex Newcomer authored
MenuSeparator is being reused in Ash, but to do this VIEWS_EXPORT needs to be added to views::MenuSeparator. Else we have linker failures: std::__1::allocator<char> > const&): error: undefined reference to 'vtable for views::MenuSeparator' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function Bug: 861885 Change-Id: I787fe6bf1d62518d03e52007b792481251ae4174 Reviewed-on: https://chromium-review.googlesource.com/1129999Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#573477}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8b9db90d117d0877c70e1b30b6af1e56cea46535 Reviewed-on: https://chromium-review.googlesource.com/1124925 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573476}
-
Xiaohui Chen authored
Bug: b:79879196 Change-Id: Ia118af06bf2efba9ae850795109a555434a76f84 Reviewed-on: https://chromium-review.googlesource.com/1130108Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#573475}
-
Yaron Friedman authored
Internal change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/649731 Change-Id: Ia98d8714494e05837274a7d69863647107ba2f87 Reviewed-on: https://chromium-review.googlesource.com/1129394Reviewed-by:
Ran Ji <ranj@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573474}
-
Kent Tamura authored
computed_style.h is used in 1,300+ compilation units, and this CL reduces its pre-processed size by 1.09MB. * Avoid including image_resource_content.h image_resource_content.h is large due to dependency to mojom files. Stop inlining ShapeValue::IsImageValid(). * Avoid including style_svg_resource.h style_svg_resource.h and svg_resource.h are large due to dependency to mojom files. - Stop inlining many functions using StyleSVGResource and SVGResource. - Move ReferenceClipPathOperation and ShapeClipPathOperation to their own files. - Fix make_css_property_subclasses.py for generated core/css/properties/longhands/marker_*.h, which depend on StyleSVGResource. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I907a7772283b282a410fb47f457c447d5417f650 Reviewed-on: https://chromium-review.googlesource.com/1128794 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#573473}
-
Nico Weber authored
Mac doesn't have touch UI, and the test doesn't really make too much sense on cast, but the code under test is built there and the test is small and fast, so might as well run it. Maybe one day the test should move to chromium_gtests_for_devices_with_graphical_output instead. Bug: 843511 Change-Id: I792e8ed5bb419346b23a3e7432a7681e797b244d Reviewed-on: https://chromium-review.googlesource.com/1129719Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573472}
-
David Black authored
Change made in response to spec clarification by UX. Bug: b:78138093 Change-Id: Ie4b642d593f51051ea3f116f73954283e8475345 Reviewed-on: https://chromium-review.googlesource.com/1129553 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#573471}
-
chrome://reset-passwordJialiu Lin authored
Minor css style changes to make its style closer to other interstitials. Bug: 848023 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie575267fd6b424dd302fb3caf6db23669a778e92 Reviewed-on: https://chromium-review.googlesource.com/1129635Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573470}
-
jdoerrie authored
This change fixes runtime errors introduced by the recent Autofill Home change. Bug: 861732 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia445d198ea4f4945b213df3e0f4d76509032c895 Reviewed-on: https://chromium-review.googlesource.com/1122616Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573469}
-
Ryan Daum authored
If the magnification gesture is enabled, the AccessibilityManager will listen for triple-tap events and turn on (or off) the PartialMagnificationController. Bug: internal b/110532350 Bug: internal b/110481596 Test: manual Change-Id: I3e1ed53fddb1c525c0cc3b238e243f59b737323d Reviewed-on: https://chromium-review.googlesource.com/1125038 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#573468}
-
Robbie McElrath authored
This is a copy of https://crrev.com/c/1067424 but with tests fixed. Bug: 844932 Change-Id: I77239bf76a673b33d56b8b7fe584a78ec319bc24 Reviewed-on: https://chromium-review.googlesource.com/1114253 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#573467}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6618d3f745e..21acb2a82232 git log f6618d3f745e..21acb2a82232 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 mheikal@google.com Throw exception instead of dying in get_device_sdk_version Created with: gclient setdep -r src/third_party/catapult@21acb2a82232 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2c995ae2a28dd2ca5b25582fe9d8d3ad0435ea8b Reviewed-on: https://chromium-review.googlesource.com/1129881Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573466}
-
Jun Cai authored
This CL adds a VariationsHeaderURLLoaderThrottle on renderer to fix the VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromSubresourceRequest. Bug: 841309 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6120ca42d7aeee9fe721a5af7c93c4047416225b Reviewed-on: https://chromium-review.googlesource.com/1103451Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#573465}
-
Fady Samuel authored
Bug: 854256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I83ff040664e008108e8265a6b21069e270dac981 Reviewed-on: https://chromium-review.googlesource.com/1128209Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573464}
-
Chris Mumford authored
Delete the explicit DownloadSaveInfo move constructor in favor of using the default move constructor. This simplifies the code and makes it less likely that a future additional member will be overlooked. Also initializing members in the declaration. This Simplifies documentation and allows the default constructor to be used. Bug: none Change-Id: I6a5ccb895d074f13e7a5aaae6cabbec4d1e7809a Reviewed-on: https://chromium-review.googlesource.com/1129214Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#573463}
-