- 12 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5cf390386bdd..da1c65fb53c3 git log 5cf390386bdd..da1c65fb53c3 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 titovartem@webrtc.org Change reporting of time_between_freezes. Created with: gclient setdep -r src/third_party/webrtc@da1c65fb53c3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iad17c389bf5c9237b6e754397232795ea8e59cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668397}
-
Peter Wen authored
Lifecycle is a self-contained package for managing Android application and activity lifecycles: https://developer.android.com/guide/components/activities/activity-lifecycle This CL moves the java target from //chrome/android/public to //chrome/lib as it is not specific to //chrome/android and can be reused by other //chrome layer features. Bug: 846440, 966644 Change-Id: I5b3a516b0818b39044ee757695203e915512acf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630740Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#668396}
-
Chromium WPT Sync authored
Using wpt-import in Chromium db82c1cf. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: atotic@chromium.org: external/wpt/css/CSS2/abspos chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I229152a38214541c11e387a718a4ec67e05df260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655027Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668395}
-
Raphael Kubo da Costa authored
Since commit b1b678fa ("Allow providing README for license.py in 3p subdirectories"), when licenses.py finds a directory with a file called additional_readme_paths.json it parses the file and scans the directories listed there. However, it then excludes the very directory containing that file from the scanning process, which can lead to missing licenses since it can also contain a README.chromium. This can be verified via third_party/angle, which has both files and whose main license was not part of chrome://credits. Bug: 39240, 794210 Change-Id: I5335446b1b086cb1618a3b879c8d3f12cef7c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645361Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#668394}
-
Anders Hartvoll Ruud authored
Unfortunately the logical properties also need -internal-visited- counterparts. Initially you'd think we could first resolve the logical property into a physical property, and then handle its associated -internal-visited property, but that's impractical, since we can't resolve a logical property to a physical property until the computed values of text-direction and writing-mode are known. Bug: 972388 Change-Id: Iff4a385ecfd2af4d491b69d51ebf8efcfc4656a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653017 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668393}
-
David Bokan authored
Change-Id: Ia8150df51426928949742cb9bea234c6a5bf2f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655690Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#668392}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I79a8f6dafb9b0da82fee0538029263bfe062d597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654936Reviewed-by:
-
Alan Cutter authored
This CL removes expired flags in flag-metadata.json that have no corresponding flag in the codebase: - enable-autofill-save-credit-card-uses-strike-system - enable-autofill-save-credit-card-uses-strike-system-v2 - enable-cros-ime-service - enable-message-center-new-style-notification - enable-sync-pseudo-uss-app-list - enable-sync-pseudo-uss-apps - enable-sync-pseudo-uss-dictionary - enable-sync-pseudo-uss-extension-settings - enable-sync-pseudo-uss-extensions - enable-sync-pseudo-uss-favicons - enable-sync-pseudo-uss-history-delete-directives - enable-sync-pseudo-uss-preferences - enable-sync-pseudo-uss-priority-preferences - enable-sync-pseudo-uss-search-engines - enable-sync-pseudo-uss-supervised-users - enable-sync-pseudo-uss-themes - safe-browsing-telemetry-for-apk-downloads - sync-USS-autofill-profile - sync-USS-autofill-wallet-data - user-activity-prediction-ml-service Bug: 897809 Change-Id: I56ccaa2c5da5186c2f9ec385438203593a4cfc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654742 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#668390}
-
Yusuf Sengul authored
Access token being passed to GCPW from chrome login UI is login scoped. As part of chrome login UI, a down scoped access token is also generated. A similar scoped token is also needed in chrome/credential_provider code. R=rogerta, tienmai Bug: 971498 Change-Id: I8696947cc7d0b46d96f786af63b4c8a597328a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646496 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#668389}
-
Kevin Bailey authored
Currently, in and below CopyOldMatches, we copy all the working matches into 2 by-provider maps, and copy out the missed ones into the final working matches. This CL changes it to move the soon-to-be-destroyed matches (the old ones) into the map, and moves any matches which need to be copied out (old ones not in new set). Change-Id: Ibf58aa018dfb6f6f79620b43860034edff254d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593732 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#668388}
-
Mohamed Amir Yosef authored
We have suspecion that there are orphan metadata in the Password sync database due to some bug. This CL is relaxing the constaints for the detecting failures when the deletions fails. After monitor UMA, we may decide to revert this change. Bug: 973053 Change-Id: Id4f57921418978d9c6805e115d868c31b3d2200b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655511 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#668387}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=melandory@chromium.org Change-Id: I2cfad90e97f4cbfb11c34c1d0d3c596224c87204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649754 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#668386}
-
Alexandre Courbot authored
Having to keep a reference to the V4L2 buffer until the decode surface is released is a constraint of the config store, where V4L2 buffer IDs are used to reference frames: reusing a V4L2 buffer ID before all references to it have dropped would result in using a different picture as reference, even if the buffer that has been used for decoding remains unchanged. The request API does not have this limitation and this is thus just a sad workaround. Make it easier to remove by moving its tracking into the decode surface release callback. This is also a required step to remove the output buffer map, which comes in the next CL. BUG=941330 TEST=VDAtest passes on Minnie. Change-Id: I79f035e02e5b31144bace1cf0499727a371a45a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647308 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#668385}
-
Noel Gordon authored
Test QuickView Metadata Box correctly displays EXIF metadata. Add TODO re: RAW file support. Update the exif display parser to format results as PiexWasm does. Verify the displayed results in test. Disable this test on the MSAN bots per issue 973397. TBR: tangltom Bug: 965370, 973397 Change-Id: Idc608e32af541667734bf8a084db389558155afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655708Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#668384}
-
Gauthier Ambard authored
In iOS 13, -traitCollectionDidChange is no longer called when the view is added to the view hierarchy. In previous version this was called and some code was written with that assumption in mind. This CL fixes the calls where needed. Bug: 973033 Change-Id: I563e20b00eac14714895f4d6c3674764f3a3039c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655448Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#668383}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/223fb5b54148..337c6daadba3 Created with: gclient setdep -r src-internal@337c6daadba3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=haraken@google.com,tangltom@google.com,flackr@google.com Change-Id: I7b537f962a537db21ae9c37038b919ae9b903c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654935Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668382}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a9952cb0c408..5cf390386bdd git log a9952cb0c408..5cf390386bdd --date=short --no-merges --format='%ad %ae %s' 2019-06-12 eladalon@webrtc.org Allow Vp8FrameBufferController::UpdateConfiguration to reset set of overrides Created with: gclient setdep -r src/third_party/webrtc@5cf390386bdd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I46c36145bbb0aa86592f6e47a0798fb2a45d3b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654934Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3a8b9da1..602da62c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d2b53df75df58c448603b13f2caad3b7824cd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655091Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668380}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. The virtual functions of this class has been refactored as part of another cl. Bug: 959157 Change-Id: I43a7ee156a5d965155e6ce39e33612bf45fcfa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649506Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#668379}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. The virtual functions of this class has been refactored as part of another cl. Bug: 959157 Change-Id: I9a0bc98d5e454f4ef2a58d5fc1b0058d2cc6bb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649360Reviewed-by:
-
Mark Cogan authored
Simple fix for the bug, which is caused by accessing the active web state after the web state list has been torn down. Bug: 968475 Change-Id: Ib450a5ac7123d23dbb03dbdd0130a9a798fb153d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649586 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#668377}
-
Benoît Lizé authored
/proc/PID is not accessible on all Android devices. Instead of implicitly allowing the calling app to call the CCT APIs in this case, make the check explicit, but keep allowing the calling app to issue requests. As a consequence, this is not a behavior change, but makes the current (intended but surprising) one clearer. Ideally we would like to have a solution for the case where we cannot read /proc/PID/ as well, but this is unlikely, see the linked bugs for details and rationale. Bug: 973368 Change-Id: Ic11f333f32c43c75f7036d14dd60065d73161da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655509Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#668376}
-
Lukasz Anforowicz authored
This CL adds ScopedAllowRendererCrashes to browser tests that (expectedly or unexpectedly) might trigger a renderer crash. Right now a browser test might pass, even if a renderer process crashed during the test execution. After https://crrev.com/c/1650463 a renderer crash will trigger an explicit test failure, but before this enforcement can start, existing tests that experience renderer crashes (expectedly or unexpectedly) need to declare this via ScopedAllowRendererCrashes. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 972220 Change-Id: If84da1b4225f56640dda2c155aaa1d86f42325ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653419 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#668375}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. It changes the functions of OAuth2TokenServiceDelegate class and its virtual function overrides. The GetAccounts() function is pretty involved and will be refactored in a different stand-alone cl. Bug: 959157 Change-Id: I88128dd162c221bad9018e3877dbd927b75b202b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648016Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#668374}
-
Anastasiia Nikolaienko authored
Renamed ToastManager from ash/system/toast to ToastManagerImpl. Added ToastManager class to ash/public/cpp to access the implementation from chrome/. Bug: 934053 Change-Id: I913dfd7e426f958d15e4e22ffcae724f8ebb668b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647706 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#668373}
-
Erik Chen authored
The argument is now unused. This CL should not have a behavior change. Bug: 965663 Change-Id: Ibc69066c8a8883fa7e1c28ba5f3b76a395e60ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652718 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#668372}
-
Mario Sanchez Prada authored
This struct is no longer used outside of Blink, so we can remove it from the public API and use both the mojom::PushErrorType and blink::PushError definitions instead, and have PushError::Take() return a DOMException* that we can pass directly to the OnError callbacks, when receiving error replies from the mojom::PushMessaging service implemented in //content/browser. We can also remove public/platform/modules/push_messaging now, since there are no files left in there anymore. Bug: 939943 Change-Id: I7719271171d8fbdd5dd4cc69a549bf4bddf5bb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645310 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Rohit Rao authored
Switches to using ASSERT_TRUE() when verifying that a base::Optional() has a value. This prevents us from trying to read the value if it is unexpectedly missing. BUG=972715 Change-Id: I15d81dfd665658c16d7e5254b9db3f406510c738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646589Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#668370}
-
Mario Sanchez Prada authored
This struct is no longer used outside of Blink, so we can remove it from the public API and merge it along with blink::PushSubscriptionOptions, which represents the same kind of information, but from a point of view that is closer to the DOM and V8 than the struct being removed. As it happened when cleaning up WebPushSubscription, to do this we also needed to adjust a few places inside the PushMessaging module. Additionally, we can also remove public/common/push_messaging entirely, since there are no more files left in there now. Bug: 939943 Change-Id: I643126db8f9391116464f45d79d761bc0ce4caac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645781 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#668369}
-
Thomas Tangl authored
This reverts commit f355a5e5. Reason for revert: browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests (See crbug.com/973397.) Original change's description: > [quickview] Add a test for JPEG image containing EXIF > > Test QuickView Metadata Box correctly displays EXIF metadata. Add TODO > re: RAW file support. Update the exif display parser to format results > as PiexWasm does. Verify the displayed results in test. > > Bug: 965370 > Change-Id: I9b0d457c8eb80f5cf9b3a1f64ce9a9d5b56ccb12 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654729 > Reviewed-by: François Degros <fdegros@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668285} TBR=noel@chromium.org,adanilo@chromium.org,fdegros@chromium.org Change-Id: Icd12dd54cd39ea8ed12bd5a4ee32a6e9d9a8a0b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965370, 973397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655435Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#668368}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/2f42850790c1..dcfa9d06a134 git log 2f42850790c1..dcfa9d06a134 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 google-shaderc-autoroll@skia.org Roll third_party/spirv-cross fccf1d046204..00a8539d1ddf (1 commits) (#691) 2019-06-12 google-shaderc-autoroll@skia.org Roll third_party/spirv-cross 5e9e8918f9a2..fccf1d046204 (1 commits) (#690) 2019-06-12 google-shaderc-autoroll@skia.org Roll third_party/spirv-headers 9242862c84fe..9cf7c3a7d2d2 (1 commits) (#689) Created with: gclient setdep -r src/third_party/shaderc/src@dcfa9d06a134 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Ib64aaf83ec0c6fbd9d8c9cb8994b91fee7417d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655372Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b3a36145a7f..223fb5b54148 Created with: gclient setdep -r src-internal@223fb5b54148 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=haraken@google.com,tangltom@google.com,flackr@google.com Change-Id: I64de7e696840ffdde8c468c8affd547870fc27b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655371Reviewed-by:
-
Marc Treib authored
The BridgeBuilder (more specifically, the bridge it owns) must be destroyed before its dependencies, and on the model thread. It's owned by the SyncableServiceProvider, a RepeatingCallback that only gets invoked on the model thread, but may be destroyed on either the model or the UI thread. Before this CL, a base::OnTaskRunnerDeleter made sure that the BridgeBuilder destruction happened on the model thread. However, if the callback destruction was already triggered from the model thread, then base::OnTaskRunnerDeleter unnecessarily posted a task to the model thread, and thus delayed the destruction of the BridgeBuilder. This could cause it to outlive its dependencies. This CL replaces the base::OnTaskRunnerDeleter with a custom version that executes the deletion immediately if it's already on the correct (model) thread. Bug: 970354 Change-Id: I8ed86668a0ca12fc4c1f4f43a62728da9de0739b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655431Reviewed-by:
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/html/track directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: I480cbec30eb50355c89817622bcd196c4a813359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654751Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#668364}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6b060a64417..1750292dc4b6 git log f6b060a64417..1750292dc4b6 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 khokhlov@google.com Override traceUrl from telemetry by the one from command arg 2019-06-12 perezju@chromium.org [Telemetry] Remove value.FromDict() method Created with: gclient setdep -r src/third_party/catapult@1750292dc4b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:969681,chromium:921616 TBR=simonhatch@google.com Change-Id: I2a68a719a426156497039e62986da0c89de31b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655370Reviewed-by:
-
Mario Sanchez Prada authored
This struct is no longer used outside of Blink, so we can remove it from the public API and merge it along with blink::PushSubscription, which represents the same kind of information, but from a point of view that is closer to the DOM and V8 than the struct being removed. To do this, though, we needed to adjust a few places in different points of the PushMessaging module (e.g. PushSubscription constructor, callback definitions...), but this will also help removing other WebPush* types in follow-up CLs, so it should pay off in the end. Bug: 939943 Change-Id: Ibdf7eff146dc4a0be92dd7bc246841ea7bec5a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645780 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Jan Krcal authored
This CL removes an argument that is not needed any more (after https://chromium-review.googlesource.com/c/chromium/src/+/1642551). Bug: 836718 Change-Id: I78298efe202881f88258e28cab60fa93a857fed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645302Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#668361}
-
Hirokazu Honda authored
V4L2WritableBufferRef::QueueDMABuf() checks the number of given fds is the same as the number of required fds. Because of this check, a caller has to duplicate their fds in order to extract the expected number of fds. This CL weakens the check. The function only checks the number of given fds is not less than the number of required fds, that is, the number of planes of the buffer. A caller then can pass their fds without duplicating them. Bug: 941330 Test: video_decode_accelerator tests --use_vd on kevin Change-Id: Ia32c63c6b6e022ce3cdfc6dfd9d81ccdd813ddc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654682 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#668360}
-
Jordan Demeulenaere authored
This CL fixes the shadow of the last action and spacing of the actions carousel (broken in http://crrev/c/1650205). * Before: https://screenshot.googleplex.com/SrtEssVsymX.png * After: https://screenshot.googleplex.com/b4PRgyOugaW.png Screenshots: Change-Id: Ie88139910874486d72202601b04948377b1173bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655488Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#668359}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/9242862c84fe..9cf7c3a7d2d2 git log 9242862c84fe..9cf7c3a7d2d2 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 johnkslang@users.noreply.github.com Merge pull request #117 from ehsannas/UserTypeGOOGLE Created with: gclient setdep -r src/third_party/spirv-headers/src@9cf7c3a7d2d2 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Ia67e477a7b3395ff65e26ec22a21d062710065ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655073Reviewed-by:
-
