GitLab

Previously, it would do this only for non-official builds. Now,
we check both.

Bug: 880853
Change-Id: I0f37a32ede20cdcb7379a748341203eab7028cf1
Reviewed-on: https://chromium-review.googlesource.com/1207211Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588961}

See discussion here:
https://groups.google.com/a/chromium.org/forum/#!topic/java/10-nLjh4Rtg

BUG=

Change-Id: Ib2007de8f88edfb08f808eb5f01005cbe975e12b
Reviewed-on: https://chromium-review.googlesource.com/1207653Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588960}

Fixes percentage sized floats which were previously not using the
correct percentage resolution size.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie57909b7f452f5d59b8dfe2f899bedf253ab90ac
Reviewed-on: https://chromium-review.googlesource.com/1205200
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588959}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/797fd93eccde..8a49a283b96c


git log 797fd93eccde..8a49a283b96c --date=short --no-merges --format='%ad %ae %s'
2018-09-05 bmgordon@chromium.org chromeos_config: Make grunt-pi-pfq builder non-experimental


Created with:
  gclient setdep -r src/third_party/chromite@8a49a283b96c

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I1adc4164209d2148e03f4955c94a1e5c5a1a1bf9
Reviewed-on: https://chromium-review.googlesource.com/1207159Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588958}

|force_clamshell_power_button_| is not needed after this cl
https://chromium-review.googlesource.com/c/chromium/src/+/1053565

Bug: None
Change-Id: Ie54f4bef235ab5f537849c70be40582a1c9f647c
Reviewed-on: https://chromium-review.googlesource.com/1207893Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588957}

This adds a document URL HTTP/HTTPS check in the renderer
(anchor_element_metrics) for OnClick. This check already happens in
OnLoad and on the browser side, and due to the browser side check being
a fast fail, this causes a crash if the user is on a data:// page with
an https:// anchor element.

Bug: 879999
Change-Id: Iec3de21649d8f4f2d81a4c9c9e23cfe02fbbc9d7
Reviewed-on: https://chromium-review.googlesource.com/1204830Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588956}

AVDASurfaceBundle sends redundant position updates to the AndroidOverlay
which results in an unnecessary re-layout of the chrome window for every
frame. This change fixes it in the AVDASurfaceBundle to avoid redundant
IPCs to the browser processes. And also in DialogOverlayCore to avoid
any client-side errors from regressing this in the future.

R=liberato@chromium.org

BUG: 880691
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I17d9264c6d117ed5fc4d1012321cbd66c5cf60d4
Reviewed-on: https://chromium-review.googlesource.com/1205599
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588955}

This is a fix for bug 880249.

Bug: 880249
Change-Id: I176f925cbddfff9b2fdd6127216bbdcce85cb4c4
Reviewed-on: https://chromium-review.googlesource.com/1207093
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588954}

Currently when a user grants access to the current page using the extension
action context menu, we run the blocked actions. But the extension may have
blocked actions which can't be run at this stage. Prompt the user to refresh the
page in this case, and grant permissions once the user accepts the refresh
bubble.

BUG=876791

Change-Id: I2516fe40050110ee2844670489796b421ad4fdb9
Reviewed-on: https://chromium-review.googlesource.com/1196225
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588953}

This is a reland of 0ea3570a

Original change's description:
> Add a sampling profiler to chrome tracing.
> 
> This CL is plumbing the base::StackProfiling to allow collecting
> stack sample at a low rate on the browser process.
> An event is triggered to the trace with the collected stackframe.
> 
> The goal of this code is to get low-rate stack samples in the field
> for the slow-report to help the investigation of stalled tasks.
> 
> 
> This is a variant of:
>   https://chromium-review.googlesource.com/c/chromium/src/+/1188502
> 
> R=ssid@chromium.org, oysteine@chromium.org
> 
> Change-Id: I150c17df51914f4535d4e7d6ec086a2e13c17cff
> Reviewed-on: https://chromium-review.googlesource.com/1191745
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588554}

Change-Id: If50c39644d0563d169281169e57839e2d223754d
Reviewed-on: https://chromium-review.googlesource.com/1205573Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588952}

A previous change misplaced the code to remove all information in addresses. It
is now moved to after GetDetectedValues is computed.

Bug: 878416
Change-Id: I15fd8d8c97d2a051aab9313be98fff5a840fcbd9
Reviewed-on: https://chromium-review.googlesource.com/1207193Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588951}

uses Math.floor() to round bits per second as fractions of a bit are not
very meaningful

Bug: 678292
Change-Id: I8b8f5cb9b4a88729d64fb37d8d05145b8330d421
Reviewed-on: https://chromium-review.googlesource.com/1207950
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588950}

Bug: 806987
Change-Id: I73c8428395fc6905636587d5143a79bfff97c65c
Reviewed-on: https://chromium-review.googlesource.com/1135752Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588949}

Things like the isConnected() flag was not updated for these elements
when removed.

Bug: 868810
Change-Id: I53aecf996c3d45253ab9929aa94cf29fd0c4ff6f
Reviewed-on: https://chromium-review.googlesource.com/1202063Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588948}

The availability caching will now be checked when a new sink query is
added. Before that, it is only checked during Refresh() (user gesture)
and when sink is added. This prevents a request from being re-sent if
a query was removed and re-added while the sink is still on the list.
In addition, the cache rule now applies when a sink is added or
updated. This means a request will be re-sent (subject to timing
threshold) if its cached availability is kUnavailable.

Note the rule to always use cache if the availability value is
kAvailable hasn't changed. An app is considered to be available until
it is offline, at which point the cache value will be invalidated.

Bug: 809249
Change-Id: Iadcee4953b51464211c3ee91777683a640f1291a
Reviewed-on: https://chromium-review.googlesource.com/1173477
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588947}

This CL implements the functionality to extract one encoded video key
frame in utility process with ffmpeg for video thumbnail retrieval.

The decoding will be done in later CLs with MojoVideoDecoder.

TBR=dtrainor@chromium.org

Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia36ffe5ab4bb6fc32e55f1de089f07046e72a1bd
Reviewed-on: https://chromium-review.googlesource.com/1145780
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588946}

Record MediaRouter.Icon.Click.Location whenever the Cast trusted area
icon is clicked.

When a media route is created, call the callback to record
MediaRouter.Source.CastingSource before calling other callbacks, so that
the MediaRouterUIBase doesn't get destroyed before we get to record.

Bug: 880624
Change-Id: Ic242cb7621886035f07f8edd96ca55b0d7b7a0a8
Reviewed-on: https://chromium-review.googlesource.com/1205992
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588945}

Nokia devices crash when trying to set to set the status bar color in
bookmarks, history, and downloads. Disable status bar theming for now.

BUG=880694

Change-Id: I48ae7ec0d7aa5059d70eb5a99b23e84d8263dcd0
Reviewed-on: https://chromium-review.googlesource.com/1207310Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588944}

https://webrtc.googlesource.com/src.git/+log/e10f3b7403d0..62228c41ea17


git log e10f3b7403d0..62228c41ea17 --date=short --no-merges --format='%ad %ae %s'
2018-09-05 magjed@webrtc.org Reland "Add tool for aliging video files"
2018-09-05 jonasolsson@webrtc.org Demote RTC_NOTREACHED in pseudotcp RTT processing to warning.
2018-09-05 henrika@webrtc.org Adds stream-switch support in new Windows ADM.


Created with:
  gclient setdep -r src/third_party/webrtc@62228c41ea17

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:877790
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I46401530f62b12518d55b6968d3cdab6e3b10d23
Reviewed-on: https://chromium-review.googlesource.com/1207152Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588943}

This CL implements correct initial values for all SVGAnimatedAngle properties
(which is only one: 'orient' on <marker>.)

Bug: 225807, 589856
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I61c50162a98a47d0da23f3a7d0830440b8c7aa25
Reviewed-on: https://chromium-review.googlesource.com/1207331Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588942}

Layout test diffs are low-bit changes due to floating point
order-of-operations in the new code.

Change-Id: Ie50c9913d2b29f0ddc5c99e6c0b35ad54ff0ef3f
Reviewed-on: https://chromium-review.googlesource.com/1203932Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#588941}

This is used by the XMPPClient in jingle/

This was done as follows:
1) Split out TLS socket creation from SocketFactory into TLSSocketFactory,
   make SocketFactory own one instead; move some of the upgrade code from
   TCPConnectedSocket into TLSSocketFactory as well.
2) Permit injection of a custom net::HttpNetworkSession::Context into
   TLSSocketFactory
3) Make ProxyResolvingSocketFactoryMojo have a TLSSocketFactory hooked up
   to its HttpNetworkSession.
4) Add an UpgradeToTLS method to proxy_resolving_socket.mojom and implement
   it in ProxyResolvingSocketMojo using TLSSocketFactory

Most of the pre-existing TLSClientSocket tests covering upgrades were then
reworked to test the new ProxyResolvingSocket path along with the pre-existing
TCPConnectedSocket path.

Bug: 875032
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I75d8bb2cd7245e459d46bc70a61dac782c7e355d
Reviewed-on: https://chromium-review.googlesource.com/1191102Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588940}

Fold Page::NonFastScrollableRectsForTesting into the only user
Internals::nonFastScrollableRects. The former method does not even touch
the Page object.

Change-Id: I3d8bec815dbcbb45cb01e2a77a1d87885d7d94f9
Reviewed-on: https://chromium-review.googlesource.com/1206590Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588939}

This causes Assistant UI to be hidden but history to be retained for
5 min. Note that starting a metalayer session does not cause widget
deactivation.

Bug: b:114042400
Change-Id: Ie343095a5bbc661e091a21624d0fa6e9af0a0e6e
Reviewed-on: https://chromium-review.googlesource.com/1207730Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#588938}

In https://crrev.com/c/1186115, the patch was rebased incorrectly and
a SettingsSection test was moved down below the Policy tests. Move the
test to the correct location.

Bug: None
Change-Id: I6102d9688eef5476e0239a8e824968f1b399aaea
Reviewed-on: https://chromium-review.googlesource.com/1207312Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588937}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/74fda7147c1b..e6438547360b


git log 74fda7147c1b..e6438547360b --date=short --no-merges --format='%ad %ae %s'
2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@e6438547360b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I455cd7eefee1e44a0420ff0dc9d54bdb22ca65ea
Reviewed-on: https://chromium-review.googlesource.com/1207154Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588936}

The hit test mask code wasn't really wired up for the mask, and it turns out
aura's window targetting code doesn't actually use the mask. So, this makes the
code use the hit test insets, which *is* honored by window targetting and
updates the one usage in Chrome.

BUG=878836,814675
TEST=covered by tests

Change-Id: I02e26b62f2847960a0c4d16eee44d653c6e45539
Reviewed-on: https://chromium-review.googlesource.com/1206172Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588935}

In the current Linux ShowPrinterManagerDialog() implementation, if the
desktop environment is "OTHER" then an error log entry gets generated
and nothing else happens. To improve this, just treat it like GNOME and
try some commands that may launch the printer management UI.

BUG=869845

Change-Id: I92da6fd3edcc9ca51b9f2b494b9762d5935ba9cf
Reviewed-on: https://chromium-review.googlesource.com/1159475Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588934}

When caption bar shows back button, it should be equivalent to clicking
the back button.

Bug: b:113048612
Test: locally build and test
Change-Id: I7b388d784e24d43ffcf863103d7746998e573a4a
Reviewed-on: https://chromium-review.googlesource.com/1205673Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588933}

Found when debugging nested remove() issue for CSS update roots.
Resolves TODO.

TEST=media/
TEST=external/wpt/media*

Bug: 868810
Change-Id: If2d13a9167ed331b562f55ca7e5a5802e7751362
Reviewed-on: https://chromium-review.googlesource.com/1202142Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588932}

Bug: None
Change-Id: Ifa3a39ba86ba899f9c736c779f20d8924dc302ce
Reviewed-on: https://chromium-review.googlesource.com/1207610Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588931}

This regressed in crrev.com/c/1081370 due to a combination of
1. Over-eager refactoring
2. Phantom tests that didn't actually test the functionality.

The regression is reverted here and the test for the feature is
fixed so it actually triggers the behavior.

Bug: 880829
Change-Id: Ic27a0718de685acea00af0b5d88e249b5fb0a6c2
Reviewed-on: https://chromium-review.googlesource.com/1206674Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588930}

Now we will dismiss launcher when longpress and OKG.

Bug: b:113337956
Test: locally build and run
Change-Id: Icd605d30baa1d494b64f90ed2a2a64569195c8f1
Reviewed-on: https://chromium-review.googlesource.com/1205538
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588929}

When media Stop is called, AudioStreamHandler::OnStopped will delete
both audio_stream_handler_ and device_owner_. However, device_owner_ is
posted to a background thread to be deleted. It is possible that
device_owner_ still using audio_stream_handler_ after
audio_stream_handler_ has been deleted.

Bug: b/113707507
Test: manual.
Change-Id: I20a48a5193b78608e58c3a911af77af7ff8d647e
Reviewed-on: https://chromium-review.googlesource.com/1200572Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588928}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a330ed95..1b573e9f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibb551aff8591eb9481604514a9245a4f8dd7005f
Reviewed-on: https://chromium-review.googlesource.com/1207090Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588927}

Previously, when animating the footer view and/or its children, we
modified visibility so as not to receive focus/accessibility events on
hidden views.

Unfortunately, changing the visibility of the footer view has a side
effect of freeing up space for UiElementContainerView. When this
happens, there is a bit of UI jank when the UiElementContainerView
takes that available space when really that space should permanently be
reserved for the footer. This becomes more obvious in a follow up CL in
which we add a shadow above the footer.

Now, we don't modify view visibility. Instead, we update focus behavior
as appropriate before animations start and after they end.

See bug for repro steps.

Bug: b:113871610
Change-Id: Ic8aa509c722ace44675a3ab7c7e0453c0aa4a352
Reviewed-on: https://chromium-review.googlesource.com/1197906
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588926}

This reverts commit 718282e6.

Reason for revert: Added for debugging purposes and no longer needed.

Original change's description:
> Add aliased variables for GPU failure browser crashes.
> 
> This CL saves some state in local variables and aliases them for
> inclusion in crash minidumps. This information will help diagnose GPU
> process failures with OOP-D and the resulting browser crash when we
> can't launch a GPU process.
> 
> Bug: 849639
> Change-Id: Id5a65c428eff83c80208b53081083d4feaf26063
> Reviewed-on: https://chromium-review.googlesource.com/1138178
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575294}

TBR=backer@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 849639
Change-Id: I09f1e28b6ccad89bde6a38139787a3e218d01d62
Reviewed-on: https://chromium-review.googlesource.com/1206697Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588925}

When the user set a custom passphrase, the unified consent toggle
on the settings page is disabled.

Bug: 873731
Change-Id: I0de9a9f933d5832eced65ac2800453ee2394ae67
Reviewed-on: https://chromium-review.googlesource.com/1206371Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588924}

When the sync section expand button is disabled, the opacity of the
section header is reduced to make it look greyed out.

This means that the sync-section header is greyed out in the following
cases:
 - the user is signed out
 - the user is in a synced-paused state

Screenshots:
https://drive.google.com/file/d/1rDwDIqinKa2gl6QGnf2WoRkF2j28JOpH/view?usp=sharing
https://drive.google.com/file/d/1IFqP5M6pSI2bSwrTNphrQBGy1bO1Hce8/view?usp=sharing

Bug: 854273
Change-Id: I29e04b19f56c7c36a2c8e00f12929327b5612742
Reviewed-on: https://chromium-review.googlesource.com/1205836Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588923}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/safe_browsing/chrome_cleaner.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=csharp@chromium.org

Bug: 874080
Change-Id: I131400a7be516f5ea30857e04528550ea5472fae
Reviewed-on: https://chromium-review.googlesource.com/1191230Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588922}