GitLab

BUG=856720
TBR=skyostil@chromium.org

Change-Id: If7de573f6c64d4f04ff08e1a82793fc3fc021ed7
Reviewed-on: https://chromium-review.googlesource.com/1116786Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570731}

This is a reland of 8f2591ae

Original change's description:
> [ozone/wayland] Manually handle fullscreen states.
> 
> In order to ensure media files can enter fullscreen mode, manually
> handle fullscreen states. Basically, a compositor sends configuration
> events on each request for state changes from clients asynchronously,
> which is unefficient for media files when they enter a fullscreen mode.
> 
> For example, when a youtube video file is being set to fullscreen, a
> WaylandWindow is also set to a fullscreen mode, but the return value from
> the WaylandWindow::GetPlatformWindowState still contains an old value until
> the compositor calls with a configuration event. This short race is
> enough for a media content to be placed in a forever "entering fullscreen"
> state, which never results in a fullscreen state for media files.
> 
> Bug: 843018
> TEST: XdgVersionV5Test/WaylandWindowTest.SetFullscreenAndRestore/0
> XdgVersionV6Test/WaylandWindowTest.SetFullscreenAndRestore/0
> 
> Change-Id: Ib9bc8c0ce09412c36437d165efc6a0cad60c4d17
> Reviewed-on: https://chromium-review.googlesource.com/1107636
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Commit-Queue: Maksim Sisov <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#569172}

Bug: 843018
Change-Id: I63866a785f5dca088aba70e500d85748b86e8a8c
Reviewed-on: https://chromium-review.googlesource.com/1113238
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570730}

Do not save base::Thread reference in the CompositorThreadScheduler and
post tasks to the scheduler default queue instead of using
Thread::task_runner.

R=alexclarke@chromium.org

Change-Id: Idc05e3547316a5aaf6de487ec62e1be430b2499b
Reviewed-on: https://chromium-review.googlesource.com/1115120Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570729}

Load OOBE configuration from file specified in command line.

Bug: 854101

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia25e36f71a3a1d14cffeb6138876aab464d7c477
Reviewed-on: https://chromium-review.googlesource.com/1069274
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570728}

stops tracks acquired from getUserMedia

BUG=836871

Change-Id: I828189da35b0c842078cdd4c1b4b38f7e7fbf355
Reviewed-on: https://chromium-review.googlesource.com/1113450Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570727}

https://chromium.googlesource.com/angle/angle.git/+log/82af620e0559..09303e448d17


git log 82af620e0559..09303e448d17 --date=short --no-merges --format='%ad %ae %s'
2018-06-27 jdarpinian@chromium.org Treat transform feedback generic binding point specially


Created with:
  gclient setdep -r src/third_party/angle@09303e448d17

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:853978
TBR=ynovikov@chromium.org

Change-Id: I56f408668abcca4b6ef3c1a407ae912f8013178d
Reviewed-on: https://chromium-review.googlesource.com/1116558Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570726}

MojoBlob is default and most other code has been already removed.

Bug: 776642
Change-Id: Ibf11da14a3dd46c7f4613d0617e0ee0c3b87b999
Reviewed-on: https://chromium-review.googlesource.com/1114564Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570725}

BUG=856969
TBR=grt@chromium.org
NOTRY=true

Change-Id: I1864afbdfa1a71f4d6acdcba9ca9873659cc5ddb
Reviewed-on: https://chromium-review.googlesource.com/1116779Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570724}

https://chromium.googlesource.com/catapult.git/+log/8b52973effb8..f989b62823cb


git log 8b52973effb8..f989b62823cb --date=short --no-merges --format='%ad %ae %s'
2018-06-27 mikie@google.com tracing: Add binder transaction size to events


Created with:
  gclient setdep -r src/third_party/catapult@f989b62823cb

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I27338b2c1f87c3e8b08d7d7c499b357f5f693a4d
Reviewed-on: https://chromium-review.googlesource.com/1116678Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570723}

BUG=856393
TBR=xiyuan@chromium.org
NOTRY=true

Change-Id: Icd9e1d02102ea6abab544141eb307f1e39342802
Reviewed-on: https://chromium-review.googlesource.com/1116707
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570722}

Currently the NTP steady location bar constraints can be broken because
the location image view is set to nil, making the intrinsic size of the
image view zero. Use a distinct set of constraints in this case.

Bug: 854057
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I67c21c9482e7def487308470e494539a24dfe9f1
Reviewed-on: https://chromium-review.googlesource.com/1115126Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570721}

This reverts commit 398ca322.

Reason for revert: Breaks protected content playback in ARM platform.

Original change's description:
> Ozone DRM: use GBM_BO_USE_HW_VIDEO_DECODER
> 
> This CL adds the GBM_BO_USE_HW_VIDEO_DECODER flag to
> gfx::BufferUsage::SCANOUT_VDA_WRITE buffers. It's a spinoff of a
> comment [1] in crrev.com/c/1021675.
> 
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/1021675/18/ui/ozone/platform/drm/gpu/drm_thread.cc#147
> 
> Bug: 822346
> Test: simplechrome video playback on nautilus, vaapi engaged.
> Change-Id: I795c6c3f74574ffab60c24d1ef746b22d214120a
> Reviewed-on: https://chromium-review.googlesource.com/1104394
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568027}

TBR=mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346
Change-Id: I8b9af48859886f0ef9c203a06079dadd53f0e477
Reviewed-on: https://chromium-review.googlesource.com/1116738Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570720}

At this time, it is treated the same as "detailed".

Bug: chromium:852701
Change-Id: I145c0ac9f93d2152aa5ac4a84a4a7f858c4f3fc3
Reviewed-on: https://chromium-review.googlesource.com/1111957Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570719}

* Some reordering.
* Move view getters to host and make them setters.
* Add IModuleEntryPoint.onDestroy (not called yet)

This is a backwards incompatible change in the
AIDL but that's ok as we have not released yet.

Bug: 843161
Change-Id: I2a705f5b51c9c3ffdf36dec6746578f2dd3e42a0
Reviewed-on: https://chromium-review.googlesource.com/1112008Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570718}

BUG=856955
TBR=grt@chromium.org

Change-Id: I3dc85cc564100b27fc4c3cd2a584952c48dfb981
Reviewed-on: https://chromium-review.googlesource.com/1116550Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570717}

https://webrtc.googlesource.com/src.git/+log/e58bd8a02b9c..b3f5aed4332b


git log e58bd8a02b9c..b3f5aed4332b --date=short --no-merges --format='%ad %ae %s'
2018-06-27 qingsi@google.com Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS.
2018-06-27 qingsi@google.com Use the sparse histogram in RTC_HISTOGRAM_ENUMERATION_SPARSE.
2018-06-26 emircan@webrtc.org Add bit depth information to PlanarYuvBuffer
2018-06-26 steveanton@webrtc.org [Unified Plan] Avoid offering two senders with the same ID
2018-06-26 steveanton@webrtc.org [Unified Plan] Do not initialize recvonly transceivers with any send streams


Created with:
  gclient setdep -r src/third_party/webrtc@b3f5aed4332b

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9f8c16944e0cd335ff5fee17bed1585c40897869
Reviewed-on: https://chromium-review.googlesource.com/1116259Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570716}

EGtests bundle don't have access to application groups.
Create a test hook to prevent app group access.

Bug: 855625
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3c773f92edfdaafb9207d69a51ba6fdee823868b
Reviewed-on: https://chromium-review.googlesource.com/1113540Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570715}

If the provider registered itself but never provided items, the caching
adapter would notify all observers that the last provided actions were
null and force them into an undefined state which caused a crash.

The proper way to handle this case, is to send an empty set to all
observers (see tests for an intuitive use case).

Bug: 855036
Change-Id: If3a0e9ee14ac3e24e163ebba092ab47f226e43b7
Reviewed-on: https://chromium-review.googlesource.com/1115220Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570714}

This CL fixes a regression caused by crrev.com/c/1012979. Previously,
AutofillAgent would scan the whole page on form activities due to the
possiblity of Autofill having been enabled after page load.
crrev.com/c/1012979 replaced that logic in favor of observing the Pref
directly. This has a side effect where previously hidden fields can go
unnoticed by AutofillManager. This CL fixes that regression by scanning the
page when a field is focused. All fields receive focuse before their value
is set by Autofill, therefore, AutofillManager can get notified of
previously hidden fields.

Bug: 855696
Change-Id: I175bf90e12d1ca356b746e6347943a295063c288
Reviewed-on: https://chromium-review.googlesource.com/1112493Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570713}

BUG=762641
TBR=xdai@google.com

Change-Id: I2b3523eed96718ac318f72aaa086b9af6f51fc12
Reviewed-on: https://chromium-review.googlesource.com/1116599Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570712}

Add a mock implementation of RunFileChooser(), with a testRunner
function setFileChooserPaths().

Bug: 637639
Change-Id: Ic5536524b2a5381556605b79e1907429d985e245
Reviewed-on: https://chromium-review.googlesource.com/1114573Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570711}

This is an attempt to deflake the currently disabled
SingleClientDirectorySyncTest.SingleClientDirectorySyncTest. The test
was failing due to running into the 45s timeout in
WaitForExistingTasksOnLoop. The theory is that that's because that
function is based on WaitableEvent, and thus doesn't allow processing of
events on the main thread while waiting. This CL changes it to spin a
nested RunLoop instead.

I could never reproduce the flakes locally, so I don't know if this
helps at all. As such, this CL leaves the test disabled for now; I'll
send a separate one to try re-enabling.

Bug: 850980
Change-Id: I16823fe01574662586e578d5f601299c58004286
Reviewed-on: https://chromium-review.googlesource.com/1116549Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570710}

EventQueue is necessary when queued events might be cancelled. This CL
replaces unnecessary usages of EventQueue wherever possible for code
simplicity.

This CL also adds comments about task sources that should have been
added at https://chromium-review.googlesource.com/c/chromium/src/+/1114672

Bug: 846618
Change-Id: I610e7163c36faea11f9abd9a7c4550acb5b6188c
Reviewed-on: https://chromium-review.googlesource.com/1116516Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570709}

TBR=alemate@chromium.org

Bug: 854101
Change-Id: I4792b0bef59a71d6628da8337043f00ca4b0e5b2
Reviewed-on: https://chromium-review.googlesource.com/1069268Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570708}

https://skia.googlesource.com/skia.git/+log/4ab7198c3a75..37b7e4714558


git log 4ab7198c3a75..37b7e4714558 --date=short --no-merges --format='%ad %ae %s'
2018-06-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0265e1ec1eb7..82af620e0559 (6 commits)


Created with:
  gclient setdep -r src/third_party/skia@37b7e4714558

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: Ice55488c5f690833b8c1745060f136b6a7c0abd9
Reviewed-on: https://chromium-review.googlesource.com/1116559Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570707}

This adds V8.GCFinalizeMC.Evacuate histogram that was not included in
the previous CL by mistake:
https://chromium-review.googlesource.com/c/chromium/src/+/1095156

Bug: chromium:850508
Change-Id: I309e6de32ae64cdd727480b014ad533920709512
Reviewed-on: https://chromium-review.googlesource.com/1105817Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570706}

There were three identical SharedBitmapIdToGpuMailboxPtr functions
which converted from viz::SharedBitmapId to
gpu::mojom::blink::MailboxPtr and those clashed in jumbo builds,

This patch makes all code use the same shared copy in
canvas_resource.cc

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic7980af0aa30d7cc90acac1d0846f626ad58671d
Reviewed-on: https://chromium-review.googlesource.com/1104461Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#570705}

These new owners are active members of the client-side team for sync.

We exclude sync/protocol to be more cautious with changes that are
visible over the wire, for backward-compatibility reasons.

Bug: None
Change-Id: Icd5ba4a300701bf993de238b04b3d14f00821bc0
Reviewed-on: https://chromium-review.googlesource.com/1116538Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570704}

TBR=kinuko@chromium.org

Change-Id: I4038a30f19cc582469b16eb4f0625cd12a4ccf5a
Reviewed-on: https://chromium-review.googlesource.com/1116543
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570703}

Bug: 850372
Test: GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5ce2e7e3adf1a3619d0cec18c9133f231c2749c0
Reviewed-on: https://chromium-review.googlesource.com/1114525Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570702}

This reverts commit 2c7a71c3.

Reason for revert: Linux with chunk size 50 broke in v8 which we
can't quickly fix, and Windows (chunk size 8) has a DWORD logging
error that looks non-trivial. We need to fix those before landing
this.

Original change's description:
> jumbo: stable assignment of inputs to chunks
> 
> Adding or removing a file from a jumbo source set causes on average
> half of the chunks to have their inputs reallocated.
> Derive chunk boundaries from a combination of list position and path
> content. This is so that when a file is added or removed, only the
> boundaries with adjacent chunks typically move.
> For a balance between maximum chunk size and stability of partitions:
> * Partition uniformly into the required number of chunks.
> * Pick a "center" from each chunk by minimum hash value.
> * Pick the boundaries between centers by maximum hash value.
> 
> Bug: 782863
> Change-Id: Ie71d82b132e8145b4ed3d1141f85886a12149d5a
> Reviewed-on: https://chromium-review.googlesource.com/1102218
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Daniel Bratell <bratell@opera.com>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570623}

TBR=dpranke@chromium.org,bratell@opera.com,brucedawson@chromium.org,david.barr@samsung.com

Change-Id: I8c81aca34ab2876aebea6b54e847cb24be3aa27f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 782863
Reviewed-on: https://chromium-review.googlesource.com/1116658Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#570701}

Creates separate text, detail, and switch cells for settings, as they will
require leading icons and different fonts from the non-Settings variants.

BUG=805213

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I465f9df05bc5cea20dbff8dfd21f2eacceb9057f
Reviewed-on: https://chromium-review.googlesource.com/1114605Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570700}

Relanding crrev.com/c/1105772 after crbug.com/855797.
Broken tests caused by calls to GetAccountsForDicePromos
were fixed.

When the user is signed out of Chrome and the profile icon
has not been explicitly changed, AvatarToolbarButton now
uses the account icon of the first sync promo account.

Screenshots:
https://drive.google.com/file/d/1a7kr12KtA11Wt7MQ9MLnSf-M3D9nlLdg/view?usp=sharing
https://drive.google.com/file/d/1nKLnoD1sbcZOvwGQY3YtHVTUv32DQNFn/view?usp=sharing

TBR=droger@chromium.org
TBR=tapted@chromium.org
TBR=bsep@chromium.org

Bug: 853363, 855797
Change-Id: I830aedd32c30cb1c39fc24551dd225c81d62c097
Reviewed-on: https://chromium-review.googlesource.com/1112253
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570699}

It flakes just about everywhere.

BUG=850980
TBR=treib@chromium.org
NOTRY=true

Change-Id: I2f4ac0620028240cdd24c75c6d45666ef6edcadc
Reviewed-on: https://chromium-review.googlesource.com/1116545
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570698}

This CL fixes MoveContentBelowHeader to have it take into account the
bottom toolbar. This function now moves the content below the header but
also add an inset for the bottom toolbar.

Bug: 851129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2b7c5e54e1597bf2779e028381b9d05910c021c7
Reviewed-on: https://chromium-review.googlesource.com/1111845Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570697}

Added a policy to limit the user's choices for their input methods in a
user session. The user can only select one of the provided input
methods in the list. If the current user's input method is not allowed,
the user's input method will be set to the hardware keyboard layout (if
allowed) or the first valid entry in this list.

Bug: 841301
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If68d812fa8b9621c776acff4e218b0002d038081
Reviewed-on: https://chromium-review.googlesource.com/1086998
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570696}

There was a DCHECK making sure we did not cached matched properties when
one of the applied properties was a non-inherited property with an
explicit inherit value. For :visited properties, we do not set the flag
for properties which are not allowed, but re-applying it to the cached
ComputedStyle later would trigger a DCHECK even if the inherit value
would not actually be applied. Applied changes to the DCHECK to handle
that case.

Also took the chance to Ribbonize valid :visited/:link properties as
IsValidForVisitedLink().

Bug: 855849
Change-Id: I0addbd969cfd71e7f177ed5afbd5eac088800dee
Reviewed-on: https://chromium-review.googlesource.com/1114977Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570695}

That CL (https://chromium-review.googlesource.com/c/chromium/src/+/1113443) introduced a crash if a saved password has only one character (it called base::RandGenerator(0)).

The goal of VotesUploader::GeneratePasswordAttributesVote is to report the maximum observed password length for a site in a privacy preserving way. To achieve this, the true length, L, of the password is reported in in 20% of cases. In the remaining 80% of cases, a random value from the range [1, L-1] is reported.

This is not well defined for L = 1, which caused the crash after https://crrev.com/c/1113443 landed. The fix, introduced in this CL, is to always report 1 if L = 1. This is still privacy preserving (if a client reports 1, the true length could have been anything) and does not violate the invariant that the maximal password length gets reported.

Bug: 849243
Change-Id: I5bf5ec03746f4339c20f1c7c3447fad3ce7d2ee2
Reviewed-on: https://chromium-review.googlesource.com/1116541
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570694}

When calling certain functions in GridLayout a resize
parameter is passed, defining how much the layout should
resize.
Most often it is passed as 0 or 1. Sometimes 100 (which
is assumed to be the same as 1) and sometimes 0.5.

This commit defines the variable kFixedSize = 0.f
in grid_layout.h and remove every local defintion of
the variables. The magic constant are replaced by this
variable. The replacements are:
0, 0.f and 0.0f becomes kFixedSize (0.f)

This commit affects chrome/browser/ui.

Bug: 854186
Change-Id: I287b1b38350a2dce2bd6e02cc871e82e0a5d89db
Reviewed-on: https://chromium-review.googlesource.com/1106159Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#570693}

c/b/extensions/api/downloads/downloads_api.h indirectly includes the
generated csd.pb.h file, so it needs an explicit dependency on the
target that produces it.

BUG=856920
TBR=jialiul@chromium.org

Change-Id: I8a1821b05b92c71fa89bb706d6e9b21abf93bc93
Reviewed-on: https://chromium-review.googlesource.com/1116539
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570692}