GitLab

The current JNI generator does not support using an inner class of an
object that is in the same package as the class being processed. This CL
add a new annotation to handle this case.

R=bulach@chromium.org

Review URL: https://codereview.chromium.org/290403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271376 0039d316-1c4b-4281-b951-d872f2087c98

to ResourceList.

This CL is not an actual fix of the bug (crbug.com/364243), but it avoids those crashes.


BUG=364243

Review URL: https://codereview.chromium.org/291833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271375 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271374 0039d316-1c4b-4281-b951-d872f2087c98

This is another try of r267768, now that gclient has been fixed to change the
DEPS without renaming the directory.

TBR=slamm@chromium.org
BUG=

Review URL: https://codereview.chromium.org/284223006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271373 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary in order to allow browser tests to run correctly when using
CLD in dynamic mode (either from an external file or via the component
updater). This change is being split apart from the actual tests that use it
because the CLD data file is too large to commit via the CQ and, as a result,
must be dcommit'ed.

BUG=367239
R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/289313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271372 0039d316-1c4b-4281-b951-d872f2087c98

Add css class 'shared' for shared folders in file list (FileTable and FileGrid).
Use special icon for folders which has a class 'shared'.

BUG=264812
TEST=manually confirmed

Review URL: https://codereview.chromium.org/293643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271371 0039d316-1c4b-4281-b951-d872f2087c98

DevToolsTracingHandler is used for inspecting two different targets: browser and renderer. The former one is used by Telemetry and behavior in that case hasn't changed.

When the handler is used for inslecting renderer we do not return response from browser override for Tracing.start so that InspectorTracingAgent in the render process could handle it.
For blink counterpart, see: https://codereview.chromium.org/254613002

BUG=361045,374411
R=caseq@chromium.org, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/295613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359586

Review URL: https://codereview.chromium.org/285293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271367 0039d316-1c4b-4281-b951-d872f2087c98

In the mean time, I've also renamed identityPrivate.getResources to
identityPrivate.getStrings to be more consistent with the fileBrowserPrivate,
wallpaperPrivate, bookmarkManagerPrivate and feedbackPrivate.

BUG=372318
NOTRY=true

Review URL: https://codereview.chromium.org/272173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271366 0039d316-1c4b-4281-b951-d872f2087c98

 - NSS lock inversions (issue 372807)
 - lock inversion in AudioStreamHandlerTest.Play (issue 374135)

BUG=372807,374135
TBR=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/292693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271365 0039d316-1c4b-4281-b951-d872f2087c98

> Revert of [Mac] Unselect generated password when mouse leaves password bounds. (https://codereview.chromium.org/282093006/)
> 
> Reason for revert:
> Speculative revert, FormFillLatencyAfterSubmit is failing
> 
> Original issue's description:
> > [Mac] Unselect generated password when mouse leaves password bounds.
> > 
> > In the Mac implementation of the password generation poup, the password
> > row is not unselected when the mouse is moved elsewhere in the popup
> > (e.g. over top of the help text).
> > 
> > The fix is that PasswordSelected() should always be called in
> > SetSelectionAtPoint, not just when the mouse is within the password
> > bounds. The Views implementation happens to work because it has a
> > subview (PasswordRow) which triggers OnMouseExited() when the mouse
> > moves outside of the password bounds.
> > 
> > Also added an optimization that PasswordSelectionUpdated() is only
> > called when the value is actually changed, not every time
> > PasswordSelected() is called.
> > 
> > BUG=114092
> > R=isherman@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270975
> 
> TBR=gcasto@chromium.org,isherman@chromium.org,dubroy@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=114092
> 
> Review URL: https://codereview.chromium.org/287063007

TBR=akuegel@chromium.org

Review URL: https://codereview.chromium.org/296473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271364 0039d316-1c4b-4281-b951-d872f2087c98

Defers the dicision to dispatch a VKEY_PROCESSKEY key event until the preedit changes or the text gets committed.

BUG=368100
TEST=Done manually.

Review URL: https://codereview.chromium.org/277973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271363 0039d316-1c4b-4281-b951-d872f2087c98

This is required for DeviceProvider implementations that are not capable of creating sockets.

BUG=None

Review URL: https://codereview.chromium.org/288353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271362 0039d316-1c4b-4281-b951-d872f2087c98

This fixes (1) and (4) in the issue 371232.
- Set correct margin for the title 'Files' app.
- Correct separator's direction. 

BUG=371232
TEST=manually confirmed

Review URL: https://codereview.chromium.org/291583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271360 0039d316-1c4b-4281-b951-d872f2087c98

A regression was introduced in the refactoring change in r269020.
VideoCaptureDelegate::started_callback_ is used to notify that the
stream has started and ran into error. However in change r269020 the
callback was reset after sending the started signal. This prevented
error signal from firing.

In this change |started_callback_| is renamed to |running_callback| to
avoid confusion. Also added a test to verify that ReadyStateEnded is
reached when a camera stops.

BUG=374495

Review URL: https://codereview.chromium.org/295483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271359 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271358 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174238:174243&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/292703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271357 0039d316-1c4b-4281-b951-d872f2087c98

Previously the existing Galley.app window do nothing when new entries are opened
in Files.app. This CL make the Gallery.app reopen its window.

BUG=358698
TEST=manually
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/294593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358808

Review URL: https://codereview.chromium.org/292523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264812
TEST=manually confirmed
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/286983005

Patch from Naoki Fukino <fukino@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/291773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276739
R=jamiewalch@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/234023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271351 0039d316-1c4b-4281-b951-d872f2087c98

These were incorrectly disabled after the stack trace for the
suppressions changed.

NOTRY=true
TBR=jyasskin@chromium.org
BUG=361044

Review URL: https://codereview.chromium.org/292703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271350 0039d316-1c4b-4281-b951-d872f2087c98

On Linux window updates properly after renderer is killed. Perhaps should be checked on Mac as well.

BUG=372504

Review URL: https://codereview.chromium.org/286843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271349 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271348 0039d316-1c4b-4281-b951-d872f2087c98

The compiler file unconditionally depenended on the GCC version.

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/292703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271347 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the regression, which is that the selection change by keyboard is not handled.

BUG=371715
TEST=manually tested

Review URL: https://codereview.chromium.org/279873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271346 0039d316-1c4b-4281-b951-d872f2087c98

> Build remoting for PNaCl
> 
> BUG=276739
> R=jamiewalch@chromium.org, rsleevi@chromium.org
> 
> Review URL: https://codereview.chromium.org/234023003

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/285243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276739
R=jamiewalch@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/234023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271343 0039d316-1c4b-4281-b951-d872f2087c98

Part1: https://codereview.chromium.org/275103004/
Part2: https://codereview.chromium.org/287843002/

This change makes all remaining functions return status code instead of boolean.


BUG=372704
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/284123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271342 0039d316-1c4b-4281-b951-d872f2087c98

We are removing the dependency of ChromeOS on Chrome to send metrics.
If Chrome is not install on a system, we will provide a simple service that will
upload the metrics. This module will need to read the same logs and use the same
parsing mechanism as Chrome does now. The common serialization code will be kept
in base to make it accessible to both Chrome and ChromeOS.

The code in chrome/browser/chromeos/ will be migrated to use this in an other
CL.

BUG=chromium:358371
TEST=unittest included

Review URL: https://codereview.chromium.org/227873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271341 0039d316-1c4b-4281-b951-d872f2087c98

Allowed revoking of file permissions for apps that required file permissions.
This button appears in the 'expanded' section of the app info dialog under
'Files'.

BUG=371691

Review URL: https://codereview.chromium.org/278773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28909
TEST=visual

Review URL: https://codereview.chromium.org/289903010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271339 0039d316-1c4b-4281-b951-d872f2087c98

This call was removed in crrev.com/132343006.

BUG=374473

Review URL: https://codereview.chromium.org/284303008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271338 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271332 0039d316-1c4b-4281-b951-d872f2087c98

Part1: https://codereview.chromium.org/275103004/

This change makes the following functions return status code instead of boolean.
- GetRegistrationsForOrigin()
- GetAllRegistrations()
- LazyOpen()
- ReadDatabaseVersion()

Other remaining functions will be fixed in the following CLs.


BUG=372704
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/287843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271329 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the creation of RenderFrameProxyHost earlier in the timeline of cross-process navigation. Instead of waiting until commit time, it creates it at the time SwapOut message is sent to the old RenderFrameHost.
It also creates the renderer-side RenderFrameProxy object. Since now both sides have proxies, when in swapped out state, RenderFrameHost and RenderFrame send their messages through the proxies. This both helps verify proxies exist and paves the way of removing the notion of swapping out frames.

BUG=357747

Review URL: https://codereview.chromium.org/281663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=willchan@chromium.org

Review URL: https://codereview.chromium.org/293503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271324 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/294563002/)

Reason for revert:
Things cycled green before this revert became active on the testers.

Original issue's description:
> Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/284343003/)
> 
> Reason for revert:
> speculative, browser_tests stated timing out on all non-dbg win main waterfall test bots, with a message such as
> 
> 
> E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\scripts\slave\runisolatedtest.py --test_name browser_tests --builder_name "Win7 Tests (1)" --checkout_dir E:\b\build\slave\Win7_Tests__1_\build E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe -- E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --lib=browser_tests --gtest_print_time --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
> 
> E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\slave\Win7_Tests__1_\build\src\tools\swarming_client\isolate.py run --isolated E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.isolated -v -- --no-cr --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
>  INFO         isolate(685): CompleteState.load_isolate(E:\b\build\slave\Win7_Tests__1_\build, E:\b\build\slave\Win7_Tests__1_\build\src\chrome\browser_tests.isolate, {}, {}, {'EXECUTABLE_SUFFIX': '.exe'}, False)
>  INFO         isolate(156): normalize_path_variables(E:\b\build\slave\Win7_Tests__1_\build, {}, E:\b\build\slave\Win7_Tests__1_\build\src\chrome)
>  INFO  isolate_format( 57): determine_root_dir(E:\b\build\slave\Win7_Tests__1_\build\src\chrome, 80 files) -> E:\b\build\slave\Win7_Tests__1_\build\src
>  INFO         isolate( 84): recreate_tree(outdir=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl, indir=E:\b\build\slave\Win7_Tests__1_\build\src, files=9443, action=4, as_hash=False)
>  INFO         isolate(1266): Running ['E:\\b\\depot_tools\\python276_bin\\python_slave.exe', '../testing/test_env.py', u'..\\out\\Release/browser_tests.exe', '--test-launcher-bot-mode', '--no-cr', '--test-launcher-bot-mode', '--test-launcher-total-shards=3', '--test-launcher-shard-index=0', '--gtest_output=xml:E:\\b\\build\\slave\\Win7_Tests__1_\\build\\gtest-results\\browser_tests\\browser_tests.xml', '--test-launcher-summary-output=c:\\users\\chrome~2\\appdata\\local\\temp\\tmpfbmzn9'], cwd=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl\chrome
> 
> command timed out: 600 seconds without output, attempting to kill
> program finished with exit code 1
> 
> Original issue's description:
> > Elimate NOTIFICATION_GOOGLE_URL_UPDATED
> > 
> > This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED
> > notification to instead register a callback with GoogleURLTracker and
> > eliminates the notification. It also migrate the GoogleURLTracker unittest from
> > listening for the notification to listening for the callback.
> > 
> > BUG=373261,373237
> > TBR=thakis
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271313
> 
> TBR=pkasting@chromium.org,blundell@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=373261,373237
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271320

TBR=pkasting@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373261,373237

Review URL: https://codereview.chromium.org/287233007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271323 0039d316-1c4b-4281-b951-d872f2087c98

Also add rsleevi to c/b/net/OWNERS

BUG=none

Review URL: https://codereview.chromium.org/291553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271322 0039d316-1c4b-4281-b951-d872f2087c98