- 20 Jul, 2018 40 commits
-
-
Ryan Hansberry authored
Integrates MultiDeviceSetupClient into TetherService. If the chromeos::features::kEnableUnifiedMultiDeviceSetup flag is enabled, Instant Tethering will only be displayed in Settings and Quick Settings if a verified MultiDevice host exists. Bug: 824568 Change-Id: Iad6b6778a2986c7c92176bc7d8f4ac47bd47f5e3 Reviewed-on: https://chromium-review.googlesource.com/1141145 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#576750}
-
Yutaka Hirano authored
virtual/outofblink-cors and virtual/outofblink-cors-ns should inherit existing test expectations. There is a dedicated bug for virtual/outofblink-cors, https://crbug.com/854630, but that doesn't make sense as none of them are OOR-CORS specific, so I changed the bug number. TBR=dcheng@chromium.org No-Try: true Bug: 834185, 854630, 859988, 862184 Change-Id: I4886c8ed063e95306d79234649dbc54a8bb53100 Reviewed-on: https://chromium-review.googlesource.com/1144582Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576749}
-
Ria Jiang authored
Some SitePerProcessHitTestBrowserTest are failing with feature VizDisplayCompositor turned on. This is because the current way of getting the page-scale-factor of the last frame doesn't work with VizDisplayCompositor - VizDisplayCompositor doesn't use RenderWidgetHostImpl::SubmitCompositorFrame so last_frame_metadata_ is never set. This CL updates those tests to use RenderFrameSubmissionObserver to get the last RenderFrameMetadata. Bug: 848325, 848325 Change-Id: Ic20e6c4a591dbc7c3c499869910b4f342b99c3cb Reviewed-on: https://chromium-review.googlesource.com/1139088 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576748}
-
Min Qin authored
For cross origin redirects, Chrome starts a new navigation request. Since the ResourceDownloader is already created, CancelRequest() is needed to destroy it. BUG=831073 Change-Id: I97456d6659fd61cf9af39b037fa95a448ab80185 Reviewed-on: https://chromium-review.googlesource.com/1143690Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576747}
-
Alex Moshchuk authored
Bug: 865802 Change-Id: I8c6a6eb45d29c9cdd1aec9557baebd3bd58cb332 Tbr: dmurph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1144521Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576746}
-
dpapad authored
Instead of having a fixed 200px width, make it occupy 50% of the available space. Bug: 704428 Change-Id: I8f647da9c2fee631548cbb0691733ade82fb7230 Reviewed-on: https://chromium-review.googlesource.com/1144137Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576745}
-
David Black authored
Now that we have indication in the OnInteractionStarted event if we are handling a voice interaction or not, we can move the commit logic in the case of a non-voice interaction. Doing so allows us to properly clear the stage whenever a new interaction is started. This fixes a bug in which notifications failed to clear the stage. Bug: 111396118 Change-Id: I288ee685f9e8fa8c385c0dbb0896c03838c53a4e Reviewed-on: https://chromium-review.googlesource.com/1144429Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#576744}
-
Paul Irish authored
Change-Id: If3ca6a8deb29680e213e151ab7aa91ddec1c19e3 Reviewed-on: https://chromium-review.googlesource.com/1144449Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576743}
-
Khushal authored
This reverts commit f9395d77. Use the GrContextOptions::PersistentCache API provided by skia to persist shaders generated internally by skia for OOP raster to disk. This requires using a special client id to namespace these shaders, similar to the one used by the InProcessCommandBuffer for viz. While the shaders for different sources are stored seperately on disk, they are finally merged into a single memory cache in the GPU process. In order to maintain a seperate cache for skia generated shaders, this also plumbs the client id for a loaded shader to the GPU process. TBR=tsepez@chromium.org Bug: 854416,840559, 865138 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I65544ccaff96c3154a822dbc2500468fbcac8a0b Reviewed-on: https://chromium-review.googlesource.com/1142829 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576742}
-
Brandon Jones authored
Received feedback that the previous enums went against platform norms Bug: 854382 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I278fbbc204f45e5032ac081e535bae5f62bc1cd3 Reviewed-on: https://chromium-review.googlesource.com/1144249Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576741}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb5cc39baf68..ea9328b8e855 Created with: gclient setdep -r src-internal@ea9328b8e855 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibaf6bcb28b885b5e0e03f0499fe67cb127e721db Reviewed-on: https://chromium-review.googlesource.com/1144027Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576740}
-
Theresa authored
BUG=863763 Change-Id: I5a60e0c8f8c79bf4e6f3763d31f006595c063c2b Reviewed-on: https://chromium-review.googlesource.com/1144439 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576739}
-
Daniel Park authored
> Scrolls if the NTP is finished loaded > If not loaded at time of method call, adds an observer to delay scrolling until loading finishes Bug: 865747 Change-Id: I8f80d1692d762efa6bba39560b148950883c4952 Reviewed-on: https://chromium-review.googlesource.com/1144319Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#576738}
-
Bence Béky authored
Add new bucket and record histogram if push is cancelled because resource was found in cache. This bucket was missing by mistake. Add new bucket and record histogram if push is rejected because push is disabled. This functionality was just added at https://crrev.com/c/1141282. Bug: 232040, 862805 Change-Id: I70af4cfc077bd65baccc7fe06cadb7dfe29d42fe Reviewed-on: https://chromium-review.googlesource.com/1142958 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576737}
-
Dale Curtis authored
This codifies assumptions about the API into variables which are used to disable or start the internal reporting timer for WTR. Specifically these two assumptions are codified: - That in shutdown the timer should not be able to start, and should be stopped. - That when a seek starts, a subsequent play call is required to allow the timer to start again. Previously these were handled by forcing the timer state to false when those events are in flight. In the case of a seek, something like OnShown() might end up called first and restart the timer. BUG=none TEST=new tests. Change-Id: Ia14c3cdf8a3e383915372eb8ab813a1e4b78e530 Reviewed-on: https://chromium-review.googlesource.com/1144301 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#576736}
-
Dale Curtis authored
Specifically if the base component has started finalize and another component (AC, controls, etc) starts finalizing it's possible that it has a higher end timestamp than the base component finalize. Instead we should clamp to the maximum of the current time value given to RecordWatchTime() instead of using a higher ending timestamp. BUG=none TEST=new unittests Change-Id: Idd32571ea4d6b7b937ca61a4606e2f8e7efc7e53 Reviewed-on: https://chromium-review.googlesource.com/1144302Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5527682463d1..abf9829bc411 git log 5527682463d1..abf9829bc411 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 tsepez@chromium.org Remove some unused default values in cfxjse_context.h. 2018-07-19 tsepez@chromium.org Change some ASSERTS() to early returns in cfxjse_class.cpp Created with: gclient setdep -r src/third_party/pdfium@abf9829bc411 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I90519b33ad62d5aea3b4a37ba0e4a8fef148a724 Reviewed-on: https://chromium-review.googlesource.com/1144026Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576734}
-
Alexander Alekseev authored
This Cl makes buttons correctly spaced on Welcome screen and Powerwash screen. Assistant opt-in screen now uses cros-shared button style. Bug: 857443,852034 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia90416579b6fefa409ccb4eba7eafeb019136409 Reviewed-on: https://chromium-review.googlesource.com/1142894 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#576733}
-
Bill Orr authored
As previously announced (https://groups.google.com/a/chromium.org/d/msg/blink-dev/-s4pWwshKhI/M78h2_scBwAJ), the WebVR Origin Trial is ending after M68 as WebVR is replaced by the WebXR Device API and Origin Trial. WebVR can still be manually enabled through chrome://flags. BUG=758265 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I752ac8d61c8436abd80a511cc66d4aad502d0245 Reviewed-on: https://chromium-review.googlesource.com/1144278Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576732}
-
Mounir Lamouri authored
This reverts commit 94b0138d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[Picture-in-Picture] Update window playback when video src changes." > > This reverts commit 93488940. > > Reason for revert: PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened is very flaky: https://crbug.com/865410 > > Original change's description: > > [Picture-in-Picture] Update window playback when video src changes. > > > > This CL make sure the Picture-in-Picture window playback state is > > reflected when video src changes. It is a follow-up to > > https://chromium-review.googlesource.com/1089331 > > > > Bug: 726619 > > Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3 > > Reviewed-on: https://chromium-review.googlesource.com/1133168 > > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#576428} > > TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org > > Change-Id: I2b35b9ef8c119915b1c07f9f12321439c3242ab2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 726619, 865410 > Reviewed-on: https://chromium-review.googlesource.com/1143324 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576454} TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org,dullweber@chromium.org Change-Id: Ia3931e803814eb9bf8bf56d44fd922f409cd5d8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726619, 865410 Reviewed-on: https://chromium-review.googlesource.com/1144560 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#576731}
-
rbpotter authored
Focusing the search box prevented the escape key from closing the destination/advanced settings dialogs. Fix this regression. Bug: 863360 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib408969df14cab47c9ec38ad60169b2577498049 Reviewed-on: https://chromium-review.googlesource.com/1137711 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576730}
-
Kyle Milka authored
http://go/scrcast/NTA5MjU0NjM3MTkxMTY4MHw4ZWNkMjkzNS0xMg Also fix a padding issue in RTL mode, introduced when the scrollbar was added. Bug: 859371 Change-Id: I8745af5191f117e712eceaba5f09a68f9166d19b Reviewed-on: https://chromium-review.googlesource.com/1144317Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#576729}
-
Klaus Weidner authored
The render target view depends on the destination texture, but wasn't being recreated on texture resize, resulting in broken rendering after changing framebuffer scale (WebXR) or canvas size (WebVR 1.1) for the OpenVR backend. BUG=835905 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I92bbcdc4f2ed4da1c248cf63132a2bc60a25a8c7 Reviewed-on: https://chromium-review.googlesource.com/1144469Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576728}
-
Daniel Park authored
> If NTP Button is enabled, caches clear tabs variant in shared preferences > Changes 'variation' to 'variant' > Adds a second call to change the button's icon earlier > The two calls make it such that the old home button icon only flashes in the first cold start following install of the new version. The icon will not flash in subsequent start ups. (confirmed by testing) Bug: 862887 Change-Id: I99b55d0ad9bf0a8977d5c1e5db17221ff25ae7d9 Reviewed-on: https://chromium-review.googlesource.com/1136527Reviewed-by:
-
Rintaro Kuroiwa authored
- Because it was using std::vector::reserve(), the size of the vector was 0. - Which means it did not match |expected_output_data_size|. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7004a7540f8760b28ddbd161cf2019c703d3fe13 Reviewed-on: https://chromium-review.googlesource.com/1143897 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#576726}
-
Min Qin authored
This reverts commit 4d370e2c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Do a null check on BrowserContext in DownloadManagerService > > DownloadManagerService may start too early before full browser is started. > In this case, downloadItem doesn't have a BrowserContext object assocuated, > > BUG=695115 > > Change-Id: Ie7dcc88bb63cdfc8af0d0e4d4670e808e22f175e > Reviewed-on: https://chromium-review.googlesource.com/1140519 > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575863} TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 695115 Change-Id: Iaaa46d8f07625f423dceadede668a7f4d254d3b6 Reviewed-on: https://chromium-review.googlesource.com/1144082 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576725}
-
Eric Karl authored
Aliases ImageTransferCacheEntry memory dumps with their Skia counterparts, preventing double-counting of memory between the two categories. After this change memory is attributed to the TransferCache not Skia. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0738cf91e091b70929dbc51dd494530c62538784 Reviewed-on: https://chromium-review.googlesource.com/1141098 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#576724}
-
Justin Novosad authored
BUG=788439 TBR=zmo@chromium.org NOTRY=true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6fdbe5e935931480817f3fd9290fae7a13c162b1 Reviewed-on: https://chromium-review.googlesource.com/1144528 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#576723}
-
Oystein Eftevaag authored
This re-enables the tracing::AgentRegistry and associated Mojo connections even when Perfetto is used, which is then used by the PerfettoTracingController to provide the list of categories to about://tracing. Also some cleanup: ServiceFactoryRef is redundant for the tracing service (it's always running anyway). Bug: 839065 Change-Id: Ie094191d16caf10a0400499135b3396ab8595bb2 Reviewed-on: https://chromium-review.googlesource.com/1142724 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576722}
-
Esmael El-Moslimany authored
Bug: 865418 Change-Id: I0710db79de5a756e302bd74b257457039523250a Reviewed-on: https://chromium-review.googlesource.com/1144121Reviewed-by:
-
Matt Wolenetz authored
Chromium's allowed use of C++11's std::vector::data for quite a while now. In anticipation of some other refactoring coming soon to the underlying code, this CL removes the workaround previously in place for IsValidAnnexB(std::vector, ...) for each of MSE's AVC and HEVC bitstream conversion utilities. BUG=860420,584384 Change-Id: I15f1cedebaa37bbac91cb62456b8322dc70e34c4 Reviewed-on: https://chromium-review.googlesource.com/1144218Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576720}
-
Jia authored
This cl contains the following changes 1. Definition of an idle event. - Now an idle event is generated when a ScreenDimImminent signal is received. 2. Calculation of recent time active. - It's the duration of activity up to the current idle event and is reset/recalculated when (i). an idle event is generated. (ii). a long suspend is received, i.e. the sleep duration is more than kIdleDelay (currently set to 30sec). 3. Reset video playing timestamps when an idle event is generated. - Two video playing sessions with a gap < kIdleDelay are merged into one session. ScreenDimImminent is likely triggered long after a video stops (i.e. more than kIdleDelay). But in the unlikely event that this happens soon after a video stops, we reset video timestamps so that next time when video starts, its session will not be merged with the previous one that occurred before ScreenDimImminent. 4. IdleEventNotifier lo longer observes SuspendImminent signal from PowerManagerClient. Bug: 862461 Change-Id: Ifcb2d0fac7d4d84eb36f2032436c356fab74777b Reviewed-on: https://chromium-review.googlesource.com/1132262 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#576719}
-
Scott Violet authored
All of these are no longer necessary, used. BUG=865689 TEST=none Change-Id: I7629c155819c92c8fb4eb0e7cde44cfb3a81f132 Reviewed-on: https://chromium-review.googlesource.com/1144255Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#576718}
-
Herb Derby authored
Change-Id: I2a6a180253fdc2b1de429194510f6b462643ab05 Reviewed-on: https://chromium-review.googlesource.com/1144232 Commit-Queue: Herb Derby <herb@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#576717}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26a1ccee228a..0ddcb32d165e git log 26a1ccee228a..0ddcb32d165e --date=short --no-merges --format='%ad %ae %s' 2018-07-19 eakuefner@chromium.org [TBMv2] Add POINT_ID reserved diagnostic Created with: gclient setdep -r src/third_party/catapult@0ddcb32d165e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862319 TBR=sullivan@chromium.org Change-Id: I2b42c1c30c398d3423f932b5dfbd8b5dc2483aa9 Reviewed-on: https://chromium-review.googlesource.com/1144280Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576716}
-
Alex Moshchuk authored
This CL fixes a bug where multiple frames on a page both defined a beforeunload handler leading to a dialog and the page was navigated away. First, one of the frames showed the beforeunload dialog. Next, another frame tried to show a beforeunload dialog before the user interacted with the first dialog. RFHI::OnRunBeforeUnloadConfirm() dismissed that attempt due to the policy of at most one beforeunload dialog per navigation. However, as part of doing that, it called JavaScriptDialogClosed() to proceed with the navigation, which unconditionally restarted the beforeunload timer. This led to the navigation proceeding as soon as the timer fired (in 1 sec), despite still having the beforeunload dialog up from the first frame. This CL adds plumbing so that JavaScriptDialogClosed() doesn't try to restart the beforeunload timers in that case. Bug: 865223 Change-Id: I1377f4891ebc86790941d7e815853ff24dda1cfd Reviewed-on: https://chromium-review.googlesource.com/1142826 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576715}
-
Renée Wright authored
This reverts commit b5e1688a. Reason for revert: This CL seems to cause a crash when installing Terminal on Eve. Original change's description: > Create crostini app folder and add all Crostini apps to it > > Bug: 822488 > Test: Manually, simulate crositini app environment. > Change-Id: I278a6ddfc709b5b48f923368aad07f047788bf40 > Reviewed-on: https://chromium-review.googlesource.com/1143883 > Commit-Queue: Renée Wright <rjwright@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576703} TBR=stevenjb@chromium.org,rjwright@chromium.org,khmel@google.com Change-Id: I3104b7d7abbf885f100aedb223d31a4d73bed47c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822488 Reviewed-on: https://chromium-review.googlesource.com/1144500Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#576714}
-
Jonathan Backer authored
This was motivated by integration with a WIP patch for CreateSharedImage https://chromium-review.googlesource.com/c/chromium/src/+/1125414 With CreateSharedImage, we don't need texture IDs on the OOP-R path (WIP patch here: https://chromium-review.googlesource.com/c/chromium/src/+/1127445/3/cc/raster/gpu_raster_buffer_provider.cc) This CL moves us slightly closer to the this desired endstate by using mailboxes instead of texture ID for OOP-R. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12e39815edf393b8a3a1a21d5a5964db162648c9 Reviewed-on: https://chromium-review.googlesource.com/1143689 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Tim Song authored
This very basic implementation currently only supports one active advertisement. Future work will add tests and better handle concurrent advertisements. BUG=846881 Change-Id: I48b76e84d67060e7265533759752fcc0e84f5cc6 Reviewed-on: https://chromium-review.googlesource.com/1142294Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#576712}
-
liberato@chromium.org authored
Receiving two OnBeginFrame calls without CompositorFrameAck means that we've dropped a frame. Previously, we would nack the second OnBeginFrame without also notifying the VideoFrameCompositor that the second frame was missed. Without an accurate count of dropped frames, the video frame selection algorithm doesn't always perform well. This CL makes sure that we notify the VideoFrameCompositor about an OnBeginFrame event even if we haven't gotten an ack for a previous one. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5c5e7dbeccde700af6f00eaf5a995db2513889cf Bug: 865790 Reviewed-on: https://chromium-review.googlesource.com/1144304 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#576711}
-
