- 15 Oct, 2018 40 commits
-
-
Lukasz Anforowicz authored
ContentBrowserClients assume that |browser_context| client is not null (e.g. HeadlessContentBrowserClient::DoesSiteRequireDedicatedProcess and ChromeContentBrowserClientExtensionsPart::DoesSiteRequireDedicatedProcess). To avoid surprises, this CL adds DCHECK(browser_context) to most methods of ContentBrowserClients, so that the assumption is documented and verified during //content-layer tests. Bug: 787576 Change-Id: I115ab53bb64cebe50b5993a39b3e153e3054b1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1276559Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#599752}
-
Aga Wronska authored
Change-Id: I2c32fb619d45746896329400737edc08ed6a0dde Reviewed-on: https://chromium-review.googlesource.com/c/1281425 Commit-Queue: Aga Wronska <agawronska@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599751}
-
Clifford Cheng authored
All tests complains about no MR dialog because Harmony UI kicks in. Change-Id: Ibcef272966f802a8fa52b8ade0f2a8247c25ca78 Reviewed-on: https://chromium-review.googlesource.com/c/1281181Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#599750}
-
Yuchen Liu authored
Once offline license is released, MediaDrm won't allow restore it no matter whether server ack is received or not. However EME allows persistent session to be loaded back in such case. We should treat such failure as success in persistent license. BUG=883895 TEST=Test page in the bug and see "EVERYTHING WORKS!" in the log. Change-Id: I301c9fd69cd21e323aaec0446a857ac4a65d2bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1227114 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599749}
-
Ken Rockot authored
Adds a |suppress_navigations| option to NavigableContentsParams, allowing clients to block navigations from occurring as a result of e.g. user gesture or scripting behavior. When enabled, suppressed navigations instead trigger a message on the NavigableContentsClient interface and a corresponding event on any attached NavigableContentsObservers. Bug: 854367 Change-Id: I85b4a0ca970f83a4d0b27e56843f99841434c483 Reviewed-on: https://chromium-review.googlesource.com/c/1269444 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#599748}
-
Henrique Grandinetti authored
It was stored in minutes, which was causing some rounding problems when the CheckTimeLimit function was called less than 1 minute before the device being locked by a screen time. Bug: 895036 Change-Id: Ia6d243e8d59e32fa07151e76542b6235caf5b33a Reviewed-on: https://chromium-review.googlesource.com/c/1281662 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#599747}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f274436bd0d..2f727917ac25 git log 9f274436bd0d..2f727917ac25 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl: add reviewers and ccs to git push command if possible. Created with: gclient setdep -r src/third_party/depot_tools@2f727917ac25 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875089 TBR=agable@chromium.org Change-Id: I3ecf74c74a21847cb52ffb91bd7d66687e93738d Reviewed-on: https://chromium-review.googlesource.com/c/1281202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599746}
-
Sergey Ulanov authored
It's not safe to map resizeable VMOs because they can be resized while being mapped and Zircon faults the thread that tries to access mapped memory outside of the VMO bounds. This CL adds ZX_VM_REQUIRE_NON_RESIZABLE to zx_vmar_map() calls, which ensures that mapped VMOs are always non-resizable. Change-Id: I5b40347400f839c2e4d879054d222950ba0d3d31 Reviewed-on: https://chromium-review.googlesource.com/c/1281051 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#599745}
-
Jonathan Backer authored
Reland of https://crrev.com/c/1258206. Revert of that CL was to defer until after M71 branchpoint to avoid unnecessary risk. Zero code change in this reland. This CL uses RasterDecoder for CPU rasterization (one-copy and zero-copy) on worker background raster threads in two cases: (1) in renderers whenever GPU raster is blacklisted or cannot create GrContext (similar to LayerTreeHostImpl::GetGpuRasterizationCapabilities) (2) in browser whenever GPU raster is not requested This CL copies some of the logic in LTHI::GetGpuRasterizationCapabilities to RenderThreadImpl::SharedCompositorWorkerContextProvider. I copied it so that if we fail GPU rasterization using GLES2Decoder, we can fallback to CPU raster using a RasterDecoder. TBR=piman Bug: 880911 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I097ede2266c9ddc4c6f6c777b34419399eb21bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1281084 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#599744}
-
Carlos IL authored
Added histograms that log start/failure/response code for autoupgraded resources, and start/failure/connection success for autoupgraded websockets. Metrics for form submissions will come in a later CL. Bug: 893685 Change-Id: I7715a61c2f7a7582d5b317c1fa8c8fa60c1408a2 Reviewed-on: https://chromium-review.googlesource.com/c/1275295 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#599743}
-
Jamie Walch authored
Bug: 879729 Change-Id: I8a7296b344c42115a7fade7d965a6b38f0688f59 Reviewed-on: https://chromium-review.googlesource.com/c/1281239Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#599742}
-
Peng Huang authored
This reverts commit 0cb76248. Reason for revert: performance regressions Original change's description: > Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets. > > Enable those two options which may improve skia performance. > > Bug: 894492 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I80a1b9d1ce018d90ab91e5e676b6d09a7dc23d8d > Reviewed-on: https://chromium-review.googlesource.com/c/1273267 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Cr-Commit-Position: refs/heads/master@{#599321} TBR=penghuang@chromium.org,robertphillips@google.com,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894492,895408,895384,895377,895369,895280 Change-Id: I657077091716a618d18a3d1109531e6b3819108c Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1281055 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599741}
-
Corentin Wallez authored
Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to translate shaders from SPIRV to other shading languages, and requires glfw for testing. Adds the Zlib license to the list of allowed license for Android. This also adds back shaderc that was very recently removed. So hopefully a new third_party review isn't required. BUG=chromium:870747 Change-Id: I506156072f34e70e12797f922a979aa8c743bd6e Reviewed-on: https://chromium-review.googlesource.com/c/1244817Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#599740}
-
Ben Kelly authored
This CL fixes some edge condition interactions when being loaded as a ReadableStream. In particular, it: 1. Properly distinguishes between the end of the DataPipe and a closed DataPipe with bytes left to be read. A ReadableStream that is not actively draining the pipe could get closed too early. 2. Responses must support explicit completion in order to handle error conditions properly. This CL makes DataPipeBytesConsumer wait for an explicit signal before closing. 3. Service worker navigation preload is updated to provide the explicit completion signals. Bug: 894815 Change-Id: I2b5d61f9fe4a6f17c37e8a728b2f081debe6d936 Reviewed-on: https://chromium-review.googlesource.com/c/1278910Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#599739}
-
Tommy C. Li authored
This CL is a followup to: https://chromium-review.googlesource.com/c/chromium/src/+/1273985 It adds the IFRAME test case, which did not seem flaky. The EMBED test case is still in-progress to deflake. Bug: 887752, 879149, 878871 Change-Id: Iee52d4314539b2d457812a220a42051caeb1bab0 Reviewed-on: https://chromium-review.googlesource.com/c/1281262Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599738}
-
Josh Nohle authored
Update the multi-device setup flow button bar to include the following buttons: Back, Cancel, Forward. Set the buttons on each page to conform to the following specs (sans padding): https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view. Screenshots with this patch applied: start screen: https://drive.google.com/open?id=1QlWKjesaBpt0ZtNQ_vONBqu1czUWiezz start screen (OOBE): https://drive.google.com/open?id=1kh9UNYjLaSbP-zE0U89sniZSb9Sbhk8fMw password screen: https://drive.google.com/open?id=1olKePztZ9pqxPHupVCdrwEBZ1pyfzLA_ success screen: https://drive.google.com/open?id=1zpZfnowdpOvge8nteqsjBHuUin_I9HgW Bug: 889574 Change-Id: I7a0834b58b6f2458e5ab6641aa5b323cb5fc32fe Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice* Reviewed-on: https://chromium-review.googlesource.com/c/1254760Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#599737}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4edc5a93c0aa..3871bde5c505 git log 4edc5a93c0aa..3871bde5c505 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@3871bde5c505 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If968c514c53b0dc58e2aba19d2e7c85b65196b95 Reviewed-on: https://chromium-review.googlesource.com/c/1281026Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599736}
-
Anand K. Mistry authored
Also, update the comment about the 'modification_time' field in the compression request. BUG=889703 Change-Id: I37df9e8abc50b195b73ffd9cf101444dc682ff33 Reviewed-on: https://chromium-review.googlesource.com/c/1279199 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599735}
-
Tom Anderson authored
Also rolls buildtools [1] and includes some small cleanups. [1] https://chromium.googlesource.com/chromium/buildtools/+log/2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96..13a00f110ef910a25763346d6538b60f12845656 BUG=894427 R=thakis Change-Id: I52fd273ab2e93f8c5e461fd3bf7a34b09135d384 Reviewed-on: https://chromium-review.googlesource.com/c/1277374 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599734}
-
Raphael Kubo da Costa authored
Follow-up to ac53c5c5 ("Remove CR_DEFINE_STATIC_LOCAL from /components"). Due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849, having base::NoDestructor<T<U>> and passing an initializer list of Us does not work if this is not done explicitly, as GCC incorrectly fails to determine which constructor overload to use: ../../components/google/core/common/google_util.cc: In function ‘bool google_util::{anonymous}::IsCanonicalHostGoogleHostname(base::StringPiece, google_util::SubdomainPermission)’: ../../components/google/core/common/google_util.cc:120:24: error: call of overloaded ‘NoDestructor(<brace-enclosed initializer list>)’ is ambiguous {GOOGLE_TLD_LIST}); See also: https://chromium-review.googlesource.com/c/chromium/src/+/1170905 Bug: 819294 Change-Id: Ie1490b6646d7998d636c485769caabf56c1cf44c Reviewed-on: https://chromium-review.googlesource.com/c/1275854Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#599733}
-
Michael Spang authored
This adds a quirk to force this device as internal so that it behaves correctly in tablet mode. Bug: b/116723180 Test: please Change-Id: Ica3ace1098daf090e843ffb03bb27ef07d5144a1 Reviewed-on: https://chromium-review.googlesource.com/c/1280845Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599732}
-
Jacob Dufault authored
Only happens where there are 2+ users (ie, user list is used). OnImageDecoded is supposed to use the animation playback type that was set in SetAnimationEnabled. However, UpdateForUser calls SetImage which updates image_->playback() to kFirstFrameOnly. This means that OnImageDecoded cannot use image_->playback() as the playback type set by SetAnimationEnabled. Bug: 894771 Change-Id: I47ac6daa1e8780e58abdabf59a7642ca4b9dcc43 Reviewed-on: https://chromium-review.googlesource.com/c/1277699Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#599731}
-
Alex Moshchuk authored
Previously, specifying the --isolate-origins command-line flag prevented any field trials involving the IsolateOrigins feature from specifying additional isolated origins. This meant that it's not possible to experiment with additional isolated origins via field trials when an IsolateOrigins enterprise policy is in effect. This CL changes the logic to instead merge any isolated origins specified in field trials with those specified by the cmdline flag. Bug: 894535 Change-Id: If38fe3280dad7f4af3d8b5383556239493ffc7f3 Reviewed-on: https://chromium-review.googlesource.com/c/1279414Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599730}
-
Wenzhao Zang authored
The marketing opt-in screen should only be shown the first time the particular user is added to the device, but not when the user is re-added. Bug: 880480 Change-Id: I0ee9a245a3a37b78a5c98b382b5f0f46696f9d19 Reviewed-on: https://chromium-review.googlesource.com/c/1272085 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#599729}
-
Jan Wilken Doerrie authored
r598929 changed the communication between the password settings backend and frontend to identify password list elements by a unique identifier instead of relying on the element's index in the list. This change renames the appropriate members of the DisplayEntry structs to reflect this change in semantics. Bug: 892260 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic4ea4456ef88f8f0a94ffc6a0a824d2f9da6659a Reviewed-on: https://chromium-review.googlesource.com/c/1278213Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#599728}
-
Anthony Vallee-Dubois authored
Bug: 895485 Change-Id: I57b740831956d1ed9985aa580b7fa24e7b085f7e Reviewed-on: https://chromium-review.googlesource.com/c/1280852Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#599727}
-
Siddhartha S authored
Helps to measure why BrowserPolicyConnector::IsNonEnterpriseUser() sometimes takes too long to run on main thread. BUG=891476 Change-Id: I5dd76dfb22a3334dc1015cf6d6c1f23c7e6f2da0 Reviewed-on: https://chromium-review.googlesource.com/c/1280550Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#599726}
-
Kevin McNee authored
Currently, the InputRouterImplScaleGestureEventTests send unrealistic input sequences. These tests still pass the GestureEventStreamValidator since the validator either doesn't check the given event type or the test sends only the events necessary to get the validator to pass. We now use realistic input sequences. Bug: None Change-Id: I9540b14f9d15bfc835d819d41ff3f2d386c2b607 Reviewed-on: https://chromium-review.googlesource.com/c/1256376 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#599725}
-
Min Chen authored
We used a callback SetShowMenuAnimationDone to start the |pre_shutdown_timer_| if the PowerButtonMenuScreenView has been full shown (opacity reaches its final opacity), but didn't stop it if UseTabletBehavior is true when power button up. Then if menu animation has been started (power_button_menu_timer_ run out of) but not finished (pre_shutdown_timer_ hasn't been started) and UseTabletBehavior is true when power button up. We did nothing in this case. This will cause the |pre_shutdown_timer_| to be started and finally trigger power off when the menu shown animation finished. This cl tried to fix the issue by calling ScheduleShowHideAnimation(false) too if UseTabletBehavior. This will cancel the menu shown animation to make sure its opacity will not achieve its final shown opacity then the callback SetShowMenuAnimationDone will not be called. Turn screen off too in this case. Bug: 894192 Change-Id: Id744597e53229384fd01279e489d9099c83be67b Reviewed-on: https://chromium-review.googlesource.com/c/1277914 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#599724}
-
Fredrik Söderquist authored
Step two of [1], invokes [2], whose step 1 invokes [3], which says to throw a TypeError if the dictionary is not "well-formed". Also remove some dead code in DOMMatrix/DOMMatrixReadOnly and remove few unused includes of svg_matrix_tear_off.h. [1] https://html.spec.whatwg.org/multipage/canvas.html#dom-path2d-addpath [2] https://drafts.fxtf.org/geometry/#create-a-dommatrix-from-the-2d-dictionary [3] https://drafts.fxtf.org/geometry/#matrix-validate-and-fixup-2d Bug: 895244 Change-Id: Icd3f7058ce945d761ab7128e294ccc2e3fd3a879 Reviewed-on: https://chromium-review.googlesource.com/c/1278789Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#599723}
-
Robert Ogden authored
The Virtual URL handling won't work while the navigation is pending. So, for every time the URL is updated on Android, check if the visible URL is a HTTPS Server Preview URL and if so, return the original host. Bug: 894881 Change-Id: I143c70bdb1b2985ed0c475b603cb25cf93d7468a Reviewed-on: https://chromium-review.googlesource.com/c/1280859Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#599722}
-
Tarun Bansal authored
Network Quality Provider is the base class for network quality estimator (NQE). It was originally added as a read-only version of NQE with the goal of passing it to consumers outside of //net, and preventing them from calling internal net-specific APIs. With servicification, this is no longer needed. In short term, it also makes it simpler to plumb NQE to H2 session class (see linked bug) which will be done in a subsequent CL. This is purely a refactor CL, and does not introduce any functionality change. Change-Id: Ibb5bbf6a06ca02d232fbca0c29022422738694f4 Bug: 823322 Reviewed-on: https://chromium-review.googlesource.com/c/1280860Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599721}
-
Tarun Bansal authored
Use the end to end RTT provided by QUIC connections to clamp the upper bound on HTTP RTT. In some cases, network quality estimator may not detect hanging XHR requests, and use the RTT samples from such requests when computing the HTTP RTT estimate. Using end-to-end RTT to clamp HTTP RTT helps in improving the accuracy of HTTP RTT estimate in such cases. Change-Id: I0c2b60eb73b35408c4d32d38ffffc29f6d3e0ce1 Bug: 834119 Reviewed-on: https://chromium-review.googlesource.com/c/1279435Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599720}
-
agrieve authored
apk_size_regressions.md: Make use of size trybot. html_report_faq.md: Link to README.md README.md: Add resource_sizes.py and size trybot README.md: Document all "Overhead:" symbols. README.md: Mention Bloaty McBloatface Change-Id: I4cab3b7cd4c711931e9cae102e2354408cfbdd02 Reviewed-on: https://chromium-review.googlesource.com/c/1278721 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599719}
-
Khushal authored
The change [1] meant to apply this workaround to all Android devices but missed removing the gl_renderer filter. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1272451 R=ericrk@chromium.org Bug: 860021 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I48537a12e14035eff7b8699f5a43c402f490e6cc Reviewed-on: https://chromium-review.googlesource.com/c/1280552Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599718}
-
Rune Lillesveen authored
There should be no reason to force computed style for the root element if it doesn't have one when trying to figure out if body background is propagated to the viewport. Change-Id: Ibf0beb7848101bd1acc20f16a826f0787ef010b9 Reviewed-on: https://chromium-review.googlesource.com/c/1280278Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#599717}
-
Fady Samuel authored
This reverts commit d15ba9ba. Reason for revert: This doesn't seem to solve the deadline reporting bug. This was a speculative fix that didn't fix the issue. Original change's description: > Surface synchronization: Don't report blocked duration of throttled children > > A child can be "throttled" for an arbitrary length of time if it is never > embedded. This skews blocked duration metrics. Simply don't report those > metrics if a surface is blocked on a parent. > > Bug: 890767 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I3c8a8494a5b1e5a973b2e5c2b61cffe5c2b76f6f > Reviewed-on: https://chromium-review.googlesource.com/c/1274591 > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598886} TBR=fsamuel@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890767 Change-Id: I3b1188d49a1301681391d526abaa25dcabf69f79 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1281083Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599716}
-
Dan Harrington authored
This is in preparation for a schema upgrade. Improvements: - we test that the new schema is compatible with the old one (minimally) - the test won't need to be changed with the next version (only the .sql/data files) - the history of schemas is now clearly documented, and diffable - we test that the migrated schema matches, not just the data - it guarantees the next schema upgrade (v3) CL will test the current schema (v2) accurately. Change-Id: Ibd0de797bcfd878b24956946552eb7a77117124b Reviewed-on: https://chromium-review.googlesource.com/c/1179977Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#599715}
-
Ben Kelly authored
R=morlovich@chromium.org Bug: 894982 Change-Id: Ic3c5ee9923bbd3ade6c0a269416684094d25dc43 Reviewed-on: https://chromium-review.googlesource.com/c/1278906Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#599714}
-
Siddhartha S authored
Helps to show the impact of settings parsing in startup. BUG=890129 Change-Id: Ia92ebd734600a9114b7cffaf1296d7ada2d1c4f5 Reviewed-on: https://chromium-review.googlesource.com/c/1260142Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#599713}
-