- 30 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ab423a548ac..f182be28903f git log 9ab423a548ac..f182be28903f --date=short --no-merges --format='%ad %ae %s' 2018-10-29 ahassani@chromium.org Revert "cros_generate_update_payload: Switch update_engine to major version 2" Created with: gclient setdep -r src/third_party/chromite@f182be28903f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4c4022b1b9e6a0e7652d4707bd147259c9fd0a51 Reviewed-on: https://chromium-review.googlesource.com/c/1306117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603734}
-
Joel Einbinder authored
This patch uses the remoteVersion of the devtools being run to apply only the fixes that are needed. Additionally, use of the /deep/ selector is swapped out for injecting a stylesheet in every shadow root. Bug: 898245 Change-Id: I311ab48d88434d821fedb279d81b2ab9a7f8c94d Reviewed-on: https://chromium-review.googlesource.com/c/1299914Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#603733}
-
Sergei Datsenko authored
In some situations mounting drivefs may take very long time. To distinguish it from a total hang we send periodic keepalives from drivefs. BUG=chromium:899746 Change-Id: Iee906651557a8f8eab62d58298f33c7c3e61724e Reviewed-on: https://chromium-review.googlesource.com/c/1305253 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#603732}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71652e2a09b7..06a4ef497ff1 git log 71652e2a09b7..06a4ef497ff1 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3957b7f8bd86..d0a4800e1487 (1 commits) 2018-10-29 herb@google.com Remove uniqueID fields from SkGlyphRun Created with: gclient setdep -r src/third_party/skia@06a4ef497ff1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ia245a8b7f90c3abc342f96009a322a846cc751f1 Reviewed-on: https://chromium-review.googlesource.com/c/1306733Reviewed-by:
-
Eric Aleshire authored
This improves debugability! Bug: 892381 Change-Id: Iee759450cb148f76bdce51d2bf86b140410719f1 Reviewed-on: https://chromium-review.googlesource.com/c/1306777 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603730}
-
Tetsui Ohkubo authored
This CL removes old System Tray support in first_run tutorial. In UnifiedSystemTray, we don't have HelpStep in the tutorial, so this CL removes HelpStep related code. This is the part 2 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TBR=alemate@chromium.org TEST=trybot pass BUG=898419 Change-Id: I97df2f9de526e0e9b443d0728a3e16e759699da5 Reviewed-on: https://chromium-review.googlesource.com/c/1301137 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#603729}
-
Jonghyun Ahn authored
Linux. Refer to b/117645649 for more context. Change-Id: I34cf636f333cc3d3826ae3b0df2d1ad2ff853d1f Reviewed-on: https://chromium-review.googlesource.com/c/1297581Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow (OOO until Nov6) <rkaplow@chromium.org> Commit-Queue: Jong Ahn <jongahn@google.com> Cr-Commit-Position: refs/heads/master@{#603728}
-
jchen10 authored
This checks the KHR_robust_buffer_access_behavior extension in the passthrough-cmd-decoder when creating webgl2-compute context. Bug: 898030 Change-Id: I1deb3308c852054a9ae29cd620231a212b82e16e Reviewed-on: https://chromium-review.googlesource.com/c/1297735Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#603727}
-
Tatsuhisa Yamaguchi authored
When a notification is PINNED type, the close button should only appear when it's a popup, but not in the message center. Messages in unified notification center are once created based on the Notification and then marked as nested. The latter change affects condition for show/hide close button. However the button visibility was not updated reflecting it. Bug: 872238 Change-Id: Ie0718578153f47e35673b3566fb51933075488be Reviewed-on: https://chromium-review.googlesource.com/c/1299095Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603726}
-
Vladimir Levin authored
This patch ensures that we dirty the compositing inputs if our svg root has visible overflow and that overflow changes. R=chrishtr@chromium.org, pdr@chromium.org Bug: 899291 Change-Id: Iaaa0eb7f48b9855af141e6b3d79d3a1667c6e38f Reviewed-on: https://chromium-review.googlesource.com/c/1306408 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603725}
-
Tetsui Ohkubo authored
This CL removes SystemTrayItem dependency from TrayItemView. SystemTrayItems will be removed with old SystemTray while TrayItemViews will remain. TEST=manual BUG=898419 Change-Id: Icd14cb942c7f33f07b198c80435a17f41908f9d8 Reviewed-on: https://chromium-review.googlesource.com/c/1304281Reviewed-by:
-
Tetsui Ohkubo authored
This CL hides tooltip in user chooser view when there is enough space to show both the name and the email. TEST=manual BUG=889415 Change-Id: I0c02e4bb78c0dfbd81700afe24b8cc9ebe423ea2 Reviewed-on: https://chromium-review.googlesource.com/c/1304179Reviewed-by:
-
Christian Biesinger authored
This avoids refcounting overhead where it's not needed. R=eae@chromium.org, mstensho@chromium.org Change-Id: Ic9303d8325ee9369b1df3f5a16a5c357da9d87bf Reviewed-on: https://chromium-review.googlesource.com/c/1306395Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#603722}
-
jonross authored
Put together a new class to hold the pair of viz::LocalSurfaceId and its allocation time. We will begin using this in (Parent/Child)LocalSurfaceIdAllocator. Bug: 655231 Change-Id: I7f5c57a8d812eca28f3d68f783b58c989659c2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1306113 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603721}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b0874f87a68d..6cf33fa7deb4 Created with: gclient setdep -r src-internal@6cf33fa7deb4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790153,chromium:790158,chromium:790159,chromium:790163,chromium:843835 TBR=mmoss@chromium.org Change-Id: I58ebb1c2f2fe16236c19a7d729727a99fda7d0df Reviewed-on: https://chromium-review.googlesource.com/c/1306216Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603720}
-
Brian Sheedy authored
This reverts commit d481ab54. Reason for revert: Cause of https://crbug.com/900049 Original change's description: > android: build: Enable RELR packed relocations for libchrome.so > > This saves about 100 kiB on 32-bit ARM libchrome.so. > > This optimization cannot be applied to libmonochrome.so, unfortunately, > because only Android P and above support these at the system linker > level. > > BUG=895194 > R=agrieve@chromium.org,torne@chromium.org,pasko@chromium.org,pcc@chromium.org > > Change-Id: I5c554dc3dbc1b3ea27edb60579a5cc0dcdc7d759 > Reviewed-on: https://chromium-review.googlesource.com/c/1304487 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603532} TBR=pasko@chromium.org,digit@chromium.org,torne@chromium.org,pcc@chromium.org,agrieve@chromium.org Change-Id: Idc7f5a39c0be7a7b7d2221a1635add4d2d5b292a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895194 Reviewed-on: https://chromium-review.googlesource.com/c/1307077Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603719}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/69066ab61e2f..06305f5d71c7 git log 69066ab61e2f..06305f5d71c7 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 tsepez@chromium.org Rename CJS_PublicMethods::MakeFormatDate() and MakeRegularDate() 2018-10-29 tsepez@chromium.org Make IJS_Runtime::AsCJSRuntime be XFA-only 2018-10-29 tsepez@chromium.org Remove ctors from CJS_ objects which cant be instantiated. 2018-10-29 tsepez@chromium.org Test CFX_V8::ToByteString() in cfx_v8_unittest.cpp. Created with: gclient setdep -r src/third_party/pdfium@06305f5d71c7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibe5dae64d0c9bee06581cb8b622f2669ab6f0abb Reviewed-on: https://chromium-review.googlesource.com/c/1306754Reviewed-by:
-
James Hawkins authored
The turn-off flow will be removed in a follow-up CL. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ie6ac355c020ca428d49b67c1f9c65e1103e666ad Reviewed-on: https://chromium-review.googlesource.com/c/1306833Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603717}
-
Tsuyoshi Horo authored
TBR=ccameron@chromium.org,jonross@chromium.org Bug: 867668 Change-Id: I07828829cd645d33b9784d6cf04804e920d8d895 Reviewed-on: https://chromium-review.googlesource.com/c/1306955Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603716}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0da64b5e1009..3420dcb0cff1 git log 0da64b5e1009..3420dcb0cff1 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 ynovikov@chromium.org Revert "Roll DEQP version forward" 2018-10-29 syoussefi@chromium.org Vulkan: Remaining disjoint timer query functions 2018-10-29 jmadill@chromium.org Remove Context::gatherParams. 2018-10-29 tobine@google.com Roll DEQP version forward 2018-10-29 tobine@google.com Vulkan: Roll VK deps forward Created with: gclient setdep -r src/third_party/angle@3420dcb0cff1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:845519 TBR=ynovikov@chromium.org Change-Id: I52228a106f71061d97e67e79b3259dd543b60817 Reviewed-on: https://chromium-review.googlesource.com/c/1306219Reviewed-by:
-
Miguel Casas authored
This CL prevs OffscreenCanvasAccelerated2D* before reenabling them in crrev.com/c/1303097. The tests are already marked as failing unconditionally. Bug: 805031 Change-Id: Iae9af1f4a21db545578c67e38eb66e57d83d2e19 Reviewed-on: https://chromium-review.googlesource.com/c/1305400Reviewed-by:
-
Jazz Xu authored
Adjust overflow menu and track list width to 260px so it won't truncate exit PiP text. Bug: 863551 Change-Id: Ie12c79eb15a06554a63fbb082d82e1ab523869a2 Reviewed-on: https://chromium-review.googlesource.com/c/1302574Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603713}
-
Lei Zhang authored
Merge its contents into chrome/browser/ui/BUILD.gn to reduce build dependency complicity. Change-Id: I046775c1b2bd7f37abc0c9786c5b70baae256255 Reviewed-on: https://chromium-review.googlesource.com/c/1306834Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#603712}
-
Mike Wasserman authored
Work will be needed to make ui_devtools work in multi-process Mash. (otherwise it will only handle events sent to Chrome-owned windows) Bug: 896977 Change-Id: Ie2487aed095ee9f62e2e9c85e56bc056b789e0ed Reviewed-on: https://chromium-review.googlesource.com/c/1300056Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#603711}
-
Philip Rogers authored
This reverts commit 4e8eb7fb. Reason for revert: Causes crashes, see 898668 Original change's description: > [BlinkGenPropertyTrees] Promote BGPT to experimental > > BlinkGenPropertyTrees (BGPT) is an incremental step towards making > compositing decisions after the paint lifecycle phase. The primary > changes are to build property trees in blink and send a layer list to > the compositor, rather than building property trees in cc from a layer > tree. This patch marks the project as experimental which will give us > test and perf coverage on the bots. > > Sheriffs: This shifts time (e.g., we now run PaintArtifactCompositor > and no longer run the cc property tree builder) and will likely change > performance benchmarks. Because this is an initial trial, feel free to > roll this patch out. > > Bug: 836884 > Change-Id: Ib867beebbead940162db0801822389f76e8eb8dc > Reviewed-on: https://chromium-review.googlesource.com/c/1294204 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602150} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836884, 898668 Change-Id: I95698da07a0015369748a5fb9a98cd3d85399d9c Reviewed-on: https://chromium-review.googlesource.com/c/1305819Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603710}
-
Max Rebuschatis authored
This is a low-frequency check that needs disk access. Change-Id: I0b6448b401c9c0176a98e7eff8c3f46d9956790f Reviewed-on: https://chromium-review.googlesource.com/c/1298743 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#603709}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/acda68b0292e..dc38c5209303 git log acda68b0292e..dc38c5209303 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 taylori@google.com trace_processor: Allow sqlite to handle string filtering Created with: gclient setdep -r src/third_party/perfetto@dc38c5209303 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I129335de9ed5b2dadbe748bf7d199b872625062e Reviewed-on: https://chromium-review.googlesource.com/c/1305895Reviewed-by:
-
Charlene Yan authored
BOOKMARK_BAR_HEIGHT gives the height of the bookmark when attached so giving an additional pixel here to the vertical margin of the bookmark bar. This makes it so there are the same number of pixels above and below each button on the bookmarks bar when the bookmark is attached. Bug: 865555 Change-Id: I271bfb7f48ef2faa390a8c9ae595c165dbc0bde9 Reviewed-on: https://chromium-review.googlesource.com/c/1280928Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603707}
-
Christian Biesinger authored
This div needs min-height: 0 after crrev.com/c/1269235 R=rdevlin.cronin@chromium.org Bug: 899177,899178 Change-Id: Ia000eb4f22b21247743986b81ae3190322d2c63e Reviewed-on: https://chromium-review.googlesource.com/c/1306033Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#603706}
-
Wez authored
Introduce a new $mixin_append key to mixins. Values in the $mixin_append dictionary must be lists, and will be appended to any existing items in the corresponding key of the test specification. Bug: 879806 Change-Id: Ibd51c679df1944bcc9f34a4acba47ee39a5f871d Reviewed-on: https://chromium-review.googlesource.com/c/1306352 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#603705}
-
Min Qin authored
We added some logs to analyze the crash, and the newly added crash dump verifies the issue is caused by duplicate download Ids. This CL works around the issue by skiping downloads with existing ids, and reverts the crash dump change. This should only impact canary/dev channel, and another CL to fix duplicate Id generation is in progress BUG=898859 Change-Id: Iab5cf36bee1cdb97566872916a6b010d6be2ac3d Reviewed-on: https://chromium-review.googlesource.com/c/1306241Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603704}
-
Tsuyoshi Horo authored
This reverts commit bbe71c7f. Reason for revert: Caused win-asan test failure. See crbug.com/900041 Original change's description: > [base] Harden base::JSONWriter::BuildJSONString > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > It replaces the old base::Value API with the new one, thus implicitly > replacing DCHECKs with CHECKs. > > Bug: 859477 > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603508} TBR=rsesek@chromium.org,jdoerrie@chromium.org Change-Id: I526bc8497110b99c5904ae61e4672514047f7412 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859477 Reviewed-on: https://chromium-review.googlesource.com/c/1306954Reviewed-by:
-
ziyangch authored
BUG=internal b/117626741 Test=Cast from Google Play Movie to nexus player. Change-Id: Ibd4e50dd10f6abf538f2f5a76cb50b802aa47f62 Reviewed-on: https://chromium-review.googlesource.com/c/1297355 Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603702}
-
Andreas Butler authored
Converting databases() wpt tests to promise_tests to fix flakiness Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=899085 Change-Id: I91848796d7508408bb3e5b9fb05f725564fa9971 Reviewed-on: https://chromium-review.googlesource.com/c/1299959Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603701}
-
Giovanni Ortuño Urquidi authored
Changes TestBluetoothAdapterClient::Properties to save Set callbacks if there is no next response set. Just like in real devices, these callbacks are run after the adapter gets removed. Also adds a test to make sure that when the adapter gets removed during a SetPowered call the state is correctly updated and there are no extra State Changed events. Bug: 896113 Change-Id: Iecc55cc2a8f4b2ff4d93fcacfd5e1a64095b2b7d Reviewed-on: https://chromium-review.googlesource.com/c/1304033 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#603700}
-
dpapad authored
Bug: 838290 Change-Id: I60e56e959e22a67018d200f8158e837ec8e9a3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1305202Reviewed-by:
-
Findit authored
This reverts commit 37618e14. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603544 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzc2MThlMTQyMDg1MzMxYTc5MmI4M2JkYzE0ZmNjMDcxNzZmNWU5Mww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6189 Sample Failed Step: browser_tests on (none) GPU on Mac Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Original change's description: > Reland "Enable the pixel by pixel comparison test for Mac OS." > > This is a reland of 01ccf727 > > Original change's description: > > Enable the pixel by pixel comparison test for Mac OS. > > > > 1. Tested on Mac and verify everything works as expected. > > 2. Removed the unnecessary call of GetNativeWindow(). > > > > Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c > > Reviewed-on: https://chromium-review.googlesource.com/c/1279301 > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601879} > > Change-Id: Ib6fa1c1d9b3487c88b240ea9262042db8af0c19a > Reviewed-on: https://chromium-review.googlesource.com/c/1296811 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603544} Change-Id: Ic8b96d7904653b5f68c5660f045dca15206ac2fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900035 Reviewed-on: https://chromium-review.googlesource.com/c/1306785 Cr-Commit-Position: refs/heads/master@{#603698}
-
Giovanni Ortuño Urquidi authored
Part of a bigger refactor to change how tests work. Currently tests perform the following steps: 1. Set the next response to a BlueZ method call 2. Call a method that will call the BlueZ method 3. Check that the BlueZ method was called the right number of times 4. Apply the values that were passed to the BlueZ method With this approach, we have no control over when BlueZ replies and we don't know what values were passed to BlueZ until after we apply them. This CL address the second problem by exposing a GetSetValueForTesting method in dbus::Property and adding a GetLastSetPoweredValue() method to tests that use GetSetValueForTesting to test that the BlueZ method was called with the right value. Now that we don't need to apply the `set_value` to know what it was, we can remove SimulateSetPoweredCompleted. A follow up CL will address the first problem. In the end tests should perform the following steps: 1. Call a method that will call a BlueZ method 2. Check that the BlueZ method was called the right number of times 3. Check that the BlueZ method was called with the right value 4. Simulate the BlueZ method replying An added benefit of this approach is that we can simulate other operations, like the adapter getting removed, between steps 1. and 4., something that happens often in real devices. Bug: 870192 Change-Id: I0c2cfc90a84d6d79b158804264c0e93664310a08 Reviewed-on: https://chromium-review.googlesource.com/c/1298818Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Becky Zhou authored
Bug: 897502 Change-Id: If4e9c315c5742be40764e9a13f0d002acb96a43e Reviewed-on: https://chromium-review.googlesource.com/c/1305821 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#603696}
-
Scott Violet authored
This way, if a client is too slow we'll inject the next event. I have no doubt we will need more sophisticated things, but this is a start to ensure we don't get entirely wedged. BUG=none TEST=covered by test Change-Id: If4c233431be3239476227fc0271a5bc18cfff479 Reviewed-on: https://chromium-review.googlesource.com/c/1303353 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603695}
-
