- 12 Sep, 2017 40 commits
-
-
Francois Doray authored
WorkerPool is being deprecated in favor of TaskScheduler. NSS calls may acquire the NSS lock or reenter Chrome code via extension hooks (such as smart card UI). To ensure threads are not starved or deadlocked, base::ScopedBlockingCall instances increment the thread pool capacity when too much time is spent in a scope where an NSS call is made. Bug: 659191 Change-Id: Iaf088d84521753a3399083047a4e5733d44c472f Reviewed-on: https://chromium-review.googlesource.com/648218Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#501248}
-
Jérôme Lebel authored
With MDM errors, no error message exists. A default message to invite the user to tap on the cell should be displayed. This bug was introduced with: https://chromereviews.googleplex.com/456347014/patch/40001/50002 BUG=717273 Change-Id: Iec972ca39dbc374a5a1003e5ef78e1927485e5f3 Reviewed-on: https://chromium-review.googlesource.com/652867Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#501247}
-
Anton Suslov authored
On systems that use-zoom-for-dsf with HiDPI find bar would shift incorrectly when obscuring search results due to WebKit returning selection box in screen coordinates without converting them to display coords. In order to write a proper test, we'd have to check if find bar still overlapped the selection box, but there is no way to know where the box is without somehow using FindReply message, which was sending wrong coordinates. Bug: 755958 Change-Id: Ifb1c1615aa019c876c3c9488b659b060ca8f8116 Reviewed-on: https://chromium-review.googlesource.com/620652 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#501246}
-
Francois Doray authored
These threads are deprecated and no longer used. NOPRESUBMIT=true Bug: 689520 Change-Id: I55b05b70626f91c8a71d56642c851bb786dbfcaa Reviewed-on: https://chromium-review.googlesource.com/660597Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#501245}
-
Lucas Garron authored
Committed Interstitial error page HTML (1/2): attach net_error and error_page_content to ThrottleCheckResult. Changes NavigationThrottle::ThrottleCheckResult into a struct that holds a net error and an optional error page content (i.e. HTML + inline JS/CSS). The old ThrottleCheckResult enum is changed to ThrottleAction and included in the struct. TBRing jochen@ for mechanical changes. TBR=jochen@chromium.org Bug: 751949 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I2b4836d1be24251704f25b05f0fd0c38bb74c341 Reviewed-on: https://chromium-review.googlesource.com/647656 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Reviewed-by:
-
Tim Schumann authored
This is about the very first integration where Chrome would directly talk to a ChromeReader frontend and interpret ChromeReader's JSON protocol. Change-Id: I1e53e64eacf879a05704bbe04b960a24fc1bba36 Reviewed-on: https://chromium-review.googlesource.com/659859 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501243}
-
Philip Jägenstedt authored
Change-Id: I89add77af2b04f4328c04674eab8f6ebc8412dd6 Reviewed-on: https://chromium-review.googlesource.com/658979 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501242}
-
Bernhard Bauer authored
Bug: 736035 Change-Id: I03821f26deb3b274a0e944b6c8537b26d18f9b2b Reviewed-on: https://chromium-review.googlesource.com/660259Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501241}
-
Max Morin authored
This CL addresses a couple of bugs related to group id computations. First, the default output device isn't correctly identified as GetPrimaryActiveOutputNodeOnMainThread function doesn't actually set the output value. Second, default input device id was assumed to correspond to the built-in microphone in earlier versions of the code. This isn't true (and wasn't true before either). Now, we actually look up what device is the default input device. BUG=636300,764228 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ief22bfa5dffe29279dd906dd252c4d2489f30f1b Reviewed-on: https://chromium-review.googlesource.com/662761Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501240}
-
Tomasz Garbus authored
This CL contains navigator.credentials.create(options), as described here: https://w3c.github.io/webappsec-credential-management/#dom-credentialscontainer-create 7 out of 15 tests are passing on iOS here: https://w3c-test.org/credential-management/credentialscontainer-create-basics.https.html * 3 tests are failing because they test PublicKeyCredential which is not meant to be implemented in this file. * 1 test is failing because of bug crbug.com/762011. Instead of TypeError, Promise is rejected with NotSupportedError * 4 tests are failing because on iOS DOMException.name is not a string, so testharness.js fails this line: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testharness.js?type=cs&q=testharness+promise_test&l=1279 Promise is still rejected with DOMException of correct type (DOMException.NOT_SUPPORTED_ERR) Bug: 435046 Change-Id: Ica5a55425f1071398fe2e2b5d936234bcffa5750 Reviewed-on: https://chromium-review.googlesource.com/650355Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Cr-Commit-Position: refs/heads/master@{#501239}
-
Takayoshi Kochi authored
These style-only reformatting were excluded from a couple of precedent move-only changes. FirstLetterPseudoElement.cpp eventually stayed in core/dom, but this change is style-only and harmless. https://chromium-review.googlesource.com/c/chromium/src/+/644928 https://chromium-review.googlesource.com/c/chromium/src/+/645909 TBR=hayato@chromium.org Change-Id: I24aedca19498813cdb2ab39717a5c7b282add282 Reviewed-on: https://chromium-review.googlesource.com/646404Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501238}
-
Tomasz Garbus authored
Now IOSChromePasswordManagerClient::GetPasswordManager() instead of nullptr returns PasswordManager owned by PasswordController which also owns the client. Motivation for the CL is following: As of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/652227, navigator.credentials.store() results in showing a dialog which is already implemented, prompting user to save or update password. But clicking 'Save' in that dialog crashes the browser. Adding PasswordManager getter to IOSChromePasswordManagerClient fixes this issue. Bug: 435048 Change-Id: I01ff29ab917c083349abc61f5043f8d123d826ea Reviewed-on: https://chromium-review.googlesource.com/660704Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e104a64. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1657 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources rego@igalia.com: external/wpt/css/css-ui-3 rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: I3bc94d7ae081d2adc9f5ad0ec0304de8033c0982 Reviewed-on: https://chromium-review.googlesource.com/662518 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501236}
-
Tomasz Garbus authored
Implemented CredentialManager methods: * HandleScriptCommandCallback * SendGetResponse * SendStoreResponse * SendPreventSilentAccessResponse * constructor (register script command callback) * destructor (remove script command callback) Added unit tests for this class, which test it via public API i.e. exposed JavaScript interface. Tests are meant to ensure that: * calling exposed navigator.credentials method |get|, |store| or |preventSilentAccess| results in calling proper method on CredentialManagerImpl * that arguments are validated before that happens * that calls from insecure context are ignored * that Promises returned by navigator.credentials methods |get|, |store|, |preventSilentAccess| resolve with correct type and correct value or reject with error of right type. Change-Id: Ia82c0ec29b9011fc763abc952b888c7483b4b840 Reviewed-on: https://chromium-review.googlesource.com/649610 Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
All probably related to a recent change to TextIterator [1], which made legacy layout dump text identically to what NG does. [1] https://chromium-review.googlesource.com/c/chromium/src/+/653665 TBR=xiaochengh@chromium.org,kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 758816 Change-Id: Idda7617e54d254d76bf170cb59c8cd7c9ddd16d6 Reviewed-on: https://chromium-review.googlesource.com/663037Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#501234}
-
Rijubrata Bhaumik authored
LUMINANCE_F16 has following issues: 1. GL_LUMINANCE (as well as GL_ALPHA) is deprecated. 2. GpuMemoryBuffer cannot support LUMINANCE_F16. 3. LUMINANCE_F16 requires cpu int-to-float conversion. This CL introduces a media switch "kUseR16Texture" feature to use R16_EXT. If we get better power/performance numbers, we can enable R16_EXT by default. R16_EXT is : + intuitive + filterable + no int to half float CPU conversion + GpuMemoryBuffer can support R16_EXT Bug: 445071, 624436 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8e5d63a8ea11ef1bbc67e26f4d74e5c1dfc76eb5 Reviewed-on: https://chromium-review.googlesource.com/633663 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#501233}
-
Gauthier Ambard authored
When the user long press the app bar displayed at the top of the Reading List collection, the context menu corresponding to the item displayed below should not be displayed. Bug: 761988 Change-Id: Iee203182aa896096875b04b886db0818bf6226ac Reviewed-on: https://chromium-review.googlesource.com/660001Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501232}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/19769c12..726c1912 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I6c65bf71466bcdee15fabe38296ad8460501b7c5 Reviewed-on: https://chromium-review.googlesource.com/662938Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501231}
-
Ondrej Skopek authored
Removed toggleStartStop and made start/stop public. Refactored placement of constants in files. Added unknown error string. Changed maxAlternative to 1. Bug: 583291 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I203636264c495dd6b450d80b60c5796f41bb73c1 Reviewed-on: https://chromium-review.googlesource.com/660281 Commit-Queue: Ondrej Škopek <oskopek@google.com> Reviewed-by:
-
James Forshaw authored
This CL implements changes to the sandbox Sid class to support the creation of Capability Sid objects. It also contains a few refactoring efforts to cleanup up older code. Bug: 760977 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Id9c05b8017abb81896c1bc30f23599441812d1fd Reviewed-on: https://chromium-review.googlesource.com/649026 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#501229}
-
Nico Weber authored
Else lld gets confused about `/LIBPATH:..../DIA\ SDK/lib` in the rsp file for dump_syms.exe and fails to link it. See https://bugs.chromium.org/p/chromium/issues/detail?id=600223#c8 for discussion about the approach taken. lld-lib doesn't understand --rsp-quoting yet, so only pass this to link, not to lib. Luckily, we don't have files with spaces in their path in lib files in the build. Bug: 761850 Change-Id: I628439fa4103c8150a324ee314c4cfe5b259adb5 Reviewed-on: https://chromium-review.googlesource.com/659162Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#501228}
-
Edward Jung authored
Adding this option allows UI to set the visibility of the 'Back to safety' button. Webview: Set to false, so the button would only be shown where there is a page to go back to. Chromium: option is always set to true so always show the Back to safety button. Where there is no previous page, the user is taken to the new tab page. Bug: 760383 Change-Id: I8857b6bf2ff977c572f507f817bf815307453c13 Reviewed-on: https://chromium-review.googlesource.com/641435Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#501227}
-
Dan Elphick authored
Instead check several conditions earlier to avoid getting (and thus creating) StoragePartitions that are never used. Also adds a new parameter to BrowserContext::GetStoragePartition to allow checking existence without creating the StoragePartition. Finally remove the hack in BackgroundFetchContext which preserved a scoped_refptr to URLRequestContextGetter to ensure it was deleted on the UI thread, now that the StoragePartition is not created and so won't create it. Bug: 762960 Change-Id: I57055c19f485be706485477125d1434e5ae99181 Reviewed-on: https://chromium-review.googlesource.com/654874 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#501226}
-
Alex Clarke authored
Sometimes in headless we need to emulate mobile devices including changing navigator.platform. This DevTools command achieves that. Bug: Change-Id: Id305db9fa595d527225c2e19bb269cb60f29110f Reviewed-on: https://chromium-review.googlesource.com/603715 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501225}
-
David Vallet authored
Bug: Change-Id: I95354a0bdb4e700ec2fc9e8a2d8d079e5f153ab2 Reviewed-on: https://chromium-review.googlesource.com/662081 Commit-Queue: David Vallet <dvallet@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501224}
-
Emi Morikawa authored
Use counter instead of using pointers in ServiceWorkerVersion. Bug: 758455 Change-Id: I4fc5205940e18b130be17c52fbcea3e56246fd0e Reviewed-on: https://chromium-review.googlesource.com/662004 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#501223}
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: I4eb69d0acfdeafecff59251f53179bfd5241d8cd Reviewed-on: https://chromium-review.googlesource.com/647392 Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#501222}
-
Eric Willigers authored
The following tests are no longer skipped: external/wpt/css/CSS2/cascade-import external/wpt/css/css-cascade-3 external/wpt/css/css-cascade-4 BUG=763610 Change-Id: I5d4b0f806d9deb160e4075d17754ea5729eae535 Reviewed-on: https://chromium-review.googlesource.com/662484 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Ramin Halavati authored
test_tool.py updated to use c++14 for generated compile commands and ignore '\r' characters that emerge in concatanating llvm::outs() results on Windows. Bug: Change-Id: I68443f84054a6b9f5d7209725263e27ce343e654 Reviewed-on: https://chromium-review.googlesource.com/657758Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#501220}
-
Lisa Suzuki authored
This CL's intention is to adjust to the change of WebIDL's specification. Before this CL, type in Argument cannot be treated with Extended Attributes as a group: - ex1) ExtendedAttributeList optional Type ArgumentName Default - ex2) ExtendedAttributeList Type Ellipsis ArgumentName All ExtendedAttributes in ExtendedAttributeList are treated with ArgumentName in AST After this CL, however, type in Argument can be treated with Extended Attributes: - ex1) ExtendedAttributeList optional TypeWithExtendedAttributes ArgumentName Default - ex2) ExtendedAttributeList Type Ellipsis ArgumentName in ex1), all the ExtendedAttributes in TypeWithExtendedAttributes can be treated with Type in AST in ex2), ExtendedAttributes in ExtendedAttributeList which are applicable to types ([Clamp], [EnforceRange], [TreatNullAs]) can be treated with Type in AST In order to check if ASTs are dumped correctly, I also added pattern match based tests and TestInterface tests. Bug: 714866 Change-Id: I063dc2f88ed31cab36c614c4d4ab7c83591e1bed Reviewed-on: https://chromium-review.googlesource.com/662483 Commit-Queue: Lisa Suzuki <lisabelle@google.com> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#501219}
-
tzik authored
This CL converts WTF::PassRefPtr to an alias of WTF::RefPtr, and removes the implementation. Bug: 494719 Change-Id: Ide96ef03dfa69668c1de87891a712bcd46470e13 Reviewed-on: https://chromium-review.googlesource.com/657786 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Yoichi Osato authored
We check more exactly. Especially this is important for PositionInFlatTree. Bug: Change-Id: I43edef60ca3b966cb5501eef241f12d99f40e0ae Reviewed-on: https://chromium-review.googlesource.com/662718Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501217}
-
Yoichi Osato authored
Use Position::IsValidfor() and remove IsPositionValidFor() which was introduce to avoid jumbo build error?: https://chromium-review.googlesource.com/c/chromium/src/+/659658 Bug: Change-Id: I5b301e598ff3654a1f5e54192556991c9bdfed0b Reviewed-on: https://chromium-review.googlesource.com/662003Reviewed-by:
-
Ben Wells authored
This reverts commit 245abec2. Reason for revert: One of the exo tests is failing flakily now. See http://crbug.com/746227 Original change's description: > Run exo tests in parallel > > BUG=None > TEST=All tests still should pass > > Change-Id: I8a2cc5598baaa9692a33a79767f93869e5a75b9b > Reviewed-on: https://chromium-review.googlesource.com/657622 > Reviewed-by: David Reveman <reveman@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500712} TBR=reveman@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I6a7d7bfef56b027a0ebf8b914f2967195029840b Reviewed-on: https://chromium-review.googlesource.com/662842Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501215}
-
Tetsui Ohkubo authored
In new-style notification, system notification has different style from other notifications such as web notifications. * The context header shows the title "Chrome OS system". * The context header has accent color. * New MD icon is used. TEST=manual BUG=761885 Change-Id: I8de0863bd95080f66123ae34704ccb6fa09e19b6 Reviewed-on: https://chromium-review.googlesource.com/649449Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501214}
-
Peter E Conn authored
Remove a few unnecessary members and add @Nullable. Bug: 740534 Change-Id: Ia51ac1cd79d42d5be725856fcb81d987c1bc2662 Reviewed-on: https://chromium-review.googlesource.com/660337Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#501213}
-
Alice Boxhall authored
- Ensure moving the mouse off the accessibility tree causes the inspected node to be scrolled back into view; - Ensure that moving focus away and back to the tree re-focuses the inspected node, including if the tree pane is hidden and re-shown; - Avoid hover highlight "sticking" to the node above/below the inspected node; - Make the context menu for breadcrumbs work again; - Make sure treeitem role and tabindex are on the same DOM node. Bug: 560525 Change-Id: I27ced90eedc115fd93c9a65c8baefe87886c092e Reviewed-on: https://chromium-review.googlesource.com/625500 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
This is a temporal fix for the issue that non-Latin IMEs doesn't work. The 'background.persistent' flag should be restored as soon as possible after fixing the root cause of the issue. Also, add some useful logs to debug the issue. chrome://inspect/#extensions. Bug: 761714 Test: Manual. Confirm that the extension always appears on Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia0a12a33036919dc2bec213fd11b49d3b7b9d54f Reviewed-on: https://chromium-review.googlesource.com/660938 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501211}
-
Ben Wells authored
This reverts commit 3c6304c0. Reason for revert: Doesn't compile on Mac. Original change's description: > Traffic annotation auditor and unittest updated. > > The following changes were done: > 1- Auditor adds a list of OSes that actively use each annotation to > annotations.xml, so that removing annotation from one OS and keeping > it in another would not result in marking it deprecated. > 2- A script is added to tools/traffic_anntotation/scripts, to call all > scripts that update a give file when annotations.xml is modified, or > to run unittests that ensure these files are up to date. > 3- 'test-only' switch added to Auditor. When this switch is present, > auditor only checks if annotations.xml is up to date and issues an > error it if is not. When switch is not specified, annotations.xml > may get updated and if so, the above mentioned script is called to > update downstream files. > 4- Auditor will prevent use of deprecated unique ids. > 5- Unittest checks that annotations.xml is loadable and its content are > valid. > 6- Unittest calls the script mentioned in (2) to test if downstream > files are correctly updated. > > Bug: 656607 > Bug: 690323 > Change-Id: I3cea4254dc4ff8bb2c31a8adc1ff5a7daf5006d7 > Reviewed-on: https://chromium-review.googlesource.com/645088 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501206} TBR=msramek@chromium.org,rhalavati@chromium.org Change-Id: Id4c9b556ec5e93d7d5e4d0cd2bd60137811e663f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 656607, 690323 Reviewed-on: https://chromium-review.googlesource.com/662503Reviewed-by:
-
Yutaka Hirano authored
Bug: 695939 Change-Id: I39a9e9ce3b030ec233a03912a3b55d25fffa46a4 Reviewed-on: https://chromium-review.googlesource.com/652208 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501209}
-
